Commit Graph

6847 Commits

Author SHA1 Message Date
Jerry Chang 291115ce7e Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev am: 0b944f6a4d am: 585411a3fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18797269

Change-Id: I7cf326d0a00c4b1dccbd3472b1adc5ec8aa9b418
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 02:07:24 +00:00
Jerry Chang 0b944f6a4d Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev 2022-06-09 00:32:49 +00:00
Winson Chung 883facf091 Updating call to match change in interface
Bug: 235273016
Test: Start up several apps and take a heap dump and verify the buffers
      have been preemptively closed prior to the next GC
Change-Id: If7e46e668efa101d4257dd174f31e5e366a02c9d
2022-06-08 23:31:15 +00:00
Becky Qiu 9074e97780 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: f9dfd06424
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I339a468a49fc8490154dd0dc4d6266ab6e41f90e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:52:38 +00:00
Becky Qiu fe83fce489 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev 2022-06-08 18:02:07 +00:00
Jerry Chang c04af333f5 Prevent wallpaper flicker while entering split screen from overview
When launching a pair of apps from overview panel, it will perform
cross-fade animations to transit from overview to the split pair. But
wallpaper might be visible for a while when both overveiw and split pair
is transparent during the transition. This updates to not fade-out
overview until the split pair is finishing showing in foregorund to
prevent the flicker of wallpaper.

Bug: 235137249
Test: swipe to home and enter overview panel, select and swipe down to
      enter a split pair, verified there's no flicker.
Change-Id: Iec1dc49e260f6e46640d47295d7f65dad5c24ab5
2022-06-08 15:26:25 +00:00
Winson Chung d3a7d37a57 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048 am: 0cf33355a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: I8b0f3b1e6a93f124ba16506872372f6e856dabf2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:50:20 +00:00
Winson Chung 46c9c66048 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev 2022-06-08 03:11:16 +00:00
TreeHugger Robot 34bc21ffb0 Merge "Show split option without consider the "Lock task mode"" into tm-qpr-dev 2022-06-08 02:35:57 +00:00
Jon Miranda 2245de7674 Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev am: 2dac4f7f4c am: dfe3b8b755
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673700

Change-Id: Ib4dd2fdbc93a7ac05e9d141183770cb33db26db6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 01:07:18 +00:00
Jon Miranda 2dac4f7f4c Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev 2022-06-08 00:15:35 +00:00
Vinit Nayak 2339933924 Merge "Rename split classes/variables for consistency" into tm-qpr-dev 2022-06-07 22:36:47 +00:00
Anushree Ganjam 8763cb57d4 Add grid_x field to DeviceSearchResultContainer.
Bug: 233297670
Test: Manual. https://paste.googleplex.com/4745437455056896

Change-Id: I63a0b2ad52282dbf836e5a26c983d3253d2aec43
2022-06-07 22:30:32 +00:00
Becky Qiu a61a2cc962 [Toast] Add query_length for launcher latency logging.
Bug: 235249335
Test: no test needed.
Change-Id: Ia16c241a2eb3cb50a17713216182192f7902be9e
2022-06-07 14:20:52 -07:00
Yunfan Chen a34340ef3a Modify the way of providing insets per WM change
The WM provides a new way to provide insets, modified the code to
reflect that change.

Bug: 161689946
Test: m
Merged-In: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
Change-Id: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
2022-06-07 17:13:47 +09:00
Jerry Chang 37d39619fa Merge "Fix Flicker of inner corners in split screen when quick switching to" into tm-qpr-dev 2022-06-07 00:55:51 +00:00
Vinit Nayak 368d4276f4 Prevent showing divider if launcher was never shown
* With stashing recents animation gets cancelled
almost instantly, so there's no point trying to
"show" the divider bar if it was never hidden
* We can use launcher showing as a good enough
proxy for whether the divider bar was ever hidden
to begin with

Fixes: 230825541
Test: Stashing/unstashing didn't cause crash
Change-Id: I3abc4ecf3605a66e67db971ae14aa6ec493d8f32
2022-06-06 15:30:27 -07:00
Winson Chung 29c68e73dc Revert changes waiting for launcher to resume when transitioning to home
- This was added for Go when they had their own recents implementation
  and isn't necessary for the default implementation

Bug: 229668039
Test: Follow steps using test apk from the bug
Change-Id: I0c36f98683e1bf9a3dc11cde2d1113ed1c4d6448
2022-06-06 22:28:09 +00:00
TreeHugger Robot 9307776597 Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev 2022-06-06 21:36:43 +00:00
Vinit Nayak 5424fca602 Rename split classes/variables for consistency
* Use "select" when in the split screen
invocation process
* Drop usage of "staged" except when defining
constants

Fixes: 233006032
Change-Id: I809f0e1e9742aa6b6b09ad8731896ad3f0c9deb0
2022-06-06 14:02:15 -07:00
Vinit Nayak 2aa5a816e9 Merge "Remove old split screen overview related code" into tm-qpr-dev 2022-06-06 20:49:45 +00:00
Vinit Nayak da9213791e Ensure null elements aren't added to TaskView shortcut list
Bug: 234874147
Change-Id: I5ed84fdc64128264e5808b7d3b019c47e3740469
2022-06-06 09:18:42 -07:00
Jeff Chang 5ee83f3b5e Show split option without consider the "Lock task mode"
wm-core supports split-screen and lock-task mode work together now.
This CL enables the split-option to allow users to enjoy the
split-screen experience.

Bug: 199342537
Test: Options show up as expected
Change-Id: I38f58dec2985eaaabdbed1fdeeeece2d6e59945f
2022-06-06 14:47:47 +08:00
TreeHugger Robot 5b765189e2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: If494d52f37fd556dca2fd6960bb69490c812e5fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:26:26 +00:00
TreeHugger Robot c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Tony Wickham 8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Ats Jenk e048af300b Merge "Enable bubbles home gesture by default" into tm-qpr-dev 2022-06-03 18:46:20 +00:00
Vinit Nayak 690645b62e Remove old split screen overview related code
Bug: 233006032
Change-Id: I294dcde586da135af3bb33400e65d5f47edca3d8
2022-06-03 16:39:49 +00:00
Ats Jenk daccf18be1 Enable bubbles home gesture by default
Update feature flag for bubbles home gesture handling to be on by
default.

Bug: 170163464
Test: manually verified that home gesture feature is enabled on a a fresh build
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble
Change-Id: Ie6bdea919dfaf6448b3c57756cd06993a6a60ce7
2022-06-02 17:05:36 -07:00
Jon Miranda 46ecc0ca08 Pause expensive view updates before setting hw/sw layers.
Prevents widgets from updating mid animation.
Also pauses view updates during app close animation.

Bug: 220939231
Bug: 230617085
Bug: 226171754
Test: manual

Change-Id: I0138d57e6a7b2c22fd9a029e971b3e27c7e9f22e
2022-06-02 12:21:01 -07:00
Jerry Chang 202f45166d Fix Flicker of inner corners in split screen when quick switching to
Update divider bar visibility immediately when quick switching to split
pair

Fix: 234609814
Test: manual check quick switch with split pair
Change-Id: I4fc36302763bc0a7de9caca0ab370e3cedc18076
2022-06-02 03:53:19 +00:00
Vinit Nayak 28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Winson Chung c9e64b3c47 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 95afbb9982
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I276ce54df65697b0778c29864a8620733b6e0cbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:55:52 +00:00
Winson Chung 238f380853 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev 2022-06-01 22:06:48 +00:00
Luca Zuccarini 728e234120 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I8cf3773dff04ced9335355f9f99311df1a9bd97f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:17:35 +00:00
Jeremy Sim 0183476559 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev 2022-06-01 02:55:47 +00:00
Winson Chung 7ca87c785a Ignore pinned tasks for purposes of gesture nav
Bug: 234170890
Test: Enter content pip, swipe up and see if a duplicate stub taskview
      is created
Change-Id: I62a994749fcaeff48901410ede26b848fa15b830
2022-05-31 23:32:26 +00:00
Jeremy Sim 3c2c3f1aea Remove deprecated verticalBar layout in Overview
Removes code that was intended for a now-deprecated layout style in Overview. See ag/18386646 for an example of an issue caused by this.

Bug: 232298587
Test: Manual on 3 devices
Change-Id: Icfd40e1e5a99cf5821b1c46357db58a31daaa835
2022-05-31 22:02:57 +00:00
Luca Zuccarini a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
Wei Sheng Shih 4cd75a1aae Merge "Cancel the recents animation for locked gesture[2/2]" into tm-qpr-dev 2022-05-30 01:48:07 +00:00
TreeHugger Robot db9a5bb80b Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118 am: a947c74b11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727

Change-Id: I9246c6ca0df462853195bf11d29dc210bcc9fa55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-28 00:05:16 +00:00
Alex Chau 4eebbac3b7 Use DeviceProfile.widthPx to initialize Taskbar touchableRegion
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion

Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
2022-05-27 18:35:26 +01:00
Brian Isganitis deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak 1eb79473aa Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: e9e0800fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7b4afd0d4eae8853e15c06c8f7f6472ef5035bf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:29:15 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00