Commit Graph

2763 Commits

Author SHA1 Message Date
Vadim Tryshev d999b60bbe Suppressing more view capture anomalies am: b36143551c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24434269

Change-Id: I961d782ea81e99e01712831b7032383d2cc41021
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-15 20:37:53 +00:00
Vadim Tryshev b36143551c Suppressing more view capture anomalies
Test: presubmit
Flag: N/A
Bug: 295904861, 295910059, 294891222, 295909454
Change-Id: I6abc34844d0dbfa53d402d4983a71655b256e091
2023-08-15 11:19:46 -07:00
Treehugger Robot 67ddbc8e4e Merge "Improving diagnostics for tests ignored due to @Stability annotation Now they will be shown as ignored, not as passed." into udc-qpr-dev am: 184fa593ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24421530

Change-Id: If84d862d2344017a305ceff852074acce3f4c38a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 22:57:09 +00:00
Treehugger Robot 184fa593ed Merge "Improving diagnostics for tests ignored due to @Stability annotation Now they will be shown as ignored, not as passed." into udc-qpr-dev 2023-08-14 22:10:52 +00:00
Treehugger Robot 2db10452f4 Merge "Skipping view capture analyzer in presubmit" into udc-qpr-dev am: 57065929ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24421528

Change-Id: Ie1f942358de9dad066a9aa847cde2ce1f41e589f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 21:03:02 +00:00
Treehugger Robot 57065929ee Merge "Skipping view capture analyzer in presubmit" into udc-qpr-dev 2023-08-14 20:51:36 +00:00
Vadim Tryshev 74eddc5490 Improving diagnostics for tests ignored due to @Stability annotation
Now they will be shown as ignored, not as passed.

Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I0913577230441c6bd60165138455ea16a759b39b
2023-08-14 20:44:05 +00:00
Colin Cross efada45adf Merge "Fix kotlin nullable errors in Launcher3" into udc-qpr-dev-plus-aosp 2023-08-14 17:55:18 +00:00
Vadim Tryshev 9082ba31d7 Skipping view capture analyzer in presubmit
The checks are not sufficient stable yet to be presubmit blockers.

Bug: 286251603
Flag: N/A
Test: presubmit
Change-Id: I3f5466a51018ff4e8de8c00ef7e0ca3fc0ec5436
2023-08-14 10:20:35 -07:00
Vadim Tryshev d21fed8f62 Ignoring alpha jumps in ArrowTipView
Bug: 24331680
Flag: N/A
Test: presubmit
Change-Id: I0de76bc2fd8791e03e7722700c72567ef6b913b5
2023-08-11 19:07:00 -07:00
Colin Cross abf18e9c03 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:28:54 -07:00
Treehugger Robot b043c7ced0 Merge "Disabling flash checks for the whole LauncherDragView" into udc-qpr-dev 2023-08-10 23:03:33 +00:00
Thales Lima 19c41f5932 Merge "Create specs for hotseat" into udc-qpr-dev 2023-08-10 20:08:38 +00:00
Jordan Silva 3646a1b7e1 Fix workspace and hotseat paddings for responsive grid in landscape
Add paddings for workspace and hotseat when vertical bar is enabled.

Fix: 294033018
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeGridDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: I7358d2eb7b7c53b436756c21bd81d4746ea01801
2023-08-10 14:15:35 +00:00
Thales Lima f8bfb036ba Create specs for hotseat
Some attributes of hotseat change depending on the size of the device. In the future more attributes could be moved to the spec, e.g. hotseat icons.

Fix: 292204436
Test: CalculatedHotseatSpecTest
Test: HotseatSpecsTest
Test: SizeSpecTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I6a4e05d75af819dbf1444a5ca45c2080f55dc203
2023-08-10 10:23:23 +00:00
Hyundo Moon fa3bd7dc8a Merge "Revert "Test: unfold_to_widgets"" into udc-qpr-dev 2023-08-10 07:19:38 +00:00
Surajit Chandra 06da59fcc2 Revert "Test: unfold_to_widgets"
Revert submission 24356173-unfold_to_widgets

Reason for revert: Test Revert b/295248721

Reverted changes: /q/submissionid:24356173-unfold_to_widgets

Change-Id: I7f138c31f306de03d9ec30dda600f7dfb18fcd26
2023-08-10 06:50:43 +00:00
Doğancan Emek 47caf4af5d Merge "Test: unfold_to_widgets" into udc-qpr-dev 2023-08-09 23:09:28 +00:00
Vadim Tryshev e11268a5b1 Disabling flash checks for the whole LauncherDragView
Flag: N/A
Bug: 295216628
Test: presubmit
Change-Id: Id58f8843d287b5e2e16c47787bd34d1b8a843ca4
2023-08-09 14:25:13 -07:00
Doğancan Emek 84226a662d Test: unfold_to_widgets
Bug: 278986839

Change-Id: I8c55a82683a02b4416aff1c152b7ea7f8131f34b
2023-08-09 20:41:22 +00:00
Vadim Tryshev 7ed637b050 Merge "Implementing detector of view flashes" into udc-qpr-dev 2023-08-09 17:57:15 +00:00
Randy Pfohl 6ff6c00b26 Merge "Adding minimal logs to investigate overview floating bug" into udc-qpr-dev 2023-08-08 22:11:19 +00:00
Andy Wickham c15fd5c248 Merge "Revert^3 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-08-08 20:58:04 +00:00
Andy Wickham bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Sebastián Franco b0f32ea815 Merge "Ensure the reorder test runs on the foldable devices" into udc-qpr-dev 2023-08-08 17:52:33 +00:00
Vadim Tryshev c6352a55f3 Implementing detector of view flashes
I.e. when a view appears or disappears for a short time.

Moving some common parts of AlphaJumpDetector and FlashDetector to their parent class, AnomalyDetector, and moving AnomalyDetector to a separate file.

Also tweaking the code a bit.

Flag: N/A
Test: presubmit, local runs
Bug: 286251603
Change-Id: I022e68eb90147abd3ed4ee3b285d672bb19c997d
2023-08-04 18:56:10 -07:00
Sebastian Franco a99e1d2a14 Ensure the reorder test runs on the foldable devices
It moves some classes form the Nexus package into the launcher package
so it can be used in both projects.

It also adds more test for foldables and test multiple
grids for each test.

Bug: 289584301
Fix: 291346193
Test: ReorderWidgets
Change-Id: I04db5f685d0344b8a3f3d42b429bbde061b3d8ea
2023-08-03 16:35:29 -07:00
Pat Manning a0e328abe7 Merge "Add test to access overview app menu." into udc-qpr-dev 2023-08-02 18:02:29 +00:00
Pat Manning ccf611234a Add test to access overview app menu.
Approved tapl DD: go/tapl-overview-task-menu-app-info

Fix: 292081139
Test: TaplTestsQuickstep.
Change-Id: Ic74267ec80b0a8c6af502a445d355f0420d8f569
2023-08-02 17:20:03 +01:00
Vadim Tryshev a1877d2888 Merge "Ignoring alpha jumps in ArrowTipView and its children." into udc-qpr-dev 2023-08-01 19:36:54 +00:00
Vadim Tryshev 1e6daed881 Merge "Detecting multiple view animation anomalies." into udc-qpr-dev 2023-08-01 17:58:12 +00:00
Federico Baron 7a3d701b4a Merge "Update the launcher test app widgets to include a custom icon instead of the default icon" into udc-qpr-dev 2023-08-01 05:55:17 +00:00
Vadim Tryshev 189f115e83 Detecting multiple view animation anomalies.
Now detecting all anomalies that were detected during the test. This helps to avoid rerunning the test multiple times and adding anomalies to the ignore-list one by one.

Generating a file with all detected anomalies and instructions how to suppress them.

Flag: N/A
Test: presubmit, local runs
Bug: 286251603
Change-Id: I0c34d228f91976451b518fd44873218b80178d0e
2023-07-31 18:03:48 -07:00
randypfohl c5ad40302c Temporarily disabling test
Test: ran test locally and ensured it was disabled.

Bug: 293191790
Change-Id: I966c466785aa7011d798ae13a52ddb07a93e1ee5
2023-07-31 16:32:31 -07:00
fbaron e0a3da08ee Update the launcher test app widgets to include a custom icon instead of the default icon
Bug: 292287927
Test: no test
Flag: no flag
Change-Id: I98b87029a7afdcaf85e40accda03a145b213136c
2023-07-31 15:44:00 +00:00
Vadim Tryshev f623f61520 Ignoring alpha jumps in ArrowTipView and its children.
I've seen an alpha jump in ArrowTipView|TextView:id/text, so disabling
the whole view sub-tree.

Bug: 292561338
Test: presubmit
Flag: N/A
Change-Id: I49e5d16d7c6e772bb848061087c56221b113d579
2023-07-28 18:08:38 -07:00
Andy Wickham fd35baa3f8 Merge "Revert^2 "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-28 21:57:54 +00:00
Charlie Anderson 6702ed1e19 adding popup test files and allow for selecting activity to use
Test: manual
Bug: 289228540
Flag: N/A
Change-Id: Ie78cd39d5636d8737b80a809fb22328de574f0c0
2023-07-28 10:07:00 -04:00
Vadim Tryshev 163633a916 Merge "Optimizing application of the ignore-list of nodes for AlphaJumpDetector. Instead of building the full path of each node, and then searching it in the PATHS_TO_IGNORE set, we are descending the tree of the nodes to ignore. This saves us building the whole path for each node." into udc-qpr-dev 2023-07-28 00:40:29 +00:00
Vadim Tryshev 4824afe538 Optimizing application of the ignore-list of nodes for AlphaJumpDetector.
Instead of building the full path of each node, and then searching it in the PATHS_TO_IGNORE set, we are descending the tree of the nodes to ignore. This saves us building the whole path for each node.

Now that AlphaJumpDetector has more fields specifically for alpha jump detection in AnalysisNode, I’ve introduced an abstraction of per-detector data in AnalysisNode, see the ‘detectorsData’ field. Each detector (alpha jumps, flash, position jump), will be able to add its own data to AnalysisNode without polluting it.

Flag: N/A
Test: presubmit, local runs
Bug: 286251603
Change-Id: Iac8504edfe43407a75e7fc4a39e21bfca502b090
2023-07-27 15:26:11 -07:00
Andy Wickham be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Treehugger Robot 372f88dd23 Merge "Add one flaking view to alpha-jupms ignore list" into udc-qpr-dev 2023-07-26 18:49:20 +00:00
Treehugger Robot 17988825f2 Merge changes I45b6f858,I28120248 into udc-qpr-dev
* changes:
  Verifying that ViewCapture data is not empty
  Restoring starting capturing existing activity.
2023-07-26 18:33:07 +00:00
Vadim Tryshev 03bbf07522 Add one flaking view to alpha-jupms ignore list
Bug: 292561338
Test: presubmit
Flag: N/A
Change-Id: Ieaaba52e0717a87ea14bcc8a8e861a89b81f9a77
2023-07-25 11:20:14 -07:00
Tracy Zhou bfef402e1e Add quick switch to trackpad gesture tests
Bug: 23895346
Test: presubmit
Change-Id: I85f3e010757595763f58ea81a13671fe49604b76
2023-07-25 10:55:40 -07:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Jagrut Desai 8997e5626a Merge "Branching Taskbar visible/hidden assertion from testQuickSwitchToPreviousAppForTablet" into udc-qpr-dev 2023-07-25 04:14:47 +00:00
Vadim Tryshev aa79bd9a07 Verifying that ViewCapture data is not empty
Flag: N/A
Test: presubmit
Bug: 286251603
Change-Id: I45b6f858cfa13a12203a61ee80ac2e7988360d58
2023-07-25 00:46:33 +00:00
Vadim Tryshev 55b5534467 Merge "Fix a typo" into udc-qpr-dev 2023-07-24 21:58:40 +00:00