Commit Graph

6281 Commits

Author SHA1 Message Date
Vinit Nayak bd5784bade Merge "Remove old split screen overview related code" into tm-qpr-dev am: 2aa5a816e9 am: 7b3916c550
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638742

Change-Id: I619a2f040cd43c7b09e40a40b34aef803c0a663d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 21:30:51 +00:00
Vinit Nayak 2aa5a816e9 Merge "Remove old split screen overview related code" into tm-qpr-dev 2022-06-06 20:49:45 +00:00
TreeHugger Robot 5b765189e2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: If494d52f37fd556dca2fd6960bb69490c812e5fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:26:26 +00:00
TreeHugger Robot 3d662872c2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: abbb482160
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: I61e3083d3d6a348dcd09d33fb43d1a592147e3fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:25:45 +00:00
TreeHugger Robot c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Ats Jenk f5098d95c4 Merge "Enable bubbles home gesture by default" into tm-qpr-dev am: e048af300b am: d2082c8c65
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18720602

Change-Id: Ie1704232532c9f6700ebf18f709d290da174efb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 00:16:28 +00:00
Tony Wickham 8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Ats Jenk e048af300b Merge "Enable bubbles home gesture by default" into tm-qpr-dev 2022-06-03 18:46:20 +00:00
Vinit Nayak 107f79a4a2 Merge "Refactor TaskShortcutFactory to return List of SystemShortcuts" into tm-qpr-dev am: dde2536a52 am: 54cdc33ca1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624822

Change-Id: Ia9e062b2e7ab1a86cdc703614fdbc44f01afb2df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-03 17:33:22 +00:00
Vinit Nayak 690645b62e Remove old split screen overview related code
Bug: 233006032
Change-Id: I294dcde586da135af3bb33400e65d5f47edca3d8
2022-06-03 16:39:49 +00:00
Ats Jenk daccf18be1 Enable bubbles home gesture by default
Update feature flag for bubbles home gesture handling to be on by
default.

Bug: 170163464
Test: manually verified that home gesture feature is enabled on a a fresh build
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble
Change-Id: Ie6bdea919dfaf6448b3c57756cd06993a6a60ce7
2022-06-02 17:05:36 -07:00
Vinit Nayak 28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Winson Chung c9e64b3c47 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 95afbb9982
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I276ce54df65697b0778c29864a8620733b6e0cbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:55:52 +00:00
Winson Chung b7fc43dd0d Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 9f5d1568bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: Ie2a5d9cfe2fe736736dff557d94652380384cbab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:39:08 +00:00
Winson Chung 238f380853 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev 2022-06-01 22:06:48 +00:00
Luca Zuccarini 728e234120 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: 9e50fc0ade
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: I8cf3773dff04ced9335355f9f99311df1a9bd97f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:17:35 +00:00
Luca Zuccarini 5f78aeab5f Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev am: 46338b09e3 am: f518ba7289
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18670230

Change-Id: Ib2697612f18adc60a7310f73f4cf1a391727244a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 10:16:54 +00:00
Jeremy Sim cc305437f6 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev am: 0183476559 am: 2e598e4859
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18422835

Change-Id: I6f966f9d33b1d769f8d4f3d2170f9f001fc5e4cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 03:38:13 +00:00
Jeremy Sim 0183476559 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev 2022-06-01 02:55:47 +00:00
Winson Chung 7ca87c785a Ignore pinned tasks for purposes of gesture nav
Bug: 234170890
Test: Enter content pip, swipe up and see if a duplicate stub taskview
      is created
Change-Id: I62a994749fcaeff48901410ede26b848fa15b830
2022-05-31 23:32:26 +00:00
Jeremy Sim 3c2c3f1aea Remove deprecated verticalBar layout in Overview
Removes code that was intended for a now-deprecated layout style in Overview. See ag/18386646 for an example of an issue caused by this.

Bug: 232298587
Test: Manual on 3 devices
Change-Id: Icfd40e1e5a99cf5821b1c46357db58a31daaa835
2022-05-31 22:02:57 +00:00
Luca Zuccarini a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
Wei Sheng Shih 57c11aab12 Merge "Cancel the recents animation for locked gesture[2/2]" into tm-qpr-dev am: 4cd75a1aae am: 143091e7ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18332637

Change-Id: Ia596934978dfdc9557fa79c629b62aff49167bcd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-30 02:30:14 +00:00
Wei Sheng Shih 4cd75a1aae Merge "Cancel the recents animation for locked gesture[2/2]" into tm-qpr-dev 2022-05-30 01:48:07 +00:00
TreeHugger Robot db9a5bb80b Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118 am: a947c74b11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727

Change-Id: I9246c6ca0df462853195bf11d29dc210bcc9fa55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-28 00:05:16 +00:00
TreeHugger Robot 663cbfabf9 Merge "Use DeviceProfile.widthPx to initialize Taskbar touchableRegion" into tm-dev am: 192b3c3118 am: 6f1e20041f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18634727

Change-Id: I493cee012a5cf9a8b9690c7c207c2b86fc76d3a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 23:55:54 +00:00
Alex Chau 4eebbac3b7 Use DeviceProfile.widthPx to initialize Taskbar touchableRegion
- TaskbarDraglayer.width isn't initialize when Taskbar is recreated before layout, so use DeviceProfile.widthPx instead
- Also listen for DeviceProfile change in TaskbarInsetsController to update Taskbar touchableRegion

Fix: 233316713
Test: Switch to 3 button, nav button works. Swtich to gesture nav, taskbar icon can be tapped
Test: Rotate deice, whole Taskbar should still be touchable
Change-Id: I29ff86fd8616a620f98d9b5438cc586bd69fac33
2022-05-27 18:35:26 +01:00
Brian Isganitis deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak ca796876ca Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: fa886a3edf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7f621d089c2f790cb6164efcef1e515bd6e063c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:50:35 +00:00
Vinit Nayak 1eb79473aa Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: e9e0800fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7b4afd0d4eae8853e15c06c8f7f6472ef5035bf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:29:15 +00:00
TreeHugger Robot 086368e4fd Merge "[conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1" into tm-qpr-dev am: a7b4152e90 am: 731978a0a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624669

Change-Id: Icf20a5e474e15c56962403cc4d9130d3289643aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 02:55:00 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Jeremy Sim 20ba8ad8f9 Merge "Fix Overview screenshot bug in fake landscape" into tm-qpr-dev am: a930633884 am: 9925e19b55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18590120

Change-Id: I408845b269377c7184de6b30fa44bcda08fb6245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 02:56:12 +00:00
Sunny Goyal 052d1dbe15 Merge "Creating the transaction on the UI thread" into tm-dev am: 279911fafc am: f6df7d76ee am: 6d6defb472 am: f9445445f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591002

Change-Id: I2d5063d4c709bbdc211e4b6c4c94df9d2bf545de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 02:12:41 +00:00
Jeremy Sim a930633884 Merge "Fix Overview screenshot bug in fake landscape" into tm-qpr-dev 2022-05-26 01:02:20 +00:00
Sunny Goyal 6d6defb472 Merge "Creating the transaction on the UI thread" into tm-dev am: 279911fafc am: f6df7d76ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591002

Change-Id: I833d70f3d0fa24020ef6eed3394f3c84e6afb5c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 23:11:01 +00:00
Jeremy Sim aba72f50b9 Fix Overview screenshot bug in fake landscape
Fixes an issue where the user would not be able to take a screenshot through the Overview menu when:
1) the task thumbnail was in LiveTile mode and
2) the phone was in fake landscape.

The issue arose because all Overview menu items, upon selection, were forcing LiveTile to end immediately, even before running the onClick method of each menu item. In the case of screenshots, this resulted in the onClick method being unable to take a screenshot because LiveTile was already ended.

This fix prevents Overview menu items from always forcing LiveTile to end, instead allowing each onClick method to determine its own order of operations and end LiveTile when appropriate. The functionality of all other current menu items (Select, Split, etc) should not be affected by this change.

Fixes: 231047451
Test: Manual
Change-Id: Ibfc79a114718fc4674dc434a907044184c7f5dd0
2022-05-25 15:48:59 -07:00
Sunny Goyal 279911fafc Merge "Creating the transaction on the UI thread" into tm-dev 2022-05-25 22:24:04 +00:00
TreeHugger Robot 9324bba29e Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev am: 9557b10c59 am: 60273b856b am: 6687578d1e am: 906e65954d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18400686

Change-Id: I3cee7b4275c48cd4611282296a8902ea36f3f51b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 20:45:28 +00:00
Brian Isganitis 0bc68242ee Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-qpr-dev 2022-05-25 20:27:21 +00:00
TreeHugger Robot 6687578d1e Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev am: 9557b10c59 am: 60273b856b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18400686

Change-Id: I8a842caecf2b929ddadf765137bf0d36465032c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 19:42:31 +00:00
TreeHugger Robot c8c0c57ef9 Merge "Update vibrations in the All set page to match the SUW welcome page." into tm-qpr-dev am: 8398c12649 am: 81afd85dea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521811

Change-Id: I250f9e61c3cd927b740d442421661702c3a055bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 18:50:14 +00:00
TreeHugger Robot 9557b10c59 Merge "Attempt to preload the Launcher activity when the user reaches the All Set Page." into tm-dev 2022-05-25 18:48:17 +00:00
TreeHugger Robot 8398c12649 Merge "Update vibrations in the All set page to match the SUW welcome page." into tm-qpr-dev 2022-05-25 18:30:06 +00:00
Brian Isganitis a9a78117c7 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-25 18:11:51 +00:00