Commit Graph

11755 Commits

Author SHA1 Message Date
Alina Zaidi 1fbf9200f1 Merge changes I5d1c9e4b,I08154c94 into sc-dev
* changes:
  Flip ArrowTipView when it goes beyond screen height.
  Add more education tips for widgets. (3/3)
2021-06-10 20:46:20 +00:00
Steven Ng d4bae086d3 Merge "Fix height estimation of the widgets recommendation table" into sc-dev 2021-06-10 18:11:45 +00:00
Steven Ng bc5099e9a6 Fix height estimation of the widgets recommendation table
There are two vertical paddings
1. Table padding
2. Widget cell padding

We haven't taken account the widget cells padding

Test: Manual
Bug: 189814077
Change-Id: I9b1dc9e880d4402b9c461d0024a0748c0afc408a
2021-06-10 16:57:40 +01:00
Alina Zaidi dca47432fc Flip ArrowTipView when it goes beyond screen height.
Bug: 185354491
Test: Manually tested tips in widget picker, all apps, and
reconfigurable widgets tip.

Change-Id: I5d1c9e4b8bc3ae89834bc198016ffa409a2b28ad
2021-06-10 15:43:30 +01:00
Alina Zaidi ecdf6575ec Add more education tips for widgets. (3/3)
Show tip on reconfigurable widget in launcher.

Bug: 185354491
Test: Manually tested tips in widget picker, all apps, and
reconfigurable widgets tip.

Change-Id: I08154c944285cac6a21c3ef4aafd878bbbccf44b
2021-06-10 14:23:47 +01:00
Hyunyoung Song 8f3d9eba02 Merge "Revert the squish translate from all apps" into sc-dev 2021-06-10 03:53:33 +00:00
Samuel Fufa 08cca82eca [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: I69ffa0ef367b182688e69c730fc9dee1afa7cadd
2021-06-09 17:13:07 +00:00
Hyunyoung Song afa327d176 Revert the squish translate from all apps
Bug: 189973274
Bug: 189975416

Test: manual, attached video on the bug
Change-Id: I881a2b79462e8d420b3dcb6a6b98adbe9e8e0394
2021-06-09 09:47:29 -07:00
TreeHugger Robot 962b212c9e Merge "Fix wrong highlighted personal | work tab" into sc-dev 2021-06-09 02:41:40 +00:00
TreeHugger Robot 93e232a57b Merge "Re-enable swipe up view inflation test." into sc-dev 2021-06-09 00:47:11 +00:00
TreeHugger Robot e57006fe63 Merge "[AA+] Reset search manager when exiting all apps." into sc-dev 2021-06-08 21:50:31 +00:00
zakcohen 284eef2bf9 Re-enable swipe up view inflation test.
Disable chips by default as they are not plan of record for launch.

Bug: 141579810
Test: Local and ran test
Change-Id: Iae270c6ac4bbec4f7c29b1137cf926383443e85e
2021-06-08 14:24:20 -07:00
Steven Ng 4716ab3037 Merge "Use WidgetSizes to estimate widget size instead of custom calculation" into sc-dev 2021-06-08 19:11:25 +00:00
Steven Ng 84fe7e3a1e Merge "Exact widget sizes functionalities into an utility class" into sc-dev 2021-06-08 18:55:07 +00:00
Samuel Fufa e721f7272c Fix wrong highlighted personal | work tab
Bug: 189915880
Test: Manual
Change-Id: I3e8687038d4f0bfdd1c5b7d8c444520730a2bcd4
2021-06-08 13:31:40 -05:00
Steven Ng eb1617521c Merge "Use grid size as the upper bound for widgets' default size in initSpans" into sc-dev 2021-06-08 14:48:29 +00:00
Steven Ng 1d47d8c705 Use grid size as the upper bound for widgets' default size in initSpans
Test: In Pixel 4, drag a monthly view Google calendar widget to a new
      home page from the full widgets picker. The widget outline is
      correctly shown.
Bug: 189060113
Change-Id: I33113b29cc8923098de95f1d5eb14c2b02429de1
2021-06-08 14:15:50 +01:00
Steven Ng 7e06df2b50 Use WidgetSizes to estimate widget size instead of custom calculation
Also fix 2 bugs in WidgetCell
1. preview layout: padding is added to the AppWidgetHostView rather
   than the preview container. We shouldn't add padding to the size
   of the preview container.
2. widget_preview_shortcut_padding is a padding added to shortcuts but
    not widgets.

Test: Open full widgets picker and observe widgets are rendered
      correctly in the widgets recommendation table. Also, observe
      the generated bitmap images are correctly rendered.
      Run AddWidgetTest.
Bug: 189975670
Change-Id: I00db3200e0b61dc5e82f3c4bfdf34e197ea20314
2021-06-08 11:48:11 +01:00
Steven Ng 22b6039270 Exact widget sizes functionalities into an utility class
Test: resize widget, move widget, add widget.
Bug: 189975670
Change-Id: Ia0bc2297891e1cfa33697e985064db5d1dcdfc8b
2021-06-08 11:42:48 +01:00
Stevie Kideckel acf27b6d64 Merge "Fix accounting for the position/offset of headers with collapsing views" into sc-dev 2021-06-08 08:37:25 +00:00
Stevie Kideckel fd9bfd3aab Fix accounting for the position/offset of headers with collapsing views
The offset should be taken before views are modified, the position
should be taken after. This fixes an off by one issue when expanding a
header below another already expanded header.

Bug: 183378651
Test: verified locally
Change-Id: I4987d57846d7bcde23b76280f800f19350b3521e
2021-06-08 07:08:42 +00:00
thiruram ea56f849c2 [AA+] Reset search manager when exiting all apps.
This is required to log search session exits properly, especially when exiting AllApps without clearing search query.

Bug: 178562918
Test: Manual
Change-Id: Id4c1007b051e9efd9ae5929c274a70cf3ae3cbf1
2021-06-07 17:14:24 -07:00
Tony Wickham 26ab4621ce Have AlphaUpdateListener update visibility in onAnimationEnd()
Previously we were only updating visibility in onAnimationSuccess(), which doesn't handle the canceled case.

Test: swipe up from nav bar twice in all apps, ensure all apps is invisible/non-interactable
Bug: 190315266
Change-Id: Ic59e6d4b404de4ee2d17c45d6fa59e2aee70c65f
2021-06-07 22:16:22 +00:00
Jonathan Miranda 93c0cfadb1 Merge "New folder icon style (uncropped icons)." into sc-dev 2021-06-07 21:48:50 +00:00
Steven Ng 0062822976 Merge "Fix preview layout crash upon screen rotation" into sc-dev 2021-06-07 20:38:39 +00:00
Jay Aliomer 4049f539c2 Merge "Improve local color extraction handling." into sc-dev 2021-06-07 19:45:13 +00:00
Steven Ng db4ec8ac1a Fix preview layout crash upon screen rotation
Preview layouts are rendered via LauncherAppWidgetHostView. These
layouts are not yet added to the launcher. And thus, there is no
LauncherAppWidgetInfo.

Test: When a preview layout is shown in the recommended widget section,
      rotate the screen. No crash is observed.
Bug: 190395009
Change-Id: Ib1d080a106681fbfe3a4293f9f51f9576ef9414b
2021-06-07 18:55:47 +01:00
Hyunyoung Song 02b62ed6fe Merge "Icon sizes/ keyline / font for AA+ results" into sc-dev 2021-06-07 14:49:50 +00:00
Pierre Barbier de Reuille 7fca870571 Improve local color extraction handling.
Local color extraction doesn't happen if the wallpaper is not currently
visible, so we don't need to add/remove the locations when the widget is
visible/hidden.

Also now compare the locations with some approximate measure, to account
for possibly slightly different calculations during drag vs drop.

Fix: 189827568
Test: Install Clock or test widgets and try to move them: the color are applied correcly.
Change-Id: Ib2a08bb0552c75bd351868e4fd5b5df8b8b732b2
2021-06-07 13:01:28 +01:00
Alina Zaidi 25788e9635 Merge "Adjust Widgets education dialog size when in landscape" into sc-dev 2021-06-07 09:11:25 +00:00
thiruram 5435b07ed4 [AA+] Fixing missing logs forr keyboard close interactions.
Bug: 178562918
Test: Manual
Change-Id: Id5a7fc3d8ded675c6a64de7416fade74ae2bacd1
2021-06-06 21:26:31 +00:00
Jon Miranda e41dd483e6 New folder icon style (uncropped icons).
- Switch Circle to PathShape as it allows for more flexibility on
  choosing what gets cropped.
- Remove shadows, and stroke.

Bug: 188095988
Test: manual
Change-Id: I602b3efcd35c2c11dc3461f49099c2f2a56eae59
2021-06-04 18:32:10 -07:00
Stevie Kideckel 6f3081affa Merge "Fix corner radius for expanded widget picker list items" into sc-dev 2021-06-04 20:50:52 +00:00
Hyunyoung Song 9450883e74 Merge "Remove APP_SEARCH_IMPROVEMENTS" into sc-dev 2021-06-04 18:24:11 +00:00
Steven Ng 5063805a4e Merge "Include widget padding & boarder spacing in widget preview size estimation" into sc-dev 2021-06-04 17:45:29 +00:00
Alina Zaidi 9f5a7f8366 Adjust Widgets education dialog size when in landscape
Test: Tested manually
Bug: 185354491
Change-Id: Ifd86f48d705b054ae6a2315a11e5398423020755
2021-06-04 18:14:02 +01:00
Steven Ng 4a0e1b40f3 Include widget padding & boarder spacing in widget preview size estimation
Test: Sideload Google dev clock and verify the 5x5 widget preview is
      rendered correctly.
      Verify conversation widget preview is rendered correctly in the
      full widgets picker and priority flow (aka pin widget flow).
Bug: 189975670
Change-Id: I4b0212ae347044c970ba40b9b33439448a6aa941
2021-06-04 15:31:22 +01:00
Yogisha Dixit 4ff5ee3a8f Add new log events for widgets.
Design doc: go/widgets-logging

Bug: 185778648
Test: manual
Change-Id: Ia3c6edb87766a33e77865e9461e7101a1df864c1
2021-06-04 14:52:37 +01:00
Stevie Kideckel d93feeba0a Fix corner radius for expanded widget picker list items
Also create the drawables at runtime to avoid all the permutations

Fix: 189329394
Test: verified locally
Change-Id: I0497759ff68bd4ae6b1635423cfd4713f06d349f
2021-06-04 13:04:04 +00:00
TreeHugger Robot b1e51e2a3f Merge "Use a selector instead of loading resource for drop target." into sc-dev 2021-06-04 12:29:22 +00:00
Stevie Kideckel 6d12fb29f7 Merge "Use scrollToPositionWithOffset in widget list and account for padding" into sc-dev 2021-06-04 11:45:27 +00:00
Yogisha Dixit 2ff963b0c7 Use a selector instead of loading resource for drop target.
Test: manual
Bug: 187355401,187035471
Change-Id: I65fef2c810c791c3282bd4a087359f6cff774cc4
2021-06-04 12:10:06 +01:00
Hyunyoung Song e3d32b543d Icon sizes/ keyline / font for AA+ results
Bug: 188946408
Bug: 189166362

Test: manual, screenshots on the bug
Change-Id: I40c77d8ea3cdcc9dcc33afb1026d1f75c21e9f05
2021-06-04 01:43:40 -07:00
Hyunyoung Song 2e747e2194 Remove APP_SEARCH_IMPROVEMENTS
Bug: 190104801
Test: manual, builds

Change-Id: Icd7f0f17bf79eda9fa8e10a6699be3852a34de67
2021-06-03 20:22:29 -07:00
Bill Lin 51b35256d2 Merge changes I7b9e6e7f,I9729cd40 into sc-dev
* changes:
  2/ Notify adjust touch slop when one handed mode activated
  1/ Provides feasibility to adjust touch slop in TouchController
2021-06-04 00:16:12 +00:00
Brian Isganitis 6afcfd7cbd Show toolbar back button on subsettings pages
Test: Back button displayed and functional on subsettings
Bug: 187732263
Change-Id: I6a3679de3a00480f5a0861f966d178be25f001d4
2021-06-03 17:04:33 -04:00
Brian Isganitis ed49a7187d Pad bottom of settings list view with bottom system insets
This change allows for a transparent navigation bar in the settings Material next redesign.

Test: Bottom of settings not cut off by bottom navigation bar
Bug: 187732263
Change-Id: I237011003ca0c3760c0fbdbb2865ef90c19d7b81
2021-06-03 17:02:05 -04:00
Jonathan Miranda 3ed65ede16 Merge "Only inset widgets if workspaceTopPadding is greater than the widget padding." into sc-dev 2021-06-03 20:23:18 +00:00
Bill Lin a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Bill Lin 945bb34b5e 1/ Provides feasibility to adjust touch slop in TouchController
There is a case when one handed mode triggered(Activated), all apps
drawer is very easy to trigger while user swipe up around NavBar
region to exit one handed mode. Since System Gesture monitor regsion
is small on screen bottom, swipe-up gesture usually cross over NavBar
monitor region and invoke launcher touch controller intercept touch
event and introduce unexpectedly trigger all apps drawer.

Adding onOneHandedModeStateChanged(boolean activated) for controller
be able to adjust the touch slop by multiplier, we can set a larger
multiplier when the visible window size translate become smaller
and make swipe gesture not too sensitive.

Test: manual swipe up to swich "home <-> all apps" and monitor
      minDisplacement of SingleAxisSwipeDetector
Test: Trigger one handed mode and swipe up to exit one handed mode
      check the minDisplacement of SingleAxisSwipeDetector
Bug: 186235522
Change-Id: I9729cd408d85b2b22582bf800e28d1471fc06980
2021-06-04 01:44:50 +08:00