1fa6de1784
Merge "Check for view measurement before animating" into tm-qpr-dev am: e8efdc1185 am: 5e92948c42
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20073475
Change-Id: Ia2c86dc7a757c85313571a53d552dd90b6882fb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-04 11:05:21 +00:00
e8efdc1185
Merge "Check for view measurement before animating" into tm-qpr-dev
2022-10-04 10:09:10 +00:00
8453f86320
Merge "Add margin to SUW back button" into tm-qpr-dev am: 64510b48b0 am: 55298f9901
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004084
Change-Id: I5e43c49bd2b5fc2bd088137c3c998eec6b9eeeac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-04 04:29:54 +00:00
64510b48b0
Merge "Add margin to SUW back button" into tm-qpr-dev
2022-10-04 03:10:21 +00:00
8f59d82294
Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev am: 33e57ebc1a am: 37638afbec
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20103367
Change-Id: I42842b333df3e9a6a623a9f47cf4c0c0aa784ee8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-04 01:00:42 +00:00
71af5b7a15
Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev am: 66160e9dd8 am: b03ec55872
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029582
Change-Id: I8ba442186bc330b7ecff0e9ee1b53a22fe20cffb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 23:45:45 +00:00
33e57ebc1a
Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev
2022-10-03 23:31:59 +00:00
66160e9dd8
Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev
2022-10-03 22:45:42 +00:00
86065b81e0
Fix animation slowdown when splitting from All Apps
...
This patch fixes a tablet bug related to splitting from All Apps. Splitting from AllApps was playing a very slow animation.
The bug occurred because there was no case set in QuickstepAtomicAnimationFactory for animating from the ALL_APPS state.
Fixed by setting the appropriate case in QuickstepAtomicAnimationFactory.
Fixes: 247053528
Test: Manual
Change-Id: I7391dc7049a6ff5a7f8c7e1ae8b69e29899248fa
2022-10-03 12:49:31 -07:00
799a021828
Fix ViewCapture NPE. am: b759de4769 am: 371ba32e44
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075879
Change-Id: Ia9c46040101719449fcb36d2bd6b7b686de32a97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 19:27:46 +00:00
b759de4769
Fix ViewCapture NPE.
...
The ViewPropertyRefs, when copied from 1 frame to another, where also
transferring the same "next" reference. Sometimes, the recycled
ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied
ViewPropertyRefs, which would caused an NPE, since the recycled VPR
would have it's next value set to null.
Bug: 249125402
Test: Repro steps are dragging and dropping around an item on the
workspace to different locations. This consistently repro's the crash in
about 10 seconds of doing this. Afte the fix, the crash stopped.
Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada
2022-10-03 15:25:04 +00:00
3c7db4901b
Merge "Refactor back navigation animtion (2/2)"
2022-10-03 08:15:51 +00:00
b988d224a6
Fix 2 bugs involving split staging task translation am: 978b0021a9 am: 635815666c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20087546
Change-Id: Idda3656d492a90df268c902405c4b6c96266be90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-01 02:08:01 +00:00
978b0021a9
Fix 2 bugs involving split staging task translation
...
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.
Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().
Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
2022-09-30 14:30:04 -07:00
517cafff18
Check for view measurement before animating
...
Sometimes the view is there but it was not measured yet, and that was making the animation run with wrong icon position values.
Fix: 233247401
Test: manual
Change-Id: Ibcce24391e99b02ecdb492191c39b62d332abe4f
2022-09-30 16:04:42 +01:00
c7295ee37a
Add margin to SUW back button
...
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.
Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity
Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
2022-09-29 15:47:15 -07:00
222efcd6ff
Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd am: 00f9389e4e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647
Change-Id: I3bc1c036de3d27af1113b118e13236c913dcca33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-29 22:13:43 +00:00
f733a716fd
Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev
2022-09-29 21:13:59 +00:00
5317efb7fc
Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490 am: 64e8d014a0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375
Change-Id: I7984e13e5169750ba8aedffdbf4bc485dc4a00ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-28 19:41:32 +00:00
888f745490
Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev
2022-09-28 18:30:16 +00:00
401b9b6614
Refactor back navigation animtion (2/2)
...
Use IBackAnimationRunner to receive the animation leashes.
Use IRemoteAnimationFinishedCallback to callback when animation finished.
Bug: 241808055
Test: atest BackNavigationControllerTests BackAnimationControllerTest
Change-Id: I315df5079b30159fc0f6da2b568af334d14b32a0
2022-09-28 02:27:23 +00:00
c7c2e8d7e6
Avoid syncing voice interaction background window for skipAnim=true.
...
Test: Manual
Fix: 236924161
Change-Id: Iaf95221678d36f9b5782fd8c4bda626b946565a9
2022-09-27 23:36:24 +00:00
ba7324e2b8
Update animations for phones: Overview > OverviewSplitSelect transition
...
This change updates the animation for initiating a split from the Overview screen on phones. Includes new timings and interpolators, and extends timing data classes related to SplitAnimationTimings.
Fixes a noticeable issue where the split animation appeared slow on phones.
Outstanding issues (fixes in progress):
- Repeated invocations of split on phones cause an erroneous animation to play. (b/249154347)
- Thumbnail corners do not match placeholder corners; the transition between the two is slightly janky. (b/236761794)
- Placeholder icons should be 72dp. (b/236761794)
Bug: 236761794
Test: Manual
Change-Id: Ibb97ef54498b0aa9556df531d8084799259c06e2
2022-09-27 11:45:02 -04:00
bcf93ab762
Merge "Set up a place holder tile for desktop" into tm-qpr-dev am: aeea6768e6 am: 98b79c3e11
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914914
Change-Id: I6b3003aa4b61ff76dfc68bd2a10607b5bb27e9a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-27 00:34:20 +00:00
aeea6768e6
Merge "Set up a place holder tile for desktop" into tm-qpr-dev
2022-09-26 23:43:19 +00:00
80014b118a
Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev am: 815018be9a am: 7fc8bf0c25
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040590
Change-Id: I4b1e3d676569c0f06f4963b3c83727d534fd40f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-26 23:31:49 +00:00
815018be9a
Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev
2022-09-26 22:56:06 +00:00
731ef0c301
Properly color taskbar nav buttons when slide-in view is shown.
...
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.
Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A
Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789
Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
b2f95fc310
Merge "Don't moveToRestState from onTaskAppeared" into tm-qpr-dev am: 34461ba303 am: 7092878a57
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040404
Change-Id: I1bec67413cc4e502f5721181912e9d46760a9d1c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-24 07:41:57 +00:00
34461ba303
Merge "Don't moveToRestState from onTaskAppeared" into tm-qpr-dev
2022-09-24 06:44:17 +00:00
919ddf19f3
Set up a place holder tile for desktop
...
Create a placeholder tile in recents for desktop.
It is based on launcher task information. With extra flag indicating it
is for desktop.
When it is clicked, it will call sysui to show apps on desktop.
Test: manually verify that desktop tasks do not show up separately in
recents
Bug: 244348395
Change-Id: I8535a54e1545841cd988d4770e6fc5e857277cda
2022-09-23 16:28:48 -07:00
017bbc098a
Don't moveToRestState from onTaskAppeared
...
There's a possible race here where we call moveToRestState before
Launcher is actually stopped, so it starts to animate the state
change, causing a visual jump before it gets stopped. We already call
moveToRestState in StatefulActivity#onStop, so this one shouldn't be
necessary anyway.
Test: Enable Winscope tracing, quick switch from app A to app B; before
this change, 9/10 times it would repro the jump in the bug, 0/10 times
after this fix. (Also verified through debug logging.)
Fixes: 244583136
Change-Id: I656b028f26a64f872960cb3fe87c39b097431511
2022-09-23 14:14:52 -07:00
decbdfdd80
Merge "Set package name on the floating intent" into tm-qpr-dev am: dea0a2466b am: bfd21f48a9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20027851
Change-Id: I4fd14e90a76a7dee682a316c859792042de0955d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 18:51:49 +00:00
dea0a2466b
Merge "Set package name on the floating intent" into tm-qpr-dev
2022-09-23 17:50:53 +00:00
c14bdbaa82
Merge "Check for null when calling getCreatedActivity which is marked as Nullable" into tm-qpr-dev am: 8c158770d7 am: f5ff31ab74
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20025053
Change-Id: I0e11c6600525923fe1054da5bc70dc3e97c96bc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 17:08:47 +00:00
8c158770d7
Merge "Check for null when calling getCreatedActivity which is marked as Nullable" into tm-qpr-dev
2022-09-23 15:19:43 +00:00
090a9fc219
Merge "Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"" into tm-qpr-dev am: d859a20086 am: 47104adfd6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20028589
Change-Id: I6a947e2b02cdb58b863a120345999594fd983624
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 07:46:51 +00:00
1f65b9d8d4
Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev am: 061e6f5dd5 am: d563e886a1
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20015839
Change-Id: Iaa1845bce0558d18c3814802e68909c3f25bdcca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 07:45:39 +00:00
dcbd4917e3
Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev am: 418b1f8e82 am: d496c3d20d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19611434
Change-Id: Ic6677741689b4c609ef2fd86aa2832730dd479f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 06:27:32 +00:00
443407fd2d
Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev am: 13b7e00fff am: 6d37424c94
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19874561
Change-Id: I7ca43d2d6c8f6fbc7015d95061c30d6160daf0f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 05:43:24 +00:00
d859a20086
Merge "Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"" into tm-qpr-dev
2022-09-23 04:33:22 +00:00
26fee57f37
Null out mSplitHiddenTaskView when resetting split selection state
...
* May have accidentally been removed in ag/19984439
Fixes: 248153819
Test: Repro in bug doesn't occur
Change-Id: Icdc04de84c28963d36368f9672baf5993cd87d8a
2022-09-22 16:27:47 -07:00
8ae6b852d7
Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"
...
This reverts commit 240b064cdb
2022-09-22 22:10:20 +00:00
061e6f5dd5
Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev
2022-09-22 21:56:55 +00:00
ceff6537ee
Set package name on the floating intent
...
Test: treehugger
Bug: 237678727
Change-Id: I70923e62893cd6578fa3fa21e025cd5cf5e15edf
2022-09-22 12:08:41 -07:00
e7c222cdb5
Check for null when calling getCreatedActivity which is marked as Nullable
...
Fix: 243508135
Test: compiles
Change-Id: Id1ff2cf68fa10690a1bbec60a0c17cceab9db8d1
2022-09-22 13:03:15 -05:00
418b1f8e82
Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev
2022-09-22 17:25:24 +00:00
13b7e00fff
Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev
2022-09-22 14:58:13 +00:00
112d516f59
Merge "Fix taskbar instrumentation crash" into tm-qpr-dev am: 98e4e461fe am: a2c42f1696
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19964665
Change-Id: I93406800a8e2abd7ff972940eb76169705f6e501
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-22 10:08:13 +00:00
98e4e461fe
Merge "Fix taskbar instrumentation crash" into tm-qpr-dev
2022-09-22 08:28:41 +00:00
Thales Lima
Vinit Nayak
Jeremy Sim
Stefan Andonian
Arthur Hung
Brian Isganitis
Ats Jenk
Tony Wickham
Mady Mellor
Sebastián Franco
Winson Chung
Schneider Victor-tulias
Nicolò Mazzucato