ItemDecorator uses item position which is not stable during animations.
Moving it to the background allows the padding to be stable
Bug: 236961658
Test: Verified that the app doesn't crash.
Change-Id: Ied12077de4097e827c5c4157f5196346a301f185
Ex) for tablets.. the nav bar height is really the height of the taskbar.
Thats why we add the current padding of the work toggle button to the
taskbar size.
As of patchset 3.. I reverted mDevice.getInsets().bottom because it caused
the button to be higher than it should be on landscape.
Bug: 235053326
Test: Manual (pictures in bug thread)
Change-Id: I2f77d759ae060311d049182e8347dede590cd0b0
Running the following commands should change your connected
device display:
adb root
adb shell setprop ro.test_harness 1
adb shell pm enable --user 0 com.google.android.apps.nexuslauncher/com.android.launcher3.testing.TestInformationProvider
adb shell content call --uri content://com.google.android.apps.nexuslauncher.TestInfo --method emulate-display --extra device:s:pixel5 --extra grid:s:crazy_big
adb shell setprop ro.test_harness 0
Alternative method for this is using
./display_emulator.py emulate --device pixel5
I hooked up the existing DisplayEmulator into a content
provider. Doing this has a couple advantages to the previous method
of calling the emulator inside of a test. The biggest one is
that running the emulation doesn't restarts the Launcher3,
and because of that the previous method could leave the user in a
fake emulation where it looks like the device is being emulated but
is not 100% accurate.
Test: Run the command lines described above.
Fix: 229666646
Change-Id: Ia039fbaf4c7330d6bdf469633127f58d2466a1bf
Fix: 234847755
Test: With a modified local build, when changing display config to swap between same grid:
- When dbFile is same but device type is different, no migration is performed
- When both dbFile and device type are different, migration is performed properly
Test: Grid migration through Wallpaper & Styles still works properly
Change-Id: Ie7429a7d59c135ba47061cae21c40b8d8af7188a
This reverts commit d3e8cc40b4.
Reason for revert: b/231312158 is fixed, log is no longer needed
Fix: 231851651
Change-Id: I3ea8b9d14e7eb6f8f9c794c5d15cdfc94153d392
Also using itemType instead of item object for widget size cache
Bug: 234008165
Test: Verified on device
Change-Id: Ia4b4a00a11627c0c454e4a699570e8ab1667a390
- Added a QSB to taskbar to be animated between inline QSB and taskbar
- Passed endValue of taskbar animator to TaskbarController to have aniamtion variation between home -> app and app -> home
- Tuned duartion of taskbar animation and also stagger animation when taskbar is present
- Disabled scaling down of taskbar and inline QSB for home -> app
- Disabled stagger animation of taskbar and inline QSB for app -> home
Bug: 220733187
Test: manual
Change-Id: I4aac0bbc343b992a0472298595770e2bf2a55990
Test: open a random app that hasn't been opened in a while, touch down
on nav handle and see if RecentsView scrolls partially or fully
offscreen; repeat 20 times to be sure
Bug: 233112195
Fixes: 235369468
Change-Id: Ie8b3dbea7c4826af037edf22360946105ab22134
Previously, the implementation used the entire screen width
within it's calculations to determine where the button should be placed.
This is wrong because allApps have it's own container which we should
take the width from. The current implementation works fine because
the width of the screen for phones is the same width as the allApps container
BUT this implemention is WRONG for tablets. With now using the
allApps width for the calculation .. it works for both tablets/phones.
Bug: 235054324
Test: Photos in bug thread
Change-Id: I4c771d310a5d33646ad618e9c241cb5662493747
This crash will occur every time user swipes back and
there is not a view to return to
Introduced in I56cda07f3eccc11e8909f7fb28210f65cc6e0f1d
Bug: 235494234
Test: manual
Change-Id: I1261afcefec8fed4be20ab9ef439a50bc706d464
Bug: 234648831
Test: touch outside recycler view inside container, doesn't swipe left/right
TL;DR;;
As the definition of ActiveRecyclerView changed in latest refactor,
scrollbar existence is no longer a condition to consume
touch event if user is in isSearching state.
Change-Id: Iec97fb036ad45796a77c59d35f329744398d4953
Sunny Goyal
Sebastián Franco
Brandon Dayauon
TreeHugger Robot
Alex Chau
Thales Lima
Hyunyoung Song
Tony Wickham
Becky Qiu
Andy Wickham
Jon Miranda
Brian Isganitis