Commit Graph

3389 Commits

Author SHA1 Message Date
Adrian Roos 1f375ab633 Dump open files if we run out of file descriptors
Bug: 12782843
Change-Id: I7254c2cb6c3f721a06b9301d674c9560f86dfde6
2014-04-29 23:15:01 +02:00
Jason Monk 4ff73887f2 Don't close folder when adding something to it
Remove the call that closes a folder when something from All Apps
is added to it.

Bug: 14273032
Change-Id: Iac970a5c997fd254eae006be75cfbba9826f47af
2014-04-24 16:53:23 -04:00
Jason Monk 031d0ff4ad Merge "Fix accessibility announce on apps page" into ub-now-nova 2014-04-24 16:33:07 +00:00
Jason Monk ed05f09aa1 Fix accessibility announce on apps page
Stops the workspace from announcing incorrectly while the apps
page is open, also makes the apps announce which page on opening.

Bug: 13006306
Change-Id: I723011fc55c24b66604a24b16c17bac4f5653f84
2014-04-24 10:13:05 -04:00
Jason Monk 490d6941fa Merge "Fix long press after already moving off icon" into ub-now-nova 2014-04-23 18:55:48 +00:00
Adam Cohen 16f645542a Merge "Second try removing orphaned items from the database" into ub-now-nova 2014-04-23 18:21:15 +00:00
Jason Monk 050eaf2a87 Merge "Add synchronization to DeferredBindRunnables" into ub-now-nova 2014-04-23 16:39:12 +00:00
Adam Cohen f9c14de995 Second try removing orphaned items from the database
-> Delete items contained directly on the desktop whose screens
   no longer exist (do not remove items contained in hotseat or
   folders, except as described below)
-> Delete items contained by folder ids which are no longer present
   (ie. orphaned as their parent folder no long exists)

Change-Id: I2f47cc970ce00677cb1c83c0f0a2d13b6f16a33e
2014-04-22 16:11:40 -07:00
Jeff Sharkey 27b4e0f7d6 am 5aeef581: Add support for partner customization.
* commit '5aeef58131e1c330d1d9c1dfcacf2e6eea6ced4b':
  Add support for partner customization.
2014-04-22 21:02:11 +00:00
Jeff Sharkey 5aeef58131 Add support for partner customization.
Traditionally Launcher workspace customization is offered through
overlays at build time, but we don't have access to partner-specific
customization at build time.  To solve this, this adds a new
"partner-folder" tag which points at an XML resource provided by
an external package.

The external package XML can't depend on the binary XML attributes
defined by Launcher3, so we switch to using manual string-based
attribute lookups.  Partners can also provide extra wallpapers.

When a folder only results in a single item, promote that item into
the folder location instead of deleting completely.

Bug: 13340779
Change-Id: Ide558288bef4113565f288b700d8245055c0fee9
2014-04-22 12:28:51 -07:00
Jason Monk a0a7a7440e Add synchronization to DeferredBindRunnables
Seems that on occasion the list is being iterated on while being
modified.  To fix this added synchronization to all modifications
to the list as well as iterating on a copy of the list to cut
down on time holding the lock.

Bug: 12885709
Change-Id: I4287bdedbeb8e438b49c1f79b44819a752c28a69
2014-04-22 10:33:33 -04:00
Jason Monk 02dd7aea3d Fix long press after already moving off icon
When an icon is in the Hotseat and a user drags off from the icon,
but continues holding down, the icon gets a long press triggered
by the CheckLongPressHelper.

To fix this a check has been added on move events to see if the
point has moved outside the view and to cancel the long press
check callback if it has.

Bug: 13569451
Change-Id: Id175cdc220d70b5e9f8e492ed5a3cc7c3f11db10
2014-04-22 10:27:01 -04:00
Sameer Padala be3e410b7a Fix source code so it compiles on google3
This is a follow up to cr/65191596 which checked for String + array warnings.

Change-Id: Id70eaa32b63b838b03be21d632c7470039b6423f
2014-04-21 19:37:17 -07:00
Adam Cohen a8171169ff am 76ac344c: Merge "Allow the old launcher content URI to be overrided" into ub-now-mister-ugly
* commit '76ac344cb61a74267c04249c9e9feec41a82c504':
  Allow the old launcher content URI to be overrided
2014-04-18 21:32:23 +00:00
Adam Cohen 76ac344cb6 Merge "Allow the old launcher content URI to be overrided" into ub-now-mister-ugly 2014-04-17 00:53:52 +00:00
Chris Wren d83ebf9270 DO NOT MERGE disable launcher restore for 3.4 launch.
Change-Id: I8e439df25cad2cb9cf92cf1faef22906420e22cb
2014-04-16 14:10:10 -04:00
Chris Wren b358f813c9 additional debug logs to track welcome back behavior.
Bug: 13568891
Change-Id: I359202ce59b3444e46331485ea22f542ae908e36
2014-04-16 13:37:00 -04:00
Mathew Inwood ad9c776bc1 am 85900298: Take account of bounds set on drag drawables.
* commit '859002985e0e5d73f54c942f2024607431db60fc':
  Take account of bounds set on drag drawables.
2014-04-16 16:30:01 +00:00
Mathew Inwood 859002985e Take account of bounds set on drag drawables.
If bounds are set on a compound drawable in a textview, drawing it into a
bitmap set to the intrinsic size of the drawable results in it being scaled
down in the top corner. Scaling it down again into the grid icon size then
gives a tiny icon.

Use the drawable bounds if any are set, otherwise use the intrinsic size.

Bug: 14103508
Change-Id: Idadd7bb891dc33d092eb9ceb3025b9a5d9e1bfd8
2014-04-16 14:17:39 +01:00
Adrian Roos 65d60e21ec Fix skia crash in widget preview loading
This fix works making sure all drawables are mutated before drawing
them in the background. Mutation has to be executed on the main
thread because that operation is not thread safe.

Bug: 12525890
Change-Id: Id7bdf9cf48d3e7b7f31938bdea4a3bf1632cf337
2014-04-16 14:16:14 +02:00
Chris Wren 1a1fdf4185 turn off LauncherAppState.DEBUG
Change-Id: Ia6d54235c353c27c8716d7fd9270a7f2ee7bc93f
2014-04-15 13:57:15 -04:00
Winson Chung babb53ef8f Adding external path for drag/drops.
Change-Id: I3b315c4d14cadb9210f15d3c3e0b9545f4591be4
2014-04-14 18:44:21 -07:00
Mathew Inwood b90860a996 Expose workspace.moveToDefaultScreen.
This is to allow derived launcher classes to move the workspace to the
default screen when a drag is started, in case the current screen is not
capable of acting as a drop target.

Bug: 13962574
Change-Id: I8a6e94ce08be825c344beb708d244d2def5f319f
2014-04-11 17:22:56 +01:00
Adam Cohen a7946070dc Fix serious data loss issue for folders and hotseat items
Change-Id: I37a5b44c670c2a1f99eb97b77cfdbc78534fdf91

bug 13964735
2014-04-11 01:13:46 +00:00
Adam Cohen f6a47bbc05 Merge "Ensure the intro view is always the top view in the draglayer if it is present" into ub-now-mister-ugly 2014-04-09 17:37:26 +00:00
Adam Cohen 646fdf70b4 Upping activity start delay
Change-Id: I4b72ae9d719825e1be8f1feb3643f9311dde2534
2014-04-08 17:02:08 -07:00
Adam Cohen b670f195ff Ensure the intro view is always the top view in the draglayer if it is present
-> On devices post-api-16, we can achieve this just with child drawing order
   but on level 16 devices, child drawing order doesn't give us touch
   dispatch which is problematic for the intro screen.

issue 13796017

Change-Id: Ibf89ae91d8489f2de1eb9c8f235a0e6e6aed1847
2014-04-08 16:56:09 -07:00
Adam Cohen c4cf34dedb Merge "Fix pre sdk-18 compatibility (crash in dispatchDraw)" into ub-now-mister-ugly 2014-04-07 22:32:58 +00:00
Adam Cohen 2d783ce2f4 Fix pre sdk-18 compatibility (crash in dispatchDraw)
issue 13801679

Change-Id: I25b997179fd8eb7cdec6fc48d81533fb1c3094ce
2014-04-07 14:12:54 -07:00
Adam Cohen 5955121742 Merge "Attempt to fix crash on workspace drag and drop on certain JB devices" into ub-now-mister-ugly 2014-04-05 00:13:46 +00:00
Winson Chung 69dffdb83a Disabling the focused hotseat app cling if GEL is not preinstalled on the device. (Bug. 13551957)
Change-Id: I24b25a0eada1ac9273a57b02d80a2451d08b02b0
2014-04-04 17:06:02 -07:00
Adam Cohen d3a4e420f8 Attempt to fix crash on workspace drag and drop on certain JB devices
issue 13801679

Change-Id: I4769220ddeab566a869050b20d6064809c70bc19
2014-04-04 16:53:02 -07:00
Adam Cohen eaabe7c89a Merge "Cleanup orphaned workspace items on db upgrade" into ub-now-mister-ugly 2014-04-04 20:42:10 +00:00
Adam Cohen 8f006edba2 Prevent exception in production when icons collide during bind
-> We only need to throw an exception for dogfooders so we can
   track the issue
-> Worst case, an icon is ignored, does not warrant a crash.

issue 12106766

Change-Id: I054a849eb3d65762dc5e1bf699c76655f687c3e8
2014-04-03 18:14:30 -07:00
Adam Cohen 119285e755 Cleanup orphaned workspace items on db upgrade
-> Any workspace item whose screen id is not present in the
   screens table is removed from the database. This is
   intended to restore database consistency.

issue 13741729

Change-Id: I9a04b4165f1d85541025fcf48ddf2ad9e39ae94e
2014-04-02 17:04:41 -07:00
Adam Cohen dcb173d0e3 Make sure the workspace screens don't get updated while workspace is loading
-> Found another path that could lead to the same issue
   [add shortcut with config activity to an existing folder,
   when config activity launches, kill launcher, configure
   shortcut. observe crash and data loss].
-> Plugged up above, and a couple other potential holes
-> Initial fix probably took care of the main issue

Issue 12523285

Change-Id: I29db9da4af4a8bf22047eb46bd49354447d04b8d
2014-04-01 14:31:51 -07:00
Adam Cohen 8440e7ce17 Merge "Increase delay before dismissing intro screen (issue 13691305)" into ub-now-mister-ugly 2014-03-31 15:10:34 +00:00
Adam Cohen 2252adea26 Increase delay before dismissing intro screen (issue 13691305)
Change-Id: I0b81d61b922278e0e72c3055086010612687c7d9
2014-03-28 15:29:07 -07:00
Adam Cohen 4a9423d6dd Add method to determine if first run activity has been shown (issue 13680732)
Change-Id: Ia0da4148fd0365c6ae9c3a5a4cff7118959f6382
2014-03-28 14:51:17 -07:00
Jason Monk 4dfbe82910 Merge "Fix missing stack trace on checkItemInfoLocked call" into ub-now-mister-ugly 2014-03-21 20:09:54 +00:00
Jason Monk 0bfccebc9b Allow the old launcher content URI to be overrided
Move the URI used to import favorites from launcher2 to be loaded
from a string resource.  This allows it to be overridden.

This will enable permissions fix for GoogleSearch.

Bug: 12058200
Change-Id: I31243fe89f545c9771d5cceffe1c9e7668a42bc5
2014-03-21 15:42:06 -04:00
Adam Cohen 36a6288545 Merge "Adding in-activity intro screen (issue 12905636)" into ub-now-mister-ugly 2014-03-20 22:34:11 +00:00
Jason Monk 8e19cf22a4 Fix missing stack trace on checkItemInfoLocked call
Just put this change into Launcher2, now adding to Launcher3

The call to checkItemInfoLocked from addItemToDatabase was missing a stack
trace so that if the check failed, the stack trace did not contain what
triggered the add.

Change-Id: Ia2e2aae20b16d4adadfe1da53b49e93073fab55c
2014-03-20 15:06:57 -04:00
Adam Cohen 432609a246 Adding in-activity intro screen (issue 12905636)
Change-Id: Ifb016ca6e5052fd91535b98a39f78569200955a8
2014-03-20 11:48:22 -07:00
Adrian Roos fa4c799a9b Fix concurrent drawable usage resulting in native crash
One of widget preview drawables was drawn concurrently from a thread pool,
causing a native Skia crash.

Bug: 12525890
Change-Id: I2dea7b86ba8b32237f40feff225657dcb2b0061b
2014-03-19 16:29:30 +01:00
Adrian Roos 5d2704fbb0 Clean up dead, ugly and wrong code in icon and widget preview loading
Removed and fixed serveral instances of dead code and small
bugs that grew in the widget preloading logic, discovered
while chasing a bug.

Bug: 12525890
Change-Id: I22e03eccecc07b73388cfd3c8462d947601c6e54
2014-03-19 16:27:35 +01:00
Mohammadinamul Sheik e769d1681e Merge "Add onClickPagedViewIcon to the Launcher." into ub-now-mister-ugly 2014-03-18 20:30:52 +00:00
Mohammadinamul Sheik 3b1a54a206 Add onClickPagedViewIcon to the Launcher.
Change-Id: I34505ee5c9a6fe6ddd1a9f3134829fe0481e8bc0
2014-03-18 11:28:19 -07:00
Anjali Koppal ef3784cf69 Merge "Add LauncherProviderChangeListener" into ub-now-mister-ugly 2014-03-17 23:47:21 +00:00
Anjali Koppal af63581cb6 Merge "Add Launcher.onDragStarted" into ub-now-mister-ugly 2014-03-17 23:22:58 +00:00