Commit Graph

2108 Commits

Author SHA1 Message Date
Shamali Patwa 1f2dabfb4e Merge "Re-enable the testDragCustomShortcut test in pre-submits" into main 2024-04-25 21:09:21 +00:00
Treehugger Robot d1a01bd8a3 Merge "testDragToFolder is stable; promoting to presubmit" into main 2024-04-25 19:43:57 +00:00
Shamali P 0dce4a0704 Re-enable the testDragCustomShortcut test in pre-submits
In follow up need to align the code that looks for widets to work for
two pane picker in tablets.

Bug: 322820039
Flag: N/A
Test: Presubmit enabled for test
Change-Id: If8a3a7867bbafd5a08ebaef6ed354105762a8a23
2024-04-25 19:13:53 +00:00
Treehugger Robot 2bed168c4d Merge "Reapply "add more unit tests for WorkspaceItemProcessor"" into main 2024-04-25 18:48:07 +00:00
Daniel Akinola e91b4b52ee Merge "Revert "Force calculator to launch in fullscreen for taskbar tests"" into main 2024-04-25 17:56:47 +00:00
Sebastián Franco 307bafc511 Merge "Adding screenrecord to get more information about the test" into main 2024-04-25 17:48:49 +00:00
Charlie Anderson 9ac6f42610 Reapply "add more unit tests for WorkspaceItemProcessor"
Also, add more unit tests around Widgets.

This reverts commit d9ed5f301b.

Test: Added unit tests
Flag: N/A
Bug: 330906931
Bug: 294386159

Change-Id: I8de74bce8bddd06e5ce1399d26253cb936281bee
2024-04-25 12:35:14 -04:00
Daniel Akinola 56ccf74899 Revert "Force calculator to launch in fullscreen for taskbar tests"
This reverts commit 8771dfe3dd.

Reason for revert: was only a temporary fix while investigating issue, should be unnecessary after ag/27089675 is landed.

Change-Id: I5963dc77f31eb45c1cdd100788b045891de2d716
2024-04-25 15:49:06 +00:00
Vadim Tryshev b63fd9b7e1 testDragToFolder is stable; promoting to presubmit
Bug: 187761685, 233075289
Test: presubmit
Flag: N/A
Change-Id: I303ea378cef3e05dfc19ce10c0fc3698a66ecf4c
2024-04-24 15:19:05 -07:00
Sebastián Franco 48d7c10a82 Merge "Make sure we keep the screen record even if the test succeeds" into main 2024-04-23 19:49:44 +00:00
Treehugger Robot 62a1a8a336 Merge "Move PreInstalled App List to UserCache." into main 2024-04-23 18:24:01 +00:00
Sunny Goyal edbe8e5ffc Merge "Fixing MainThreadInitializedObject" into main 2024-04-23 18:06:38 +00:00
Sebastian Franco ad15dd719e Make sure we keep the screen record even if the test succeeds
Bug: 322823478
Test: testEdu
Test: testDevicePressMenu
Flag: NA
Change-Id: Ia11d3cbc0a10e15d716b1845e3590bca2bd1ff76
2024-04-23 10:37:22 -07:00
Himanshu Gupta ae4631e6a3 Move PreInstalled App List to UserCache.
Bug: 333543006
Test: atest PrivateSpaceHeaderViewTest, AlphabeticalAppsListTest
Flag: NA
Change-Id: I84233c5a6406325d9e641b72ea8455911b46f65f
2024-04-23 15:28:01 +01:00
Sebastian Franco ea78903380 Adding screenrecord to get more information about the test
Test: testWorkspace
Flag: NA
Bug: 331261431
Change-Id: Ifeaa0fe287c2cbf0b9c1c468c494752fe7f35d37
2024-04-22 19:38:23 -07:00
Sunny Goyal 10fa016352 Fixing MainThreadInitializedObject
> Making SafeCloseable implementation mandatory, to prevent leaks during test and preview
> Removing getNoCreate method and defining executeIfCreated to avoid null pointer exceptions
> Fixing sandbox value leaking into main, by Checking sandbox against App context
> Converting sanbox to an interface instead a class

Bug: 335280439
Test: Presubmit
Flag: None
Change-Id: I951dcde871898e745ff6490a1c4f8fd1512888f5
2024-04-22 17:04:33 -07:00
dakinola 8771dfe3dd Force calculator to launch in fullscreen for taskbar tests
Taskbar tests are flaking when desktop windowing is enabled due to calculator app being launched in splitscreen unexpectedly during test setup (due to unexpected effect of DesktopModeLaunchParamsModifier on activity launch.) While looking into root cause, this temporary fix to address the test failures ensures that calculator app is always launched in fullscreen, by enforcing it with ActivityOptions.

Bug: 333446588
Bug: 333446588
Flag: None
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
Test: forrest build with CL (https://android-build.corp.google.com/builds/abtd/run/L47500030003265061)
Change-Id: If12e8490214aa1dd5de89ff8535495c2a0c1fe82
2024-04-22 21:42:09 +00:00
Federico Baron 9350e71447 Merge "Revert "Add screenrecord for simple reorder widgets test"" into main 2024-04-22 18:31:49 +00:00
Federico Baron 0e9fce7046 Revert "Add screenrecord for simple reorder widgets test"
This reverts commit 8248279894.

Reason for revert: test stopped failing

Change-Id: I7993e38124530bdb0bdbb3447a449bd727b56d0a
2024-04-22 16:45:41 +00:00
Charlie Anderson 299e42cf8d Merge "Fix NPE for where intent.package is null but targetpkg is not." into main 2024-04-19 15:10:20 +00:00
Charlie Anderson ce255ff6fd Fix NPE for where intent.package is null but targetpkg is not.
- Also update WorkspaceItemProcessorTest with a new test and to use real intent instead of mock

Bug: 330250727
Test: unit tests
Flag: N/A
Change-Id: I77e17901f4754c301ca20b3c6f93bbe29bead59b
2024-04-18 17:48:27 -04:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
2024-04-18 14:32:33 -07:00
Federico Baron 6188ec4157 Merge "Make hotseat column span responsive" into main 2024-04-16 17:17:55 +00:00
Brandon Dayauon 31e713ee4c Merge changes If93e3975,Ifed45f06 into main
* changes:
  Fix views being visible after closing private space.
  Set attach consumer after animation finished
2024-04-16 15:14:26 +00:00
fbaron e4b0b71faa Make hotseat column span responsive
Flag: NONE
Test: DeviceProfileDumpTest, DeviceProfileAlternativeDumpTest, HomeScreenImageTest
Bug: 325084912
Change-Id: Ifa9e8066662a1ab053f66b8800b739d813d2dab8
2024-04-16 06:19:16 +00:00
Winson Chung 240956e7d8 Merge "Use shared method for updating the runtime status flags for an item info" into main 2024-04-16 02:59:54 +00:00
Stefan Andonian 0d2cc9e87c Merge "Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-04-16 02:42:04 +00:00
Stefan Andonian 1a626d2d05 Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit a80997d9eb.

Bug: 324670265
Test: Locally tested this, as well as ran it through post-submit via go/abdt with the fix.
Flag: NA
Reason for revert: Root-caused the issue with this, and will push the fix along with this revert.

Change-Id: I4bda53d94dfdb865883fef6ceec9dacd0b87f015
2024-04-15 18:28:25 +00:00
Anushree Ganjam 6642ea0d48 Merge "Add new class for SetPropRule and move outside ShellCommandRule." into main 2024-04-15 17:41:15 +00:00
Brandon Dayauon a271511240 Set attach consumer after animation finished
Its possible after the animation that attached view's alpha can still be stuck at 0 and never change.
This only happens when the view isn't in range to animate and after onBind() is already called.

Also added flag guarding to the animation as it seems to be forgotten since the big CL change moving
everything to privateProfileManager.

bug: 333506236
Test locally: https://screenshot.googleplex.com/8Kk6rLaczMPwr49 and https://screenshot.googleplex.com/9wXHeNuiCVFEMp6
manually: before https://drive.google.com/file/d/15hSqaUVjwE-lLp6IIv_mqwYbn_ITzR7s/view?usp=sharing
after: https://drive.google.com/file/d/15m7Al5H3vldFgIaQfFyulm1h92_Mgd0H/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation trunkfood

Change-Id: Ifed45f065b536bca5e8878b1bb95d16caf136ed6
2024-04-15 10:12:08 -07:00
Winson Chung 21cf4439d2 Use shared method for updating the runtime status flags for an item info
- The method AppInfo#updateRuntimeFlagsForActivityTarget should also
  both add and remove runtime flags to match the current state

Bug: 323112914
Test: atest NexusLauncherTests
Change-Id: If87acf1e2324f98cf1d96d194eac13a93fa432c1
2024-04-14 06:19:49 +00:00
Anushree Ganjam 8cac99a8dc Add new class for SetPropRule and move outside ShellCommandRule.
Clean up the mEnableInputTransportPublisherRule from TaplWidgetPickerTest since b/325377690 is fixed now.

This is follow up for ag/26419353.

Bug: 325377690
Test: Manual
Flag: NA
Change-Id: Id55000ac3cb4b88097ad00b97773c39a725711b8
2024-04-12 16:45:18 -07:00
Jagrut Desai 49d4429881 Fixing TaplUninstallRemoveTest#uninstallWorkspaceIcon test
Test: Presubmit
Bug: 319501259
Flag: NONE
Change-Id: I9566b947bc7d5d64953a8c637fefd4fa37cca87c
2024-04-12 11:37:27 -07:00
Vadim Tryshev 2a6ce15290 Merge "Removing users synchronously" into main 2024-04-12 17:19:36 +00:00
Brandon Dayauon c1de065650 Merge "Fix stale header height being used in scroll to header calculation" into main 2024-04-12 17:00:40 +00:00
Brandon Dayauon 5da04b231f Fix stale header height being used in scroll to header calculation
- This fixes the inconsistency of how far down is needed to scroll to since
the values used to calculate the header during drawOnScrimWithScaleAndBottomOffset() is faulty.
- Tweaked the row to scroll to when there are tabs vs no tabs. When there are no tabs, its possible the
header gets cut off most of the time hence subtracting by 1 will help this problem.

bug:332543940
Test locally: https://screenshot.googleplex.com/5y4vYiQcnSMKcA6
manual - before: https://drive.google.com/file/d/14Zj_FyO-3bVfXwuxaqgG_DXMELYS5bQn/view?usp=sharing
after with tabs:
after 5x5: https://drive.google.com/file/d/16rjaut6VqBMxG6uLQSnVTLRhUQnAANZ5/view?usp=sharing
after 4x5: https://drive.google.com/file/d/16jCPN8BewwuIQobt0t6tdVouUKpp1CdI/view?usp=sharing
after 4x4: https://drive.google.com/file/d/16VFQb5s6IfrpjRU9PmLlAJWjh1zIo77o/view?usp=sharing
after 3x3: https://drive.google.com/file/d/16VFQb5s6IfrpjRU9PmLlAJWjh1zIo77o/view?usp=sharing
after 2x2: https://drive.google.com/file/d/16N6Myuv9VtXgI1p4sIuV23iupea7jYLQ/view?usp=sharing

after no tabs:
after 5x5: https://drive.google.com/file/d/17H1oF_9fJnrtSqmJJqQyyn4upuM2CsoG/view?usp=sharing
after 4x5: https://drive.google.com/file/d/178Vu3SvnvSPODIfaR0oz6-jPVYDDNMaA/view?usp=sharing
after 4x4: https://drive.google.com/file/d/16yt_5ePPR7kwSrZlo5Sj3x0DqHoQKqYP/view?usp=sharing
after 3x3: https://drive.google.com/file/d/17HqebtHWcEHg-i9AfqHEVdl4YnQhX06P/view?usp=sharing
after 2x2: https://drive.google.com/file/d/17HqebtHWcEHg-i9AfqHEVdl4YnQhX06P/view?usp=sharing

after tablet:
landscape: https://drive.google.com/file/d/16JQGs0A3ifKpgqrpQwIzssrXbH-OC0Ej/view?usp=sharing
portrait: https://drive.google.com/file/d/16LmLnOEB6XkuAkAcgvP2mKHe5QQqG1oh/view?usp=sharing

Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: If8a70cc71e9cff4a7f8d3b648e3e59c414e40ee5
2024-04-11 16:22:11 -07:00
Vadim Tryshev 2c72271915 Removing users synchronously
Bug: 302400996
Test: presubmit
Flag: N/A
Change-Id: Iac1863039cbb9d612abe416b7aee135eec25f223
2024-04-11 15:59:41 -07:00
Randy Pfohl c21b0000b5 Revert^2 "fixing tests to match new abstraction"
8e4c0b7afb

Change-Id: I9875d6f9c16f1406d0818164a98e790c2b101650
2024-04-11 08:58:22 -07:00
Priyanka Advani 8e4c0b7afb Revert "fixing tests to match new abstraction"
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: Ibafc66cf3677d24e7912d55cb45c948cb6519df7
2024-04-10 21:31:14 +00:00
randypfohl f75709e78b fixing tests to match new abstraction
This change will let us move from activity to other parent views for recent viewss

Change-Id: I2424d94f799f87b2d2262da96b289aac6dfadee9
2024-04-10 09:14:38 -07:00
Sunny Goyal efc3c46419 Fixing null check causing test breakage
Bug: 333609600
Test: Presubmit
Flag: None
Change-Id: Ic44df00ba945c79010c2cf99a034cca2b5d6c161
2024-04-09 17:04:46 -07:00
Sunny Goyal 3b00e7909a Merge "Using resource override instead of code-swap for ApiWrapper" into main 2024-04-09 20:33:20 +00:00
Alex Chau 55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Sunny Goyal 11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Vadim Tryshev 5940c59a2c Merge "Honoring @PortraitLandscape annotation in presubmit" into main 2024-04-09 16:26:14 +00:00
Alex Chau 3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Uwais Ashraf 7a0150d02e Use script to auto-enable all tests that are currently working
Fix: 325088906
Test: presubmits passing, gradle robo run passing locally
Flag: NA
Change-Id: I481bfe9caeb8cc18b3e01ec8b7a58fb0eb36fdaa
2024-04-08 20:59:23 +00:00
Treehugger Robot adbdfe2ac7 Merge "Fix failing LauncherIntentTest." into main 2024-04-08 16:43:28 +00:00
Sebastián Franco 5ccac93d0a Merge "Adding even more tracing for the tests" into main 2024-04-05 18:26:54 +00:00
Himanshu Gupta b04262784d Fix failing LauncherIntentTest.
Bug: 332894108
Test: atest Launcher3Tests
Flag: NA
Change-Id: I654a45d5a9371aa9da74ae89a0513bf203e27981
2024-04-05 18:11:06 +01:00