Commit Graph

13856 Commits

Author SHA1 Message Date
Vinit Nayak 1eb79473aa Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: e9e0800fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7b4afd0d4eae8853e15c06c8f7f6472ef5035bf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:29:15 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brandon Dayauon 039036693a Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev am: 5ba5c76c76 am: cd9cffe63d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18512230

Change-Id: I9d35410f26d6e7ea42872e3029f51883aa65093e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 17:12:55 +00:00
Brandon Dayauon 5ba5c76c76 Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev 2022-05-26 16:06:02 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Brian Isganitis 0bc68242ee Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-qpr-dev 2022-05-25 20:27:21 +00:00
Abhilasha Chahal 91a9bf1ac3 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev am: d18c5085c5 am: 17318edce5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18457403

Change-Id: I43dafd3be5d6e46d49fe900a660cd34596b7feb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 19:39:44 +00:00
Abhilasha Chahal d18c5085c5 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev 2022-05-25 18:31:59 +00:00
Brian Isganitis 261dec20f7 Merge "Check if event is over All Apps correctly on large screens." into tm-qpr-dev 2022-05-25 18:13:33 +00:00
Brian Isganitis a9a78117c7 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-25 18:11:51 +00:00
Alex Chau 6329b20f43 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: I57dd855387257a8704f8529f14ea176562e63549
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:02 +00:00
Alex Chau 4ffebaa68c Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev am: a2ecf75082 am: 9899c3f028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580266

Change-Id: Ib8da8d3fa08aad0335b9d5cfcf50e2a5c2f12dbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:01 +00:00
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau a2ecf75082 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau 158caf466c Only setup SecondaryDropTarget in onDragStart
- In LauncherAccessibilityDelegate.getsupportedActions, it calls supportsAccessibilityDrop on each button regardless if DropTargetBar is visible or not. SecondaryDropTarget.supportsAccessibilityDrop attempts to setupUi which causes measure/layout of DropTargetBar (as well as DragLayer) each time LauncherAccessibilityDelegate.getsupportedActions is called
- To avoid this, only setupUi in onDragStart. In other cases don't call setUi.
- Also fixed a bug that when accessibility is on, upon dragging a suggested app, the secondary action suddenly changed to Uninstall

Fix: 233383721
Test: Enable accessibility, observe no excessive amount of onLayout is called on DropTargetBar
Change-Id: I4d1a00d320cceed81fa1312b5fc5f1081637bea8
2022-05-25 11:04:42 +00:00
Alex Chau e2e1509d55 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
(cherry picked from commit 51da219869)
Merged-In: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-25 10:53:29 +00:00
Brian Isganitis 5b8e3dd34e Check if event is over All Apps correctly on large screens.
Test: Manual
Fix: 232826650
Change-Id: Ia6a0aefe1a2886ba21150c7d65be5c5d95f18141
2022-05-25 00:19:11 +00:00
Andy Wickham 2ba7797edb Moves Search results into a separate RV (take 2).
Bug: 206905515
Test: Manually verified b/230648542 did not resurface. Tested
on phone and tablet with and without work profile.

Change-Id: If724f635286b9dff2c64255f9ece3568a5cb4ea9
2022-05-24 17:10:24 -07:00
Stefan Andonian ed2340ac0b Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev am: 748195421c am: 6213c103eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18579642

Change-Id: Ic79998268e0194dc2cd723ba66d8d9d819343e62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 23:48:27 +00:00
Stefan Andonian 748195421c Merge "Change accessibility announcement for workspace from "Pixel Launcher" to "Home"." into tm-dev 2022-05-24 22:47:50 +00:00
TreeHugger Robot 03b821a8f2 Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev am: 69149d07ff am: 0210441e55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580078

Change-Id: Ia134caf82253fa4d00e5dba1d7a6ff4488c5f467
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 20:56:35 +00:00
TreeHugger Robot 69149d07ff Merge "Fixing ConcurrentModificationException in FirstScreenBroadcast" into tm-dev 2022-05-24 19:52:32 +00:00
Sunny Goyal 1fa184c778 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev am: f7a48aae65 am: 6bea7c51d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18493941

Change-Id: I7274fde74b9c37b997546fc00f38cc85c8bd74f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:35 +00:00
Stefan Andonian 058c88bfce Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev am: af8b7d3313 am: 2e8f2e192b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18090271

Change-Id: I30e4c6c0884721519ecf5167f0b8c6aa68c18911
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:30 +00:00
Brandon Dayauon ded505e5d5 Merge "Fixes scroll bar issues." into tm-dev am: 6bb327888e am: 6c5ad138d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18566198

Change-Id: I95f22eda8f30537002b2f5b001eedae6876cf4d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:24 +00:00
Anushree Ganjam 1b5a2333fb Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev am: 223bfe0908 am: 5b39a7db99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18570019

Change-Id: I7562458f5f5e47d13bb016f0a4fe6e9034c3e77e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:15 +00:00
TreeHugger Robot 913831282f Merge "Fix widget span" into tm-dev am: ec3723beb1 am: 97e2f47199
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18579283

Change-Id: I632a9104fd8e22312b40f51b7dd572fe16acccad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 18:34:06 +00:00
Stefan Andonian 45fc301b0e Change accessibility announcement for workspace from "Pixel Launcher" to "Home".
Bug: 228410736
Test: Verified correct talkback announcements.
Change-Id: Ic0a5295cde3cd23d2fc5a6fcd19b6cf8e0f3e386
(cherry picked from commit 83bc5f5050)
2022-05-24 18:21:33 +00:00
Sunny Goyal f7a48aae65 Merge "Adding support for customiting the animation in PropertySetter" into tm-dev 2022-05-24 18:21:24 +00:00
Stefan Andonian af8b7d3313 Merge "Fix folder app icon truncation after rotating to landscape." into tm-dev 2022-05-24 18:19:03 +00:00
Brandon Dayauon 6bb327888e Merge "Fixes scroll bar issues." into tm-dev 2022-05-24 18:10:42 +00:00
Anushree Ganjam 223bfe0908 Merge "Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."" into tm-dev 2022-05-24 17:38:08 +00:00
Alex Chau 5b0193026a Center drop target button alignment across devices
- Partial re-land of http://ag/18520765

Fix: 229789612
Fix: 231711806
Test: manual
Change-Id: I0630c19901435a30379596378e9c0cd4beb2e764
2022-05-24 18:31:57 +01:00
TreeHugger Robot ec3723beb1 Merge "Fix widget span" into tm-dev 2022-05-24 17:31:13 +00:00
Sunny Goyal 425bfa320f Fixing ConcurrentModificationException in FirstScreenBroadcast
Bug: 232333237
Test: Not sure, unable to reproduce
Change-Id: I3eeabf76c14651d2fb64c82955851efa883760ce
2022-05-24 09:17:39 -07:00
Brandon Dayauon c472da1e5e Fixes scroll bar issues.
Fix issue where the letter bubble stays showing. Now it is able to disappear.
Fix fast scroll so its smoother and able to grab

Bug: 233607012
Bug: 233076260
Test: Manual
Change-Id: Ieccc72079602f4606da6ded7ee48d82440882ef7
2022-05-24 08:50:07 -07:00
Thales Lima 4f3cf5d05f Fix widget span
Need to take the horizontal margin of the view into consideration.

Fix: 233302799
Test: manual
Change-Id: I5f584977db85d5436b22c3701f586a5b079099ae
2022-05-24 14:49:26 +01:00
Cherry Ng d89f704671 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev am: 6a4ea4c849 am: f05363a7d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18568158

Change-Id: I2c64a8cb9bd2397b74b2d99aee65838a2b70df3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 02:50:04 +00:00
Anushree Ganjam 13b3922af9 Revert "Revert "Add "incrementEventCountBy" function to Onboardi..."
Revert submission 18568158-revert-18500283-dismissEduCard-SCFTOPONPS

Reason for revert: b/233680944 , This is a build merger issue. 
Reverted Changes:
Ia39781c78:Revert "Add "incrementEventCountBy" function to On...
Ibba14f7c2:Revert "Save the value to sharedPreference When ed...

Change-Id: I1c0e4be10cf7e9b21623a056604618cbea2639d4
2022-05-24 02:19:57 +00:00
Cherry Ng 6a4ea4c849 Merge "Revert "Add "incrementEventCountBy" function to OnboardingPrefs."" into tm-dev 2022-05-24 02:16:40 +00:00
TreeHugger Robot 4c48d57434 Merge "Do not launch home disambiguation screen when home is not known" into tm-qpr-dev 2022-05-24 02:03:09 +00:00
Anushree Ganjam 6367ff131c Merge "Add "incrementEventCountBy" function to OnboardingPrefs." into tm-dev am: 218703d5a9 am: bfc82b027e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18500283

Change-Id: I2715b9694e6c49e5b6e593be05eff3cb77fcea96
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 01:21:32 +00:00
Anushree Ganjam 514979dd2d Revert "Add "incrementEventCountBy" function to OnboardingPrefs."
Revert submission 18500283-dismissEduCard

Reason for revert: Reverting because of build failures.
Reverted Changes:
I727cefb70:Save the value to sharedPreference When edu card i...
I180ab3bd6:Add "incrementEventCountBy" function to Onboarding...

Change-Id: Ia39781c78776a629d4678c78dd4ca75f49abbb6d
2022-05-24 00:44:55 +00:00
Anushree Ganjam 218703d5a9 Merge "Add "incrementEventCountBy" function to OnboardingPrefs." into tm-dev 2022-05-23 23:55:36 +00:00
Stefan Andonian 28f61b5177 Fix folder app icon truncation after rotating to landscape.
The folder bubble text views were being recycled after the launcher's
cache was cleared. This caused the new orientation's folders to re-use
the old views with their stale configuration. After this change, the
cache won't recycle views whose cache entry has been recreated,
implying that their environment might have changed and new setup is
required.

Bug: 230304658
Test: Verified erroneous UX on device was no longer reproducible after fix.
Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
2022-05-23 23:42:04 +00:00
Sunny Goyal 4a35dd4f0d Do not launch home disambiguation screen when home is not known
Bug: 233071361
Test: Verified on device
Change-Id: I54e71e19363920b0778c328dc391575d0921f304
2022-05-23 23:30:58 +00:00
Abhilasha Chahal 50d8cf6d5e Merge "Add LAUNCHER_SYSTEM_SHORTCUT_APP_SHARE_TAP event" into tm-dev am: 23dd0006ad am: a57630d1e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18495984

Change-Id: I244889069e40b3c737485a4c9eeb04905cb7d071
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-23 23:02:24 +00:00