The psApp icon will have an original title "Private Space" but should
only be "Add" in the container.
bug: 360313403
Test: manually:
Before: https://hsv.googleplex.com/6348079987949568
After: https://hsv.googleplex.com/6126091247812608
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: Ifcb599cdb5f4a97e2da68cafa81f23b387a2beb6
Since psApp is supposedly a system app, private space team requests that
the icon changes according to theme like previous "install" icon. To do
so Launcher can apply the same treatment to the bitmapInfo as for
the private space app.
bug: 360313403
Test: manually video in bug
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I78f0d0dbb12d5cfba2cac7e7b53714e424a49660
Revert submission 29352757-update-usericoninfo
Reason for revert: <DroidMonitor created revert due to b/379000263. Will be verified through ABTD for standard investigation.>
Reverted changes: /q/submissionid:29352757-update-usericoninfo
Change-Id: I751536274ec9dcc4047bf9c76b3a5cab258da6e4
This issue is triggered due to onAppsUpdated() randomly due to app installing/uninstalling/updating/archiving. Eventually
onBind() is called but logs shows evidence that the state is correct (even though it doesn't reflect that), hence invalidating will fix this issue.
We can't call notifyItemChange() in updateView() since updateView() can be part of onBind() in which case means this is part of a scrolling gesture. notifyItemChange()
via adapter index will also not work in reset() since doing so will mess up upon animation.
bug: 373345958
Test: manual/presubmit
Flag: NONE invalidating when updateView() is called
Change-Id: Ibc99cc70562575cadf035136e50e9e5eec1e70ea
Suspect that the jump in these flakes where it cannot find the private space container is due to this calculateDiff call when onAppsUpdate() is called
bug: 355466672
Test: tapl presubmit and vid: https://drive.google.com/file/d/1hshI6g7oqvi45EiO92Rl4e-gaXfDVe_b/view?usp=sharing
Flag: NONE trying to fix flake
Change-Id: I0bff416624c5b9e2cb7a4fe32834f9d521507922
With the addition of floating mask views, settingsAlpha and textAlpha animation shouldn't be played in the beginning when animatorSet starts but more so during the parallel set. Otherwise, the text/settings alpha will start first before/same time as translationView. You can see this if you were to look at the video at the bottom of this commit message, specifically during the collapse case.
bug:355042924
Test manually -
before:https://drive.google.com/file/d/1BoCA5rlr9m3QDVfF5zfp9G12Ldst3kn0/view?usp=sharing
after:https://drive.google.com/file/d/1y84uxmAfJ7_SNh26jT2O-m2xOFWCMkJm/view?usp=sharing
Flag: com.android.launcher3.enable_private_space
Change-Id: I98248f4b9aa2a4e1287183710ffdc66093cef022
Provide logs at the end state to see if alpha/visibility is showing or not to indicate any reasons the issue may happen
because of the animation.
bug: 341053089
Test: N/A
Flag: com.android.launcher3.enable_private_space
Change-Id: Ib94bc955e2d061d1799040ac6180d150b24118fe
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.
Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9
Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class
bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
This is because during onBind() that the icon alpha should be set to 0 ONLY in the case
when animation + scroll is happening.
The repro cuj is this:
user has private space unlocked -> goes to toast and clicks qs tile -> onBind() happens
and animationScrolling = true -> icon alpha is now 0. Instead we should check getAnimate() && scrolling()
&& isStateTransitioning()
bug: 340836439
Test: manually -
before: https://drive.google.com/file/d/1WLZRPsz-hm1d3fVRNGXs_Ps_AcdJhkPs/view?usp=sharing
after: https://drive.google.com/file/d/1LidDKhx2ijOXmX_tcPAmng5P56WNPyyx/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation NEXTFOOD
Change-Id: I10b8ee5d8449acdb3d2c64e0e311f7dde89a464a
Need to create a bug-fix flag since feature flags can't reach nextfood in time for V. We do this by renaming
the current flag.
According to https://g3doc.corp.google.com/company/teams/android-core-experiments/trunk-stable/gantry-stages/bug-fix.md?cl=head
After a flag declaration has been merged, it's no longer possible to change its purpose. If the purpose of a flag changes over time, simply rename the flag; this will create a new workflow and invalidate the previous workflow.
In cases where renaming is not possible, please file a bug for the ACE oncall. Even when re-using the name of a flag for a new purpose, please note that all the progress in the pre-existing workflow will be lost; the new bug-fix workflow will start from scratch.
bug: 339850589
Test: Presubmit/locally adb shell device_config put launcher_search com.android.launcher3.private_space_add_floating_mask_view true
Flag: ACONFIG com.android.launcher3.private_space_add_floating_mask_view STAGING
Change-Id: Iffbc6a93c4ef6bbe121e0c8fb83250174f367b9d
- On expand, we add the floating mask view and translate it out at the end.
- On collapse, we translate off the mask view in the beginning once the floating mask view is added
so that we can translate it in before the actual collapsing part of the animation
bug:339850589
Test manually:
https://drive.google.com/file/d/1YNc3vq9Cb5BcbcPOHp8H3lhe6KmYBdLI/view?usp=sharing
Flag:ACONFIG com.android.launcher3.private_space_floating_mask_view STAGING
Change-Id: I7c303e6629d83408bd314886fe10113246e44dcb
Referencing the view by ID animates correctly. Passed in views are supposedly not the same
and therefore, not animating the correct thing. (fixes on the device that can repro issue).
Bug:339179262
Bug:299294792
Test manually verified on device that can repro:https://drive.google.com/file/d/16L4wEroGEDsp_BIkmoARg9vR43upF6_8/view?usp=sharing
Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I20b06cc50928c35afa3dc1e8800b3a5bff0769be
The entire animation is 800ms where there are differences between lock/unlock.
Unlock 1.0:
app Opacity: time = 400 -> 800ms Linear
text opacity: time = 500 -> 800ms Linear
settingsAndLockGroup "size": time = 400 -> 800ms Standard
settingsGear: time = 400 -> 800ms Linear
Lock 2.0:
app Opacity: time = 0 -> 400ms Linear
text opacity: time = 0 -> 50ms Linear
settingsAndLockGroup "size": time = 0 -> 400ms Standard
settingsGear: time = 0 -> 400 Linear
bug:299294792
Test manually video:
after: https://drive.google.com/file/d/1_Y5I7vQhDHPX8DLM_rSM3mV9DrVN0v-q/view?usp=sharing
after 10x: https://drive.google.com/file/d/1_WLz2ijLs19qE1vYA9zdXF9YZB_CqMns/view?usp=sharing
Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I8a578e70bb834f403075824785fa9b4d8825858c
This Cl contains:
1. Alt text for Lock/Unlock button as per state.
2. Alt text for Header when Locked.
3. Removing Header from accessibility target when unlocked.
Bug: 328024119
Test: Manual
Flag: NA
Change-Id: I791176afdae4fc6eb9387080aa036c1aed2a03a9
- Setting the button's user via iteminfo to the privateprofile user
doesn't let the user to go into the play store. This was initially done so that
we can check the itemInfo to see if item is private space instead of just checking
if the item has a decorationInfo for collapse animation.
- The itemInfo change is reverted and we can check that case by checking with instanceOf PrivateSpaceInstallAppButtonInfo
bug:335600922
Test manually video: https://drive.google.com/file/d/1N2zOHvPmBptBaBf8SCqjBAM6UhV0lQBI/view?usp=sharing
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD
Change-Id: I09f22c9df5b4f9408eea6995eafea83e30c93a0d
Its possible views are still being binded before the app list is refreshed.
So instead make the views gone in that case (by making sure private profile is disabled).
Fixes:
- install app icon still showing because it is not identified as a private space item
- Divider still containing a decorator when collapsing before app list is refreshed.
bug: 334868779
Test video manualy:
before:https://drive.google.com/file/d/1IWdGsTSq7-xRZKOJso-5p9g-j7RTEkas/view?usp=sharing
after:https://drive.google.com/file/d/1IVNTksryFi5o4uHzZtzNC0Yz7-rxrje3/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation trunkfood
Change-Id: If93e39753352741fb6f0728f717a67b7f9315d0b
Sunny Goyal
Andy Wickham
Brandon Dayauon
Himanshu Gupta
Pechetty Sravani (xWF)
Olivier Nshimiye
Anna Zhuravleva