Commit Graph

9368 Commits

Author SHA1 Message Date
Mateusz Cicheński 357f68275c Reparent PiP overlay under task as soon as possible
For enter PiP animations started from Launcher, we send the signal to
WMShell to reparent the overlay under task as soon as possible.

This avoids flicker issue caused by race condition of cleaning up the
transition leash before the reparenting was done, which made the issue
of overlay being not attached to anything for few frames.

Bug: 281711939
Test: winscope trace from comment#28, leash follows task
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/ewrarENSYYOmUCa0b3fdtp

Change-Id: Ia16afd49a94d9ba8456287c2cdffb2a84e5a2bc7
2023-06-20 21:04:24 +00:00
Jagrut Desai bde7e310c5 Merge "Match Navigation Icon Colors Folded/unfolded" into udc-qpr-dev 2023-06-20 20:04:55 +00:00
Andy Wickham a3808a8e33 Merge "Revert "Switch ScrimView to use view alpha"" into udc-qpr-dev 2023-06-20 17:04:42 +00:00
Randy Pfohl bdfaf926b4 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev am: 6ec21cbe45 am: 7f44f3c6b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23699415

Change-Id: I68ba3799ec44f1910e8ea2327fe5de519ef538c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 16:56:14 +00:00
Treehugger Robot a81e601afc Merge "Don't remove the overflow from the bubble bar" into udc-qpr-dev 2023-06-20 16:29:03 +00:00
Jon Miranda 883ce5f131 Merge "Fade in/out taskbar bg alpha when unstash/stashing." into udc-dev am: 613cc95c8a am: 004ed77d11
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23696768

Change-Id: I7ed64a239bff6254151032758bc8ca9cff360c49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-19 06:45:22 +00:00
Randy Pfohl 6ec21cbe45 Merge "Aligning the intialization process with groupedtaskview to set content description Test: built locally, tested against tablet with bluetooth keyboard." into udc-dev 2023-06-16 23:18:02 +00:00
Jagrut Desai 6bf3af0b81 Match Navigation Icon Colors Folded/unfolded
Recently we did color token migration for Taskbar which included navigation icon also, but phones and foldable device can't really adapt to new color tokens because of contrast issue with underlying wallpapers.

As a result, now home screen which default back to balck and white nav icon colors while all apps and in app navigation icon color will be themed to new GM3 Color tokens.

Test: Manual
Bug: 284408922
Flag: Not needed
Change-Id: I8c8ea11ebb7237885ae4673fda0409ab463b37db
2023-06-16 20:13:15 +00:00
Liran Binyamin cd5591a773 Don't remove the overflow from the bubble bar
When a new bubble is added to the bar and we're over the limit
remove the second to last bubble instead of the overflow.

This change also updates the key of the overflow bubble to
match the one in wmshell.

Bug: 287121592
Test: manual - Add 6 bubbles to the bubble bar
             - The overflow bubble should still be there
Change-Id: Ibd3ab73be5d3afb49f771a1925ebda2c45b55136
2023-06-16 14:51:33 -04:00
Schneider Victor-tulias af1932ebf7 Merge "Remove TIS command line arg handling" into udc-qpr-dev 2023-06-16 18:10:50 +00:00
Jeremy Sim 5ee79af27e Merge "Fix two bugs with thumbnail screenshotting for split apps" into udc-qpr-dev 2023-06-16 00:03:27 +00:00
Andy Wickham 88dd86bda9 Revert "Switch ScrimView to use view alpha"
This reverts commit 99c4becf24.

Reason for revert: b/287488354

Change-Id: Ic4db08ca771f1d744ba2c19eb55b9f2d277ad529
2023-06-15 22:27:28 +00:00
Jon Miranda bfd7f9cb6d Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev am: 6352c9bc88 am: b375d82a55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23678091

Change-Id: I5f5299385f50b09b39833b3bea04647e571d36b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 22:16:48 +00:00
randypfohl 3c2ab1de45 Aligning the intialization process with groupedtaskview to set content description
Test: built locally, tested against tablet with bluetooth keyboard.

Bug: 287287064
Change-Id: I2be667b2a4b0a08f73c3233a05bbaf7eec08c0e4
2023-06-15 15:11:57 -07:00
Schneider Victor-tulias 8ab395c445 Remove TIS command line arg handling
These args did not have much usage and only complicate the code.

Flag: not needed
Fixes: 287306282
Test: dumped TIS logs
Change-Id: Iafc07723345d8ddbe15f7ca280579f6b42d5c3b6
2023-06-15 17:55:11 +00:00
Jon Miranda 613cc95c8a Merge "Fade in/out taskbar bg alpha when unstash/stashing." into udc-dev 2023-06-15 00:02:02 +00:00
Jon Miranda d76713eb08 Fade in/out taskbar bg alpha when unstash/stashing.
This prevents the case where we are drawing both the taskbar bg
renderer and the stashed handle at the same time.

Fixes: 287245176
Test: go home/overview, open/close notif shade, stash/unstash in app
Change-Id: Ib025a0cf1ad5fd8a9afd079aa50210f3b2388d8e
2023-06-14 14:04:27 -07:00
Treehugger Robot 77110f977f Merge "Polish redesgined tutorial home and overview animations" into udc-dev 2023-06-14 18:35:21 +00:00
Vinit Nayak 9ab1a4a835 Merge "Remove mFirstFloatingTaskView from recents view" into udc-qpr-dev 2023-06-14 16:31:23 +00:00
Jon Miranda 6352c9bc88 Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev 2023-06-14 01:10:08 +00:00
Sihua Ma d655e07dcc Merge "Fix widget foreground disappearing when swiping back" into udc-qpr-dev 2023-06-14 00:03:34 +00:00
Jeremy Sim 174ba93ed5 Fix two bugs with thumbnail screenshotting for split apps
This patch fixes two bugs with the thumbnail screenshotting flow for split apps. There is no currently filed bug behavior for these bugs, but they look wrong in the code -- this is the proposed fix/refactor.

Fixes: 285191462
Test: Still passes presubmit
Change-Id: I43eefa334d66676b8175919e266b82947f1837e5
2023-06-13 22:14:52 +00:00
Jon Miranda a6653ae660 Revert "Suspend immersive mode autohide while pending transient taskbar timeout"
This reverts commit 0a074648c2.

Reason for revert: caused regression
Bug: 260765455
Fixes: 286808390

Change-Id: I0e017cf8e432f9c36b0ad34154c127c0dbe73504
2023-06-13 20:09:58 +00:00
Vinit Nayak 62a9635970 Remove mFirstFloatingTaskView from recents view
* Part of effort to slowly migrate split state out
of RecentsView and into SplitSelectStateController

Test: Existing split flows work
Bug: 276361926
Change-Id: I099a59cf4820b4b2e4af94b59c464158c5e62806
2023-06-13 12:04:53 -07:00
Brian Isganitis cca18d8028 Merge "Support zero-state suggestions in Taskbar All Apps." into udc-qpr-dev 2023-06-13 18:26:36 +00:00
Schneider Victor-tulias 3b9c654669 Merge "Polish redesgined tutorial home and overview animations" into udc-qpr-dev 2023-06-13 13:47:21 +00:00
Randy Pfohl 27e1e8eddc Merge "switching animation to screenshot to avoid visual jank" into udc-dev am: f5bec7dd30 am: c338164e7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23665476

Change-Id: Id99b6964e18cc7ec7daca9993ec2cffe5c8044b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:50:06 +00:00
Saumya Prakash 07ed097042 Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev am: cb5e2cfd3e am: 83301267f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23632910

Change-Id: I1f12a7dddfa9fd9efbd762fad142e87a2e5842e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:49:43 +00:00
Randy Pfohl f5bec7dd30 Merge "switching animation to screenshot to avoid visual jank" into udc-dev 2023-06-13 05:43:21 +00:00
Saumya Prakash cb5e2cfd3e Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev 2023-06-13 05:38:01 +00:00
Saumya Prakash afda61d92c Merge "Update the strings in the gesture nav tutorial" into udc-dev am: 0d87c4766e am: 87085d3b4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23659350

Change-Id: I7718af3e47d2d076e73812f277040dd89e01e3a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 05:25:55 +00:00
Saumya Prakash 0d87c4766e Merge "Update the strings in the gesture nav tutorial" into udc-dev 2023-06-13 03:39:38 +00:00
TreeHugger Robot a9d2db38f5 Merge changes from topics "draglayer-inline-qsb", "draglayer-search" into udc-qpr-dev
* changes:
  Allow LauncherState to define floating search side margins.
  Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
2023-06-13 03:19:49 +00:00
randypfohl d3cc664391 switching animation to screenshot to avoid visual jank
Test: built locally, recorded, and slow replayed it to verify no jank/visual anomalies visible.

Bug: 245750127
Change-Id: If7e72512d3303222f4d006a9e2a1639b2f86b1af
2023-06-12 18:28:57 -07:00
Andy Wickham bd9a180fbc Allow LauncherState to define floating search side margins.
This lets home screen align to workspace icons while All Apps
aligns with those icons. In addition, on tablets where the QSB
is inlined with the hotseat, floating search bar can also move
horizontally accordingly.

Bug: 275635606
Bug: 259619990
Test: Manual on tablet as well as foldable.
Flag: ENABLE_FLOATING_SEARCH_BAR

Change-Id: I67745c66390736cdf39d969ef7767096ae13c671
2023-06-13 00:28:59 +00:00
Vadim Tryshev 167ff73108 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev am: af641a6e80 am: 27e2251b7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23662872

Change-Id: I81d60e0d7d92267cadad309450a90ed39be0bc84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 23:07:01 +00:00
Andy Wickham 64896f3098 Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
This means adding the search view to the drag layer, so it can
persist and animate across Launcher states (i.e. Home, All Apps,
Overview, Overview from App).

Some high level things:
 - LauncherState now has a flag indicating if the floating
   search bar should be visible, as well as a method indicating
   how high it should rest when the keyboard is not showing. By
   default the height is set negative if the flag is not present,
   so the search bar will rest off screen in that state.
 - LauncherState also has a new method indicating if the search
   bar should show as a pill when not focused. Currently this is
   done in phone portrait mode in all apps and overview.
 - SearchUiManager now has a method for gestures to hint that
   the search bar will be focused or unfocused soon, e.g. for
   the app -> overview case, we hint that it will be focused
   when crossing the threshold, and unfocused if retracting.
   This allows the search bar to animate during the gesture
   and take or release focus after the state change completes.
 - AllAppsTransitionController lets the apps panel translate in
   from the bottom of the screen, for example when coming from
   an app and we don't want to pop it in halfway up the screen.
   Instead it can slide in gracefully from behind the keyboard
   and floating search bar.
 - KeyboardInsetAnimationCallback can now notify listeners of
   keyboard alpha changes during controlled animations. And
   StateAnimationConfig has a new animation type to control
   the keyboard alpha during the all apps transition.
 - This new ANIM_ALL_APPS_KEYBOARD_FADE is used to pop the
   keyboard in at the threshold for going from an app to all apps.
   Note that its position moves linearly before this, so the
   search bar starts moving up accordingly before the keyboard
   alpha is non-0.

Fix: 266761289
Fix: 268845147
Fix: 267683921
Fix: 265849321
Fix: 266446733
Fix: 269301440
Bug: 275635606
Bug: 259619990
Bug: 261866704
Test: Manual with all the state transitions on phone and tablet
(also folding/unfolding foldable).
Flag: ENABLE_FLOATING_SEARCH_BAR, ENABLE_ALL_APPS_FROM_OVERVIEW
(latter just for the background app interpolator changes).

Change-Id: I6f06552e95747348a62260279626cf407bf145b0
2023-06-12 21:55:24 +00:00
Vadim Tryshev af641a6e80 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev 2023-06-12 21:49:39 +00:00
Saumya Prakash b932cf4b64 Update the strings in the gesture nav tutorial
Change the strings for the instructions and feedback for the gesture navigation tutorial to align with new UX changes.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 286547594
Test: Manually went through the redesigned tutorial and verified that
the new strings correctly show up. Also checked that the previous
tutorial remains unchanged.

Change-Id: I27a3e8c0f09e7755e6087ce5b004b687f229d153
2023-06-12 21:26:43 +00:00
Schneider Victor-tulias 7ebb54f24e Polish redesgined tutorial home and overview animations
- Added a 6th hotseat icon to the tablet and unfolded foldable
- not animating the previous task view when animating to hotseat from the home step
- updating the first hotseat icon's color and visibility at the correct times
- cross fading the animating task view and hotseat icon's color

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 283967613
Test: ran the tutorial on handheld, tablet and foldable with ENABLE_NEW_GESTURE_NAV_TUTORIAL true and false
Merged-In: I7a76646ca71502e924f45bba76d72be17d31249d
Change-Id: I7a76646ca71502e924f45bba76d72be17d31249d
2023-06-12 21:04:38 +00:00
Schneider Victor-tulias 1c2c5a58a2 Polish redesgined tutorial home and overview animations
- Added a 6th hotseat icon to the tablet and unfolded foldable
- not animating the previous task view when animating to hotseat from the home step
- updating the first hotseat icon's color and visibility at the correct times
- cross fading the animating task view and hotseat icon's color

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 283967613
Test: ran the tutorial on handheld, tablet and foldable with ENABLE_NEW_GESTURE_NAV_TUTORIAL true and false
Change-Id: I7a76646ca71502e924f45bba76d72be17d31249d
2023-06-12 21:03:30 +00:00
Brian Isganitis 4337083b40 Merge changes If4669756,Ide702745 into udc-dev am: 77a40999e1 am: d0e61e3eef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23603557

Change-Id: I6140b46469c6e4251819afdd124bc869bceeadac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 18:07:50 +00:00
Saumya Prakash 08a2708739 Scale the gesture tutorial animation to work on smaller devices
The lottie animations in the gesture navigation tutorial would get cut
off due to having to crop them to smaller devices. This change uses a
matrix to correctly scale the animation such that the aspect ratio is
maintained.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283969417
Test: Went through the tutorial on devices of different sizes and aspect
ratios and ensured that the lottie animation isn't cut off.

Change-Id: I4b4cc9e11a68daef29fa31d6a89a1c9006041937
2023-06-12 17:55:00 +00:00
Vadim Tryshev b5057c496a Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"
This reverts commit 1a2462914d.

Reason for revert: Likely culprit for b/286115393

Change-Id: I613ca9f62c5b9f43f2e3cd240e45bc1a0db0e661
2023-06-12 17:40:22 +00:00
Brian Isganitis d478b1464e Support zero-state suggestions in Taskbar All Apps.
Test: manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I016d4e4e6a096ca4f5bd65fcda1bf24a444459f4
2023-06-12 17:19:16 +00:00
Brian Isganitis 77a40999e1 Merge changes If4669756,Ide702745 into udc-dev
* changes:
  Make sure FLAG_IN_APP is set when launching apps from keyguard.
  Report unstashed content insets for notification panel.
2023-06-12 16:51:37 +00:00
Saumya Prakash 7a69792b26 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev am: 372de4f521 am: 4522e5d2ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23493333

Change-Id: I0efd0da5bea9f4490b2688aaf295a320947eceea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-11 23:56:40 +00:00
Saumya Prakash 372de4f521 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev 2023-06-11 22:24:13 +00:00
Tracy Zhou a6909d121a Merge "Guard TrackpadStatusBarInputConsumer with canStartSystemGesture" into udc-qpr-dev 2023-06-10 20:00:15 +00:00
Jagrut Desai a2d86286fe Merge "Set AccessibilityPaneTitle for taskbar view" into udc-dev am: 2d5bb34b6b am: 45263ef98a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23624910

Change-Id: I9c8d22e27c3ec63047df5b9341e2541891b66ff0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 23:25:43 +00:00