PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
71,626 Commits 1 Branch 0 Tags
1be772df1d320656b3205fb09fc8e747ff634539
Commit Graph
17113 Commits
Author SHA1 Message Date
Brian IsganitisandAndroid (Google) Code Review a4497e55b2 Merge "Remove onTaskCreated for hiding Taskbar overlay." into main 2023-09-19 21:20:38 +00:00
Brian IsganitisandAndroid (Google) Code Review 8f45ef6bdf Merge "Reapply "Have backup TouchController of Taskbar All Apps AFV."" into main 2023-09-19 18:02:42 +00:00
Pat ManningandAndroid (Google) Code Review 349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review f5099749be Merge changes I26080534,Iede0881b into main 
* changes:
  Send ACTION_CANCEL motion event to TIS instead of finishing the recents animation on screen off
  Replace all uses of string concatenation with CompoundString in ActiveGestureLog
 2023-09-19 12:59:35 +00:00
Sunny GoyalandAndroid (Google) Code Review 10c14c297d Merge "Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread during onAttachToWindow" into main 2023-09-18 22:55:26 +00:00
Jagrut DesaiandAndroid (Google) Code Review 555d71f70f Merge "Taskbar Pinning Analytics Event" into main 2023-09-18 22:11:08 +00:00
Vinit NayakandAndroid (Google) Code Review 3a57263a7d Merge "Exit split selection state if launcher interrupted" into main 2023-09-18 21:56:07 +00:00
Schneider Victor-tulias 44de9caaeb Send ACTION_CANCEL motion event to TIS instead of finishing the recents animation on screen off 
Finishing the recents animation on screen off callback did not necessarily stop touch tracking, which would allow the user to double press the power button, but create a broken experience.

Sending ACTION_DOWN instead stops touch tracking and runs the proper clean up methods.

Flag: not needed
Fixes: 299235099
Test: single-pressed and double-pressed the power button mid-gesture
Change-Id: I2608053460f43703613bd6caead91ccb4ce08ceb
 2023-09-18 16:28:43 -04:00
Sunny Goyal 140883e599 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread 
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
 2023-09-18 13:26:31 -07:00
Schneider Victor-tulias a1a5e08713 Replace all uses of string concatenation with CompoundString in ActiveGestureLog 
Flag: not needed
Fixes: 300926831
Test: ran launcher, tested gestures and checked logs
Change-Id: Iede0881be315cb1ef0a30eaf2a9e17e020828586
 2023-09-18 15:51:14 -04:00
Jagrut Desai 4439af4191 Taskbar Pinning Analytics Event 
Inlcuded Analytics Event
- Taskbar Divider Popup Menu Open/Close
- Taskbar was pinned
- Taskbar was unpinned

Bug: 265436916
Test: Confirm with data scientist that data is being logged.
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I307d000efe9ad8a32cdbe0b8df7248b19eabb08b
 2023-09-18 12:36:17 -07:00
Vadim TryshevandAndroid (Google) Code Review 8a80ae21fd Merge "Adding TestStabilityRule; otherwise @Stability annotation is ignored." into main 2023-09-18 18:51:11 +00:00
Mady MellorandAndroid (Google) Code Review 2a76764d73 Merge "Only stash bubbles in overview when it's transient taskbar" into main 2023-09-18 18:48:58 +00:00
Tony WickhamandAndroid (Google) Code Review 2b9b15325c Merge "Remove unused variables in FullscreenDrawParams and PreviewPositionHelper" into main 2023-09-18 17:41:06 +00:00
Tony WickhamandAutomerger Merge Worker 2a35b5801e Finish recents animation synchronously on cancel event am: 2316dc4750 am: e136b6a641 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: I95fbc8c18584fe304696be81c75677d3e388ac5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 17:08:27 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 0afb0b740b Merge "Add overview button rate-limiter to fix recurring bug" into main 2023-09-18 16:52:19 +00:00
Tony WickhamandAutomerger Merge Worker e136b6a641 Finish recents animation synchronously on cancel event am: 2316dc4750 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: Ib8bd21048402db34caf681802599517b4a37cb94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 16:11:14 +00:00
Pat ManningandAndroid (Google) Code Review 9ea209b893 Merge "Add test to check swiping from app to overview without unstashing taskbar." into main 2023-09-18 15:39:23 +00:00
Pat ManningandAndroid (Google) Code Review 66c1051e7e Merge "Remove taskbar tooltip hover delay." into main 2023-09-18 15:37:34 +00:00
Tony Wickham 2316dc4750 Finish recents animation synchronously on cancel event 
Fixes: 300247322
Test: invoke omnient via long press nav handle
Flag: ENABLE_LONG_PRESS_NAV_HANDLE

Change-Id: I5d7cd1d0a2a50da26a881a6daa203806bf857909
 2023-09-18 15:34:29 +00:00
Nicolò MazzucatoandAutomerger Merge Worker 6eb5e0892b Merge "Preload overview after unfold" into udc-qpr-dev am: 3c898a7550 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24771967

Change-Id: Ic4f1ca2b27cd408963ff33ad7972ec4d1fef5a66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-18 09:53:20 +00:00
Nicolò MazzucatoandAndroid (Google) Code Review 3c898a7550 Merge "Preload overview after unfold" into udc-qpr-dev 2023-09-18 08:37:56 +00:00
Vinit NayakandAutomerger Merge Worker dd96f79b36 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213 am: a6f66eeba7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312

Change-Id: I3f6610ca6dd3087298e84d24ceb0570d3d2749ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-16 02:45:25 +00:00
Vadim Tryshev 403d945037 Adding TestStabilityRule; otherwise @Stability annotation is ignored. 
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Ic13a183ff285eca02ed69a2e09822cc66655797b
 2023-09-15 19:09:11 -07:00
Vadim TryshevandAndroid (Google) Code Review 58d24763a1 Merge "Re-promote testStressPressHome to presubmit" into main 2023-09-15 21:55:19 +00:00
Mady Mellor d23489af61 Only stash bubbles in overview when it's transient taskbar 
Bug: 284104811
Test: manual - enable 3 button nav
             - expand a bubble in overview
             => observe that scrim is shown on top of taskbar and it
                isn't stashed
             - repeat with transient taskbar but instead it stashes
               when bubbles are expanded in overview
Change-Id: I725513bb0015c85f26fb1eedbe22da5eb2612e55
 2023-09-15 12:48:02 -07:00
Tony WickhamandCherrypicker Worker 8179ac323e Remove unused variables in FullscreenDrawParams and PreviewPositionHelper 
Flag: none
Test: FullscreenDrawParamsTest
Bug: 293224095
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d48be359b3773237ff659b660b0d7f80a3866fde)
Merged-In: Icbd71082b5278c0f9ce8a742eed25395b31d4284
Change-Id: Icbd71082b5278c0f9ce8a742eed25395b31d4284
 2023-09-15 19:46:36 +00:00
Schneider Victor-tulias 89d64bb346 Add overview button rate-limiter to fix recurring bug 
Processing the TYPE_TOGGLE command immediately makes it relatively easy to start overlapping animations that clobber each other and prevent clean up callbacks from running. This would cause a janky overview animation, a full command queue that can't be emptied and a recents tile than gets stuck on the screen. Added a rate limiter to (hopefully) prevent this type of bug from recurring.

Flag: not needed
Fixes: 298792963
Test: quickly and repeatedly pressed the overview button, checked logs to check that the error case never occurs anymore and rate-limiter procs instead.
Change-Id: I1575c932bb24d2405792539e8a14ed8d4171f5ae
 2023-09-15 18:51:46 +00:00
Liran BinyaminandAndroid (Google) Code Review 070be25853 Merge "Adjust the hotseat when the bubble bar becomes visible" into main 2023-09-15 17:48:41 +00:00
Vinit NayakandAutomerger Merge Worker a6f66eeba7 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev am: 8ad9393213 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24761312

Change-Id: Ib31bfdd11c5f1c62b1ffcfe24bcdd81fd4903633
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-15 17:24:13 +00:00
Vinit NayakandAndroid (Google) Code Review 8ad9393213 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev 2023-09-15 17:20:43 +00:00
Vinit Nayak d91f811ab6 Exit split selection state if launcher interrupted 
* Launcher gets paused as a natural part of
confirming a split, so only cancel when 1 app is
confirmed

Test: Start split from workspace, then go to
* double tap camera
* settings via notification drawer
* mic icon on QSB
Bug: 276361926

Change-Id: I048964403303defe35035ee24950cfbbfc201afd
 2023-09-15 17:19:13 +00:00
Vinit Nayak 9b3598f154 Provide bgExecutor for RotationButtonController 
Bug: 289341065
Test: Unfolded, checked perfetto trace, it
shows up not on UI thread

Change-Id: I9a080c9a5c3c57f38eb6719ed73952dde4f6bba1
 2023-09-15 10:46:00 -04:00
Pat Manning 237f3a6677 Add test to check swiping from app to overview without unstashing taskbar. 
Follow up to ag/24420598

Fix: 293419351
Test: TaplTestsTransientTaskbar.
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Id5c6b441f45e4e17baa29bc2e1de10a1863d754e
 2023-09-15 12:46:21 +01:00
Nicolo' Mazzucato f6264d2387 Preload overview after unfold 
Before this change, the configChange was processed when launcher becomes visible. However, this happened during animations (e.g. swipe to home after unfold to app).

With this change, the onConfigChange received by TIS (so, it's received also if the activity is not visible), is used to preload overview, moving a ~100ms block to unfold instead of during the animation.

Bug: 294352799
Test: recorded a perfetto trace and checked jank decrease
Change-Id: I35a7036887cc9ea490f27d5ccd47fe423775350b
Merged-In: I35a7036887cc9ea490f27d5ccd47fe423775350b
(cherry picked from commit 11ce5f85c9)
 2023-09-15 11:38:46 +00:00
Nicolò MazzucatoandAndroid (Google) Code Review 2ca32596f5 Merge "Preload overview after unfold" into main 2023-09-15 11:35:42 +00:00
Pat Manning 2db8ce7e94 Remove taskbar tooltip hover delay. 
Fix issue when setting fullscreen drag layer causes hover exit/enter events.

Update ArrowTipView paddings to match spec.

Update ArrowTipView to check on each time it is shown if it should point up or down, not only the first time.

Fix: 295851126
Fix: 295315397
Test: TaskbarHoverToolTipControllerTest
Change-Id: I314c65cb9fce3fb8d6002d8917bd5c97301d9dbc
 2023-09-15 12:24:51 +01:00
Vadim TryshevandAndroid (Google) Code Review 0d50b19f4b Merge "Verifying that workspace looks correct at the end of the test." into main 2023-09-14 23:44:24 +00:00
Brian Isganitis ef89f1a7ee Reapply "Have backup TouchController of Taskbar All Apps AFV." 
This reverts commit 73c695f04e2aff3ef90f89668ee563bcf1fc3a29.

Change-Id: I21f560be9d340d1c343467c1704063ce85f63056
Fix: 299165179
Test: Manual + TaplTestsTaskbarSearch
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
 2023-09-14 23:32:10 +00:00
Brian IsganitisandAndroid (Google) Code Review 1bffca2eec Merge "Revert "Have backup TouchController of Taskbar All Apps AFV."" into main 2023-09-14 22:52:11 +00:00
Brian Isganitis a7e47717f8 Revert "Have backup TouchController of Taskbar All Apps AFV." 
This reverts commit 91a4aca5a5.

Reason for revert: b/300482980

Change-Id: If910bad31816851283de834b11db5151f237dadd
Fix: 300482980
Bug: 299165179
Test: Presubmit
 2023-09-14 22:48:18 +00:00
Vadim Tryshev 089498d5b1 Re-promote testStressPressHome to presubmit 
It's reasonably stable now

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I68e59265cacef9018604bb294ec52724e5fa7d8c
 2023-09-14 15:32:40 -07:00
Brian Isganitis f6dd3d108c Remove onTaskCreated for hiding Taskbar overlay. 
See https://b/299166570#comment4 for explanation.

Test: Manual for Taskbar + EDU. Work profile toggle no longer closes All
Apps.
Fix: 299166570
Flag: No

Change-Id: I6e3dba018975a924cccdc008f92c91bb9385cf99
 2023-09-14 20:33:08 +00:00
Vadim Tryshev 62e3b162ba Verifying that workspace looks correct at the end of the test. 
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: I6ad3598fb675d8b24ec0f273d255b7f2464dc53f
 2023-09-14 10:11:25 -07:00
Federico BaronandAutomerger Merge Worker 099f7f936e Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7 am: f3a2082285 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I8183be8017e43d588b5baed2b80bed70aca7a728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-14 16:53:40 +00:00
Becky QiuandAutomerger Merge Worker 543dbad157 Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce am: 09b354b232 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823

Change-Id: Icd77d37a3e009bb54044fcd501bc7ea5fc659e0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-14 16:52:54 +00:00
Tracy ZhouandAndroid (Google) Code Review bcbb5745b8 Merge "Fix wrong insets in phone mode with FLAG_HIDE_NAVBAR_WINDOW on" into main 2023-09-14 16:51:26 +00:00
Federico BaronandAutomerger Merge Worker f3a2082285 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I06df48dda4c77024b9b35127a8eeda9b42080607
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-14 16:51:15 +00:00
Federico BaronandAndroid (Google) Code Review 15b81093d7 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev 2023-09-14 16:26:34 +00:00
Jagrut DesaiandAndroid (Google) Code Review a144105c12 Merge "Fix TaplTestsNexus#testSearchForApp" into main 2023-09-14 16:08:35 +00:00