Commit Graph

16741 Commits

Author SHA1 Message Date
Vinit Nayak 64f3766ba7 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev 2023-07-11 23:06:47 +00:00
Schneider Victor-tulias 19c22c20b2 Merge "Add debug tracing Launcher's lifecycle callbacks" into udc-qpr-dev 2023-07-11 22:35:53 +00:00
Brian Isganitis 1a50287c08 Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev 2023-07-11 19:39:07 +00:00
Brian Isganitis f54c6fa4b4 Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""
This reverts commit 853a5b9e0c.

Fixes SecondaryDisplayLauncher class by using lambda instead of method
reference for #getAllAppsItemLongClickListener. This change is necessary
because mDragLayer is late-init.

Test: Home Settings > Developer Options > Launch Secondary Display
Bug: 289261756
Flag: No
Change-Id: I7b83f81651dde360edea6ee7bea6cc82441e6bef
2023-07-11 13:21:47 -04:00
Treehugger Robot f69ebc04b0 Merge "Adding flag for use of ParametrizeReorderAlgorithm" into udc-qpr-dev 2023-07-11 17:15:34 +00:00
David Saff aaf3094540 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev 2023-07-11 12:32:36 +00:00
David Saff 853a5b9e0c Revert "Provide AllApps item OnLongClickListener through ActivityContext."
This reverts commit 0acab2532d.

Reason for revert: b/290403189

Change-Id: Ie3f67f78a8ffce8c2d5a92f65a7e74d788c82a81
2023-07-11 10:45:33 +00:00
Sebastian Franco 7ba948967c Adding flag for use of ParametrizeReorderAlgorithm
Also, some cleaning of the comments.

Bug: 289420844
Test: compiling
Change-Id: I5dfb4b252755550059c3ee050bc491f5449bec97
2023-07-10 20:32:18 +00:00
Vinit Nayak f6c2e87747 Dismiss split select when tapping on home button
Bug: 276361926
Test: Initate split, dismiss whenever home is pressed,
doesn't dismiss when all apps dragged down
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Idc95123e27963c3913d04c6eb27f0e4c9b1eb401
2023-07-10 11:06:42 -07:00
Andy Wickham fd924b479e Merge "Use DECELERATED_EASE for workspace scale for all apps on tablet." into udc-qpr-dev 2023-07-10 17:05:11 +00:00
Treehugger Robot b6a32d1340 Merge "Fix pageindicator for RTL mode" into udc-qpr-dev 2023-07-10 16:48:33 +00:00
Charlie Anderson 58013497d0 Merge "Fixes home screen popup animation by removing unnecessary animation from ArrowPopup" into udc-qpr-dev 2023-07-10 14:39:19 +00:00
Andy Wickham 17ef3bde32 Use DECELERATED_EASE for workspace scale for all apps on tablet.
This helps it feel less abrupt and more connected to the gesture.

Demo video: https://drive.google.com/file/d/1TRQzMQfpmsCR5VYE9KXCT9IauOmApUYK/view?usp=drive_link&resourcekey=0-beONDiqU42HcVPj-M7O32A

Fix: 290257598
Test: Manual
Flag: N/A
Change-Id: I62577e2b3e937ab5e72b33754f98517fe5406a08
2023-07-07 17:34:54 -07:00
Brian Isganitis ea206bbad5 Merge "Provide AllApps item OnLongClickListener through ActivityContext." into udc-qpr-dev 2023-07-07 19:43:01 +00:00
Vinit Nayak ea12af617e Merge "Add support for taskbar phone 3 button seascape" into udc-qpr-dev 2023-07-06 23:18:07 +00:00
Brian Isganitis 0acab2532d Provide AllApps item OnLongClickListener through ActivityContext.
This cleans up how alternative AllApps implementations such as Taskbar
and SecondaryDisplay override the default INSTANCE_ALL_APPS listener.
This change will also be helpful for Toast in Taskbar drag-n-drop.

Test: Manual
Bug: 289261756
Flag: n/a
Change-Id: I55eb881bcd1e210852d435a3ea2a6686ce0a9838
2023-07-06 22:12:20 +00:00
Vinit Nayak 15a9feb67f Add support for taskbar phone 3 button seascape
* Ignore orientation check from ag/22709055 for now,
that will be reverted. This causes recreateTaskbar() to
not run when folding the device

Bug: 274517647
Test: Tested 3 button nav in portrait/landscape/seascape
Flag: persist.wm.debug.hide_navbar_window
Change-Id: Ied02ead677d496b465c748257e32b7db5eb9580c
2023-07-06 13:58:30 -07:00
Charlie Anderson 5ebecb830f Fixes home screen popup animation by removing unnecessary animation from ArrowPopup
Bug: 281004993
Test: manually
Flag: None
Change-Id: I072b61281fafd955557ccc4aabdde3a56eba9c15
2023-07-06 13:48:36 -04:00
Schneider Victor-tulias 84c66b69ff Add debug tracing Launcher's lifecycle callbacks
It is possible that SimpleActivityRule is not being properly notified of Launcher's creation in Platinum tests.

Flag: not needed
Bug: 289161193
Test: AddWidgetTest
Change-Id: I09947e7202129d9335f737dcd626f706de6dbf00
2023-07-06 10:44:16 -07:00
Vinit Nayak f6f192853d Cleanup WorkProfileTest logs
Fixes: 243688989
Change-Id: Ic3f143062c1a1383d1e79959dae59c45743547e9
2023-07-05 16:27:11 -07:00
Fengjiang Li 1e3d799fe3 Merge changes from topic "preinflate-allapps-rv" into udc-qpr-dev
* changes:
  Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
  Fix calculation of all apps recyclerview pool size of app icons
2023-07-05 22:44:55 +00:00
Jeremy Sim 66ec0f6a28 Merge "Remove flag ENABLE_LAUNCH_FROM_STAGED_APP" into udc-qpr-dev 2023-07-05 21:22:22 +00:00
Fengjiang Li 1519c168da Pre-inflate BubbleTextViews into Launcher/TaskBar All Apps RV
This CL ensures no inflation of BubbleTextView happens while binding applications, and reduces jank on slow device.

1. Let active/inactive all apps RVs share the same AllAppsRecyclerViewPool
2. Use worker thread to pre-inflate BubbleTextViews and add them to shared view pool on main thread

Bug: 287523421
Test: See before/after screenshot/video/trace attached in bug
Change-Id: I00213407be2c7c2d329997552785d0aa56c4d057
2023-07-05 13:07:26 -07:00
Fengjiang Li 1acda93e26 Fix calculation of all apps recyclerview pool size of app icons
grid.numShownAllAppsColumns is the column size of all apps, whereas mNumAppsPerRow is the column size of workspace, we should use the former one to calculate num of all apps icons

Bug: 287523421
Flag: N/A
Test: Open all apps from launcher and taskbar and scroll it, Expect scorlling works without jank.
Change-Id: Ife488e5853c84f6cc94e1e9e7edae67844275439
2023-07-05 13:07:18 -07:00
Jagrut Desai 491b0f9028 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I9d438b3edda25a7407d30d702013b385b3fd9195
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:47:37 +00:00
Jagrut Desai d4b4e95bea Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I33a1ec0e54a662878f981bd599abb3f1d5c6f105
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-30 23:05:06 +00:00
Holly Jiuyu Sun 18e0e1e50a Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-qpr-dev 2023-06-30 17:56:16 +00:00
Holly Sun 35b9960b63 [a11y] Fix crash when using talkback to add to home screen.
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
2023-06-30 08:42:31 -07:00
Federico Baron 25f5fc2470 Merge "Add WidgetPicker screenshot tests" into udc-qpr-dev 2023-06-30 02:34:30 +00:00
Treehugger Robot 4c4f9b67a7 Merge "Small tweak to floating search on phone." into udc-qpr-dev 2023-06-30 01:53:38 +00:00
Treehugger Robot b1f4670843 Merge "Make 1.8 the default threshold for overview -> all apps." into udc-qpr-dev 2023-06-29 23:52:24 +00:00
fbaron 246f1c9206 Fix pageindicator for RTL mode
Fix: 288981846
Test: Verify that in RTL the page indicator dots and the selected page dot align
Flag: no flag
Change-Id: I103b27c936e59b66ce5a55e1e197cfce594d72d5
2023-06-29 16:40:50 -07:00
Andy Wickham 3d0661292c Make 1.8 the default threshold for overview -> all apps.
Bug: 275132633
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW (disabled by default)
Test: Clear launcher data and enable flag; verify default value
Change-Id: I005dde743e445287e03f4f92b511e5fe1c023d6f
2023-06-29 23:33:21 +00:00
Brandon Dayauon aa9332af88 Merge "Fix prediction row title consistency" into udc-qpr-dev 2023-06-29 21:45:40 +00:00
Jeremy Sim d2255f2b79 Remove flag ENABLE_LAUNCH_FROM_STAGED_APP
This patch makes it so that the "launch from staged app" feature, which has been enabled since TQPR3, has its flag removed.

Fixes: 270395567
Test: None
Change-Id: I46878475c0dac5a3d64938ec9dfa5ca4123c7bb4
2023-06-28 22:45:32 +00:00
Brandon Dayauon dba7359d23 Fix custom buttons with translated string
The reason why the buttons aren't being updated with the translated string is because the cache the views get the string from is not updated/loaded with the new language.
Rather, the update happens after the view has been inflated. With this change, when the string cache updates in bindStringCache(), we update the UI right then.

bug: 280958663
bug: 288442609
test: Manual
Change-Id: I7a49ee401d5a5f3268cfaef1abee8153e913a8ce
(cherry picked from commit 076dcdfd54)
2023-06-28 21:49:25 +00:00
Jagrut Desai 53d953ccd2 Taskbar All Apps Shortcut Menu Acccessibility Focus
Bug: 280657266
Test: manual
Flag: not needed
Change-Id: I2426636067ce3635b8b24b9f5d093dad7d9ddf4c
2023-06-28 14:48:54 -07:00
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
Jordan Silva 12fae110b7 Decrease icon size by steps for folders
Resize the icon so that it fits within the cell. This will stop the icon from being cut off if it is larger than the cell.

Fix: 288075868
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I67c703d89bb7f54a457793490b8251584363dedc
2023-06-28 21:06:49 +01:00
Alex Chau f63ceebadd Merge "Decrease the padding between app icon and label" into udc-qpr-dev 2023-06-28 19:51:44 +00:00
Thales Lima 93ee8fcb30 Decrease the padding between app icon and label
The app icon size in XMLs are 10% larger because of http://b/235886078, so we need to remove that from the padding between the icon and the label.

Bug: 235886078
Fix: 279142287
Test: DeviceProfileDumpTest
Flag: N/A
Change-Id: I2662c30252dc4e06d4767dbe7125a99a02ce2b64
2023-06-28 16:12:52 +01:00
Federico Baron 827001a1fa Add WidgetPicker screenshot tests
We need screenshot tests for widget picker to prevent unintended UI changes.

Bug: 268219507
Test: n/a
Change-Id: I405401f5c68bb73bcb7bbd097f507abb1d66ff7e
2023-06-27 17:20:11 -07:00
TreeHugger Robot d5b3a0a099 Merge "Removing explicit target SDK for launcher" into udc-qpr-dev 2023-06-27 22:34:40 +00:00
Treehugger Robot d2d1942b27 Merge "Add themed work badge for themed icons in dragview or floatingiconview" into udc-qpr-dev 2023-06-27 16:42:25 +00:00
Sunny Goyal b02dafc1d4 Removing explicit target SDK for launcher
> It will automatically target the latest SDK it was compiled with

Bug: 284349887
Test: Presubmit and manual
Flag: N/A
Change-Id: I32629b0dd710c3c04d8f70f988b7279e7cae6731
2023-06-26 10:15:14 -07:00
Holly Sun c3127d29b2 [a11y] Add FLAG_NOT_PINNABLE and modify supportAddToWorkSpace.
// play uninstalled app
Bug: 286998395
Bug: 287156208
Bug: 287157282
// contact
Bug: 287362865
Bug: 287370843
Bug: 287372663
// clock
Bug: 287166186
Bug: 287166771
Bug: 287167527
Test: manual
Flag: N/A

Change-Id: I859deba6218e232a232f009793044ca4be2cab19
2023-06-26 16:52:53 +00:00
Schneider Victor-tulias a4d1e9aa99 Merge "Remove unnecessary method from StatefulActivity" into udc-qpr-dev 2023-06-26 16:41:12 +00:00
Holly Jiuyu Sun befe262d18 Merge "[a11y] Add FLAG_NOT_PINNABLE and modify supportAddToWorkSpace." into udc-qpr-dev 2023-06-26 16:39:42 +00:00
fbaron 4ac0379f8b Add themed work badge for themed icons in dragview or floatingiconview
Bug: 288491653
Test: Verify that dragging icons with work badge have the right badge theming and that when the icons are animatng (e.g swipe to go back home from app) have the right themed/non-themed work badge
Change-Id: I3d75e83ebab0d99866f1fe3688dc06bb7e933a6e
2023-06-23 15:22:12 -07:00
Holly Sun 40df2fc8d8 [a11y] Add FLAG_NOT_PINNABLE and modify supportAddToWorkSpace.
// play uninstalled app
Bug: 286998395
Bug: 287156208
Bug: 287157282
// contact
Bug: 287362865
Bug: 287370843
Bug: 287372663
// clock
Bug: 287166186
Bug: 287166771
Bug: 287167527
Test: manual
Flag: N/A

Change-Id: I859deba6218e232a232f009793044ca4be2cab19
2023-06-22 16:39:05 -07:00