.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().
This was found while updating android lint.
Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
We just migrate them using the special case where everything shifts up
if we meet the criteria
Bug: 392978014
Test: GridSizeMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4efda781d6fbe6f3e1854b22685abd1b923c3dc4
> Do not add listeners when binding FolderIcon for preview
> Cleaning up preview object when the caller is no longer holding
on to the communication channel for preview.
Bug: 393086035
Flag: EXEMPT bugfix
Test: Verified manually
Change-Id: I4b758e6ce103c5201ef05ab824dd4e02f98c40b6
Revert submission 31445615-model-callbacks
Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>
Reverted changes: /q/submissionid:31445615-model-callbacks
Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
Some interactions have been experiencing delayed hapics (see bug in this
CL) due to haptics firing if a -sometimes- busy background thread. Like
in SysUI, we can avoid this by using a newSingleThreadExector when
firing one-shot MSDL feedback.
Test: manual. Rapidly selected different wallpapers and verified haptics
played in sync with the UI update.
Flag: com.android.launcher3.msdl_feedback
Bug: 391384092
Change-Id: I1661c85976c4744058e046c7ff8386bb99c6d50b
> Using ShapeDelegate for icon clipping
> Creating ShapeDelegate based on the current icon shape
> Defining different shape delegates for icon and folder
> Updating preview rendering to use dagger graph
> Adding tests for all icon shapes
Bug: 392145015
Test: atest IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ic9f287e2a6fef2aad18ba224404de58a64da0bb3
Making the BubbleTextView.applyItem stateless so that it does not depend on the order of events
Bug: 390572144
Flag: EXEMPT refactor
Test: atest LauncherBindableItemsContainerTest
atest BubbleTextViewTest
Change-Id: Ib9c0ac6c330d6f4e08c3db5772d35787fa056b65
The MSDL token to play haptics when dragging was being played as soon as
a widget was long-pressed but not dragged over a new drop-off location.
Haptics should only play while the UI item is being hovered over new
cells. The new condition checks if the drag cell and drag cell span are
cleared and avoids playing haptics in this initial state.
Test: manual. Verified haptics while dragging icons over Workspace and
Hotseat only when actually dragging over new cells.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 376103470
Change-Id: I7b2056f1c713b65f9df37f3138c1acf3b5376822
Bug: 377555526
Test: Verified that this works well for both this use case and for b/383456105's use case.
Flag: EXEMPT bug fix
Change-Id: I91426487f435d6c0b796cafe58b526c73dfaa398
ag/30344959 showed the recommendations if available, to avoid the issue
of widgets list flashing when exiting search mode. However, we usually
hide recommendations in phone landscape due to the sticky header layout
not having enough space. In this fix, instead, we rebind recommendations
as before (to let the logic there decide whether to show or hide them),
and in order to fix the flashing problem that the earlier change was handling, we reset the recycler view.
Bug: 391231345
Flag: EXEMPT bugfix
Test: Manual, we don't have tests for interactions between screens
Change-Id: I535aa43cc553c9287c5d38ef7cde30f01e84d347
We decided to always shift the cells down, so that the new row always
shows up at the top
Bug: 391697719
Test: GridMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id093e0d64e437bf218f942bfdf6d2f14ee875776
Allow overriding of various interfaces that allow a subclass
of ArrowTipView to stipulate its own layout.
Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 388311172
Change-Id: Id42e2a18faf5ca6a4259c0e707f09584a6804cb0
Cole Faust
Treehugger Robot
samcackett
Charlie Anderson
Federico Baron
Sunny Goyal
Priyanka Advani (xWF)
Pechetty Sravani (xWF)
Anushree Ganjam
Juan Sebastian Martinez
Shamali Patwa
Stefan Andonian
Adnan Begovic