Commit Graph

9999 Commits

Author SHA1 Message Date
Ats Jenk 186e60e94c Merge changes from topic "overview-to-desktop" into main
* changes:
  Account for freeform tasks being visible in overview
  Enable live tile for desktop
2023-10-06 22:05:06 +00:00
Brian Isganitis 447b09057a Merge "Prevent NPE from changing all apps visibility in shared state." into main 2023-10-06 20:59:33 +00:00
Brian Isganitis f79785065b Merge "Have dragged search items return to All Apps icon if cancelled." into main 2023-10-06 20:44:06 +00:00
Schneider Victor-tulias 8265d04e0a Merge "Fix NullPointerException in OverviewInputConsumer" into main 2023-10-06 20:30:39 +00:00
Sunny Goyal b34296face Merge "Making AsyncClockEventDelegate a singleton" into main 2023-10-06 16:58:41 +00:00
Vinit Nayak 0f9d9a825f Merge "Null reference to split callback" into main 2023-10-06 14:21:18 +00:00
Vinit Nayak a7b491e35e Null reference to split callback
Bug: 302551868
Test: Ran atest NexusLauncherTests:com.android.quickstep.TaplTestsSplitscreen
which caused some regressions last time. Passed locally

Change-Id: I94b28296cf12c5087ee3e878352c057d1d1a73de
2023-10-05 17:22:46 -07:00
Tracy Zhou 528356e744 Merge "Fix task bar crash in gesture nav mode with task bar / nav bar unification on" into main 2023-10-05 23:38:13 +00:00
Ats Jenk 0927251a7b Account for freeform tasks being visible in overview
When live tiles are enabled, desktop tasks remain visible while in
overview. This is due to tasks remaining in running state.
Update DesktopVsibilityController to handle this case. If in freeform,
it should return that freeform tasks are not visible to any callers.
Also move launcher state handling to inside the controller so we don't
have this handling in other places.
Introduce separate handling of background and overview state. In
background state we want to keep the freeform task visibility state
matching the actualy visibility. And show the launcher views and resume
the activity.
In overview state we want to override the freeform visibility and show
launcher views.

Bug: 297590571
Test: open an app on desktop
      - swipe up for taskbar multiple times, observe that we remain on
        desktop
      - swipe up for taskbar and launch an app, observe it launches on
        desktop
      - swipe up to recents, observe that recents UI is shown and task
        remains running
      - swipe up to recents, launch desktop again from recents
      - swipe up to recents, launch another fullscreen app from recents
      - swipe up from a fullscreen, launch desktop from recents
Change-Id: Id5cef7111da6929c8435ef9d221db1abd8361b15
2023-10-05 15:53:42 -07:00
Stefan Andonian 9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Sunny Goyal df178f5320 Making AsyncClockEventDelegate a singleton
RemoteViews can get inflated after the activity is destroyed during
async inflation. This can cause the delegate to loose the destroy event.

Bug: 303686041
Test: Presubmit
Flag: N/A
Change-Id: Iecb9d69d95b2c924e1189ac15515fac327d8f44d
2023-10-05 13:23:58 -07:00
Stefan Andonian 23f869f0f0 Merge "Don't show FloatingIconView during Back to Home Animation when animations are disabled." into main 2023-10-05 20:22:49 +00:00
Tony Wickham d7c43cab9b Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178 am: 3809c0a278
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: Id81adcfc07d2c6a01655b4d88df524764b38e5fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:37:58 +00:00
Tony Wickham 3809c0a278 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: I4a2cc03328d09757ff1a5454138b61794a5cadee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:05:04 +00:00
Vinit Nayak c939620fd1 Merge changes Id9a74edd,Iab1f1e99 into main
* changes:
  Support fullscreen split selection launch for contextual
  Add icon when launching widgets in split
2023-10-05 18:31:15 +00:00
Tony Wickham cf596d4178 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev 2023-10-05 18:16:40 +00:00
Stefan Andonian 17ee527e15 Don't show FloatingIconView during Back to Home Animation when animations are disabled.
Bug: 235915161
Test: Reproduced the issue locally, then verified that the fix worked as
desired without introducing unwanted side effects.

Change-Id: I3db3b2ddbd34a2ef19eae10282758df32c2d5b3f
2023-10-05 17:44:12 +00:00
Anushree Ganjam 2fbb34fc7b Developer options should reflect the correct DeviceConfig value for ReleaseFlag. am: 13517070d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24945015

Change-Id: Ic0b22dd740409cafc3a4224e3dba3ed7ac60516f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 16:09:05 +00:00
Alex Chau 2ca7481b04 Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag" into main 2023-10-05 15:40:17 +00:00
Schneider Victor-tulias 6c58b1db66 Fix NullPointerException in OverviewInputConsumer
OverviewInputConsumer should wait until the root view is attached to the window before using the ViewRootImpl.

Flag: not needed
Fixes: 303117246
Test: used the OverviewInputConsumer with the keyboard
Change-Id: I78c23cb146f35cdb1f4b87f42726d6260d4a2b87
2023-10-05 10:05:47 -04:00
Uwais Ashraf cfaba6e814 Merge "Align empty recents message+icon to center of View." into main 2023-10-05 09:00:28 +00:00
Tracy Zhou 27d7769000 Fix task bar crash in gesture nav mode with task bar / nav bar unification on
a11yButton is reserved for 3-button mode so it can be null. Also TaskbarNavLayoutter is used for large screen both in gesture nav and 3-button mode, so need to check isContextualButtonShowing to add contextual buttons

Fixes: 300849078
Test: Make sure that it doesn't crash in large screen gesture nav mode
Change-Id: I9d0694b7f4c95461f24efb2af1af905e68e3cd8d
2023-10-04 20:17:23 -07:00
Anushree Ganjam 13517070d8 Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
Merged-In: I5d83207cf454c60278fd02e59199207e855d51a8
(cherry picked from commit 9eb68bb7cf)
2023-10-05 01:45:32 +00:00
Stefan Andonian 54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Vinit Nayak ae3c5749ef Support fullscreen split selection launch for contextual
* Migrate animating split placeholder to fullscreen into
SplitAnimationController from RecentsView to consolidate
* Reset state from RecentsView via a callback

Fixes: 295457117
Test: Tapping on placeholder in overview and home works
as expected

Change-Id: Id9a74eddc134a0470110845b90729c05193a1f93
2023-10-04 16:05:03 -07:00
Vinit Nayak a6bf642d5a Add icon when launching widgets in split
* Load the icon in the BG (though it should be
cached), then run the animation in the FG

Test: Initiating split contextually with a widget
shows icon
Bug: 293935354
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Iab1f1e9965479b0f84c74c2a5ae6e272b9a5db3a
2023-10-04 16:05:02 -07:00
Anushree Ganjam 9a809d9121 Merge "Developer options should reflect the correct DeviceConfig value for ReleaseFlag." into main 2023-10-04 22:14:41 +00:00
Tony Wickham 94a0a58b37 Fix gestures for exclude-from-recents + translucent tasks
- If task is translucent and excluded, fade out as swipe up
  - Fade back in when re-launching live tile
- Ignore excluded tasks if there is another visible task,
  and use that underlying task during gesture instead.

Fixes: 299351175
Fixes: 300297333
Fixes: 302672319

Test: Invoke translucent + excluded app (e.g. expanded Volume
dialog) over another app, swipe to overview, quick switch, home

Change-Id: I5740afc4bf561d1a264bd132863ffc15f27d2b20
2023-10-04 20:23:07 +00:00
Brian Isganitis 8f3342967c Prevent NPE from changing all apps visibility in shared state.
Also setting to false in onCloseBegin since this is an earlier signal
than onClosed.

Test: Manual (regular + recreate by toggling dark theme)
Fix: 301705545
Flag: No
Change-Id: Ifb356d4f1346f7af15a375ad7b88d2d8be227328
2023-10-04 15:32:37 -04:00
Brian Isganitis d5684000f9 Have dragged search items return to All Apps icon if cancelled.
Test: Manual
Fix: 303302706
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: Id2a06b38a987566b8e334125a050196a2845921e
2023-10-04 15:03:59 -04:00
Anushree Ganjam 9eb68bb7cf Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
2023-10-04 11:43:58 -07:00
Uwais Ashraf e61ad56098 Align empty recents message+icon to center of View.
Seems like it was previously aligned to center of task which doesn't always look good.

Screenshots:
Handheld before - https://screenshot.googleplex.com/6GmqhTjUhUpwwBs
Handheld after - https://screenshot.googleplex.com/3QMYCQaS6USMQYy

Tablet before - https://screenshot.googleplex.com/7tsERFGVsa6QSNY
Tablet after - https://screenshot.googleplex.com/8itDgQ2jDTHk463

Unfolded before - https://screenshot.googleplex.com/AJaqC9LqP2Dwfz2
Unfolded after - https://screenshot.googleplex.com/8aaa7ZhemqHXHRh

Fix: 299100892
Test: OverviewEmptyMessageImageTest and observed on tablet, handheld and unfolded.
Change-Id: I538d25e5a98e25351e71718de3ca572fd00438ad
2023-10-04 14:57:11 +00:00
Tracy Zhou b1122a4ad3 Merge "Fix some merge issues in repositioning contextual buttons for taskbar/navbar unification" into main 2023-10-04 04:00:24 +00:00
Jeremy Sim 4986aa85e5 Merge "App Pairs: App pairs now save with automatic default name and custom split ratios" into main 2023-10-04 00:06:57 +00:00
Ats Jenk eb143041fa Enable live tile for desktop
Remove logic to always screenshot desktop tasks.

Bug: 297590571
Test: swipe up to recents when on desktop
Change-Id: Ie6e95f711e1721f66a2ed6081fe99d941c18b393
2023-10-03 13:52:46 -07:00
Liran Binyamin 5bec1164b9 Merge "Make the bubble bar flag dynamic in Launcher." into main 2023-10-03 17:47:11 +00:00
Jeremy Sim 6ac8949fc4 App Pairs: App pairs now save with automatic default name and custom split ratios
[App Pairs 4/?]

This patch includes:
- Ability to save and launch app pairs with custom 0.3, 0.7, or 0.5 split ratios
- App pairs now save with default name "App1 | App2"
- Grid migration, prediction, and other misc. flows should now work with app pairs

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: AppPairsControllerTest.java
Change-Id: I46dd3e30f8de03dd3e6d086c8ff9fc52e7e7fd2b
2023-10-03 10:38:03 -07:00
Liran Binyamin e41e6185e4 Make the bubble bar flag dynamic in Launcher.
Changing the flag currently requires a reboot, because it is read once when the process starts and never changes.
This change triggers a re-read of the flag value from SystemProperties whenever Taskbar is recreated.
This allows setting the flag as part of integration tests for bubble bar.

Bug: 273994695
Test: Manual:
       - turn flag off
       - create bubbles
       - observe floating bubbles are added
       - turn flag on
       - change navigation mode to gesture navigation
       - observe bubble bar becomes visible
Change-Id: I277ea6aa2c8d3ab04094537bf4cd31630310dfec
2023-10-03 10:49:30 -04:00
Alex Chau 6f264a927b Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag
Bug: 270397206
Test: OverviewActionsControllerTest
Flag: enableGridOnlyOverview
Change-Id: I1519e0e8d5b8a7e294d2d310c1614e8462649031
2023-10-03 12:58:18 +01:00
Tracy Zhou 5b3c85564f Fix some merge issues in repositioning contextual buttons for taskbar/navbar unification
Fixes: 300849078
Test: Rotate around, and make sure the rotation button stays in the same corner
Change-Id: Ifb7904117f4ae8b28f2d14b27fbb39fe1a82e6ae
2023-10-03 01:09:56 -07:00
Tracy Zhou fe38407873 Merge "Repostion contextual buttons upon layout changes" into main 2023-10-02 20:15:31 +00:00
Brian Isganitis c0b9b422be Merge "Add AllApps TAPL APIs for toggling with meta key." into main 2023-10-02 19:09:38 +00:00
Pat Manning 1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Schneider Victor-tulias 8f795844e9 Merge "Refactor the BorderAnimator for simplicity" into main 2023-10-01 17:27:16 +00:00
Brian Isganitis c3c0664ab1 Add AllApps TAPL APIs for toggling with meta key.
Test: TAPL
Bug: 300147433
Flag: No
Change-Id: Ie4d91ac77a325febb521806a008f8fcad5869f85
2023-09-29 15:26:42 -04:00
Schneider Victor-tulias 7335bcf7f5 Refactor the BorderAnimator for simplicity
The internal implementation of BorderAnimator does not need to be as exposed. refactored the class to be simpler to implement

Flag: ENABLE_KEYBOARD_QUICK_SWITCH, ENABLE_CURSOR_HOVER_STATES
Bug: 302334949
Test: check border animation in keyboard quick switch and recents view
Change-Id: I8a2e4fa0abc5af743352cd6409aee9f2912b41a2
2023-09-29 15:08:05 -04:00
Luca Zuccarini 850a282446 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79 am: f876cb4bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Iac57076c82c798876d7d94c9f03d3fc1d34bc09f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 18:41:51 +00:00
Luca Zuccarini f876cb4bf4 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Ic9371183df1de229eb96a867c01eab21fd0f8b02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 17:36:12 +00:00
Sunny Goyal 72a7407695 Merge "Passing activityClassName when setting unlock controller" into main 2023-09-29 16:48:03 +00:00
Fengjiang Li 576c7ff4d7 Merge "Don't preinflate all apps for taskbar in AllAppsStore#setApps" into main 2023-09-29 16:16:58 +00:00