Commit Graph

12011 Commits

Author SHA1 Message Date
Jon Miranda 175f5c865b Merge "Fix badged icons / icons with notification dot being cropped." into tm-qpr-dev 2023-04-03 21:06:21 +00:00
TreeHugger Robot f00e831f05 Merge "Stash taskbar on swipe to go home for 3p fallback launcher." into tm-qpr-dev 2023-04-03 19:47:40 +00:00
Mike Schneider 99cd75e9e3 Merge "Change the use of ScreenLifecycle to WakefulnessLifecycle." into tm-qpr-dev 2023-04-03 19:44:23 +00:00
Jon Miranda b0195376d4 Fix badged icons / icons with notification dot being cropped.
For icons, we use radius = 0 during the reveal animation so
that the entire view will be visible.

Fixes: 276625136
Test: - have work profile icon or badged shortcut in taskbar/hotseat
      - swipe up to close
      - also check swipe back to close
      - ensure entire icon is visible at the end of the animation so
        that there is a clean handoff
      - run same test with icons that have notification dot
Flag: ENABLE_TRANSIENT_TASKBAR true

Change-Id: I3fef1eede5cac189dab1bf1be4ebd048720727c7
2023-04-03 10:06:16 -07:00
Vinit Nayak 8e307ba50a Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev 2023-04-03 14:58:29 +00:00
Mike Schneider 65b1561a68 Change the use of ScreenLifecycle to WakefulnessLifecycle.
This is a better fit for the signal in launcher, since it identifies
whether the device is awake or asleep, where asleep also inclues AoD

Test: manual, unit tests
Bug: 275319714

Change-Id: I6d6a6694ab018d182606c5554377caec1986bc08
2023-04-03 16:47:12 +02:00
Pat Manning 9330d4991e Stash taskbar on swipe to go home for 3p fallback launcher.
Follow up to b/21916480, which was reverted due to test failures which are now fixed.

Fix: 269070986
Test: manual. Install launcher3WithoutQuickstepDebug and swipe to home from within an app.
Change-Id: I52fad88a25325e5c38a600ccf90b30ebf60bf71a
2023-04-03 10:09:11 +00:00
TreeHugger Robot 503d86c45b Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-04-02 03:31:15 +00:00
Winson Chung 13bf1598b9 Merge "Fix gesture insets issue for IMEs" into tm-qpr-dev 2023-04-02 03:26:14 +00:00
Winson Chung 8436e0b382 Fix gesture insets issue for IMEs
- Setting the override frame for the gesture insets sources prevents
  the insets from being calculated correctly for the IME window
- Update the set of provided insets based on the current nav mode
  so that we don't report gesture insets in button nav

Bug: 265614886
Test: Dump IME window insets for button/gesture nav
Change-Id: I22f9d09a66b50d6e2fb5002af19058657a06404d
Merged-In: I22f9d09a66b50d6e2fb5002af19058657a06404d
2023-04-01 06:37:47 +00:00
Bill Yi 9ed0217d00 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id00dea37f59152b745d84b9d6883c72f8e7012b8
2023-03-31 18:16:12 -07:00
Brian Isganitis 4500171c6b Merge "Clean up device profile change listeners for AllApps." into tm-qpr-dev 2023-03-31 16:42:07 +00:00
TreeHugger Robot d9dd75d2cc Merge "Don't stash immediately when drag was canceled" into tm-qpr-dev 2023-03-31 00:08:44 +00:00
Vinit Nayak ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Jagrut Desai d1d0fb8607 Merge "Taskbar System Action with Broadcast Receiver." into tm-qpr-dev 2023-03-29 23:26:26 +00:00
Tony Wickham 52f046e027 Don't stash immediately when drag was canceled
Instead, keep the taskbar open for the normal timeout.

Test: Drag an app from taskbar and drop back in taskbar, ensure taskbar
stays open until 5 second timeout; Drag an app from taskbar and drop
into split screen, ensure taskbar stashes immediately
Flag: ENABLE_TRANSIENT_TASKBAR true
Fixes: 275019813

Change-Id: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
Merged-In: I06ca0eccbfe313dbae8f6d96c7c09bb659f6a27b
2023-03-29 23:10:11 +00:00
Jon Miranda e008411f00 Merge "Align taskbar so that it does not overlap with nav buttons." into tm-qpr-dev 2023-03-29 23:04:43 +00:00
TreeHugger Robot 495c7819ef Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-03-29 22:22:16 +00:00
Jon Miranda 156ff34f35 Align taskbar so that it does not overlap with nav buttons.
Fixes: 275510698
Bug: 259712417
Test: View device where taskbar should be start aligned
      Update Display size to make everything bigger
      Observe that taskbar icons never overlap nav buttons
Flag: ENABLE_TRANSIENT_TASKBAR true

Change-Id: I246374518f21c4b92d3e02e5582c929a471d9305
2023-03-29 21:04:03 +00:00
Schneider Victor-tulias 1db2fcbd19 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev 2023-03-29 18:54:22 +00:00
Brian Isganitis d43d7c3702 Clean up device profile change listeners for AllApps.
Test: https://b.corp.google.com/issues/260177372#comment1
Bug: 260177372
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d17261029af89ef03b860686d1d3c6651e7c8e13)
Merged-In: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
Change-Id: Ic7417980e8280bf2fcb110e5de74ea2ae59d9b74
2023-03-29 18:46:47 +00:00
Jagrut Desai d2140ba498 Taskbar System Action with Broadcast Receiver.
Test: Manual
Bug: 265618836
Change-Id: I734402ef277a09cf5e41aa63f8be09375706c17a
2023-03-29 10:37:45 -07:00
Schneider Victor-tulias 90259a6db4 Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev 2023-03-29 17:03:59 +00:00
Bill Yi 4a7f7025b7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idd3d822debe118ff239dbbcac121170df81769f0
2023-03-28 20:05:36 -07:00
Saumya Prakash eed10f31f7 Merge "Add extra error checking for Home Gesture Tutorial" into tm-qpr-dev 2023-03-28 22:30:56 +00:00
Randy Pfohl 40f065d1fd Merge "checking if outline provider is null to handle rare NPE" into tm-qpr-dev 2023-03-28 22:02:03 +00:00
Jagrut Desai 6fcdfb166d Merge "Make taskbar accessibility announcement when user is in app only." into tm-qpr-dev 2023-03-27 22:38:54 +00:00
Schneider Victor-tulias 2851be8cba Add the gesture nav tutorial menu page
- Added the gesture tutorial menu page (launched using an intent extra)
- tutorial steps now launch the menu when complete if launched from the menu
- the new default set of tutorial steps is home -> back -> overview. this is to handle the case where an intent is launched that is meant to launch the tutorial menu, but ENABLE_NEW_GESTURE_NAV_TUTORIAL is false

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 274463555
Test: Ran the tutorial and menu on a large screen, foldable and phone
Change-Id: I2eb5f658115be4d5ecb0233a8f09d22efe6ebadc
2023-03-27 14:36:01 -07:00
Schneider Victor-tulias 7cd0ae3f73 Fix TwoPanelWorkspaceTests
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click

Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
Randy Pfohl f96827b331 checking if outline provider is null to handle rare NPE
test: verified that a null value wouldn't cause a crash, and would still show the well being toasts correctly. defaulting a value could cause abnormal behavior so I have created a task to follow up with to figure out why this value is being set to null.

bug: 236918951
Change-Id: I9d4282273cb0bc5b6b095dbd082dd1ef79add0dc
2023-03-27 20:18:46 +00:00
Saumya Prakash f641813483 Add extra error checking for Home Gesture Tutorial
Add an error message for when a user swipes horizontally from the middle
of the screen.

Fix: 275386244
Test: Manual
Change-Id: If4d0dd412c3d1625da18f9c068e5fd7b281548c5
2023-03-27 19:56:35 +00:00
Jagrut Desai 4661854dd6 Make taskbar accessibility announcement when user is in app only.
Test: Manual
Bug: 265099829
Change-Id: I9d90ed7ae3479cf51b261bba63aedccf515bd2c5
2023-03-24 17:02:58 -07:00
Bryce Lee 1276443016 Merge "Revert "Do not allow system gestures when dreaming."" into tm-qpr-dev 2023-03-24 22:58:03 +00:00
Jon Miranda 085c53869f Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev 2023-03-24 21:51:42 +00:00
Hyunyoung Song e8abfee5e9 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev 2023-03-24 21:41:04 +00:00
Jon Miranda 9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Bryce Lee 340f6c0988 Revert "Do not allow system gestures when dreaming."
This reverts commit 05c9d551d8.

Reason for revert: leads to b/274525884

Test: manual
Fixes: 275081253
Change-Id: I4bef532b1d8cb4e4c71458e609f25da901ed943d
2023-03-24 18:34:11 +00:00
Jon Miranda a8f03bbe13 Update transient taskbar shadow alpha for light/dark theme.
Bug: 259712417
Test: manual
Change-Id: If3b24efa7b619501e8ed07621d8673e68d2c903d
Flag: ENABLE_TRANSIENT_TASKBAR true
2023-03-24 17:22:39 +00:00
Mike Schneider 1a09d4a2a2 Merge "Auto-stash taskbar when locking device" into tm-qpr-dev 2023-03-24 10:32:43 +00:00
Johannes Gallmann 96892011ff Merge "Fix taskbar linger above notification shade" into tm-qpr-dev 2023-03-24 09:46:42 +00:00
Jagrut Desai 601e0ff89c Merge "Make clear announcment for taskbar education." into tm-qpr-dev 2023-03-23 23:52:24 +00:00
Charlie Anderson bc65c3d442 Merge "reorder System shortcuts for taskbar and secondary display" into tm-qpr-dev 2023-03-23 20:39:06 +00:00
Mike Schneider ba19f31669 Auto-stash taskbar when locking device
This greatly reduces the the jank of the taskbar being shown above the
lockscreen.

Before: http://shortn/_PhXhkWR73t
After: http://shortn/_MC3ZLGHp4o

Bug: 264604213
Test: manual (http://shortn/_ISEXThUFM2), tapl
Change-Id: Ib1c5dbaafd4d0e1d69fbc03d908632e0275c8a0b
2023-03-23 19:30:12 +00:00
Tony Wickham 2b8b47952f Merge "Handle swipe down on taskbar to stash" into tm-qpr-dev 2023-03-23 18:54:09 +00:00
Jagrut Desai ef1a9b798d Make clear announcment for taskbar education.
Test: Manual
Bug: 273393698
Bug: 273408584
Flag: not needed
Change-Id: I6c6eb1e1e1047a2e702592290bf5735e8bfa6ce2
2023-03-23 11:26:09 -07:00
Bill Yi 70727e87eb Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-03-23 18:03:14 +00:00
Jon Miranda fc8606dadc Merge "Update nav bar buttons to spec." into tm-qpr-dev 2023-03-23 17:37:53 +00:00
Jon Miranda cbe578b269 Merge "Fix spring not springing when unstashing." into tm-qpr-dev 2023-03-23 17:37:35 +00:00
Charlie Anderson 04c6def895 reorder System shortcuts for taskbar and secondary display
Bug: 269343928
Bug: 272418357
Test: locally on device
Change-Id: Iec7f9ad702214c7ab7f49758dbf2463fe63b0324
2023-03-23 15:27:12 +00:00
Tony Wickham c73db73a79 Handle swipe down on taskbar to stash
- Moved all touch-to-stash logic to new TaskbarStashViaTouchController
  (handles both tap outside to stash instantly as well as swipe down
  inside to stash after letting go)
- This is a TouchController on TaskbarDragLayer, so it intercepts
  touches from TaskbarView before icons can be dragged during swipe down

Test: swipe up to invoke transient taskbar in an app, swipe down or
touch outside to stash
Flag: ENABLE_TRANSIENT_TASKBAR=true
Fixes: 246631710

Change-Id: I5cf64848bba34ad32fcc80a93fb4f79ebd2c10a7
2023-03-23 15:13:52 +00:00