Commit Graph

17119 Commits

Author SHA1 Message Date
Vinit Nayak 1525cd7269 Add method to determine if launcher is in split selection state
* Available for both launcher and taskbar via
ActivityContext

Bug: 295981634
Change-Id: I8767deea0b2432da3047209037874c966b83c3b3
2023-10-06 14:40:49 -07:00
Kevin Lim 07546b88e7 [AppInfo] Enable logs for debugging unexpected AppInfo changes.
Here's a sample log run through of AllAppsStore and PackageUpdatedTask
logs: http://gpaste/5250747917664256

Bug: b/290090023
Flag: None. Adding logging.
Test: None. Adding logging.
Change-Id: Ia1d620a50267d6a65fe719936d7e87e6dad13afa
2023-10-02 19:40:58 +00:00
Pat Manning 1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Sebastián Franco 94f7b53a54 Merge "Adding a keyboard shortcut delegarte to move logic outside of the launcher" into main 2023-09-29 18:03:02 +00:00
Fengjiang Li 576c7ff4d7 Merge "Don't preinflate all apps for taskbar in AllAppsStore#setApps" into main 2023-09-29 16:16:58 +00:00
Jagrut Desai 7a2bfd39bb Merge "Add isTransientTaskbar as DeviceProfile Builder Property" into main 2023-09-28 22:34:25 +00:00
Fengjiang Li e92556819b Don't preinflate all apps for taskbar in AllAppsStore#setApps
Triggering all apps pre-infation at AllAppsStore#setApps is too late for taskbar, because it is in same frame when user opens all apps from taskbar. We should find an earlier entry point to pre-inflate all apps for taskbar.

Test: Verify taskbar is rendered correctly. Also verify we no longer pre-inflate all apps for taskbar in perfetto trace
Change-Id: If1f8c616b6be7f64ea16807f4b7a8b75da55d038
2023-09-28 14:29:07 -07:00
Sebastián Franco d37195dc35 Merge "Moving getters and setters to the end of the file" into main 2023-09-28 20:13:46 +00:00
Jagrut Desai 3a7d139110 Add isTransientTaskbar as DeviceProfile Builder Property
- Breakout CL part 5
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of adding isTransientTaskbar as DeviceProfile Builder Poropety
- This cl alos consist a shared pref listener for taskbar pinning to update device profile.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I2ade751ffc8c59bd4b862b56c8ca7eb2aa05b7f2
2023-09-28 12:01:58 -07:00
Stefan Andonian dfc628dabb Merge "Make exception for TASKBAR_PINNING so it is boot aware." into main 2023-09-28 18:59:14 +00:00
Sebastian Franco 4080fddfe7 Adding a keyboard shortcut delegarte to move logic outside of the launcher
Bug: 301142423
Test: compiling, this change is a no-op change
Change-Id: I2f5ee35a9ab645c26cc97669f6a745490fdfdb61
2023-09-28 10:03:17 -07:00
Fengjiang Li e05ada7992 Merge "Lower thread priority to pre-inflate BubbleTextView for all apps" into main 2023-09-28 16:28:45 +00:00
Sebastián Franco 015eda683f Merge "Make sure to not call DragOver when the drag is still under PreDrag" into main 2023-09-28 16:13:32 +00:00
Sebastian Franco 1be772df1d Make sure to not call DragOver when the drag is still under PreDrag
Adding a flag so we can turn off this behavior if it break a drag functionallity

Fix: 299748096
Test: most of dragging test will test this
Change-Id: I4f45faea4f19bd99a946a28372546e18ca5f6a2f
2023-09-27 15:05:47 -07:00
Stefan Andonian 939d5f876b Make exception for TASKBAR_PINNING so it is boot aware.
Bug: 251502424
Test: No launcher exceptions where thrown when TASKBAR_PINNING feature
is enabled.

Change-Id: I7e71d37547af1951938c6d5e77325d5e8e6b9fbd
2023-09-27 21:42:45 +00:00
Fengjiang Li 39133c38bc Lower thread priority to pre-inflate BubbleTextView for all apps
During sys health review it was called out that we could lower the thread priority to pre-inflate BubbleTextView so that ui thread and loader task thread has better chance to run on big core.

Bug: 297352492
Test: Grabbed perfetto trace and observed preinflation is run on "preinflate-allapps-icons" thread
Change-Id: I9330d4fbe5a98cdb793e8bfa970dfd84ae1f6c39
2023-09-27 13:29:17 -07:00
Schneider Victor-tulias f055c25ec1 Merge "Clean up FeatureFlags.java" into main 2023-09-27 17:28:16 +00:00
Brandon Dayauon cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Schneider Victor-tulias 8d3d623bc7 Clean up FeatureFlags.java
Flag: not needed
Bug: 291651514
Test: not needed
Change-Id: I37d7ac39f5feddab303ccb3c3305e2e2b3b6bd3e
2023-09-26 17:25:33 -04:00
Brandon Dayauon 3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Thales Lima 8f58b0a63d Enable TEAMFOOD for ENABLE_RESPONSIVE_WORKSPACE flag
Bug: 299935275
Test: manual
Change-Id: If341730c3eb43ffb243b960ad76bc223058e426d
2023-09-25 16:27:21 -07:00
Thales Lima ca31b6105e Migrate ENABLE_RESPONSIVE_WORKSPACE to aconfig
- Keeping FeatureFlags.ENABLE_RESPONSIVE_WORKSPACE for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_RESPONSIVE_WORKSPACE in tests as aconfig still can't be mocked

Bug: 299935275
Test: manual
Change-Id: I092df894a3624dca6b9d381d56ada71d807547b5
2023-09-25 16:25:15 -07:00
Federico Baron 0bc00d24ab Merge "Add extraItems to dump log for BgDataModel" into main 2023-09-25 21:35:15 +00:00
Andrew Cole e81a3cef0c Merge "Unfolded Two Pane Widget Picker Prototype" into main 2023-09-25 19:59:30 +00:00
Brandon Dayauon c65b902cc4 Merge "Fix gray work apps when WorkPausedCard shoul've shown" into main 2023-09-25 18:13:12 +00:00
Andrew Cole c19a618706 Unfolded Two Pane Widget Picker Prototype
As described, this is a small prototype to show what the current state of the two pane widget picker would look like in an unfolded foldable.

Bug: 301918659
Test: N/A
Flag: UNFOLDED_WIDGET_PICKER
Change-Id: Ia495de39a470f1dccf70ce53e59c7929525c4a00
2023-09-25 11:00:24 -07:00
Stefan Andonian 84230b2ea0 Merge "Move "Enable Boot Aware Startup data" to behind a FeatureFlag." into main 2023-09-25 17:06:12 +00:00
Thales Lima 2d1d14193b Merge "Fix to prevent unsorted breakpoints returning wrong spec" into main 2023-09-25 16:12:56 +00:00
Treehugger Robot 3cc4f5baaf Merge "Avoid sending an IME close request if the IME is already closed." into main 2023-09-22 22:14:10 +00:00
fbaron 5c835dafa1 Add extraItems to dump log for BgDataModel
The extraItems include suggested hotseat icons, which we want to have in the dump to help us debug future bugs regarding hotseat

Bug: 301369051
Test: n/a
Flag: no flag
Change-Id: I6a0f5e785441915ecfece95dfcba7d60ef5912d2
2023-09-22 10:27:33 -07:00
Brandon Dayauon c8af851e99 Fix gray work apps when WorkPausedCard shoul've shown
The reason is because WorkManager doesn't reset when user searches (which is why the apps gray out when you go to toast, turn off work profile then back gesture to all apps)

Added test for ActivityAllAppsContainerView that test onAppsUpdated() and check for if there are work apps.
From the test environment, onAppsUpdated() needs to be public because the method is outside the package. However, I've wrapped onAppsUpdated package private so I can test it with a boolean parameter.

bug: 298492729
test: video:
before: https://drive.google.com/file/d/1D0VlGeJEI5lGbYgP5Tnu5UO_Dv61X8Dv/view?usp=sharing
after: https://drive.google.com/file/d/1D0qsq7sX_kAp2t92xser7YI4ADBhQfHY/view?usp=sharing
Change-Id: I4eb7cf21e273e29171fcd62a4762e8bb1778e720
2023-09-22 17:18:10 +00:00
Sunny Goyal 9dfbb0aca8 Merge "Fixing pending tasks being queued on bind after the pending executor is already finalized." into main 2023-09-22 16:52:00 +00:00
Brandon Dayauon 8e24505d09 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37 am: f9a203c586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: I4e955f635773b5084b315282d373b16cff6988e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 16:22:21 +00:00
Brandon Dayauon 28ae77df37 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev 2023-09-22 14:36:45 +00:00
Charlie Anderson 605db4b74a Merge "Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests. See tearDown method in RestoreDbTaskTest for fix." into main 2023-09-22 14:13:39 +00:00
Jeremy Sim dcb6f5736e Merge "Request split launches using a new enum, snapPosition, rather than a float splitRatio" into main 2023-09-21 23:50:38 +00:00
Sunny Goyal f0925fdf31 Fixing pending tasks being queued on bind after the pending executor is already finalized.
Bug: 291664186
Test: Tentative fix, will know more from dashboard
Flag: N/A
Change-Id: I1f1883fb315f05417839507b95ccc80e0b57b530
2023-09-21 13:50:48 -07:00
Federico Baron fe442a18c2 Merge "Shortcut crash fix" into main 2023-09-21 19:25:40 +00:00
Federico Baron 9bbb0c7522 Merge "Shortcut crash fix" into udc-qpr-dev 2023-09-21 19:25:25 +00:00
Federico Baron 9c4132b31d Merge "Fix indexoutofbounds folder preview" into main 2023-09-21 19:25:04 +00:00
Stefan Andonian dbc8ec530c Move "Enable Boot Aware Startup data" to behind a FeatureFlag.
Previously this was hard-coded to disabled, but that was before
FeatureFlags were made to be boot aware.

Bug: 251502424
Test: Verified that doing this doesn't break my device. Also tested the
Pre-loading feature itself and didn't see any errors in the logs.

Change-Id: I031e1756b985664a2e8d8ad26e16803ead874727
2023-09-21 19:10:22 +00:00
Jeremy Sim da230cf526 Request split launches using a new enum, snapPosition, rather than a float splitRatio
Split ratios are now stored as an int enum rather than float values. Previously, split ratios were stored as floats, which needed to be recalculated frequently and differed depending on device screen size. Now Shell to store and launch split screen setups using an enum rather than floats.

Bug: 274835596
Bug: 182839788
Test: Existing tests still pass
Change-Id: Iebb8d3c7e8f9d597a59b677e48072300ddea458f
2023-09-21 11:34:07 -07:00
Uwais Ashraf d295e3510a Merge "Set taskbar heights to 0 when taskbar is not present." into udc-qpr-dev 2023-09-21 16:39:10 +00:00
Jordan Silva e4d7aaa6fd Fix to prevent unsorted breakpoints returning wrong spec
It orders the breakpoint list to guarantee that the smallest breakpoint is always returned for a given availableWidth or availableHeight.

Fix: 301396419
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: CalculatedWorkspaceSpecTest
Change-Id: Ia545e84150027bd8daa8d0dde58ff6fc579c3b6a
2023-09-21 11:44:56 +01:00
fbaron 7f4bbfa599 Fix indexoutofbounds folder preview
The indexoutofbounds issue came from the fact that folder was being animated open when there are no items in preview. It might be a race condition where we try to open the folder at a time where it's actually being emptied. This check should prevent folders from running animateOpen() if there's <= 1 items, avoiding the outofbounds error

Fix: 298740874
Flag: no flag
Test: no test
Change-Id: I31ed53fbdf22a7f19bc9ec414242312afe7c6cd2
2023-09-20 23:57:00 -07:00
fbaron d87178460c Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-21 05:53:45 +00:00
fbaron ba0f7a0b17 Shortcut crash fix
Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.

Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
2023-09-20 22:52:46 -07:00
Randy Pfohl bd585e4d42 Merge "Remove logs for bug investigation" into main 2023-09-20 23:14:33 +00:00
Brandon Dayauon 47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Charlie Anderson 8c1cf2db26 Make sure to set Launcher restore pending as false after setting in RestoreDbTaskTest to not affect state of Launcher in tests.
See tearDown method in RestoreDbTaskTest for fix.

This reverts commit 2d86f3337a.

Reason for revert: fixing the issues for revert b/298077774
Test: running presubmit and affected test suite on CL

Change-Id: I94c643f38259c4e920869c231f706229390c7c2a
2023-09-20 18:43:35 +00:00