- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape
Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.
Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
Updated logic for taskbar scrim view alpha calculation, setting it to 0
when bubble manage menu is shown.
Fixes: 337169457
Flag: NONE
Test: Visual.
For gesture navigation:
1) On foldable phone while device is being folded expand any
bubble, click mange button, then unfold. Observe no scrim view is
visible.
2) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles are open.
3) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles and mange menu is open.
4) Enable persistent taskbar. Fold device. Open bubble and click manage
button. Unfold device. Observe no scrim view is visible.
For 3 button navigation
1) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles are open.
2) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles and mange menu is open.
3) Fold device, open bubble and click manage button. Unfold device.
Observe no scrim view is visible.
Change-Id: Ic011ae9bd11801a479062cc51c60377823a926fb
This could be caused by landscape layout not receiving inset changes
Adding logs for hotseat layout info as well
Bug: 335141365
Flag: EXEMPT bugfix
Test: N/A
Change-Id: I987f8622907a10fac5375ddddac3db2c5eba41c1
* changes:
Adjust previews in a row to align with each other and remove whitespace.
Move item animator to its own class and use it only for full sheet
Measure recommendation children using the provided available height
This reverts commit 883a79db71.
Reason for revert: Revert this change because it caused other bug b/343285163
Change-Id: I1fdb21cc4a5cdcf2c22e9b1927753b290626289c
- Introduces a WidgetTableRow that identifies preview height for all of
its children while keeping them aligned with minimum whitespace
- The fullSheet's move / change animations can conflict with the resize
so, we wait for them before performing resize of the row.
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: Id843430c7adfc228c219ba54d504baddba792df0
We always want to measure the pages based on the provided height.
Bug: 335715046
Test: Manual
Flag: NONE BUGFIX
Change-Id: I9de2ed1e0d4cc37d24435b9077e60bf5f0456091
This way we can keep the click listener in this PrivateSpaceSettingsButton.java class.
- Moved itemInfo creation to PrivateSpaceSettingsButton and created a test class
bug: 341053089
Test: manually - presubmit video: https://drive.google.com/file/d/1_TCGrILvwmMpxbgIcbOcpB2AxeBJbyNf/view?usp=sharing
Flag: Aconfig com.android.launcher3.enable_private_space Nextfood
Change-Id: I79cd319274f4445dd00bc257be81728360d09684
Disabling animations altogether reduces the flakiness, however, icon's alpha seem to be changed and then cleared, and there was 1 out of 24 runs where it flaked; so, avoiding the toggle of alpha when animations are disabled.
Bug: 337916664
Test: Screenshot tests
Flag: N/A
Change-Id: I4e9d703d005e3916ee01cf74baa2a804a3c1efd1
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.
Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
This is because during onBind() that the icon alpha should be set to 0 ONLY in the case
when animation + scroll is happening.
The repro cuj is this:
user has private space unlocked -> goes to toast and clicks qs tile -> onBind() happens
and animationScrolling = true -> icon alpha is now 0. Instead we should check getAnimate() && scrolling()
&& isStateTransitioning()
bug: 340836439
Test: manually -
before: https://drive.google.com/file/d/1WLZRPsz-hm1d3fVRNGXs_Ps_AcdJhkPs/view?usp=sharing
after: https://drive.google.com/file/d/1LidDKhx2ijOXmX_tcPAmng5P56WNPyyx/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation NEXTFOOD
Change-Id: I10b8ee5d8449acdb3d2c64e0e311f7dde89a464a
Currently entire workspace scales down, but the original view sticks
to user's finger at same size as before. This makes the view look larger
obstructing the view of workspace behind it - specifically, when the
widgets are of larger size.
Additionally, with this scaling change, the preview images that aren't
of same aspect ratio don't break the transition to final widget as
before.
Bug: 338290585
Test: Unit test
Flag: None bugfix
Change-Id: I1d1818e60506898c7b28074f01cee91282032a94
Test steps:
1. Execute adb shell settings put secure selected_search_engine <search_engine_package_name> (Ex: com.duckduckgo.mobile.android)
2. Install the app and verify the search widget on launcher is updated.
3. Uninstall the app and verify the search widget is replaced by
placeholder
When we change the search engine setting after the app is installed , we need to force-stop launcher app for the new settings to take effect.
Bug: 333029477
Flag: EXEMPT bugfix
Test: Manual
Change-Id: If127dcc87c5278a98177b83514cddb09a4124223
Need to create a bug-fix flag since feature flags can't reach nextfood in time for V. We do this by renaming
the current flag.
According to https://g3doc.corp.google.com/company/teams/android-core-experiments/trunk-stable/gantry-stages/bug-fix.md?cl=head
After a flag declaration has been merged, it's no longer possible to change its purpose. If the purpose of a flag changes over time, simply rename the flag; this will create a new workflow and invalidate the previous workflow.
In cases where renaming is not possible, please file a bug for the ACE oncall. Even when re-using the name of a flag for a new purpose, please note that all the progress in the pre-existing workflow will be lost; the new bug-fix workflow will start from scratch.
bug: 339850589
Test: Presubmit/locally adb shell device_config put launcher_search com.android.launcher3.private_space_add_floating_mask_view true
Flag: ACONFIG com.android.launcher3.private_space_add_floating_mask_view STAGING
Change-Id: Iffbc6a93c4ef6bbe121e0c8fb83250174f367b9d
Brandon Dayauon
Mykola Podolian
Alex Chau
Shamali P
Xiaowen Lei
Treehugger Robot
Sihua Ma
Schneider Victor-tulias
Liam Lee Pong Lam
Anton Vayvod
Kevin Lim
Himanshu Gupta
Anushree Ganjam
Jordan Silva
Sunny Goyal
Brian Isganitis
Pierre Barbier de Reuille