Commit Graph

14167 Commits

Author SHA1 Message Date
Min Chen 12fafb2469 Merge changes from topic "empty-desk" into main
* changes:
  Remove wallpaper task and tasks below from `getCachedTopTask`
  Handling for an empty desk
2025-03-26 13:02:49 -07:00
Treehugger Robot f40ab3e250 Merge "Migrate DesktopVisibilityListener from RecentsView to RecentsViewUtils" into main 2025-03-26 13:00:29 -07:00
Treehugger Robot f271fb049d Merge "Run dismiss immediately if no neighbors exist." into main 2025-03-26 12:11:39 -07:00
Treehugger Robot 4d9ced3c59 Merge "Use a specific dimension for the overview app chip menu bottom margin" into main 2025-03-26 11:31:16 -07:00
Pat Manning 8216005fd0 Run dismiss immediately if no neighbors exist.
Previously was still relying on spring driver to end, even if driving no neighbors.

Update live tile before canceling animation to bring task off screen, or else it may still show at the top of the screen.

Fix: 405364868
Test: Manual
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ic9a1b4ba9aaf1ec3830e49bf15573388a6d7a2ad
2025-03-26 10:45:22 -07:00
Suhua Lei c23e0bdee9 Migrate DesktopVisibilityListener from RecentsView to RecentsViewUtils
Bug: 401002178
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: manually add and remove desks
Change-Id: I7a7b8b67eb2f84a83cef6fdd7d728967ab6a7c20
2025-03-26 17:40:45 +00:00
Alex Chau 66ac9dc459 Merge "Revert "Remove unnecessary call to RecentsView.reset when switching from any non-overview state."" into main 2025-03-26 10:22:42 -07:00
Jon Miranda 333a9bd983 Merge "Prevent NPE when syncing app launch with taskbar stash." into main 2025-03-26 10:21:58 -07:00
Treehugger Robot 5b280a12f6 Merge "Update fonts in gesture nav tutorial menu page" into main 2025-03-26 10:17:44 -07:00
Jordan Silva 8134ad2b53 Use a specific dimension for the overview app chip menu bottom margin
Fix: 401476868
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id6932958bd694f28fdad4004946106a28f726cb2
2025-03-26 09:12:54 -07:00
Daniel Andersson 6db50866de Merge "desktop-exploded-view: Fix glitch with thumbnailView.outlineBounds" into main 2025-03-26 09:05:37 -07:00
Jagrut Desai 7a6b2a39f6 Merge "Fix Taskbar Flicker with Recents or Running Apps Present" into main 2025-03-26 08:59:05 -07:00
Jordan Silva ec18b825e4 Merge "Adjust IconAppChipView chip width based on state" into main 2025-03-26 08:36:26 -07:00
Alex Chau fc5a07e40b Revert "Remove unnecessary call to RecentsView.reset when switching from any non-overview state."
This reverts commit 162a85e777.

Reason for revert: b/406430367

Change-Id: I1be60513d8f034d6aab9489a95f98a7a0f16d26d
2025-03-26 07:41:36 -07:00
Shamali Patwa a8455409f6 Merge changes from topic "dwb-refactor-data" into main
* changes:
  Add a useCase to get the remaining app time rounded down to minutes
  Add a repository to fetch the remaining time for DWB
2025-03-26 06:02:52 -07:00
Treehugger Robot dd7d89d7e1 Merge "Account for Recents Scale when computing dismiss length to take task off screen." into main 2025-03-26 05:09:07 -07:00
Treehugger Robot 8292d26063 Merge "Snap to Large tile or first grid task when they are the next page." into main 2025-03-26 05:07:40 -07:00
Jordan Silva 3451ddddd1 Adjust IconAppChipView chip width based on state
This CL will fix the issue when the app chip is bigger than the TaskView and doesn't respect its maxWidth value.
Also fixes the bug when the first chip expands when taps over the second app chip.

Fix: 406225230
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id1c806a320522e6d5bda3d4d8712a43637c57834
2025-03-26 04:38:32 -07:00
Jordan Silva f4b5725ef0 Merge "Add marquee for AppChip and simplify text view handling in IconAppChipView" into main 2025-03-26 04:28:26 -07:00
Treehugger Robot b4a37aed36 Merge "Remove unnecessary call to RecentsView.reset when switching from any non-overview state." into main 2025-03-26 00:12:42 -07:00
Vinay Joglekar 6b59446c58 Merge "Add logs for debugging to overview blur" into main 2025-03-25 21:58:52 -07:00
Vinay Joglekar fe5b8108b5 Merge "Reduce calls to surface reparenting and set relative layer." into main 2025-03-25 21:58:28 -07:00
Shamali P 258d1297fe Add a useCase to get the remaining app time rounded down to minutes
The flag will be applied at the code using this use case.

Bug: 405974619
Fix: 405974619
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: GetRemainingAppTimerDurationUseCaseTest
Change-Id: I939b3447b93e7e84eb69032aa0f67c1629f916c1
2025-03-25 23:50:20 +00:00
Shamali P 24ba38b393 Add a repository to fetch the remaining time for DWB
The usage of this chain will be flagged

Bug: 405359454
Fix: 405359454
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: AppTimersRepositoryTest
Change-Id: Ife0db79175dd30982a0cb179369a3cea470ef7ba
2025-03-25 23:41:46 +00:00
Daniel Andersson aeca730761 desktop-exploded-view: Fix glitch with thumbnailView.outlineBounds
This is a follow up to ag/32333172. With that change, task thumbnails
are immediately placed in the exploded position and then transformed
into the intermediate positions/sizes that is controlled by the explode
progress.

This CL fixes a glitch where thumbnailView.outlineBounds was not
computed properly. The bounds are now computed per frame (since the task
may animate in from a position that is partially off-screen). The
intersection with the screen bounds rectangle is now done with the
per-frame position of the task window and then crucially scaled to
account for the transformation that is applied to the thumbnail itself.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
BUG=399822967

Change-Id: I66d6d9f662f0e70e86ea1befcec4c43d2434fb35
2025-03-25 16:28:09 -07:00
Treehugger Robot 4a22d06f6a Merge "Fix split chip wrong translation in Fake Landscape" into main 2025-03-25 15:56:55 -07:00
Treehugger Robot 2032de9d20 Merge "Fix miscellaneous TAPL testing issue" into main 2025-03-25 15:24:28 -07:00
Jon Miranda 9bf65787e9 Prevent NPE when syncing app launch with taskbar stash.
This can happen because when callback is ran after onDestroy.
We call the runnable as part of the cleanup process to avoid
a leak.

Bug: 319162553
Fixes: 405316024
Test: Launch an app, note the two animations are synced
      Verified by locally introducing a startDelay (since otherwise it is hard to tell)
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: I961b9a185b2751a8a908d1a7b2cbfdb8bfe0b8f9
2025-03-25 15:18:03 -07:00
Treehugger Robot be8869060d Merge "Use up-to-date hover tooltip text for recents." into main 2025-03-25 14:28:16 -07:00
Jagrut Desai 64d448a8db Fix Taskbar Flicker with Recents or Running Apps Present
Test: Manual, Presubmit
Bug: 404772481
Flag: EXEMPT bugfix
Change-Id: If3b87474e6e85fabf24a42ac2a3e4ac6a19a4358
2025-03-25 14:16:12 -07:00
Priyanka Advani (xWF) 6e32188c4f Merge "Revert "Notify StateManager of workspace reveal animations."" into main 2025-03-25 13:35:54 -07:00
Jordan Silva 5c5028bf0b Fix split chip wrong translation in Fake Landscape
This change will prevent the split menu and app chip translation when in Fake Landscape and Fake Seascape.

Fix: 406239562
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: Id4aade8ce15cc51e81d5b1b7a82597924cdce7ca
2025-03-25 13:34:41 -07:00
Jordan Silva 7e676c6a40 Add marquee for AppChip and simplify text view handling in IconAppChipView
- Consolidates the two TextViews (collapsed and expanded) in `IconAppChipView` into a single `appTitle` TextView.
- Updates the app name's width based on the current chip status (expanded/collapsed)
- Removes the `icon_text_collapsed` and `icon_text_expanded` from layout and uses only `icon_title`.
- Adds marquee support to handle text ellipsis in the collapsed state.
- Refactors text width calculation for collapsed state to take into account maximum available width.
- Updates text animations to use the new `appTitle`.
- Updates the maximum width to not be set to less than the min width.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ic82790d0a79b65adb7ba14dad7848748cd568f62
2025-03-25 20:31:28 +00:00
Schneider Victor-Tulias 58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
Brian Isganitis 409ea18bf8 Merge "Perform system actions on focused display." into main 2025-03-25 12:28:30 -07:00
Schneider Victor-Tulias f1353604a9 Update fonts in gesture nav tutorial menu page
Flag: com.android.wm.shell.enable_gsf
Fixes: 405310693
Test: screenshots on bug
Change-Id: If806d4d87acf09b280bfe2efbea6256e0f936058
2025-03-25 15:21:00 -04:00
Treehugger Robot fb9548ac90 Merge "Close the Recents window onNewIntent" into main 2025-03-25 11:14:23 -07:00
Treehugger Robot 982c2abef5 Merge "Also cancel TaskView collection Jobs when Overview is not on screen." into main 2025-03-25 10:37:01 -07:00
vinayjoglekar af83003826 Add logs for debugging to overview blur
Bug: 406197011
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Iec9def155d91025e94a6ade2dc332b4c3f3ee943
2025-03-25 10:21:22 -07:00
Daniel Andersson 1735205986 Merge "desktop-exploded-view: Avoid triggering layout when starting animation" into main 2025-03-25 09:21:05 -07:00
Schneider Victor-Tulias 848b743c20 Close the Recents window onNewIntent
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Ied8a1ce6bb5b3a0c371ce857fe6df9d94fd04b40
2025-03-25 08:41:39 -07:00
Treehugger Robot d4c2dedf81 Merge "Add null backup for title." into main 2025-03-25 08:36:53 -07:00
Uwais Ashraf deefa3db71 Also cancel TaskView collection Jobs when Overview is not on screen.
This prevents old scopes still being active when new TaskView state emissions are being sent to main. They were previously cancelled in time but still result in empty continuations occuring on main.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I539a6fde8c9315ceeac74c9bf622d1e2dca1403a
2025-03-25 15:23:56 +00:00
Pat Manning ac5027dbf8 Account for Recents Scale when computing dismiss length to take task off screen.
Fix: 406213321
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: If0e79fc58a1f094071b98587e3f57af4af64c524
2025-03-25 14:41:27 +00:00
vinayjoglekar 1653a5082d Reduce calls to surface reparenting and set relative layer.
Surface reparenting was happening on every frame since we call
applyDepthAndBlur on each frame during animation. Instead we can do it
only when base surface is set. mBlurSurface should always be parented to
mBaseSurface so no point in calling it again and again.

Relative layer changes only when we either draw above or recents. While
drawing above recents, mBaseSurface relative layer should be used.
mBaseSurfaceOverride otherwise. No point to call this during animation.

Added perfetto traces comparison home->all apps, alongwith all other
generic overview scenarios which possibly could have caused jank is
added here:

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9dae7c5ece37e51664d82c680ea247f89bb5664b
2025-03-25 07:02:46 -07:00
Shamali Patwa 15fa804ddf Merge "Add ViewStubs for DWB layouts to avoid duplicate views in refactor" into main 2025-03-25 06:38:42 -07:00
Uwais Ashraf e54f38f7c7 Add null backup for title.
Fix: 403146003
Flag: EXEMPT - test bugfix
Test: Postsubmit runs
Change-Id: Icd94a207ba6e35b92c72e407db4ebc1ba0178723
2025-03-25 13:20:25 +00:00
Pat Manning b147f6f4b7 Snap to Large tile or first grid task when they are the next page.
Fix: 398232493
Fix: 399622012
Test: Manual
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I10cbd303b3e36059a41cb4ff7fdb4b4af7f93f23
2025-03-25 12:44:35 +00:00
Alex Chau f5956e01b2 Merge "Still play home task dismiss animation when aniamtorSet is null" into main 2025-03-25 05:03:06 -07:00
Treehugger Robot 5ff3717c6f Merge "Add debounce to TaskView emissions" into main 2025-03-25 03:58:44 -07:00