Commit Graph

12272 Commits

Author SHA1 Message Date
Sunny Goyal 12e3f1f2f7 Removing UI dependency from LauncherModel in case of 2-panel layout
Bug: 175939730
Bug: 192431856
Bug: 185515153
Test: Manual
Change-Id: I8baa1cf9e5a8a04d5b8bc38c1f4b0755265cd8a9
2021-07-22 10:34:25 -07:00
TreeHugger Robot f3a387d731 Merge "resolve merge conflicts of 46378eb881 to sc-v2-dev" into sc-v2-dev 2021-07-22 16:49:35 +00:00
TreeHugger Robot b971baefe1 Merge "Fix scaling on widget previews that have width / height set to wrap_content" into sc-v2-dev 2021-07-22 12:05:03 +00:00
Steven Ng 2b90d043f6 Fix scaling on widget previews that have width / height set to
wrap_content

If the widget preview has width / height set to wrap_content, we should
set the layout param width / height to the exact dimension after
measurement. Otherwise, we will end up clipping the previews.

Test: manual
Fix: 193144010
Change-Id: I101f7c6d3dbd264fee448b85c54029d5650d6630
2021-07-22 11:19:25 +01:00
Thales Lima 496ca0081e Merge "launcher: correct page spacing for multiple panels" into sc-v2-dev 2021-07-22 09:41:56 +00:00
Thales Lima e445774ab5 launcher: correct page spacing for multiple panels
This fixes 2 things:
- adding the correct space between pages as insets (eg camera) were
being discarded
- adding the space between pages instead of between panels as was before

This solution should work with more panels and don't create problems for
phones, where panels = 1.

Fixes 193194192
Test: manual testing in unfolded state in portrait and landscape, both
rotations

Change-Id: Ia3b148ceb773c6d5b6f8848ced07d7f9c1459e92
2021-07-22 09:41:43 +00:00
Jonathan Miranda c2a49ee2bc resolve merge conflicts of 46378eb881 to sc-v2-dev
Folder icon polish.

- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 194339057
Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Change-Id: I09ce9ef59e340b1009de3d26eed430a0a8dc4b33
Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
2021-07-22 00:43:27 +00:00
Jonathan Miranda 46378eb881 Merge "Folder icon polish." into sc-dev 2021-07-22 00:15:29 +00:00
Brian Isganitis a9b1814d42 Support overriding All Apps EDU animation on drag am: ec4a56a311
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15349065

Change-Id: Ie0caf9308989d8f3ba0b23ffb68b0157c5d2c22e
2021-07-21 20:15:33 +00:00
Brian Isganitis ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
Brian Isganitis d9d525236a Merge "Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"" into sc-dev 2021-07-21 00:37:36 +00:00
Vinit Nayak 6d2dd7a9e4 Merge "Move NavButtons to end of taskbar" into sc-v2-dev 2021-07-21 00:11:31 +00:00
Jon Miranda 92c1b5d3ab Folder icon polish.
- Increase the overlap between the preview items and the background
  so that it appears more intentional (lots of reports of users
  thinking that its a bug)
- Fix bug where clip path was still clipping icons when
  dragging and swiping to home.

Bug: 193701705
Bug: 191225536
Test: test 2 icon, 3 icon, and 4 icon folders
      close folder on 2nd page, ensure clipping
      ensure no preview items are clipped in drag view
      ensure no preview items are clipped in swipe up to home
      test 2x2, 3x3, 4x4, 4x5, and 5x5 grids to ensure no clipping
      of folder icons
      drag and drop folder in and out of hotseat
      create folders (2 icon, 3 icon, 4 icon)

Merged-In: Id49bae33438e10248bef05450d7e2c92c2140748
Change-Id: Ic3708bd402704f0a6f57ae5315ef602e2bbc6d82
2021-07-20 22:16:21 +00:00
Vinit Nayak 8dcbde87c0 Move NavButtons to end of taskbar
* Layout hotseat icons from the end instead of the start
* IME down and system back arrow are now separate views

Bug: 191399224
Test: Tested w/ RTL + LTR in gesture
and 3 button nav w/ and w/o IME

Change-Id: I4d0ecd0bee0c519892c63eeefef45055b26d349b
2021-07-20 13:55:37 -07:00
Hyunyoung Song 46255ad68e Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev am: 56c33c3cb8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15331688

Change-Id: I103161ef85f4f546399793b40aa7054263e64c84
2021-07-20 19:36:14 +00:00
Hyunyoung Song 56c33c3cb8 Merge "Fix fast scroller issues / remove fast thumb access / fix wrong popup location" into sc-dev 2021-07-20 19:06:36 +00:00
Hyunyoung Song 02e5d63fc7 Fix fast scroller issues / remove fast thumb access / fix wrong popup location
(1) Remove jumping to arbitrary fast scroller position
because back gesture can trigger arbitrary fast scrolling
(2) Pop up would show up in random location when user combines
touching the track and scrolling. This was because thumb
location was not updating when user was scrolling on the main
container.

Bug: 193177670
Bug: 191562400

Test: manual
Change-Id: I129aaa37ca911666453a8c98e24eaac33827238f
2021-07-19 23:44:14 -07:00
Brian Isganitis b684c1b59b Revert "Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev"
This reverts commit 7de95d6767, reversing
changes made to 0a70a5a690.

Lints have been added to fix errorprone.

Test: Widgets should adapt to wallpaper colors in launcher preview.
Bug: 192205054
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: I6866f8521ed427d096f27da0a92d8b40e1099187
2021-07-19 21:03:26 -04:00
Jonathan Miranda 7de95d6767 Merge "Revert "Use wallpaper colors for widgets in wallpaper change preview"" into sc-dev 2021-07-20 00:45:57 +00:00
Jonathan Miranda f5fee1a7d3 Revert "Use wallpaper colors for widgets in wallpaper change preview"
Revert "Implement generateColorsOverride from LocalColorExtractor"

Revert submission 15331418-colorcp

Reason for revert: Broke the build
Reverted Changes:
Ife80b07f9:Use wallpaper colors for widgets in wallpaper chan...
I1371eb787:Implement generateColorsOverride from LocalColorEx...

Bug: 194138049

// Using original change's merged-in tag to avoid clashing
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586

Change-Id: I3835dfb8efe745dc0a654712a5b1f68c4946f446
2021-07-20 00:44:42 +00:00
TreeHugger Robot 0a70a5a690 Merge "Remove the shadow under PendingAppWidgetHostView." into sc-dev 2021-07-20 00:25:48 +00:00
TreeHugger Robot 0c1c0daa12 Merge "Remove the shadow under PendingAppWidgetHostView." into sc-v2-dev 2021-07-20 00:24:57 +00:00
Brian Isganitis 6819202b65 Merge "Use wallpaper colors for widgets in wallpaper change preview" into sc-dev 2021-07-19 23:47:56 +00:00
Brian Isganitis 9b3ef3e638 Merge "Use global color extraction in widgets for wallpaper preview" into sc-v2-dev 2021-07-19 22:54:56 +00:00
Pierre Barbier de Reuille a28f864bbf Remove the shadow under PendingAppWidgetHostView.
Fix: 194007734
Test: Manual (see bug)
Change-Id: Ia46dbf8417bb9df17f35b43bfa2698206d940587
2021-07-19 22:21:06 +00:00
Pierre Barbier de Reuille 771c60d36e Remove the shadow under PendingAppWidgetHostView.
Fix: 194007734
Test: Manual (see bug)
Change-Id: Ia46dbf8417bb9df17f35b43bfa2698206d940587
2021-07-19 22:55:49 +01:00
Brian Isganitis 74e6ced362 Use wallpaper colors for widgets in wallpaper change preview
Test: Widgets should adapt to wallpaper colors in launcher preview.
Bug: 192205054
Merged-In: I3fb76b6036cb909771b789eac15742df78c2c742
Merged-In: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
Change-Id: Ife80b07f99da913d65bff96fba2ccd76b0a2ed48
2021-07-19 16:58:20 -04:00
TreeHugger Robot 550e7d8eba Merge "Updating bounce animation to move hotseat instead of all-apps" into sc-dev am: 380afd86ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302019

Change-Id: I103bbbeeff0d5bd4eb16e3cafdf27b4d192d4dd1
2021-07-19 20:19:34 +00:00
TreeHugger Robot 380afd86ab Merge "Updating bounce animation to move hotseat instead of all-apps" into sc-dev 2021-07-19 20:05:44 +00:00
Brian Isganitis 57c8d68001 Use global color extraction in widgets for wallpaper preview
Test: Widgets in wallpaper app should use wallpaper colors
Bug: 192205054
Change-Id: I4da9ad1cc88be251f97e86b6c8c9b346ed20f586
2021-07-19 15:03:27 -04:00
TreeHugger Robot b0ef69e886 Merge "Wait for dismiss animation to finish before checking task count" into sc-v2-dev 2021-07-19 18:39:18 +00:00
Jonathan Miranda 70e8c0b022 Merge "Fix notification dot not always being up to date." into sc-dev am: 8e095ccb05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15302020

Change-Id: I73d52b726f120029edc345a4154e36e734a6ea32
2021-07-19 18:00:49 +00:00
Jonathan Miranda 8e095ccb05 Merge "Fix notification dot not always being up to date." into sc-dev 2021-07-19 17:45:26 +00:00
Alex Chau 97cba26a20 Wait for dismiss animation to finish before checking task count
- See http://b/193440212#comment5, TaskView takes time after swipe gesture to finish dismiss animation, so wait for the animation to finish before checking task count

Bug: 193440212
Test: TaplTestsQuickstep#testOverview
Change-Id: I21397e68f384e956a7c9f2ee8a8161ac784b4d2e
2021-07-19 17:34:57 +01:00
Sunny Goyal f706230a00 Updating bounce animation to move hotseat instead of all-apps
Bug: 193827513
Test: Manual
Change-Id: I86c0e9cb56ab3c6e8e978f574e564fe1e1a41c43
2021-07-19 08:38:47 -07:00
TreeHugger Robot daf4289766 Merge "Fix widget cell container size" into sc-v2-dev 2021-07-19 09:18:44 +00:00
Jon Miranda f8441cc276 Fix notification dot not always being up to date.
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
2021-07-16 17:50:56 -07:00
Alex Chau 0686931b68 Use DeviceProfile.isTwoPanels for two panels expectation in tests
Fix: 193810767
Test: TaplTestsLauncher3.testWorkspace
Change-Id: Ifec5506415b79f3effa84fe0163eb1bb2bc7cc8d
2021-07-16 15:14:34 +00:00
András Klöczl f52f6206dc Merge "Fix two panel accessibility issues" into sc-v2-dev 2021-07-16 12:05:47 +00:00
Steven Ng 4f0f5d732d Fix widget cell container size
This was the same calculation used before http://ag/15177218.

Test: run AddWidgetTest, AddConfigWidgetTest
Bug: 193819550
Change-Id: I1b5e0072a4c05b656de98f8d42667ae99438c005
2021-07-16 12:43:55 +01:00
Steven Ng 4083ae30db Merge "Scale RemoteViews from requestPinAppWidget shown in AddItemActivity" into sc-v2-dev 2021-07-16 09:24:02 +00:00
Andras Kloczl 77b3eb0acb Fix two panel accessibility issues
When two panel home was enabled in Launcher the items on
the left panel weren't able to get selected while on Talkback
because of an incorrect calculation in getScrollProgress.
Also the user was unable to jump to other workspaces by doing
simple one finger swipes because the page jump count was
only 1.

Test: manual
Bug: 174464170
Change-Id: I6cfe39b5059e8e7e7a32c9b0d372c658e796c3e8
2021-07-16 10:39:51 +02:00
Steven Ng 02c75d9897 Fix class cast issue in AddItemActivity am: 671ffb88ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15299573

Change-Id: I393d4540df0b32e644e3d1a963db14564281c03c
2021-07-16 02:04:23 +00:00
TreeHugger Robot f877edb8fc Merge "Fix work profile disable button falsing" into sc-dev am: 753c8b7016
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15286021

Change-Id: I20ea01059f339d8a3dbe1186b7d838fd17faf539
2021-07-16 02:02:54 +00:00
TreeHugger Robot 4aac62110e Merge "Removing support for change listeners from feature flags" into sc-v2-dev 2021-07-16 01:20:32 +00:00
Alex Chau 0eaf4e86a2 Merge "Enable logs on swipe detection in tests" into sc-v2-dev 2021-07-16 00:28:42 +00:00
Sunny Goyal 8cbefe2086 Removing support for change listeners from feature flags
FeatureFlags are supposed to work as static values and change
listeners can cause leaks if not handled properly at every place.

Bug: 193825269
Test: Manual
Change-Id: I54f9113bc01025da781a420154829d80ffa6a084
2021-07-15 15:07:04 -07:00
Alex Chau 46b9a41686 Enable logs on swipe detection in tests
- Enable BaseSwipeDetector log in tests
- Add log for scroll finish and motion pause event

Bug: 193440212
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: Idab566bc615050f73d898459897b66f8b95951b3
2021-07-15 20:45:51 +01:00
Sunny Goyal 711c596c86 Binding Taskbar directly from Launcher model
This allows taskbar to be loaded even in case of 3P Launchers
and removes dependency on LauncherActivity lifecycle

Bug: 187353581
Bug: 188788621
Test: Manual
Change-Id: I5a0988e0697b41677d4c58f0213aef14ec0c0972
2021-07-15 12:43:11 -07:00
Steven Ng 2b123833ad Scale RemoteViews from requestPinAppWidget shown in AddItemActivity
Test: manual
Bug: 193144010

Change-Id: Ia2b64c32f92a43a8d71ee82f164543e1e624814a
2021-07-15 17:59:45 +01:00