Commit Graph

15152 Commits

Author SHA1 Message Date
Treehugger Robot 5df718b3d5 Merge "Fix more kotlin nullable errors in Launcher3" into udc-dev-plus-aosp am: 1a0b25c326
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24593180

Change-Id: I11a4409c09ae3b2a03fdfde2de906123fd39f8b1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-05 21:59:43 +00:00
Saumya Prakash 1a6522f7bf Ensure Gesture Nav Edu animation scales to fit different screen sizes am: 7146fc249f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24642559

Change-Id: I2de39364096864d4d92c8a2a187da4ad5abe1a1b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-05 13:57:34 +00:00
Saumya Prakash 7146fc249f Ensure Gesture Nav Edu animation scales to fit different screen sizes
The lottie animation in the gesture nav tutorial wasn't scaling correctly for certain devices
leading to gaps around the animation. This change uses animation's scale transformation to ensure it fits the
dimensions of the device.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 295809541
Test: Went through the tutorial on different types of devices and ensure
the animation takes up the entire screen.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3ca10a1325f2db21185d6143d310f55056865f05)
Merged-In: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
Change-Id: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
2023-09-01 23:39:16 +00:00
Colin Cross 4aef83aa32 Fix more kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Merged-In: I88aec6fbc814be98f9ef048bbc5af889d0797970
Change-Id: I158db4f57d46606d7152a438d68e2b9f4c0014d9
2023-08-29 23:29:11 +00:00
Bill Yi c9ca8eb4a1 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-08-25 13:37:24 +00:00
Bill Yi e0b64f34df Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I80d5fb34f120c417ac392c40d007bbbe42734afc
2023-08-23 14:34:07 -07:00
Luca Zuccarini e9b6fe7c20 Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-dev am: c0891e5e0d am: ee3c41e5de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24224609

Change-Id: I6a4300a733d1ec3b90d7798af0395b6cdd64e9b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 12:11:44 +00:00
Luca Zuccarini ee3c41e5de Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-dev am: c0891e5e0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24224609

Change-Id: Id2aead02469ee1ffe77fd71d8c731180ff4279c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 11:34:55 +00:00
Luca Zuccarini d70d4050ea Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-dev am: c0891e5e0d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24224609

Change-Id: I0c42611a80d84fc9e817d9357e4c1ddc17caf9cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 11:32:38 +00:00
Luca Zuccarini c0891e5e0d Merge "Animate depth from the right value on Taskbar All Apps launches." into udc-dev 2023-08-21 11:01:10 +00:00
Bill Yi 186f8a6143 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic4049df2074bb4a4c074b12bf0a3e4bf02ec3897
2023-08-15 09:45:44 -07:00
Bill Yi efdbc1a0cf Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9ac6ce68a6a55b1326fcbe1dd90c43beb4df0deb
2023-08-15 09:45:09 -07:00
Colin Cross ae14bc26e2 Fix kotlin nullable errors in Launcher3 am: 4cc251e6c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24406718

Change-Id: Id52bac704d54d31eafda8c8b648a576ab56617c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-14 19:00:56 +00:00
Colin Cross 4cc251e6c1 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
Merged-In: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:29:10 -07:00
Colin Cross 4b5bfb7096 Fix kotlin nullable errors in Launcher3 am: 2608381792
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24392740

Change-Id: Ia6fd37aa0a437da84b5b3108b49f0e9edb95a794
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-11 05:20:53 +00:00
Colin Cross 2608381792 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2
Merged-In: I26edfec35dca14abe90b08e3c74de0446eda95d2
2023-08-10 11:16:17 -07:00
Sunny Goyal adfbec8d4e Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f am: 0b1089978f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: I23624392e6bcde0f97ee4302c75a6e5b7f3fa671
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 21:03:39 +00:00
Sunny Goyal 0c5ddeb3af Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Id507b9d9faf1c209e11fcf7ece9d87119cf9d4f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 20:44:28 +00:00
Sunny Goyal 0b1089978f Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Ibf1f54176e73578fc9cd1cc2510022e3c6a84237
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-04 20:39:57 +00:00
Sunny Goyal 7a080a7e0f Merge "Log appear animation's scale factor" into udc-dev 2023-08-04 20:13:43 +00:00
Bill Yi 39e9688873 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic65ee5796da63c3999571e23307fffec332bebfe
2023-08-03 21:56:20 -07:00
Fengjiang Li 2303acd7d4 Log appear animation's scale factor
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
Merged-In: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
2023-08-03 14:25:00 -07:00
Treehugger Robot 2234a8252d Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-08-03 00:02:58 +00:00
Sunny Goyal 644d85ad0d Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 am: 9e10ffc553
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I9587890282eacc4cb29f626591aefedad9078208
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-02 22:00:22 +00:00
Sunny Goyal 85d1a1cea1 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I7fa7f4ae8e69f8ae07f1b38053d2f738c2e35726
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-02 21:35:37 +00:00
Sunny Goyal 9e10ffc553 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I38c903a70bb637d78403a29a468d6722269553dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-02 21:34:25 +00:00
Bill Yi 22c51bf135 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I289e821ff4b091ffa506a3176f27a884e0c1dde3
2023-08-02 14:18:50 -07:00
Nick Chameyev 2e53f5ef97 [Unfold animation] Do not preemptively start the animation if it has run already
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
(cherry picked from commit 6d756970e7)
2023-08-02 11:41:53 +00:00
Luca Zuccarini 3e91646d12 Animate depth from the right value on Taskbar All Apps launches.
`MyDepthController` in `QuickstepTransitionLauncher` assumes that we
want the background to always animate the same way, matching the rest
state of the workspace (depth == 0). However, in Taskbar All Apps the
background is visible, and depth != 0. We now initialize the one-off
`DepthController` for launches to take into account the latest depth set
by the top level `DepthController`, so there is no jumpcut at the
beginning of the animation.

Note that in my opinion we should use the same `DepthController` for all
cases, rather than having this one-off. I'm looking into the feasibility
of that change, but for now this fixes the issue at hand.

Fix: 292959100
Flag: N/A
Test: manual, see videos in the bug

Change-Id: Id90e8e728cc3e2ccf7d92148fbb0d6ff3e6fd6ca
(cherry picked from commit 627d67549f)
2023-07-27 13:33:21 +00:00
Bill Yi efdab72c00 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I4e2edca61ed43c235d0ad175d9c763f137a1858d
2023-07-26 07:58:46 -07:00
randypfohl 3998e16bba Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 am: d6091ac2d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: I2a4c7683a2aa80c9c151943b8abc3af76b87261d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:04:36 +00:00
randypfohl d6091ac2d7 Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: If35e00543826daa19eefa2045105561817d3c494
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 19:11:58 +00:00
randypfohl b947238a9e Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: Ife4db9cda8ecd85ee21e51575a7bc24c37882ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 19:07:48 +00:00
randypfohl 2b3dc6f730 Removing obsolete call to start home activity with shell transitions
- The second start activity was causing issues with 3p launchers which
  may not expect another new intent (ie. if it handles gestures at
  the bottom of the screen).  We can't completely remove this logic
  because for button navigation we don't want to fall through to the
  launch-next-task animation below, but we can can continue to
  finish the recents animation immediately.
- With shell transitions, leashes for opening apps are always hidden
  by default so when transitioning to a 3p launcher from
  RecentsActivity we also need to show the surface if we want to
  animate it in

Bug: 289609734
Test: Set 3p Launcher as default, in both gesture & button navigation
      - Go from 3p home -> overview, then overview -> 3p home
      - Go from app -> 3p home
      - Go from app -> overview, then overview -> 3p home
      - Quickswitch from app

Change-Id: I6875083931de63a8097d23d180553885ed7cfb01
Signed-off-by: Winson Chung <winsonc@google.com>
2023-07-21 04:20:29 +00:00
Bill Yi 877e7fe5ef Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8ad0866b24b4f2bc66cc943681fbbb54c69485c4
2023-07-20 17:23:58 -07:00
Bill Yi 31855be8d4 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3dc01f06b2302cea0b5435a745e0e96c8a465bea
2023-07-18 11:56:05 -07:00
Bill Yi 112ba79d1b Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-07-14 19:56:06 +00:00
Treehugger Robot 6f59fcc079 Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-d1-dev am: 2a749f1e60
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23877939

Change-Id: I1723336f35a1bc75ef29743c02e8437b6959242d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-14 18:20:13 +00:00
Treehugger Robot 2a749f1e60 Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-d1-dev 2023-07-14 17:49:46 +00:00
Bill Yi 0835d8178d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I30cabeea6af5c4f7469baa1b10051c0f546786ac
2023-07-13 19:56:50 -07:00
Schneider Victor-tulias 5a96798f21 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev am: 3d1e78a496 am: ea547ecb4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23796565

Change-Id: I50091bfa0af884e3990c939af5e576fcab511bc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 19:49:36 +00:00
Schneider Victor-tulias abf59f658c Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev am: 3d1e78a496
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23796565

Change-Id: I65672b6fdd803cd1f7d6ed069b3a254a2c85b8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 19:08:49 +00:00
Schneider Victor-tulias 3d1e78a496 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev 2023-07-10 18:33:25 +00:00
Bill Yi 039df45c67 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-07-08 17:48:12 +00:00
Winson Chung 1108507fcb Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd am: a8e08175ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: Ie3fb097de6ced28d239dc129b10335e0b10448bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 19:59:08 +00:00
Winson Chung 3537a91808 Ignore recents transition if there are no closing tasks am: 6f7e15ff64 am: b06c5f7a2b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: If676c1f88a4bab7299fca8d97a0d33090accb269
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 19:58:56 +00:00
Winson Chung e4b98ea44d Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: Ifc99248dda1a45f3034a80ddca47e8dcc506cd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 19:20:03 +00:00
Winson Chung 38e763613b Ignore recents transition if there are no closing tasks am: 6f7e15ff64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: I25d6e8f6b1cadf1a102980258dd5842f4e7277b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 19:19:53 +00:00
Winson Chung a53261b9cd Merge "Fix an issue with nav bar translations not being updated" into udc-dev 2023-07-07 18:33:16 +00:00
Bill Yi 14d76c5fe6 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1527753aecdfc71c57ef5ba94e62fe7426b1442e
2023-07-06 22:40:58 -07:00