Commit Graph

16682 Commits

Author SHA1 Message Date
Winson Chung 6482c91676 Merge "Reset the static preloaded icon result once launcher is hidden" into udc-dev am: 7cd608594b am: f2433f39eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23697218

Change-Id: I63ea52de92f342eebac6e7b796e4aded305e0a16
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-19 06:45:30 +00:00
Holly Jiuyu Sun d9e0a2836a Merge "[Play] Enable play flag by default on client side for udc-d1-dev." into udc-d1-dev am: a78a22e0c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23680192

Change-Id: Ic5d58714e15ba6926c1c07b25f98c7812fa2c02a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-17 06:05:31 +00:00
Thales Lima abfe364629 Implement calculations of Responsive Grid for AllApps
All Apps follow the same sizes as the workspace, so we copy the measurements to AllApps values.

Bug: 284152932
Test: HomeScreenAllAppsImageTest
Test: DeviceProfileDumpTest
Test: HomeScreenResponsiveAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I12743a6ac5ab5f1a8bc911511bdc7e12b2261d86
2023-06-16 10:19:19 +00:00
Winson Chung f2433f39eb Merge "Reset the static preloaded icon result once launcher is hidden" into udc-dev am: 7cd608594b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23697218

Change-Id: Ia9dc508fb9d9225e01d7bf627032a384e2d9324b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 04:19:57 +00:00
Winson Chung 7c500166b2 Reset the static preloaded icon result once launcher is hidden
- In the case where the system does not play the requested animation
  we can still ensure that this doesn't result in a leak of the
  activity by resetting the result when launcher is hidden (which
  happens after the launch transition)

Bug: 285995223
Test: Presubmit
Test: Take heapdump after repro steps in b/285995223#comment6 and verify
      there are no lingering static icon load results

Change-Id: I1d169df158cfaab64fbe1f4ce597d8f73d86a1c1
2023-06-14 19:39:58 +00:00
Thales Lima 961e683187 Merge "Create AllApps responsive spec" into udc-qpr-dev 2023-06-14 17:09:20 +00:00
Brandon Dayauon 383cc17a6f Merge "Fix custom buttons with translated string" into udc-qpr-dev 2023-06-14 16:13:48 +00:00
Thales Lima 196e44baec Create AllApps responsive spec
Copy the parser from WorkspaceSpec and modify to use AllApps attributes.

Bug: 284152932
Test: AllAppsSpecsTest
Test: CalculatedAllAppsSpecTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I9362e126c64cb1a1abdef61894b003f14701b8e3
2023-06-14 15:02:58 +01:00
Jordan Silva 296a9f3389 Merge "Update SizeSpec attributes to accept max size threshold" into udc-qpr-dev 2023-06-14 09:37:42 +00:00
Sihua Ma d655e07dcc Merge "Fix widget foreground disappearing when swiping back" into udc-qpr-dev 2023-06-14 00:03:34 +00:00
Sebastián Franco 29a13676f4 Merge "Remove flags ENABLE_TWO_PANEL_HOME FOLDABLE_WORKSPACE_REORDE and FOLDABLE_SINGLE_PAGE" into udc-qpr-dev 2023-06-13 23:08:40 +00:00
Holly Sun cd5d9a70b2 [Play] Enable play flag by default on client side for udc-d1-dev.
Bug: 275082654
Test: N/A
Flag: ENABLE_SEARCH_UNINSTALLED_APPS
Change-Id: I22032f99dd0f3b84e34eb3ee5394901d10a4f9f4
2023-06-13 22:55:48 +00:00
Treehugger Robot 74a27fb3de Merge "Making UserCache the source of truth for all user events" into udc-qpr-dev 2023-06-13 21:55:40 +00:00
Jordan Silva 1b336110a4 Update SizeSpec attributes to accept max size threshold
Add maxSize attribute to SizeSpec to limit the cell size up to a max size when matchWorkspace is true. The same validation was added when using fixedSize, ofAvailableSpace and ofRemainderSpace, so they could have a maxSize as a threshold.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: SizeSpecTest
Test: WorkspaceSpecsTest
Change-Id: I113657c241e6618eb3e501243412d8c5626fc3d5
2023-06-13 18:09:37 +01:00
Jordan Silva b1dc7718be Merge "Add FolderSpec for responsive grid support" into udc-qpr-dev 2023-06-13 15:41:49 +00:00
Jordan Silva 7ae9e3a6f5 Add FolderSpec for responsive grid support
Adds responsive grid implementation for folders. It follows the same concept as WorkspaceSpecs, so we have a parser similar to WorkspaceSpecs for FolderSpecs.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: FolderSpecsTest
Test: CalculatedFolderSpecsTest
Change-Id: Iea6d7d88ef42d1273aed7cf2ed5b397035518a52
2023-06-13 15:01:39 +01:00
Thales Lima eb83006b0b Merge "Correct AllApps horizontal padding" into udc-qpr-dev 2023-06-13 11:04:47 +00:00
Sebastian Franco 76a1ceb5f2 Remove flags ENABLE_TWO_PANEL_HOME FOLDABLE_WORKSPACE_REORDE and FOLDABLE_SINGLE_PAGE
Fix: 270392643
Fix: 270395070
Fix: 270395274
Test: atest FoldableItemsIntegrity
Change-Id: I2d7af312da8aeb070588ca94a2a256d2def65eeb
2023-06-12 18:05:22 -07:00
Andy Wickham bd9a180fbc Allow LauncherState to define floating search side margins.
This lets home screen align to workspace icons while All Apps
aligns with those icons. In addition, on tablets where the QSB
is inlined with the hotseat, floating search bar can also move
horizontally accordingly.

Bug: 275635606
Bug: 259619990
Test: Manual on tablet as well as foldable.
Flag: ENABLE_FLOATING_SEARCH_BAR

Change-Id: I67745c66390736cdf39d969ef7767096ae13c671
2023-06-13 00:28:59 +00:00
Andy Wickham 64896f3098 Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
This means adding the search view to the drag layer, so it can
persist and animate across Launcher states (i.e. Home, All Apps,
Overview, Overview from App).

Some high level things:
 - LauncherState now has a flag indicating if the floating
   search bar should be visible, as well as a method indicating
   how high it should rest when the keyboard is not showing. By
   default the height is set negative if the flag is not present,
   so the search bar will rest off screen in that state.
 - LauncherState also has a new method indicating if the search
   bar should show as a pill when not focused. Currently this is
   done in phone portrait mode in all apps and overview.
 - SearchUiManager now has a method for gestures to hint that
   the search bar will be focused or unfocused soon, e.g. for
   the app -> overview case, we hint that it will be focused
   when crossing the threshold, and unfocused if retracting.
   This allows the search bar to animate during the gesture
   and take or release focus after the state change completes.
 - AllAppsTransitionController lets the apps panel translate in
   from the bottom of the screen, for example when coming from
   an app and we don't want to pop it in halfway up the screen.
   Instead it can slide in gracefully from behind the keyboard
   and floating search bar.
 - KeyboardInsetAnimationCallback can now notify listeners of
   keyboard alpha changes during controlled animations. And
   StateAnimationConfig has a new animation type to control
   the keyboard alpha during the all apps transition.
 - This new ANIM_ALL_APPS_KEYBOARD_FADE is used to pop the
   keyboard in at the threshold for going from an app to all apps.
   Note that its position moves linearly before this, so the
   search bar starts moving up accordingly before the keyboard
   alpha is non-0.

Fix: 266761289
Fix: 268845147
Fix: 267683921
Fix: 265849321
Fix: 266446733
Fix: 269301440
Bug: 275635606
Bug: 259619990
Bug: 261866704
Test: Manual with all the state transitions on phone and tablet
(also folding/unfolding foldable).
Flag: ENABLE_FLOATING_SEARCH_BAR, ENABLE_ALL_APPS_FROM_OVERVIEW
(latter just for the background app interpolator changes).

Change-Id: I6f06552e95747348a62260279626cf407bf145b0
2023-06-12 21:55:24 +00:00
Brandon Dayauon 076dcdfd54 Fix custom buttons with translated string
The reason why the buttons aren't being updated with the translated string is because the cache the views get the string from is not updated/loaded with the new language.
Rather, the update happens after the view has been inflated. With this change, when the string cache updates in bindStringCache(), we update the UI right then.

bug: 280958663
test: Manual
Change-Id: I7a49ee401d5a5f3268cfaef1abee8153e913a8ce
2023-06-12 14:33:08 -07:00
Jordan Silva d22a85cd64 Merge "Adding match workspace to SizeSpec for responsive grid support" into udc-qpr-dev 2023-06-09 20:04:54 +00:00
Treehugger Robot d1b3c43d72 Merge "Fix crash on first open of widget picker when changing orientation" into udc-qpr-dev 2023-06-09 18:37:47 +00:00
Jordan Silva 2b8556ce1a Adding match workspace to SizeSpec for responsive grid support
Added matchWorkspace property to support responsive grid implementation for AllApps and Folders. This property indicates whether the attribute value will be used from the workspace instead of defining a fixed value in the AllApps and Folders XML. The class was updated to be a data class and added a auxiliar constructor new make it more flexible for testing and to add other initializers to support AllApps and Folders.

Bug: 284155638
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: WorkspaceSpecsTest
Test: SizeSpecTest
Change-Id: I65b71e66be7b8236a1dee62b56a487b87881d991
2023-06-09 17:05:22 +00:00
Anushree Ganjam ab58a0a005 Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED.
Launcher Search related educards is being sent from AiAi now and we
don't need to hold the count in launcher.

Flag: NA
Bug: 265476821
Test: Manual

Change-Id: I5374e7cab6551d44fc995adb3b3a46173169ab6c
Merged-In: I5374e7cab6551d44fc995adb3b3a46173169ab6c
2023-06-09 13:51:42 +00:00
Anushree Ganjam 66b03a42e0 Merge "Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED." into udc-qpr-dev 2023-06-09 13:50:31 +00:00
Andreas Agvard affa20609b Merge "Added utility function to VibratorWrapper for generating Assist hapic" into udc-qpr-dev 2023-06-09 10:29:17 +00:00
Jon Miranda cc51c84a46 Merge "Update taskbar paddings/sizes to match spec." into udc-dev am: 10b3e64d51 am: b6e38fb23f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23597945

Change-Id: Ib7fa92acf0049fae35b9dbb1c5b2676dc204556a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 01:33:29 +00:00
Jon Miranda 10b3e64d51 Merge "Update taskbar paddings/sizes to match spec." into udc-dev 2023-06-08 23:55:06 +00:00
Andreas Agvard edd9c96e70 Added utility function to VibratorWrapper for generating Assist hapic
Test: Manual

Change-Id: I14c1c4e5a5c1aef54de12524282d21f16c4021c0
2023-06-08 21:40:17 +00:00
Fengjiang Li 9c17c9f046 Merge "Fix NPE where CellLayout is null when removing item out of folder" into udc-dev am: 5d81dd2d77 am: d0642ee589
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23521759

Change-Id: I92674e401f3280237dba0551687ce81f3ff01bd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 19:51:07 +00:00
Fengjiang Li 5d81dd2d77 Merge "Fix NPE where CellLayout is null when removing item out of folder" into udc-dev 2023-06-08 19:33:52 +00:00
Thales Lima 0bd7a37971 Correct AllApps horizontal padding
There was one extra border space being added to handheld, which makes AllApps and Workspace icons to not align.

Fix: 284151671
Test: DeviceProfileDumpTest
Test: HomeScreenAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Test: HomeScreenAllAppsImageTest
Flag: N/A
Change-Id: I6e4a0d93336a3c59db2a25805d90adfaf7a231cf
2023-06-08 12:09:24 +01:00
Pat Manning abe6de475f Merge "Refactor ArrowTipView so it can be customized and used in any drag layer." into udc-qpr-dev 2023-06-08 10:14:54 +00:00
Sunny Goyal c80e60dc7a Making UserCache the source of truth for all user events
Bug: 243688989
Test: Presubmit
Flag: N/A
Change-Id: I0e6b853d965eff1abaeb3b26dd6b94424e5212df
2023-06-07 20:43:36 -07:00
Treehugger Robot fbc0328fec Merge "Log UserManager users and cached users each time users accessed" into udc-dev am: ffdcac46b6 am: 9b0164c832
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23604024

Change-Id: Ib562a0157e0e1914814d83fd56b767d4cd48f2da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 23:27:30 +00:00
Fengjiang Li d29db8ea4d Fix NPE where CellLayout is null when removing item out of folder
Fix: 282249989
Test: create a folder of 2 app icons, remove one icon out of folder, no crash
Change-Id: I3c132ec8833c7cb14066cc403c0641d089bab8ab
2023-06-07 15:36:54 -07:00
Treehugger Robot ffdcac46b6 Merge "Log UserManager users and cached users each time users accessed" into udc-dev 2023-06-07 22:08:03 +00:00
Sunny Goyal cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Vadim Tryshev 544dff52af Merge "Switch ScrimView to use view alpha" into udc-qpr-dev 2023-06-07 21:47:59 +00:00
Sunny Goyal 7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Vinit Nayak 9377e56f47 Log UserManager users and cached users each time users accessed
Bug: 243688989
Change-Id: Ifa6eec39f9fc90a4871ac2ff010588c3a5cac531
2023-06-07 11:32:01 -07:00
Schneider Victor-tulias 19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Jon Miranda 95f4472ba9 Update taskbar paddings/sizes to match spec.
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Anushree Ganjam caf2c0ffb0 Remove SEARCH_ONBOARDING_COUNT & QSB_SEARCH_ONBOARDING_CARD_DISMISSED.
Launcher Search related educards is being sent from AiAi now and we
don't need to hold the count in launcher.

Flag: NA
Bug: 265476821
Test: Manual

Change-Id: I5374e7cab6551d44fc995adb3b3a46173169ab6c
2023-06-06 18:59:06 +00:00
Schneider Victor-tulias ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
TreeHugger Robot ddfb4a982e Merge "Enabled NOTIFY_CRASHES for teamfood" into udc-dev am: ed4695e37e am: 344146970d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23570671

Change-Id: Iaf053f020e0e7ee1dbeece136f80ff2395f0f38f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 18:02:08 +00:00
TreeHugger Robot ed4695e37e Merge "Enabled NOTIFY_CRASHES for teamfood" into udc-dev 2023-06-06 16:29:12 +00:00
Pat Manning 58b6145feb Refactor ArrowTipView so it can be customized and used in any drag layer.
Allows use in TaskbarDragLayer.

Allows customization of properties like text color, background color, and open/close animations.

Bug: 250092437
Test: manual. (Will test with TaplTestsTaskbar in follow up CL when implemented.)
Change-Id: I056395322e5fef7aa4d9fd7e4c2d73c050eff759
2023-06-06 13:46:31 +01:00