Commit Graph

1543 Commits

Author SHA1 Message Date
vadimt d4c90e12e9 Freezing all apps updates during certain tests
This CL adds a very low risk because most (but not all) changes affect
only Launcher behavior during the test.

This should fix a lab-only flake when all apps keeps changing while
the test is working with it.

Example: test figures out which icon to click, by the moment it clicks
there, there is another icon there, or the icon is under the search box,
and clicking opens IME.

Switching test devices to airplane mode didn't help. The earlier change
that prevents popup menu cancellation is not general enough.

Now the tests are given an API to explicitly freeze and unfreeze
all-apps, which should be a final solution.

Bug: 132900132
Bug: 133765434
Change-Id: I8b81cc9be004482beb6cdcdd05406e2d9b4c7629
2019-06-06 11:10:56 -07:00
TreeHugger Robot f36e5e002a Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev 2019-05-31 06:01:25 +00:00
Sunny Goyal e9c6f4cc69 Fixing interactive state for background states and
notifying LauncherCallback accordingly

During quick switch Launcher can get resumed only to be paused again
when launching a new app. Updating the logic for deferred resume to
account for that and moving some additional calls to deferredResume

Bug: 134062513
Change-Id: Ia607f178bc17d45d53fb032a06cd70f9abc6b513
2019-05-30 11:59:29 -07:00
Sunny Goyal da14cf8b9f Disabling seamless rotation in multiwindow mode
Bug: 133765491
Change-Id: If68c709fa5b8216d63fc516f16f03bf2aa83172a
2019-05-30 10:32:11 -07:00
Sunny Goyal c62699fd63 Merge "Removing prediciton loading state" into ub-launcher3-qt-dev 2019-05-24 22:01:09 +00:00
TreeHugger Robot 1d847cf266 Merge "Lock launcher rotation during activity transition to allow proper seamless transition at the end" into ub-launcher3-qt-dev 2019-05-24 18:07:08 +00:00
Sunny Goyal 9820c05f2b Removing prediciton loading state
Also fixing test flakyness due to delayed prediction loading

Bug: 132993129
Bug: 131854153
Change-Id: I85f7afff0e3ee0ca9e40e92e91681f797a0bc2de
2019-05-23 17:01:19 -07:00
Sunny Goyal ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00
vadimt 0c1ed7cb4c Quick patch for PredictionUiStateManager.applyState interrupting allapps
Constructor of PredictionUiStateManager posts an action in 5 sec, which
may interfere with the process of opening all apps.

Waiting until the posted action happens.

Hopefully this will fix massive flakes.

Bug: 131854153
Change-Id: I6544eae1a3b063c03e78185826c05a76add1f71b
2019-05-23 12:36:32 -07:00
Sunny Goyal be8c34077c Lock launcher rotation during activity transition to allow
proper seamless transition at the end

Bug: 131360075
Change-Id: I2b76d4b3e0528e56b7b4709fd3708bc858bf1612
2019-05-22 15:21:56 -07:00
vadimt 3ab80bb734 Enable debug tracing for a lab-only non-starting app from all apps
Bug: 132900132
Change-Id: I9c5bb51e49f865ea1e1d3d2209a8dfb149f66e87
2019-05-22 12:58:35 -07:00
Sunny Goyal dedda05568 Using a proxy activity for startActivityForResult
This ensures that the home task is never blocked by a different task

Bug: 74500048
Change-Id: I01fd26f1d6242e39b2d8fabac5e064b748aebe62
2019-05-15 16:33:06 -07:00
Sunny Goyal 41d51a0a15 Enabling fake rotation by default
Fake rotation is only enabled if homescreen rotation is not enabled

Bug: 131360075
Change-Id: Ie56fc4b46b38d3a599ec6da3d506a971e73b0394
2019-05-15 11:21:34 -07:00
Sunny Goyal 7a39b1bc5f Fixing insets mapping in 3-button and 2-button mode
Bug: 131360075
Change-Id: If6e3a4fbb011fc313efeb91686a9d787761862c5
2019-05-13 10:29:11 -07:00
Sunny Goyal ae6e318711 Initial changes to creating a fake landscape Launcher UI
Workspace and hotseat are drawn in rotated UI giving the impression that the
device is in Portrait, even though it is in landscape

Bug: 131360075
Change-Id: I29c4068af25fd4dcf7039b9a45886e864a137977
2019-05-02 10:59:28 -07:00
Hyunyoung Song 497708c297 Clear should not show after Widget Configuration activity
Bug: 119847865

TL;DR;;
When configuration activity starts, simply make everything in drop
target bar invisible.

Change-Id: I37d067168368de4ee43b54e5dc95f958f5e94623
2019-05-01 16:33:31 -07:00
Hyunyoung Song efe8475093 Merge "Add important dump logging Bug: 130851537 Bug: 119992316" into ub-launcher3-qt-dev 2019-04-25 22:33:31 +00:00
Hyunyoung Song a310a80c7b Add important dump logging
Bug: 130851537
Bug: 119992316

Change-Id: I3de7c1d910d1aecd80b47a85284565c79fe0e2cc
2019-04-25 15:14:44 -07:00
Tony Wickham 03f27013bf Log undo button click
Also fix a bug where we logged workspace swipe upon clicking undo, since
rebinding the pages causes us to reset mCurrentPage = 0 followed by
setCurrentPage(pageBoundFirst). Since the page isn't actually visibly
changing, we shouldn't log in that case.

Bug: 118758133
Change-Id: Ie87164a8c7c278680f67dee75657210bd33408a4
2019-04-25 14:22:54 -07:00
Sunny Goyal 77b3419ad5 Adding support for showing predicted apps as a floating row in all-apps
and overview

Bug: 130053407
Change-Id: Idb93a0ba6cfea8406f75ab86d9e0acde2fc04b3a
2019-04-23 14:26:44 -07:00
Govinda Wasserman c06e151e0f Makes Launcher hide the all apps content and scrim on assistant visible.
This hides the quick search bar and the suggested apps. Visibility is
unchanged when the all apps view is fully expanded.

Test: Tested locally
Change-Id: I6bc453b5ad89ca3d1280957e595bf2a3f074a72d
BUG:129755311
FIX:129755311
(cherry picked from commit 917af755e4)
2019-04-23 17:20:37 +00:00
Sunny Goyal 9589916418 ShortcutInfo renamed to WorkspaceItemInfo
Will get rid of ShortcutInfoCompat in a follow up cl

Change-Id: I7d7d9c938635f59b216290ba28bea9d0e0721a7d
2019-04-16 00:08:24 -07:00
Sunny Goyal d158097cfd Do a full touch dispach when proxying touch
> Workspace can no longer be scrolled when swipin on hotseat

Bug: 130027168
Change-Id: Ie4621e5b7de8d7248227b25fb065249d0c252090
2019-04-09 11:53:41 -07:00
Govinda Wasserman 24e489e5a3 Adds the ability for Launcher3 to respond to QSB alpha change requests.
Test: Tested locally
BUG:124063782
Change-Id: I8c4bfaa62d9608fcfffff5e30b2913f3a6fb2f75
(cherry picked from commit 827f0807d3)
2019-04-03 17:33:55 +00:00
Sunny Goyal 5743f8635b Making navigation mode listener a singleton so that the change is dispatched
everywhere synchronously.

Change-Id: Iee8c5957d78dfad3fb03e814de0367adcaa0c98b
2019-03-29 09:36:45 -07:00
Sunny Goyal 369212aed9 Adding a utility class to listen for app launches
Change-Id: I62e82a6e04b7101773d98c6e7aec574facd053fe
2019-03-26 16:38:58 -07:00
Jon Miranda 7143ba6fec Make QSB_ON_FIRST_SCREEN a boolean.
Bug: 118140522
Change-Id: Ic8e47e71f538b0b0caff6f630566665d05a65522
2019-03-15 09:11:54 -07:00
TreeHugger Robot f820d5d817 Merge "Fixing launcher UI not reapplied properly when IDP changed as a result of display changes" into ub-launcher3-master 2019-03-11 23:07:07 +00:00
Jon Miranda e6f3fa47d6 Fix bug where folder items preview remain in low res state.
- We update the ranks of all folder items after loading, to ensure there are
  no gaps caused by removed folder items. This also ensures that we load
  the high resolution icons for all preview items.
- FolderIconPreviewVerifier#setFolderInfo was not always called
- Init mGridSize with [1, 1] to prevent divide by zero error in case
  setFolderInfo is not called

Bug: 126268196
Change-Id: I856489968665a39303e2922c78cf90f2b3ee6ebb
2019-03-08 12:43:09 -08:00
Sunny Goyal 371ea051d1 Fixing launcher UI not reapplied properly when IDP changed as a result of display changes
> Removing unnecessary check when binding model data as its safe to bind old data,
  we should just not persist it (that check is already there in model writer)
> Adding additional check in model bind to skip old bind if there are multiple binds

Bug: 126259547
Bug: 118441555
Change-Id: Ic250d2af13797d3e70c6e1fc70da65ebe6ab8d70
2019-03-06 15:41:29 -08:00
Sunny Goyal 2db5342f04 Fixing some Launcher crashes because of using old model data even
after launcher has reloaded

Bug: 126289691
Bug: 124288578
Change-Id: Id7fb29716241a13f4e03ee0fc0e879523de4f878
2019-03-05 12:43:50 -08:00
Sunny Goyal bbece869eb Reapply the current state after onCreate
In case of normal restart we were never applying the NORMAL state and
so various state properties didn't start with correct default values.
We generally get insets after start which reapplies the state and
fixes this issue but that is not always the case.

Bug: 126416861
Bug: 118441555
Change-Id: Iaa178556618f8a49197187d0820d8b8afdc73378
2019-03-01 13:16:29 -08:00
Miranda Kephart 1a359a261d Add hints in Overview
If the ENABLE_HINTS_IN_OVERVIEW flag is enabled, pulls chip hint
data (currently from the NavBarHint plugin; eventually from AiAi)
and shows the chips between the task view screenshot and the QSB.

Screenshot: https://screenshot.googleplex.com/Ww05W13XjBv

BUG:124390101

Change-Id: I7686673b705257eca31f2fa40e2744e197153c7c
2019-02-20 15:17:03 -05:00
Sunny Goyal a002c6c19d Removing use of onQuickstep event and determining the touchSlopPassed in Launcher
Bug: 124255113
Change-Id: If6fe77c7086a30775f78ec2a86251cb6bcd3c4c4
2019-02-13 10:25:21 +00:00
Sunny Goyal 202ae0b0f5 Sending notification and widget changes to a listner so that
popups outside Launcher can also listen for changes

Change-Id: I2eb2d8374a6806381e1c682eaef3cc35f30693df
2019-02-11 16:23:11 -08:00
Sunny Goyal aae6fbb903 Moving some utility methods around
Change-Id: I8abca49a0dbf656212b21e0552502036a1619164
2019-01-31 16:07:40 -08:00
Hyunyoung Song c5e0fb94e2 Merge "Icon size should update when grid config changes" into ub-launcher3-master 2019-01-30 19:17:03 +00:00
Hyunyoung Song 31971a3b2d Icon size should update when grid config changes
Bug: 123311886

More context: after IDP changes, DeviceProfile member is never updated
with newly calculated values.

However, all apps is still seriously broken, and I didn't address that
in this CL because jon may be working on it.

Change-Id: I69447a44c30ee467eec52b04bff0dc1afa5696a9
2019-01-30 19:04:11 +00:00
TreeHugger Robot 3663b314fa Merge "Removing diagnostics" into ub-launcher3-master 2019-01-30 18:43:08 +00:00
Sunny Goyal 8c48d8bea6 Changing min sdk to 25
Change-Id: I0d28069967854357ca755bf25dec19d4979bdecf
2019-01-29 11:29:52 -08:00
vadimt 3f8591f003 Removing diagnostics
Now that b/117332845 is fixed

Bug: 117332845
Change-Id: If8c137b9c7cc386dfc5b5af4b81a3efbfa33f770
Tests: None
2019-01-25 10:35:53 -08:00
TreeHugger Robot 95ee747f76 Merge "Adding more events for reproducing race conditions during Launcher start" into ub-launcher3-master 2019-01-23 00:10:40 +00:00
vadimt 13edcc304f Add more diags for b/117332845
Bug: 117332845
Change-Id: I1726e69e8d39e65a39c175f97fe76ef4fa6d5d2b
Tests: No
2019-01-15 13:44:58 -08:00
vadimt cb863750e0 Adding more events for reproducing race conditions during Launcher start
Bug: 120628042
Change-Id: Ifcb6a170e3b227c690eff0255ca3e25cd5d491a5
Tests: StartLauncherViaGestureTests
2019-01-11 18:07:35 -08:00
Tony f80e893163 When undoing a removal, always return to the page it came from
We were already returning to the current page, but this wasn't
always right, e.g. when removing the last item on the last page.
So now we mark the page the item was removed from, and bind that
page first when undo is clicked.

This also addresses an issue where we incorrectly returned to the
first page if currentPage = INVALID_RESTORE_PAGE, which happens if
there are no items on the first page.

Bug: 118846684
Change-Id: I4ec1f64b24ba1cc308ce08bfb3111b5981fae99b
2018-12-21 12:21:53 -08:00
vadimt 00d4255272 Adding tests that would reliably reproduce shifted search.
This would guaranteed to repro b/118441555 before it was fixed.

The test doesn't use the most powerful feature of race condition
reproducer, which is enumerating all possible event sequences.

Instead, it uses explicit repro sequences, which makes the test much
faster.

Bug: 120628042
Test: The added test
Change-Id: I89a7a9964f160a8a20ba3d9dda2f248237713014
2018-12-17 14:41:20 -08:00
Sunny Goyal c5939393a9 Bye bye workspace screens table
Removing a separate table for workspace screens. List of screens are
automatically parsed using the items in the favorites DB. Order of the
screen based on the screen id and rearranging screens is no longer
supported. In case the screens need to be rearranged, all the items
in the favorites db will need to be updated with new screen ids.

This makes backing up the DB (in the same database) easier as only
one table needs to be duplicates.

Change-Id: I8ba947a898f637d780e2f49925e78604263126e8
2018-12-10 11:43:35 -08:00
Tony Wickham 7120490595 Merge "Rename "badges" to "dots" where appropriate" into ub-launcher3-master 2018-12-05 21:19:57 +00:00
Sunny Goyal ef92b82778 Adding support for launcher preview generation
Creating a utility class which generates a launcher preview
for a provided InvariantDeviceProfile

Bug: 118758696
Change-Id: I0aebeb6eed37f72edd1cc305e58eece305aae3ff
2018-12-04 20:19:14 -08:00
Tony Wickham f34bee819c Rename "badges" to "dots" where appropriate
This will reduce confusion with the other "badging" concept we use for,
e.g. work profiles. It is also consistent with the external name
"notification dots".

Change-Id: I2a2c9d96dc0d6284eb0c48adc78a856271caad4d
2018-12-04 10:46:40 -08:00