Commit Graph

10756 Commits

Author SHA1 Message Date
Pinyao Ting 0d97f8d19a Disable Database overwrite upon restore
Launcher overwrites user's favorites table (icons in WorkSpace) upon new
install session from Play Store with install reason being restore. The
overwrite was introduced in the attempt to mitigate failed restore
session due to asynchronous nature of user profile restore, but it has
been causing general instability in backup and restore. Going forward
Launcher should be moving away from table overwrite approach, this will
be implemented in b/148284747.

Bug: 171774227
Test: manual
Change-Id: I91221544dbaeb42224ce9f595906b6d9f0e4aa89
2020-12-05 07:05:12 -08:00
Schneider Victor-tulias f0d79cbac1 Merge "Disable app theme crossfade animation." 2020-12-02 16:02:30 +00:00
Tracy Zhou 620c249929 Merge "Log grid size change" 2020-12-01 16:50:43 +00:00
TreeHugger Robot c3a3805301 Merge "Rename flag to remove reference to blocked word." 2020-11-25 22:13:11 +00:00
Schneider Victor-tulias f6f41535bf Disable app theme crossfade animation.
Pending the resolution of b/172467144, disabling the app theme crossfade animation.

Test: manual
Change-Id: Id18d2022601d7c5d7debb2365d4b65e5fcf6c5a5
2020-11-24 15:03:36 -05:00
TreeHugger Robot 64594c803a Merge "Revert "Add ActivityOptions for SecondDisplayLaucher to launch activity"" 2020-11-23 20:38:50 +00:00
TreeHugger Robot cd0c18460a Merge "fix the issue widget id wasn't being migrated in backup" 2020-11-23 17:49:16 +00:00
Sean Stout beb416cd4f Revert "Add ActivityOptions for SecondDisplayLaucher to launch activity"
This reverts commit 3a8075366c.

Reason for revert: This behavior is no longer needed and was requested to be removed here: b/165931807

Change-Id: I3f16528403fb2e33eba620f8082ac2dcbe9591bf
2020-11-23 16:35:53 +00:00
Pierre Barbier de Reuille c63e16f99e Rename flag to remove reference to blocked word.
Change-Id: I145f5dfb2ba020331a4cae3225a4345a6d10233a
2020-11-23 11:16:25 +00:00
Pinyao Ting 7aaaa35501 fix the issue widget id wasn't being migrated in backup
After SuW the favorite table is copied into backup table, but the widget
id in the backup table hasn't been migrated. This introduces general
unstabality and can sometimes leads to the disappearance of widgets
after a restore.

Bug: 171774227
Test: run Backup Restore flows and verified database status with arbitrary
logging

Change-Id: If275a6b5395504d6de90e26c3998f759e797f6e1
2020-11-20 18:18:52 -08:00
Tracy Zhou 5b468d252f Log grid size change
Test: manually make sure that the correct path is fired
Fixes: 173481818
Change-Id: I7dc2143eb9c0527287398590d46fc2408bc47e44
2020-11-20 17:15:30 -08:00
Samuel Fufa cb6ac3df97 Merge "hide app results if app info can't be found" 2020-11-20 16:29:57 +00:00
Samuel Fufa d41dfd3288 hide app results if app info can't be found
Bug: 173673806
Change-Id: I337912a354ba4374240c4be1c3f2595c4228ec74
2020-11-19 12:55:06 -06:00
John Li ce7f9f2ae1 Haptic effect on alphabetical scroll in Pixel Launcher
Bug: 169397156
Test: manual
Change-Id: Id0c51ac9e9ca7d0f3aaf9b490874de6ee0e97a28
2020-11-18 08:13:25 +00:00
Samuel Fufa 2c86122fa4 Resolve auto close on widget swipe
Bug: 172891360
Test: Manual
Change-Id: Icb384b6dc5ec9a29b6a9a7811b862a2d83ca11a7
(cherry picked from commit 5fa6f3ce503cde51687985ebc9dee6f163b9b1ea)
2020-11-17 18:34:46 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
Schneider Victor-tulias 7bbec50031 Fix AllAppsSearchPlugin icon redrawing without special-casing.
Preventing icon animations in deep shortcuts fixed the icon redrawing issue in the all apps search page, however other icons could still be redrawn, yet could not be special-cased without removing icon update animations altogether. Added logic to only animate icon updates outside of the all apps search page.

Demo: https://drive.google.com/file/d/1ReT2O_1tV20terY0Jr1NJGxIxPblHCK4/view?usp=sharing

Change-Id: Ibe0b43801ec5340c3551125aef13170d569d2c55
2020-11-12 10:31:20 -05:00
TreeHugger Robot c32e39f1db Merge "Fix OutOfBounds issue on getFocusedChild" into ub-launcher3-master 2020-11-11 21:56:54 +00:00
Pinyao Ting af0391f9b2 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
(cherry picked from commit ae1997b9d5)
2020-11-11 19:36:09 +00:00
Samuel Fufa 437513d5ef Federate SliveLiveData for Search results
Instead of every slice result creating its own live data, we should manage a single SliceLiveData per url that SliceViews can observe.

Bug: 173022319
Test: Manual
Change-Id: Ieaf599aadfac40450be4f39657d3cefb70644e0c
2020-11-11 12:48:40 -06:00
Samuel Fufa c25bc0335b Fix OutOfBounds issue on getFocusedChild
In cases where search only shows items that don't require focus highlighting,getFocusedChildIndex returns -1.

Bug: 13023194
Change-Id: I6145ae26e3953c5fc4fd1ed1696eb931017cac0f
2020-11-11 11:31:54 -06:00
Samuel Fufa 9ee4e86cf8 Merge "Search support for widgets with config activity" into ub-launcher3-master 2020-11-11 16:21:01 +00:00
Pinyao Ting ae1997b9d5 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
2020-11-10 16:53:25 -08:00
Hyunyoung Song f62b8a93c0 Merge "IME stability" into ub-launcher3-master 2020-11-10 18:45:00 +00:00
Samuel Fufa ffd2b6d25e Search support for widgets with config activity
Shows widget preview in search if widget requires config.

preview: https://drive.google.com/file/d/1q1ROu7-OUGfskDMRxXPNQMdr3T-WMMkv/view?usp=sharing
Bug: 168321831
Test: Manual
Change-Id: I6c1c168ebac4ce33a4234e8a417eba789f664f43
2020-11-10 10:16:02 -06:00
Hyunyoung Song 90a43a5f00 IME stability
Bug: 170739594

Change-Id: Ib667c6dfb321411d59e728a1f34d4803f7293f05
2020-11-10 00:54:46 -08:00
TreeHugger Robot bbaf9ff6f8 Merge "Fix NPE inside getFocusdChild" into ub-launcher3-master 2020-11-10 07:05:41 +00:00
Hyunyoung Song 3a4caed1f3 Fix NPE inside getFocusdChild
Bug: 172883035
Change-Id: Iea3e07165cdaa45031ee5bbc11add5c115cab366
2020-11-09 22:19:37 -08:00
Samuel Fufa 104463a1e2 Merge "Polish search result icons" into ub-launcher3-master 2020-11-10 03:10:56 +00:00
Samuel Fufa 81de07e405 Polish search result icons
SearchResultIconRow consumes a loaded ItemInfoWithIcon from its child SearchResult and updates other siblings with itemInfo.

preview: https://drive.google.com/file/d/1ijZsR5Q6M0DeZdlRJWpRb4AKmmTLBElY/view?usp=sharing
Change-Id: Ibb3fb697494749fd2e886dcdaa93241767a65944
2020-11-09 19:33:58 -06:00
TreeHugger Robot d7f0ead7e5 Merge "Dismissing popup if the underlying icon no longer supports it" into ub-launcher3-master 2020-11-09 23:41:12 +00:00
TreeHugger Robot 06849da424 Merge "Resolve search scroll hightlight issue" into ub-launcher3-master 2020-11-09 23:30:22 +00:00
Samuel Fufa 3116dc918f Resolve search scroll hightlight issue
After getting the index of the first item that should be highlighted, Section decorator should not assume getChildAt(index) will return item at position. Instead use findViewHolderForAdapterPosition.

Bug: 170665892
Change-Id: Id81d021bde8868184013e8d51e49af7842b64125
2020-11-09 16:35:43 -06:00
Sunny Goyal 1818fb7a6e Dismissing popup if the underlying icon no longer supports it
Bug: 168641545
Change-Id: Ia4f44819af02397efaead935db3fc8e305e47ba7
2020-11-09 14:33:24 -08:00
Samuel Fufa 20d99c5229 Support drag/drop on live widget search results
Preview: https://drive.google.com/file/d/1p0BMoQTaatwcslzPWoD5W_ZWQms5GpSp/view?usp=sharing

Bug: 168321831
Test: Manual
Change-Id: I237546a884083372d5d1ca80f500504b9fd9ba86
2020-11-09 16:16:26 -06:00
Samuel Fufa a204de7d12 Merge "Initial setup for widgets in Search" into ub-launcher3-master 2020-11-09 18:33:51 +00:00
Hyunyoung Song 003859cdd0 Show remote action's description in SearchResultIconRow
Validated against Pixel Tips corpus

Change-Id: I3c3f8eb69007a97e55e2ef08e7f4e0b800bfe247
2020-11-09 01:38:20 -08:00
Samuel Fufa 37432444fc Initial setup for widgets in Search
LiveSearchManager creates AppWidgetHost when user starts a new search session and destroys it when user returns to home. In addition, it also manages the creation and caching of PlaceholderSearchWidget which can be used to create AppWidgetHostViews.
Bug: 168321831
Test: Manual

Change-Id: I06a893028e55aa6e0702a4f1cd7a2edbb1f61671
2020-11-07 10:07:33 -06:00
Samuel Fufa 984e0d0a63 Show settings icon at start of settings results
Bug: 170792963
Test: Manual
Screenshot: https://screenshot.googleplex.com/MVBtDZGtQ3aChwU
Change-Id: I16a28a7bd9e3129b40102e020cd7c0111e6fe29b
2020-11-06 10:14:41 -06:00
thiruram d15915f5fd Fixes invalid ids for UiEvents: LAUNCHER_FOLDER_CONVERTED_TO_ICON, LAUNCHER_HOTSEAT_PREDICTION_PINNED
Bug: 169100235

Change-Id: I1cae4e61b97947c5a7e56daeaccac0ece55f021c
2020-11-06 02:09:34 +00:00
Sunny Goyal ff9e7d6aa9 Removing separate Cancel and End callbacks and using AnimationListener instead
This removes the additional step of invoking these callbacks separately

Change-Id: I0b60047a44f179ba725f15b1e791e336884869c9
2020-11-05 16:35:11 -08:00
Samuel Fufa 171ad424a7 Merge "Consolidate Hero search result with SearchResultIconRow" into ub-launcher3-master 2020-11-05 18:58:06 +00:00
Samuel Fufa 6e5efb0929 Consolidate Hero search result with SearchResultIconRow
With this, we can now show app title and support drag/drop for shortcut results.

Bug: 172245107
preview: https://drive.google.com/file/d/1A4eKKTDPht-MDbfA2VFI3OuAO36fc3AS/view?usp=sharing
Change-Id: Icf94a2d23b44bfe5527aea71e27178906e5deb3e
2020-11-05 11:57:35 -06:00
Tracy Zhou ae567f96f6 Merging from ub-launcher3-master @ build 6952418
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6952418.html

Change-Id: Id8ec665ff7be486b794807f6524e385728ea7717
2020-11-04 12:33:10 -08:00
Tony Wickham 22a5a68464 Fix a couple notificaiton dot issues
Fixes: 172010602 by adding drawDotIfNecessary() back to BubbleTextView
Fixes: 167272638 by overriding drawDotIfNecessary() to do nothing in
DeepShortcutTextView

Change-Id: I0bfbbc6e27dedac73ae97c5a084412ce1aba11e4
2020-11-02 17:04:58 -08:00
TreeHugger Robot a1733bceb7 Merge "fix the issue widget id can be wrong after restore" into ub-launcher3-master 2020-10-29 17:30:35 +00:00
TreeHugger Robot 90faddeff3 Merge "Quick fix from ag/12914139" into ub-launcher3-master 2020-10-29 06:38:13 +00:00
Tracy Zhou 991e8208cc Quick fix from ag/12914139
Test: N/A
Change-Id: I0b8274f8a912d091cfbbebafdee220b5e46ee74f
2020-10-28 22:34:23 -07:00
Pinyao Ting f39f351a0d fix the issue widget id can be wrong after restore
Bug: 171774227
Test: manual testing
1. randomly add/remove widgets to workspace
2. create a backup (Settings > System > Backup)
3. reset the device
4. restore from the backup
5. verify all of the widgets are restored properly

Change-Id: Id65e474dd9349aca715d7e6b88f8d58bc63066ae
2020-10-28 22:04:35 -07:00
TreeHugger Robot a90ddeea57 Merge "Settings/Play/Suggest layout polish" into ub-launcher3-master 2020-10-28 22:12:52 +00:00