Fix the root cause of falling tests.
Bug: 359277238
Flag: TEST_ONLY
Test: TaplTestsQuickstep,TaplTestPersistentTaskbar
Change-Id: I1e3138e26d0ab253dff7a64cbb3253c220a7db1a
Reuse the same UiObject2/HomeAppIcon objects
when capturing Launcher icon positions.
When invoking 'launcher.workspace.allWorkspaceIcons'
we wait for the animation to finish which makes
the test fail as we expect to capture icon positions
midway through the animation.
Test: atest LauncherFoldAnimationTest
Bug: 315163608
Bug: 296991492
Flag: EXEMPT bugfix
Change-Id: I668d15165e4c777b3be24d66ad3f7888eaca2fea
1. Announce description of both snapshot in GroupedTaskView.
2. Announce them in correct order.
After setting right content description for both the apps in split mode, announcement order was reverse. Seems that order of the node tree which android sees was wrong. Also order did not change even in RTL mode.
see here https://paste.googleplex.com/6492038621298688.
The correct order is manually set using addChildrenForAccessibility in GroupedTaskView. (similarly being used in RecentsView since we use reverse order for overview). Also considered RTL.
See order after fix here
https://paste.googleplex.com/6492038621298688https://drive.google.com/file/d/1BA1YKkcNsovEu4us9cvq5xOdXviTR1OV/view?usp=drive_link
Other alternatives tried were fixing order using android:accessibilityTraversalAfter and android:accessibilityTraversalBefore, both in layout and programatically which doesn't seem to work.
Test: Manual - Using Node tree debugging of talkback developer options.(Print and filter by tag TreeDebug)
BUG: 330424779
Flag: EXEMPT bugfix
Change-Id: If3c360277bd951d2d2b223bab7844e078e9c7d27
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size
Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
Code changes:
- TaskView, GroupedTaskView and DesktopTaskView now uses different resId, so it can be differentiated by TAPL
- Extracted result handling of icon loading, so we can override in DesktopTaskView
- DesktopTaskView now load icons, so titleDescription can be loaded. When icons are loaded, contentDescription are applied to respective snapshotViews; icon unloading is ignored
- Track launchDesktopFromRecents and composeRecentsLaunchAnimator in TAPL events so we can test if the TaskView launch path is correct
Test changes:
- Added TaplTestsOverviewDesktop that move 2 TestActivities into Desktop, and launch the DesktopTaskView as static and live tile
- TaplTestsOverviewDesktop is limited to Tangor/cf_tablet only, and added LimitDeviceRule to AbstractLauncherUiTest to enable @AllowedDevices and @IgnoreLimit
TAPL changes (2 APIs added/modified):
- Changed TaskView matcher to use id/task_view_* to match all TaskView types
- When Overview is launcehd from Background, mark the currentTask after the launch as liveTile. When an OverviewTask has the same accessibility node as the liveTile, it'll expect different event when launching.
- [API change] BaseOverview.getTestActivityTask can now matches mutiple test activiites, useful for matching GroupedTaskView and DesktopTaskView; Fix a bug that getTestActivityTask wrongly use `getParent()` which is RecentsView to match activityName.
- In OverviewTask.open, we'll expect different events based on TaskView types and whether it's a live tile. Launching DesktopTaskView will in additional verify Desktop header is present on screen.
- [API change] In OverviewTaskMenu, support tapping Desktop menu and verify Desktop header is present on screen.
- Removed unused OverviewTaskMenuItem
Fix: 320313527
Test: TaplTestsOverviewDesktop
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I89261c787364901320f3acb18f01ddad5f62d17c
This cl addresses
- removing of getWorkspaceIconsPositions()
- addition of getWorkspaceIconPosition()
getWorkspaceIconsPositions() was not reliable as it was getting any icon selector and not actually waiting for the icon of intereset.
now we wait for specific icon of interest and tests are change accordingly.
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ia65b9d51520763a7fbbb8d5cd3bc129496e443cc
NexusTestInformationHandler only relied on one boolean switch that is not currently used so I am deleting it.
Bug: 353303621
Test: TAPL
Flag: TEST_ONLY
Change-Id: I6181d47561b318d1eb1bd632d4ae042e126cfdb9
We should ignore KeyEvents with the FLAG_CANCELED flag in log analysis for Launcher tests as these KeyEvents should not have any effect.
Bug: 346943119
Flag: com.android.window.flags.predictive_back_system_anims
Test: atest BackNavigationTests
Test: atest OnBackInvokedCallbackGestureTest
Test: Manual, i.e. verifying in a test app that onUserInteraction is called when pressing back key in 3-button-nav and when enableOnBackInvokedCallback=true
Change-Id: Icff47009757c49cdd8998244dd3e9459cc6ee085
Verify the text after it's collected. I ran the test 20 times and
couldn't find the stale object exception being thrown.
Bug: 340341450
Bug: 339737008
Test: Manual
Flag: com.google.android.apps.nexuslauncher.enable_inject_private_space_tile
Change-Id: Ib153205db36cdd8b5fba4734b8b68930857659ff
Attempts to fix a flaky test by ensuring that recents is always cleared before creating a split pair (so the split pair under test is always the same).
Bug: 340935208
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair(), testSplitTaskTapBothIconMenus()
Flag: TEST_ONLY
Change-Id: Ibc81b90fac531f0e78e93a494ff59073ab5e52cf
Currently we have logic to only enable input monitor when a trackpad is connected. Tapl tests need to have infrastructure to override that logic
Bug: 335146977
Test: presubmit
Change-Id: Ib7f80c828760f8b5abd7ed2788b246e47fca6e34
They hide actual sequences, are not necessary for Tigers who are power users and require maintenance.
Bug: 187761685
Test: presubmit
Flag: NONE for test
Change-Id: I5d4b3d80a916845fcf8c08a0ecd135527466fa5a
Attempt to improve jank and memory regressions by simplifying the view layout of OverviewActionsView.
Bug: 339688091
Bug: 339853741
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair()
Flag: EXEMPT bugfix
Change-Id: Ib4a7c5a813b221c0a083144e7fb1e1c5f3fedb1c
The goHome gesture is slow enough sometimes that it gets confused with an overview gesture. Reducing the step count should resolve this (verified in atest and haven't had it fail after changing this)
Flag: NONE
Bug: 336606166
Test: TaplTestsTrackpad#switchToOverview
Change-Id: I7ad388968205addb363cfd9ff4b7eefece170d1b
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).
This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.
Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
In this test:
1. Private Space is created.
2. Lock Button is clicked, locked view is verified.
3. Unlock Button is clicked, unlocked view is verified.
4. Private Space is removed.
Doc: go/private-space-tapl
Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I1c399a96ea14a4464113576d31eed8db1caf1f2a
Not waiting for FailureWatcher to catch the exception and save
artifacts. This will help to save test artifacts before potential
deinitialization in the test which may change the screen contents.
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I7aa95028acfae3fe0895fc5df4ea6f6912fcda52
This will help us catch and debug following issues
* Prediction row view is missing
* Prediction row view doesn't contain enough apps
Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I11035997afb26799a2c3b69d5139b4f3c28fc405
This test verifies that a user installed app
is shown above the sys apps divider, within the
Private Space container.
Bug: 322882655
Test: atest NexusLauncherTests:com.android.quickstep.TaplPrivateSpaceTest
Flag: NA
Change-Id: Id85105339ae45c263d9ef52a3bb55784587e887d
This reverts commit 503ce966ef.
Reason for revert: Culprit for test breakages in b/334995023. Will be verifying through ABTD for confirmation and before submitting the revert.
Change-Id: Id8707cb2074b4f00ec332ebb14deb7d143ff1bbb
This reverts commit b80c6c347a.
Reason for revert: The original change was not the cause for the test failures
Change-Id: Icfe0da43a96f5471076554c4dd25eae649bee81e
This reverts commit f8f00f4233.
Reason for revert: DroidMonitor: Potential culprit for http://b/334162623. verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: Id165df41a87af4757abd3266b8643949ce012a08
Mykola Podolian
Nick Chameyev
vinayjoglekar
Alex Chau
Treehugger Robot
Schneider Victor-tulias
Tracy Zhou
Johannes Gallmann
Andrew Cole
Winson Chung
Jagrut Desai
Anushree Ganjam
Jeremy Sim
Vadim Tryshev
Holly Sun
Federico Baron
Himanshu Gupta
Priyanka Advani
Liana Kazanova