Commit Graph

826 Commits

Author SHA1 Message Date
Sunny Goyal 0cd2a254b2 Reset state amanger, when switching from state animation to task launch animation
A pending task launch animation can set some transient properties on state manager.
If the next animation is not a state animation, and reapply is not called, the
transient properties are never cleared

Bug: 79935289
Change-Id: I18398c74692960c460af537bf0c48801e69ac11e
2018-06-06 11:45:00 -07:00
Winson Chung 48412ca2c9 Merge "Fixing task window is not getting alpha set properly when long-swiping" into ub-launcher3-edmonton 2018-06-06 01:00:55 +00:00
Sunny Goyal d01a28758d Fixing task window is not getting alpha set properly when long-swiping
We were setting the alpha of the target window to 0 on the UI thread, and setting it
back to 1, through ClipAnimationHelper on background thread

Bug:109701914
Change-Id: I4abb73298b5e957a66f91c5654b184cdd398724b
2018-06-05 17:24:06 -07:00
Winson Chung 7938e9fbc6 Merge "Log source component instead of current task base intent" into ub-launcher3-edmonton 2018-06-06 00:20:32 +00:00
TreeHugger Robot af19ffff62 Merge "Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions" into ub-launcher3-edmonton 2018-06-05 23:57:08 +00:00
Sunny Goyal 1c63c72c1a Adding a pending invisibility flag, which is used to indicate that the launcher
is not really invisible, but consider it invisible for window transitions

When a recents animation is cancelled, the callback can be received before or after the
wallpaper animation. To ensure that wallpaper animaiton runs properly, we keep the launcher
forceInvisible=true, only for that particular animaiton and false everywhere

Bug: 109735443
Change-Id: I5b22cc3327c8cd53a836d10e09fc88ae103becfc
2018-06-05 16:47:54 -07:00
Winson Chung 3cc3df59af Log source component instead of current task base intent
- Report original launch source component to ensure app relaunches can be
  associated with the same app for predictions.

Bug: 109698096
Bug: 109675704
Change-Id: Icc5e95560777ad827fd2430cf3b3b052b65eb1b6
2018-06-05 21:09:32 +00:00
Tony Wickham 406aefce10 Merge "Use getLocationOnScreen() to determine home bounds" into ub-launcher3-edmonton 2018-06-05 17:25:35 +00:00
Sunny Goyal d936f6a5e9 Do not change state in the middle of quickstep gesture
Changing states causing quickscrub to get cancelled and recentsView to
get reset to page 0, causing an abrupt jump.

Bug: 80537625
Bug: 80497058
Change-Id: I19cfe4380bbff15734b9d90dc31596904da27483
2018-06-05 10:12:23 -07:00
Tony Wickham 678be9b823 Use getLocationOnScreen() to determine home bounds
This correctly accounts for device cutouts in landscape.

Bug: 76220728
Change-Id: I34f022d92957caeffae49b21a89acaf13e188076
2018-06-05 08:36:44 -07:00
Sunny Goyal 87168ca1f7 Skip logging if device profile is not initialized
Since recentsAnimation and animationCancel come on the event queue, we may skip
recentsAnimation and only process animationCancel if they happen too close to
each other, before the first event is scheduled on eventQueue.
As a result deviceProfile is never initialized.
Prevent crash by skipping logging in this case, we shouldn't be logging it anyway

Bug: 80515833
Change-Id: Ife1d6009bcdc34af6c281d848665145cd235fa40
2018-06-01 12:54:10 -07:00
Jorim Jaggi c1ee70bf3d Merge changes from topics "am-d455296f-ca9f-4a88-999f-65e8ba3f6b8a", "am-6ed11203-0b52-4aea-b304-3f471c0aa3bf" into ub-launcher3-edmonton
* changes:
  Use SyncRtSurfaceTransactionApplier for recents enter/exit
  Use SyncRtSurfaceTransactionApplier for app opening
2018-06-01 12:27:04 +00:00
TreeHugger Robot f4392dbf5a Merge "Some launcher3 fixes so that it compiles with different configurations" into ub-launcher3-edmonton 2018-05-31 16:42:56 +00:00
Sunny Goyal d0f43ceba7 Some launcher3 fixes so that it compiles with different configurations
Bug: 79996542
Change-Id: I4267aeb8f5b0714415970c63453049ff41466644
2018-05-30 18:15:21 -07:00
TreeHugger Robot c86805f433 Merge "Theme updates for dark text:" into ub-launcher3-edmonton 2018-05-30 23:06:26 +00:00
Sunny Goyal 337fcb7983 Theme updates for dark text:
> Using white scrim on adjescent tiles in overview
> Using a ligher scrim in dark-theme+dark-text

Bug: 80253867
Change-Id: I3f257d3addaca8bc5970a61722f5ae0e7af89382
2018-05-30 15:53:10 -07:00
Tony 2f347149af Shift recents up slightly in quick scrub
Bug: 79883290
Change-Id: If57fd52505d7f965ea8a28e90e715c5723915e57
2018-05-30 14:28:20 -07:00
Vadim Tryshev 442fc108c3 Removing accessibility action for Clear-all
Now that Clear-all button is visible for accessibility, there is no need
in it.

Bug: 80156299
Test: Manual
Change-Id: I5997692be015947692a8bb720a449d1d36302526
2018-05-29 17:34:19 -07:00
Sunny Goyal ab66067def Update displacement on ACTION_UP as well, in case ACTION_UP and came in a different frame
than last ACTION_MOVE

Bug: 80292740
Change-Id: Ie75ac3ebb74024073965a7455a6503e8ed3f6d99
2018-05-29 15:54:59 -07:00
TreeHugger Robot ad85852cc0 Merge "Accounting for one frame jump when starting a fling animation" into ub-launcher3-edmonton 2018-05-29 22:07:55 +00:00
TreeHugger Robot 688701317a Merge "Enable accessibility of Clear All button." into ub-launcher3-edmonton 2018-05-29 20:48:47 +00:00
Sunny Goyal 9c3f172d9c Accounting for one frame jump when starting a fling animation
Bug: 80292740
Change-Id: I47bca071d42d1d217068c128f9793e87210d0286
2018-05-29 13:38:57 -07:00
Sunny Goyal 9bb8ffb5e3 Various quickscrub fixes
> Fixing PagedView resetting the currentPage, if scrollToPage was called before first layout
  This causes quickscrub to jump back to the current task if launcher activity was dead.
> Fixing missing callbacks in DeferredTouchConsumer causing missed quick scrub flings
> Sending the resents animation callbacks on the motion queue thread, to avoid synchronization
  issues with sysui callbacks.
> Waiting until the recents animation is received before starting the scale down animation
> Calculating the offset for quickscrub statically incase launcher activity was dead

Bug: 80214390
Change-Id: I1b7d00b7b266655a92fcd6239f25ba191655150f
2018-05-29 12:17:20 -07:00
Vadim Tryshev a3e48d8035 Enable accessibility of Clear All button.
The button appears in the accessibility hierarchy
as a child of RecentsView.

This makes both Talkback and Switch access
to work with it normally.

Bug: 80156299
Test: Manual

Change-Id: Ife2044b2ef78fb27b32f2d33fb17744662a2b054
2018-05-29 18:51:57 +00:00
Jorim Jaggi 87356e7b48 Merge "Fix binder call for app opening" into ub-launcher3-edmonton 2018-05-29 17:40:56 +00:00
Jorim Jaggi 80b9314781 Use SyncRtSurfaceTransactionApplier for recents enter/exit
To ensure proper synchronization, fixing jank.

Furthermore, we need to move the background choreographer to
vsync-sf pulse in order to allow for a smooth transition
background -> foreground when handling the touch.

Test: Swipe up, disable swipe, press recents to enter/exit
Bug: 80292740
Change-Id: Ie58616edf6432a0154d6dbf8497218721154d2b8
2018-05-29 15:50:14 +02:00
Jorim Jaggi 1008f6d72e Use SyncRtSurfaceTransactionApplier for app opening
To ensure 100% synchronization, fixing jank.

Test: Open and close apps
Bug: 78611607
Change-Id: I6843e88ab1de0b8e7d80e6a6f547b895b527d093
2018-05-28 18:10:47 +02:00
Jorim Jaggi 1d1a3d7242 Fix binder call for app opening
Needs to acquire the AM/WM lock, which may cause jank during
the animation.

Test: Open app, observe no binder calls.
Bug: 78611607
Change-Id: I3459383c9597801405dd9c688837a2bffeeb7f9e
2018-05-28 18:08:40 +02:00
Vadim Tryshev 5c17a390d2 Merge "Reporting range of visible tasks" into ub-launcher3-edmonton 2018-05-25 19:55:39 +00:00
Winson Chung 30d2fc748d Merge "Tweaking quickscrub launch animation for new task sizes." into ub-launcher3-edmonton 2018-05-25 19:54:24 +00:00
Vadim Tryshev 528b9e0615 Reporting range of visible tasks
Also fixes task position being incorrectly reported specifically for
swipe events due to using stale getCurrentPage().

Bug: 72222505
Test: Manual
Change-Id: Ic79b67f8a6ffbfabc397b411b14afc309405197e
2018-05-25 12:24:40 -07:00
Sunny Goyal 4308bd232e Merge "Fixing launcher going to a different state when dragging an icon from different activity" into ub-launcher3-edmonton 2018-05-25 19:17:28 +00:00
Sunny Goyal 4dcda06542 Fixing launcher going to a different state when dragging an icon from different activity
Bug: 80191074
Change-Id: I45ea646dc2bd21627e8b724dac9c9fc23c18797d
2018-05-25 11:56:53 -07:00
Sunny Goyal 271dc919d0 Merge "Cancelling quickscrub state incease we missed quickscrub end event" into ub-launcher3-edmonton 2018-05-25 18:40:16 +00:00
Winson Chung 35cde20a17 Tweaking quickscrub launch animation for new task sizes.
Bug: 79945202
Change-Id: Ibe1e53d45bc3fda325cebc14aa6a61f61f08edb0
2018-05-25 10:58:17 -07:00
Hyunyoung Song de184a243d Add logging for selected text and split screen
Bug: 79787082

action:LONGPRESS
  Source child:TASK_PREVIEW

action:TAP
  Source child:SPLIT_SCREEN_TARGET


Change-Id: Ica5a3955f092c6678e646b6df76567cdfa3485df
2018-05-25 10:53:39 -07:00
Tony Wickham 5d6282fcf3 Merge "Use correct interpolator for recents scale when quick scrubbing" into ub-launcher3-edmonton 2018-05-25 17:11:23 +00:00
Tony Wickham 4ff7d8e7b3 Use correct interpolator for recents scale when quick scrubbing
Use same interpolator for scale and translationY so that they feel more
coordinated. (They were already the same in all cases except when
scrubbing when already in overview, which never had a scale component
before.)

Bug: 80139193
Change-Id: Id143b5cc9279d55aaa1b0444db5fe4b41ce92170
2018-05-24 22:48:46 -07:00
Winson Chung f13015d76a Merge "Fix recents task view launch animation unclipping issue." into ub-launcher3-edmonton 2018-05-24 22:38:59 +00:00
Winson Chung af41ea2ac5 Fix recents task view launch animation unclipping issue.
- Don't apply the scale to app window crop (which should be in app window
  space)

Bug: 79945202
Change-Id: I68862f7f7d69eab64570ab3b1e3996a2e9a9e2ba
2018-05-24 15:10:50 -07:00
TreeHugger Robot 96bc904ded Merge "Fixing keyboard navigation when Overview list is empty" into ub-launcher3-edmonton 2018-05-24 20:16:45 +00:00
Vadim Tryshev 1b0c5032d1 Fixing keyboard navigation when Overview list is empty
Bug: 80155387
Change-Id: Ife86fe4b718ef01291a04b21020155110d75fa7b
Testing: Manual
2018-05-24 13:06:18 -07:00
TreeHugger Robot db28a992a9 Merge "Wait until the remote transtions are received before trying to quickscrub animations" into ub-launcher3-edmonton 2018-05-24 19:46:39 +00:00
Sunny Goyal 0fb1e4b5a7 Cancelling quickscrub state incease we missed quickscrub end event
> This can happen when the remote transition is cancelled while animating down
during quickscrub, cause WindowTransformSwipeHandler to get invalidated
and miss onQuickscrubEnd

Bug: 80140388
Change-Id: I0221e301d4d633bab0defaa6af76e0054776a95a
2018-05-24 12:19:50 -07:00
TreeHugger Robot e8532d84a9 Merge "Calculate the scale up for quickscrub based on the available size of the screen" into ub-launcher3-edmonton 2018-05-24 18:33:01 +00:00
Sunny Goyal 6ec237a260 Wait until the remote transtions are received before trying to quickscrub animations
Bug: 80219743
Change-Id: Ib94568827f30b996477d82f38675e3cd55031849
2018-05-24 11:24:22 -07:00
Sunny Goyal ccd90231e6 Calculate the scale up for quickscrub based on the available size of the screen
Bug: 80139193
Change-Id: I0492ce5bfa347bad12a09a13e404ded77e797623
2018-05-24 11:16:05 -07:00
Winson Chung fb6721da45 Merge "Initial changes to support full-width quickscrubbing." into ub-launcher3-edmonton 2018-05-24 02:24:36 +00:00
Winson Chung ededa9cce2 Initial changes to support full-width quickscrubbing.
Bug: 79945202
Change-Id: Ida8443432faafc74fbdc0a7dae87f0cf8c8ce648
2018-05-23 18:30:06 -07:00
Vadim Tryshev d5ccb6978d Reverting task order reported via accessibility.
Now tasks go in the natural left-to-right direction.

Bug: 72222505
Test: Manual
Change-Id: I9e90d0eaaaa3ca0a73b2fe6d20e82689c2b2f376
2018-05-23 18:01:50 -07:00