Commit Graph

12718 Commits

Author SHA1 Message Date
Sunny Goyal d6692cedff Revert "Set mState = mCurrentStableState in onAnimationCancel"
This reverts commit 8935d9515c.

Reason for revert:
Bug: 109814458
Bug: 79935289

Change-Id: I33e4933a68060b6055ad7af8e45cffceec14880d
2018-06-06 18:47:59 +00:00
Winson Chung d455b9b2ec Merge changes from topic "am-5d68cedc-e069-4434-917c-921eeb6efcf3" into ub-launcher3-master
* changes:
  [automerger] Hides the keyboard when qsb loses focus in All apps am: 25b4dfee29
  Hides the keyboard when qsb loses focus in All apps
2018-06-06 00:17:41 +00:00
Winson Chung 0abc19ae0d Merge "Hides the keyboard when qsb loses focus in All apps" into ub-launcher3-edmonton-polish 2018-06-06 00:17:41 +00:00
TreeHugger Robot af19ffff62 Merge "Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions" into ub-launcher3-edmonton 2018-06-05 23:57:08 +00:00
TreeHugger Robot 8e84f42f64 Merge changes from topic "am-6756c3c9-4e27-48e1-8ae4-b6d5cdd77952" into ub-launcher3-master
* changes:
  [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a am: 7ef92daaf5
  [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a
  Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions
2018-06-05 23:57:08 +00:00
TreeHugger Robot eb424209ff Merge changes from topic "am-6756c3c9-4e27-48e1-8ae4-b6d5cdd77952" into ub-launcher3-edmonton-polish
* changes:
  [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a
  Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions
2018-06-05 23:57:08 +00:00
TreeHugger Robot 25c7e81ee5 Merge "Fix wrong labeling of app launch session type (HOME vs OVERVIEW)" into ub-launcher3-edmonton-polish 2018-06-05 23:55:46 +00:00
Android Build Merger (Role) fd662397b3 [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a am: 7ef92daaf5
Change-Id: Ia98e9e536debd114efe95d545639b48c081e558c
2018-06-05 23:48:02 +00:00
Android Build Merger (Role) 7ef92daaf5 [automerger] Adding a pending invisibility flag, which is used to indicate that the launcher is not really invisible, but consider it invisible for window transitions am: 1c63c72c1a
Change-Id: Ic88f7803c9a938f20f002f7d8eaf8df33e0f578f
2018-06-05 23:48:01 +00:00
Sunny Goyal 1c63c72c1a Adding a pending invisibility flag, which is used to indicate that the launcher
is not really invisible, but consider it invisible for window transitions

When a recents animation is cancelled, the callback can be received before or after the
wallpaper animation. To ensure that wallpaper animaiton runs properly, we keep the launcher
forceInvisible=true, only for that particular animaiton and false everywhere

Bug: 109735443
Change-Id: I5b22cc3327c8cd53a836d10e09fc88ae103becfc
2018-06-05 16:47:54 -07:00
Android Build Merger (Role) 16cd2a8456 [automerger] Fix wrong labeling of app launch session type (HOME vs OVERVIEW) am: 4bd472550c
Change-Id: I6afc740fca72d6aa261759765bdcf75997171fc9
2018-06-05 23:46:34 +00:00
Hyunyoung Song 4bd472550c Fix wrong labeling of app launch session type (HOME vs OVERVIEW)
Context: onResetOverview callback should be called the moment launcher state
exits from OVERVIEW.
More context: When user drag and drop from overview, and happens to launch
an app immediately after dropping the icon before animation finishes,
that app launch is labeled as OVERVIEW and not HOME.

Bug: 109747805
Change-Id: I24dc8681d6c51dfd2043fe71a1a81d6e96027ef4
2018-06-05 16:45:27 -07:00
Android Build Merger (Role) b47aa5d0d1 [automerger] Hides the keyboard when qsb loses focus in All apps am: 25b4dfee29
Change-Id: I27a5d03b26345596918aca62a89e78255bef4c9c
2018-06-05 23:23:19 +00:00
Mehdi Alizadeh 25b4dfee29 Hides the keyboard when qsb loses focus in All apps
Bug: 80190879
Change-Id: I88da6ef7a88b9dd4fce06e4f2b4592ee6ce39195
2018-06-05 16:22:35 -07:00
Android Build Merger (Role) bf3ac479a4 [automerger] Fixing controller state is not properly cleared when the animaiton is cancelled. am: 87a6ad18cd am: b72f69d073
Change-Id: I96d04e27788f1233c951421edccfbf00e3b3a35b
2018-06-05 23:07:43 +00:00
Android Build Merger (Role) b72f69d073 [automerger] Fixing controller state is not properly cleared when the animaiton is cancelled. am: 87a6ad18cd
Change-Id: If50ce87da192ed0339d5b9faa1983bfc4174b647
2018-06-05 23:07:41 +00:00
Sunny Goyal 87a6ad18cd Fixing controller state is not properly cleared when the animaiton is cancelled.
This was leading to a pending animation running while the state had changes,
leaving user in an inconsistent state.

Various atomic animation fixes
> Ensuring that there is only one success listener on atomic animation, so that atomic
  controller is created only once and to the final mToState
> If atomic controller is already running, skip animating the atomic conmonenets as
  part of main animaiton
> Cancel atomic controller if it is going to a different state

Bug: 80549582
Bug: 109583168
Change-Id: Ie7a032e0fa73b1f1c2ef53055c08d16444f0385e
2018-06-05 16:07:29 -07:00
Android Build Merger (Role) 4826463555 [automerger] Do not change state in the middle of quickstep gesture am: d936f6a5e9 am: 7c8ffd1d3b
Change-Id: Iabd6fef0416f0672854ff352b13dffb870792bc1
2018-06-05 17:12:32 +00:00
Android Build Merger (Role) 7c8ffd1d3b [automerger] Do not change state in the middle of quickstep gesture am: d936f6a5e9
Change-Id: I6297797bb034ad8bd2600c8abb5a959ee0e6aa32
2018-06-05 17:12:30 +00:00
Sunny Goyal d936f6a5e9 Do not change state in the middle of quickstep gesture
Changing states causing quickscrub to get cancelled and recentsView to
get reset to page 0, causing an abrupt jump.

Bug: 80537625
Bug: 80497058
Change-Id: I19cfe4380bbff15734b9d90dc31596904da27483
2018-06-05 10:12:23 -07:00
TreeHugger Robot 6e680f9bf6 Merge "Deleting invalid icons when an app is restored" into ub-launcher3-edmonton-polish 2018-06-04 23:54:10 +00:00
TreeHugger Robot 1c9a61ad6a Merge changes from topic "am-ba267b72-28d8-4a62-9fa3-dd082d28e8e7" into ub-launcher3-master
* changes:
  [automerger] Deleting invalid icons when an app is restored am: e48fe1095d
  Deleting invalid icons when an app is restored
2018-06-04 23:54:10 +00:00
Android Build Merger (Role) 1e636dfa08 [automerger] Do not run StateHandler code while holding the lock am: f46779fe01 am: bda981419c
Change-Id: I90c280ebe5868ffc92618134802c95f7acc2b4c3
2018-05-31 21:13:05 +00:00
Sunny Goyal f46779fe01 Do not run StateHandler code while holding the lock
Deadlock:
Main thread:
  InternalStateHandler.run() =>
  	 LauncherFrameDrawn =>
  	 Switch MotionEventQueue to Main thread =>
  	 Try to acquire MotionEventQueue lock while holding InternalStateHandler lock

Remote UI thread
  Recents Animation cancel on MotionEventQueue =>
     Cancel SwipeHandler =>
     Clear previously registered InternalStateHandler =>
     Try to acquire InternalStateHandler lock while holding MotionEventQueue lock

Bug: 80536505
Change-Id: I75e522edea2a76f8bc90e8abc2a174583cc709c4
2018-05-31 14:12:52 -07:00
TreeHugger Robot f4392dbf5a Merge "Some launcher3 fixes so that it compiles with different configurations" into ub-launcher3-edmonton 2018-05-31 16:42:56 +00:00
Android Build Merger (Role) a7d219f798 [automerger] Some launcher3 fixes so that it compiles with different configurations am: d0f43ceba7 am: 9e40ef9894
Change-Id: Ie3eed75fab341dfe274a566c71d6b6fdbab70854
2018-05-31 01:15:28 +00:00
Android Build Merger (Role) 9e40ef9894 [automerger] Some launcher3 fixes so that it compiles with different configurations am: d0f43ceba7
Change-Id: I4886d9a1880c35ebb36ccda20401e6c7e394dad9
2018-05-31 01:15:27 +00:00
Sunny Goyal d0f43ceba7 Some launcher3 fixes so that it compiles with different configurations
Bug: 79996542
Change-Id: I4267aeb8f5b0714415970c63453049ff41466644
2018-05-30 18:15:21 -07:00
Android Build Merger (Role) a648206cd5 [automerger] Theme updates for dark text: am: 337fcb7983 am: a4feb0c385
Change-Id: Id1edd1dfac985be021f84e92c9014bcbf61608bb
2018-05-30 22:53:18 +00:00
Sunny Goyal 337fcb7983 Theme updates for dark text:
> Using white scrim on adjescent tiles in overview
> Using a ligher scrim in dark-theme+dark-text

Bug: 80253867
Change-Id: I3f257d3addaca8bc5970a61722f5ae0e7af89382
2018-05-30 15:53:10 -07:00
Android Build Merger (Role) f9f6e18eb7 [automerger] Deleting invalid icons when an app is restored am: e48fe1095d
Change-Id: Ia1f31b6c9c7cad813797357be1a3932aeae911ea
2018-05-30 22:23:21 +00:00
Sunny Goyal e48fe1095d Deleting invalid icons when an app is restored
When a app is restored, it may not be in exactly the same state as it was when backed up.
Some components might be missing, and some shortcuts may be disabled or unavailable

Bug: 63525806
Change-Id: I09e6c0e9a9d2c1e8ccd73430f94bd065bdf2718e
2018-05-30 15:23:09 -07:00
Android Build Merger (Role) c7c050497c [automerger] Fix animation not playing when going home while another animation is playing am: 67f9cad75a am: 7b77403629
Change-Id: I06b6f28a514852c7f11698f5b54c4a26f3244631
2018-05-30 00:39:06 +00:00
Tony 67f9cad75a Fix animation not playing when going home while another animation is playing
When going to a new state, we cancel any currently playing animation. When
canceling the animation, we reset mState = mCurrentStableState. Thus, when
determining the duration of the new animation, we have both state == NORMAL
and mState == NORMAL, leading to a duration of 0 and therefore no animation.
Storing the fromState before canceling/resetting fixes the issue.

Change-Id: I92332deae8058c4dd41212fe7f749955ede28b1c
2018-05-29 17:33:16 -07:00
Tony Wickham 78bf9b6265 Merge changes from topic "am-44d997ce-f83c-4bd7-aee0-6ab74e7269f5" into ub-launcher3-master
* changes:
  [automerger] Unhide badge when popup closes without animation am: bb9378aead am: d7eaf26425
  [automerger] Unhide badge when popup closes without animation am: bb9378aead
  Unhide badge when popup closes without animation
2018-05-29 22:44:10 +00:00
Tony Wickham 0512a6de57 Merge "Unhide badge when popup closes without animation" into ub-launcher3-edmonton 2018-05-29 22:44:09 +00:00
Android Build Merger (Role) 4cd3f2280c [automerger] Set mState = mCurrentStableState in onAnimationCancel am: 8935d9515c am: 556a97d9d6
Change-Id: I5de9060970fe6f8cb87f45d2e27ec591c4db543c
2018-05-29 22:03:17 +00:00
Tony Wickham 8935d9515c Set mState = mCurrentStableState in onAnimationCancel
mState is set when the transition starts toward that state even if it is
never reached. If the animation is canceled, therefore, we should reset
mState = mCurrentStableState since that is the state we came from.

For instance, when swiping up from overview, mState = ALL_APPS, but when
swiping back down we cancel that animation and create the task launch
animation. When creating the task launch animation, we reapplyState(),
which, before this change, was still ALL_APPS instead of OVERVIEW.

Bug: 79935289
Change-Id: I59c5799e92350747e4ef1d99a80ba678a2ce7b98
2018-05-29 21:58:52 +00:00
Android Build Merger (Role) b052aabc6e [automerger] Unhide badge when popup closes without animation am: bb9378aead am: d7eaf26425
Change-Id: I879d3e174ebad674893d02f674254675e56e7aeb
2018-05-29 21:46:15 +00:00
Android Build Merger (Role) d7eaf26425 [automerger] Unhide badge when popup closes without animation am: bb9378aead
Change-Id: Ib3e8bc6622e74c9a7ca214cfabecac956b666397
2018-05-29 21:46:13 +00:00
Tony bb9378aead Unhide badge when popup closes without animation
Bug: 80379412
Change-Id: I7d6c1b67a07747078b43b17612d8c67a46c8cc0e
2018-05-29 14:44:41 -07:00
Android Build Merger (Role) 1d9a44748a [automerger] Various quickscrub fixes am: 9bb8ffb5e3 am: c7bf48338c
Change-Id: I2ed6d0318a36148bf177108d3d2c21506644d33f
2018-05-29 19:17:28 +00:00
Sunny Goyal 9bb8ffb5e3 Various quickscrub fixes
> Fixing PagedView resetting the currentPage, if scrollToPage was called before first layout
  This causes quickscrub to jump back to the current task if launcher activity was dead.
> Fixing missing callbacks in DeferredTouchConsumer causing missed quick scrub flings
> Sending the resents animation callbacks on the motion queue thread, to avoid synchronization
  issues with sysui callbacks.
> Waiting until the recents animation is received before starting the scale down animation
> Calculating the offset for quickscrub statically incase launcher activity was dead

Bug: 80214390
Change-Id: I1b7d00b7b266655a92fcd6239f25ba191655150f
2018-05-29 12:17:20 -07:00
TreeHugger Robot 03aaced252 Merge "Fix clipping of adaptive icons Bug:62372639" into ub-launcher3-edmonton 2018-05-29 17:38:28 +00:00
Android Build Merger (Role) 6876902357 [automerger] Report when a notification is shown in the popup am: c97d846372
Change-Id: Iff0559113aea636559400a5772b0749d4855b225
2018-05-29 17:05:08 +00:00
Tony c97d846372 Report when a notification is shown in the popup
Change-Id: I5c06b18f731e2dc8e47bacba59746fc4cc02c42c
2018-05-29 17:05:02 +00:00
Android Build Merger (Role) 869977208b [automerger] Fix clipping of adaptive icons Bug:62372639 am: 49df554dc2 am: b7a30c69b3
Change-Id: I135ea15d2bcf1c3f3c1f0afe45418fbc0433c8d2
2018-05-25 23:31:05 +00:00
Android Build Merger (Role) b7a30c69b3 [automerger] Fix clipping of adaptive icons Bug:62372639 am: 49df554dc2
Change-Id: If59cb96023914f65fca3d75eb6f3155deeb1932c
2018-05-25 23:30:58 +00:00
Hyunyoung Song 49df554dc2 Fix clipping of adaptive icons
Bug:62372639

Context: only noticeable on large form factor AND Large display setting
Ceiling operation is needed to calculate offset of the drawing.

Change-Id: I7c77fa53f0811990b8cfdc3a12e2b43eb4d2d73e
2018-05-25 16:30:23 -07:00
Vadim Tryshev 5c17a390d2 Merge "Reporting range of visible tasks" into ub-launcher3-edmonton 2018-05-25 19:55:39 +00:00