Commit Graph

12718 Commits

Author SHA1 Message Date
Lucas Dupin f006d37acf Merge "Act on scrim visibility" into sc-v2-dev 2021-08-11 02:59:05 +00:00
Lucas Dupin e4a9469156 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
2021-08-10 14:18:50 -07:00
TreeHugger Robot 26b25c222c Merge "Use target size to scale down a widget preview image" into sc-v2-dev 2021-08-10 19:01:45 +00:00
Steven Ng caf2e5f350 Use target size to scale down a widget preview image
WidgetCells are being recycled in WidgetFullSheet. getWidth/getHeight
could be a recycled dimension. There is also no guarantee that measure
has taken placed before the scale down logic. Let's use the targeted
width for the scale down logic instead.

Test: Manual
Fix: 195417705
Change-Id: Idfb3cc485604d19658e210709bebde6f163003cf
2021-08-10 18:18:11 +01:00
Yogisha Dixit 104d09f143 Add logging when item not added due to insufficient space.
Bug: 194061824
Test: manual
Change-Id: Ib6f6b9ab4a8e1b59b1dbd1c7c137962efa3e880e
2021-08-10 13:57:47 +01:00
Brian Isganitis 47f0c5fba4 Merge "Update folder pagination dot color to match mocks." into sc-v2-dev 2021-08-09 22:08:18 +00:00
TreeHugger Robot 264f6a4b69 Merge "Add logs when runningTaskView after re-binding tasks is null." into sc-v2-dev 2021-08-09 22:07:51 +00:00
TreeHugger Robot 758faccca3 Merge "Use windowInsets for bottomGestureSize instead of gestureInsets" into sc-v2-dev 2021-08-09 21:38:18 +00:00
Steven Ng f90ad3be22 Merge "Fix wallpaper parallax calculation for large screen devices" into sc-v2-dev 2021-08-09 21:29:46 +00:00
Vinit Nayak 1a8f7120c1 Add logs when runningTaskView after re-binding tasks is null.
Bug: 195430732
Change-Id: If776c834bc2b06000230d853aeff58094e1fe88c
2021-08-09 13:42:40 -07:00
Brian Isganitis cbaf149f87 Update folder pagination dot color to match mocks.
Test: Folder page dot color matches mocks in light and dark mode.
Fix: 195045519
Change-Id: Ib485e51fbb903b1345ee865ddd8614f280e7608a
2021-08-09 16:03:54 -04:00
Alex Chau e9dbb0d952 Use windowInsets for bottomGestureSize instead of gestureInsets
- getTargetInsets will be reverted to its behavior before ag/15431427
- getBottomGestureSize will use the new getWindowInset call uses windowInsets instead of the max of windowInsets/gestureInsets, with the taskbar inset calibration

Bug: 195263971
Test: com.android.launcher3.ui.widget.AddWidgetTest#testDragCustomShortcut
Change-Id: I89368edee5252a404ef490db6540734ec4806f2b
2021-08-09 18:49:29 +01:00
TreeHugger Robot e649047f05 Merge "Add logs to MotionPauseDetector" into sc-v2-dev 2021-08-09 17:13:26 +00:00
Alex Chau 1338dd7e71 Add logs to MotionPauseDetector
- Add logs to MotionPauseDetector to confirm if the current 700ms timeout is enough for tests

Bug: 194114179
Test: atest NexusLauncherOutOfProcTests:com.android.launcher3.memory.MemoryTests#testAppLaunchFromWorkspace
Change-Id: Ifc3e8a24c245b1877e3fae5d2cb96636c34e8e4b
2021-08-09 15:56:11 +01:00
vadimt 6b534ee54f Diagnose when lab device sends fake touch screen events to test
Bug: 189874683
Test: local
Change-Id: I8ac569ab049bafaa0a6263598f2b43a99386e6d9
2021-08-06 15:49:02 -07:00
Jonathan Miranda 86d80936ac Merge "Update extra space allocations for taller devices." into sc-dev am: dd16ecbc61
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15457550

Change-Id: I8fe398bacbdc11a3ba6d43829c1be75248249740
2021-08-05 18:42:44 +00:00
Jonathan Miranda dd16ecbc61 Merge "Update extra space allocations for taller devices." into sc-dev 2021-08-05 18:33:56 +00:00
Steven Ng cea65b75d8 Fix wallpaper parallax calculation for large screen devices
Test: manual
Bug: 193403434
Change-Id: Ifaed71f8c3645b012def02a9ea36fc3fb29bac00
2021-08-05 16:05:50 +01:00
Alex Chau 42f914e254 Merge "Make icon drawable for non-focused grid tasks smaller" into sc-v2-dev 2021-08-05 09:57:19 +00:00
Brian Isganitis c2a6378fc1 Merge "Fix crash from previewing launcher with unknown wallpaper colors." into sc-dev am: 200d7634d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15462873

Change-Id: I4965f54b75f9762ef51ed15f27f43f73b2919164
2021-08-05 01:28:12 +00:00
Brian Isganitis 200d7634d1 Merge "Fix crash from previewing launcher with unknown wallpaper colors." into sc-dev 2021-08-05 01:08:00 +00:00
Alex Chau 974635127b Merge "Increase motion pause timeout for tests" into sc-v2-dev 2021-08-04 21:59:53 +00:00
Steven Ng f4b1b0af75 Merge "Don't delete widgets that violate min size requirement" into sc-dev am: 5fc53cbc22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15455163

Change-Id: I2783668d3315537fd64b2a6175064abbcbbe132f
2021-08-04 20:29:24 +00:00
TreeHugger Robot b78e77f581 Merge "Storing form factor as part of backup and disabling restore if form-factor is different" into sc-v2-dev 2021-08-04 19:12:10 +00:00
Alex Chau 0dfe56cff1 Increase motion pause timeout for tests
- In cuttlefish occasionally MOTION_MOVE and MOTION_UP takes more than 300ms due to lag, increasing the motion pause timeout to avoid getting false signals in tests

Bug: 194114179
Test: atest NexusLauncherOutOfProcTests:com.android.launcher3.memory.MemoryTests#testAppLaunchFromWorkspace
Change-Id: I0a33f34b5bf96f4f7ae56020c5a27f4ef9a0ff64
2021-08-04 20:09:06 +01:00
Jon Miranda a56cb84141 Update extra space allocations for taller devices.
- Take less space from cells
- Distribute some of the empty space above the workspace
- Already confirmed from previous testing that these thresholds
  only affect taller devices

Bug: 194688362
Test: long press on app icons,
      test drag and drop bounds
      test drop target bounds
      test folder opening bounds
      test all grids on taller devices

Change-Id: If90b7663ab4afedca1193bdd73a0ae38a1f25243
2021-08-04 12:00:36 -07:00
Brian Isganitis dafa5040ef Fix crash from previewing launcher with unknown wallpaper colors.
Test: Open wallpaper app with live wallpaper applied should not crash.
Fix: 195246865
Change-Id: Id64de32b35aa7a553daa752438060d7f6822bec8
2021-08-04 18:31:20 +00:00
Sunny Goyal 68031ca3f9 Storing form factor as part of backup and disabling restore if form-factor is different
Bug: 195301649
Test: Manual
Change-Id: I9a9c4bc9246f40af2209cb914b3966319bc78bff
2021-08-04 09:51:04 -07:00
Sunny Goyal a67358bc8d Merge "Using themed icons in taskbar" into sc-v2-dev 2021-08-04 16:32:15 +00:00
TreeHugger Robot 1e46696161 Merge "Fix Workspace item move issues when using Talkback" into sc-v2-dev 2021-08-04 10:48:22 +00:00
Steven Ng b269cc5150 Don't delete widgets that violate min size requirement
Test: Manual
Bug: 194766124
Change-Id: I4713e65e27da23d833bb60fb556ae8924a63e305
2021-08-04 11:14:09 +01:00
Andras Kloczl e32e8641d6 Fix Workspace item move issues when using Talkback
- fix the crash when an item was moved onto the right panel
- fix the issue that prevented the user from moving an item from the left panel

Test: manual
Bug: 194903736
Change-Id: Ib41f5d6d08e8815a52631ef952d32dcf899455e2
2021-08-04 11:04:19 +02:00
Sunny Goyal 59f1915c9d Using themed icons in taskbar
Bug: 195437559
Test: Verified on device
Change-Id: If8c0a72e037783e96abbaae6b60aa36a686fcfea
2021-08-03 12:25:22 -07:00
Alex Chau ac9df38e9f Make icon drawable for non-focused grid tasks smaller
- Center the icon drawable in center of IconView with and allow a smlaler size to be set

Bug: 194194694
Test: dismiss focus task, swipe from app etc.
Change-Id: I2855249b13e2ccdb45f101bfb7afef4311f7b46f
2021-08-03 17:36:15 +01:00
Steven Ng 61cfa57ad8 Correct cell layout spacing in n-panels UI
Test: manual
Fix: 184966000
Change-Id: I6940413c24f41df0b1ffcfd4bec4b0c5c3497b6d
2021-08-03 16:40:41 +01:00
Andras Kloczl b063294e60 Follow up CL for controller navigation fix
Fixing unresolved comment: http://shortn/_YCaiPNApNc

Test: manual test with a game controller, check on both normal and two panel home
Bug: 187205980
Change-Id: I8cae48effcce852c85273f16d1107dec90ff6f51
2021-08-03 14:03:58 +02:00
TreeHugger Robot 144b16bbb1 Merge "Band-aid for getHomeActivities returning null" into sc-v2-dev 2021-08-02 19:20:01 +00:00
vadimt 42a7d1af83 Band-aid for getHomeActivities returning null
It can return null immediately after android.intent.action.ACTION_PREFERRED_ACTIVITY_CHANGED
notification.

Test: local
Bug: 187080582
Change-Id: I8625fdfc0add57fed832bdca4713747a005bf08c
2021-08-02 10:38:12 -07:00
Brian Isganitis bb6bb5bbbd Merge "Adding support for overriding long-press menu in Launcher" into sc-v2-dev 2021-07-30 22:47:46 +00:00
TreeHugger Robot f02c754eb9 Merge "Fix Launcher3 tests for tablets" into sc-v2-dev 2021-07-30 22:36:52 +00:00
Jonathan Miranda 4edf78695d Merge "Add more restrictions on whether we increase the hotseat size for tall devices." into sc-dev am: 4a17e66166
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15412628

Change-Id: Ifb92308f3c0a3fef040e3a863e9e11300ad46334
2021-07-30 20:50:28 +00:00
Jonathan Miranda 4a17e66166 Merge "Add more restrictions on whether we increase the hotseat size for tall devices." into sc-dev 2021-07-30 20:37:29 +00:00
Sunny Goyal 831212ec92 Adding support for overriding long-press menu in Launcher
Bug: 188222480
Test: Manual
Change-Id: Ic0b425fafde8beedc15a5aa42a8897b9143a3309
2021-07-30 16:07:26 -04:00
Alex Chau 6951aef060 Fix Launcher3 tests for tablets
- Consider taskbar size for bottom gesture size, by using TargetInsets
- TargetInsets should substract overlapping taskbar size when it's present
- For pressHome, use the same gesture scope when context menu is present as well.
- For pressHome, GestureScope.INSIDE_TO_OUTSIDE should only be used when it's already at home screen on launcher3 tablet.

Bug: 193539246
Test: NexusLauncherTest and Launcher3Test
Change-Id: I4a20522f3b38ef326acae4b189df11a125990411
2021-07-30 20:39:05 +01:00
Steven Ng 3edfa98ba7 Use the right content to estimate the span in WidgetsFullSheet
Test: Manual
Fix: 194784402
Change-Id: I150f4c7b5a0344caa2bea3f1502894cb0f32e208
2021-07-30 13:15:26 +01:00
TreeHugger Robot 02d45252f3 Merge "Fix cell size calculation in large screen devices" into sc-v2-dev 2021-07-30 11:39:26 +00:00
Steven Ng 2a5c594855 Fix cell size calculation in large screen devices
Test: Digital clock widget is no longer cropped.
Bug: 184966000, 194784402
Change-Id: I26c406da1e10232019f34620a4d2bc0dbafcbb31
2021-07-30 11:14:11 +01:00
András Klöczl 7f569f14b4 Merge "Fix controller navigation on two panel launcher home" into sc-v2-dev 2021-07-30 08:43:27 +00:00
TreeHugger Robot eb6391ff8d Merge "Fixing hotseat hidden in 3P Launcher" into sc-v2-dev 2021-07-29 21:51:39 +00:00
Andras Kloczl 7e91244a1b Fix controller navigation on two panel launcher home
Test: manual test with a game controller, check on both normal and two panel home
Bug: 187205980
Change-Id: I2515e476556098acf407c0bdcd634e3dd1cb308c
2021-07-29 22:04:27 +02:00