Commit Graph

12718 Commits

Author SHA1 Message Date
vadimt ae76bebfed More diags for non-receiving scroll end
Bug: 160238801
Change-Id: I2e19d16e49e84e93bdf135eb97d5f033475305e8
2020-07-08 10:09:46 -07:00
TreeHugger Robot 4c40be975c Merge "Fixes the issue Launcher state propagation is slower than onDeferredResume." into ub-launcher3-master 2020-07-08 00:27:35 +00:00
TreeHugger Robot 289aca6a0e Merge "Guard swipe to notification gesture with system settings preference" 2020-07-07 02:02:11 +00:00
Jon Miranda e38322294b Fix bug where non-center page is visibile in HINT_STATE.
Bug: 160122854
Change-Id: I3d970e49aa891f5c9ccda60a6d6f4f73dd0a9f03
2020-07-06 15:38:38 -07:00
Jerry Chang 779efaca91 Guard swipe to notification gesture with system settings preference
Bug: 154080211
Test: make and install, check the gesture works as expectedly
Change-Id: Ibd6bbd595d2fba5d68e66eb54e4a7fec160b9bf8
2020-07-01 11:44:02 +08:00
Pinyao Ting 3bf889a02f Fixes the issue Launcher state propagation is slower than onDeferredResume.
There's currently a bug prevents Launcher release drag lock for two step
widgets. Supposedly, onDeferredResume should release the drag lock; However,
in 3-button navigation mode, the transition from Overview -> Normal is
triggered in Launcher#onNewIntent, which happens after onDeferredResume.

This issue is not reproducible with gesture navigation because its
transition from Overview -> Normal is handled in NavBarToHomeTouchController

Test: manual verified with following steps
1. Enable 3-button navigation
2. Long press in WorkSpace -> Widgets
3. Drag Settings Widget to WorkSpace
4. When the config activity is shown, press "recents" button to see Overview
5. press "home" button to go back to workspace
6. repeat 2 and 3, verify the widget can be dragged
Bug: 149659788

Change-Id: I396ffa8a7db44bf3872a10de4208340a99a7efe8
2020-06-30 17:00:24 -07:00
vadimt 1af70f2729 Add logging for non-sending "end scrolled" event for Widgets
Bug: 160238801
Change-Id: I60a1cb689110c5b22b0a145b3cca7d47d867005e
2020-06-30 12:36:09 -07:00
TreeHugger Robot 9f6e0f88d3 Merge "Disable auto correct/suggest on folder edit text Bug: 160075575" into ub-launcher3-rvc-dev am: fe4d64f4e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12031769

Change-Id: If3e3f0b4f0f33a21d8923b08f939b3f6227b494c
2020-06-29 19:51:56 +00:00
TreeHugger Robot fe4d64f4e3 Merge "Disable auto correct/suggest on folder edit text Bug: 160075575" into ub-launcher3-rvc-dev 2020-06-29 19:37:23 +00:00
Hyunyoung Song 37bda2bcc9 Disable auto correct/suggest on folder edit text
Bug: 160075575

TL;DR;; displayCompletions still work

Change-Id: I0a7cd06d25ae3976371be0707a2783702b92e8cc
2020-06-29 00:26:14 -07:00
TreeHugger Robot 434327342c Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev am: 0538863c58 am: 458fef861f am: 28e8758e55 am: 72eb94ab1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12010483

Change-Id: I1e8164d04dd80ff065e037e9d0148d801d6ee9c4
2020-06-26 22:50:46 +00:00
TreeHugger Robot 0538863c58 Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into rvc-dev 2020-06-26 21:59:15 +00:00
thiruram e358cfc002 Fixes missing folder label after launcher restarts. am: e148652075 am: aa823d103e am: 1587221298 am: 0ed72b3e35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12003751

Change-Id: Ic8dfc8979d631564a60baa863e8748c7dcd8c807
2020-06-26 19:10:07 +00:00
Adam Cohen ef1d088a4c Merge "During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate" into ub-launcher3-rvc-dev am: f6edf98902
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12005660

Change-Id: I1646d2a238e58d897351610963824229a8c853f9
2020-06-26 17:27:21 +00:00
Adam Cohen 9e3aebd8dd During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

Bug: 155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
(cherry picked from commit 6e7c37a205)
2020-06-26 17:15:03 +00:00
thiruram e148652075 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
(cherry picked from commit 6ab4da8aa0)
2020-06-26 16:30:31 +00:00
Tracy Zhou 081b800e38 Do preview grid migration in a worker thread am: 6b79a3767d am: f1c369589a am: 4959b0f79f am: 02f3b9bf57
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002728

Change-Id: I6092f5b7cf2b3145460374253e285a5350659767
2020-06-26 08:35:28 +00:00
Adam Cohen 6e7c37a205 During accessible drag, hover events were not properly getting dispatched to the DragAndDropAccessibilityDelegate
=> regressed in ag/10634216 which attemped to use onHoverListener
=> the problem is that onHoverListener is only triggered when the event is passed to the CellLayout, however, as with all dispatching, these events are handled depth first, and so in cases where a child handled the event, it would never bubble back up to the parent.
=> instead we have to continue to override dispatchHover event to always give presecedence to the delegate when it exists

b/155956518

Change-Id: Ic3ecf1b422c1821456328035a66a2fc1277e6746
2020-06-26 02:34:36 +00:00
thiruram 07a31d04ac Fixes missing folder label after launcher restarts. am: 6ab4da8aa0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11999547

Change-Id: I839d910fcef8e6c1d432b68e68b2ba0f3d7550c2
2020-06-26 00:26:10 +00:00
thiruram 6ab4da8aa0 Fixes missing folder label after launcher restarts.
Rootcause: FolderInfo was persisted into DB only when folder options are updated. Hence when folder was created (Folder option remains suggested) its title was not persisted into DB.

Fix: Persists folderInfo into DB always whenever title is updated

Bug: 159904890
Change-Id: If0d20b0d7fa6966dd7bb40a2c07bcb22bd0893e0
2020-06-25 23:48:17 +00:00
TreeHugger Robot e997bd682e Merge "Improving diagnostics when can't find a widget" into ub-launcher3-master 2020-06-25 22:24:05 +00:00
Tony Wickham 3d6bfc2905 Merge "Fix tracking window being slightly off when swiping from an app" into ub-launcher3-master 2020-06-25 22:18:32 +00:00
Tracy Zhou 6b79a3767d Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:05:04 +00:00
Tracy Zhou f957ff9123 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:04:25 +00:00
Tracy Zhou 633a4bdf57 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
2020-06-25 13:12:52 -07:00
Tony Wickham f0a1b2ccd8 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
2020-06-25 11:51:28 -07:00
vadimt fb099c7fe1 Improving diagnostics when can't find a widget
Instead of "exceeded number of attempts" now printing that can't scroll
to widget.

Change-Id: Ia6f582e038d68fc35f152d94e592f60ef0bc2cf4
2020-06-24 21:54:16 +00:00
TreeHugger Robot 7e3d07fc77 Merge "Use isolated display context to get display info" into ub-launcher3-rvc-dev am: a0b0d66e20
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11969862

Change-Id: Ibb6496b2ed97f782940cdf8f846731ba6a36811a
2020-06-24 05:37:07 +00:00
TreeHugger Robot d0ab65cd8e Merge "Use isolated display context to get display info" into rvc-dev am: 7f5a670cc3 am: f58ec22c1c am: 0891adf289 am: bb352ef052
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11969858

Change-Id: Ifd6478e67c71e2380b8f6db7a6afc410e5cb00ae
2020-06-24 04:26:53 +00:00
TreeHugger Robot 44035d9d17 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev am: 738b1af342 am: f7897465e3 am: 808a7c1920 am: dde7797ec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975976

Change-Id: Ifdd13981f0e61d248e89a1f10eec3b51369840f4
2020-06-24 04:26:33 +00:00
Riddle Hsu 8995590e44 Use isolated display context to get display info
While display is in landscape, and the launcher is transformed to
portrait, the display rotation from activity or application context
will get the rotation in portrait.

In order to transform the input event when the orientations are
different, the actual device rotation is still needed. By creating
the display context from application context, the resources of
the new context won't be affected by the activity/application level
display info adjustments. That provides the actual device states.

Additionally, DefaultDisplay#INSTANCE should only be used for the
operations related to physical orientation/size because it won't
contain the override information from activity.

Bug: 157456493
Test: Use a device which may switch refresh rate.
      Open Maps and put device in landscape.
      Use gesture navigation to swipe up.
      The direction of movement should be consistent with UI.
Change-Id: I03108b1ab057e28727b6a6db3629d2c1c069e828
2020-06-24 04:00:13 +00:00
TreeHugger Robot 7f5a670cc3 Merge "Use isolated display context to get display info" into rvc-dev 2020-06-24 03:44:07 +00:00
Jon Miranda 6fc3648e89 Fix map initial capcity.
Change-Id: I69f9dc2310435ba23d9a12cc8a5ef1037b43bb2b
2020-06-23 22:51:27 +00:00
Tracy Zhou b1e003c1fb Merge "Support having dup items in folder for migration" into ub-launcher3-rvc-dev 2020-06-23 16:12:25 +00:00
Riddle Hsu 8108009929 Use isolated display context to get display info
While display is in landscape, and the launcher is transformed to
portrait, the display rotation from activity or application context
will get the rotation in portrait.

In order to transform the input event when the orientations are
different, the actual device rotation is still needed. By creating
the display context from application context, the resources of
the new context won't be affected by the activity/application level
display info adjustments. That provides the actual device states.

Additionally, DefaultDisplay#INSTANCE should only be used for the
operations related to physical orientation/size because it won't
contain the override information from activity.

Bug: 157456493
Test: Use a device which may switch refresh rate.
      Open Maps and put device in landscape.
      Use gesture navigation to swipe up.
      The direction of movement should be consistent with UI.
Change-Id: I03108b1ab057e28727b6a6db3629d2c1c069e828
2020-06-23 17:09:33 +08:00
Tracy Zhou 76773cd210 Support having dup items in folder for migration
Fixes: 159312066
Test: Have two dup items in a folder under one grid setting. Migrate. Make sure the folder is migrated correctly to the new grid setting.
Change-Id: Ic5aeb30a1c8acb382bccf744d7553913d8a8a320
2020-06-23 00:29:23 -07:00
TreeHugger Robot 7cb6d738c0 Merge "Eliminating messages that launcher activity is frozen" into ub-launcher3-rvc-dev 2020-06-23 06:09:26 +00:00
Hyunyoung Song 0b51b916b0 Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https: //android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_master_6617269.html
Change-Id: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-22 18:53:39 -07:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
vadimt 839fb7b3ae Eliminating messages that launcher activity is frozen
They were ultimately caused by killing Launcher process from tests.

Now having a test info handler request to clear db.

Bug: 152629799
Change-Id: Ia81ddc3e338718c4cff08c7396b9fda1b7091024
2020-06-22 15:39:19 -07:00
Thiru Ramasamy 51ece1847c Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev 2020-06-22 21:04:12 +00:00
Vadim Tryshev 21cea8e55c Merge "Changing event check implementation from logcat to TestProtocol" into ub-launcher3-rvc-dev 2020-06-22 20:42:23 +00:00
thiruram ec75cbd85a Adds additional folder label states (UNLABELED & EMPTY_LABEL)
UNLABELED -> title==null and EMPTY_LABEL -> title=="". When adding new items for the folder if the folder is in UNLABELED state, auto-labeling will be enabled.
This change also addresses auto-labeling issue due to false edit from UNLABELED to EMPTY.

Bug: 159164315

Change-Id: Ia17cd27b4afb60420dc15c544f544061fc46ad33
2020-06-22 13:24:07 -07:00
Hyunyoung Song 5c9a1ef5cd Merge "Log Launcher transitions to WW" into ub-launcher3-rvc-dev 2020-06-22 20:21:10 +00:00
Hyunyoung Song 801f81fba5 Log Launcher transitions to WW
- ONRESUME / ONSTOP
- HOME_GESTURE
- OVERVIEW_GESTURE
- QUICKSWITCH
- SWIPELEFT/SWIPERIGHT

Bug: 156875719
Bug: 148822714
Bug: 137777105

Debug log: go/launcher-log-parity

Change-Id: I64a0deab4996b5be36320fbe0339f320891c53e0
2020-06-22 12:09:06 -07:00
vadimt a17a10cddd Changing event check implementation from logcat to TestProtocol
Bug: 153670015
Change-Id: Id9fc759bd5be68758ef9cf0abbba3cd6fa452796
2020-06-22 11:04:03 -07:00
Samuel Fufa 6dac493218 Merge "Send app launch events from TaskSwitcher" into ub-launcher3-rvc-dev 2020-06-22 17:36:12 +00:00
TreeHugger Robot 845f135d17 Merge "Add depth animation when multiwindow mode changes." into ub-launcher3-rvc-dev 2020-06-22 17:31:35 +00:00
Winson Chung c46daa9572 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev 2020-06-21 04:08:09 +00:00
Winson Chung 4941f65d52 Tweak quickswitch thresholds
- Reduce slop for gestural mode (and apply multiplier to slop
  at checktime)
- When quickswitch threshold is passed, reduce the total movement
  check and reduce the velocity needed to fling to the next page
  to accommodate short swipes
- Use touch slop to determine scrolling in paged view, and only
  use paging slop to determine flinging to the next page (when
  easy flings are disabled (which is the default))

Bug: 157165240
Test: Ensure the flings in normal overview/paged views don't change,
      check short flings from quickswitching
Change-Id: Idd04ce23f53c06759e84ac8ad73cf2cc6dff6975
2020-06-20 19:41:32 -07:00