Commit Graph

12718 Commits

Author SHA1 Message Date
TreeHugger Robot 4cd5fee186 Merge "Adjust padding, margin of tabs in the WidgetsFullSheet" into sc-dev am: 1002981fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14602830

Change-Id: Iab84c81890bbcc9ee50507513f62e0e8cddd812a
2021-05-25 11:59:13 +00:00
Alina Zaidi 9d24de1353 Add more education tips for widgets. (1/3)
Show Arrow education tip on WidgetsBottomSheet. This tip is shown only
once either in widgets full sheet or bottom sheet.

Test: Tested manually
Bug: 185354491
Change-Id: I6d770ed0906a5cb0f5bcfe6ae0cd327b790cf164
2021-05-25 10:50:02 +01:00
Steven Ng 21979aca50 Fix tabs abruptly reset during swipe
The indicator position has already been updated by
PersonalWorkPagedView#onScrollChanged. The updateIndicatorPosition
call in setActiveMarker has abruptly reset the mScrollOffset to a page
index rather than a [0f, 1f] offset.

Test: On a work profile device, swipe left & right in the all apps.
      Then, swipe left & right in the full widgets picker. In both
      cases, I no longer observe an abruptly reset of the tabs
      transition animation.
Bug: 187704466
Change-Id: I53c4ed3a98219093f3d61dfa4de2fe21ec88851c
2021-05-24 23:57:28 +01:00
Schneider Victor-tulias b199e20acc Enable unpausing apps from the workspace.
Fixes: 188675002
Test: manual
Change-Id: I02715450016e9b91fff774525b5e32c337c74547
2021-05-24 21:44:29 +00:00
Andras Kloczl 55edfe55f7 Add two panel home support for page binding logic
There's a logic which prioritizes the binding for the
current page and defers the other pages' binding.
If two panel home is enabled, we want to bind both pages
together. LauncherPageRestoreHelper has been created to
contain the logic for persisting restoring and calculating
which pages to load immediately.

Test: manual + run LauncherPageRestoreHelperTest robo test
Bug: 174464691
Change-Id: I57ac3f7150303b95b272e922f44bda26f9d5ce2a
2021-05-24 23:22:06 +02:00
Alex Chau 960a2b2696 Always focus a task in overview
- Focus first task when applying load plan
- Focus the next task in shorter row when focused task is dismissed, scale the snapshot and translate the task into focused position
- Always show actions view as there is always a focused task. Update scroll alpha when toggling grid enabled
- In fallback recents, take into account that home task will be dismissed when determining rows for the grid, ensuring next focused task won't affect row balancing
- Bring back clearAllShortTotalCompensation as there isn't always a snappedTaskView (e.g. when snapped to ClearAllButton)
- Ensure that getFocusedTaskView is only used when showAsGrid is true

Bug: 187839470
Fixes: 188001858
Fixes: 189057812
Test: manual
Change-Id: I6f31ef469c58fda70d2dd8caa2ee7d8a80c7f03b
2021-05-24 18:13:04 +01:00
Steven Ng e90dddaaa0 Fix full widgets picker fast scroller height.
1. Fix the app title to one line.
2. Use the measured height of a header view to estimate the available
   fast scroll bar height.

Test: Open full widgets picker. Scroll to the bottom by scroll gesture.
      Observe the fast scroll bar indicator is correctly shown.
      Scroll back to top and then use the fast scroll bar to scroll to
      the end of the page. Observe the last app row is aligned to the
      bottom of the page.
Bug: 188914448
Change-Id: I57a2419d1fbfc8f946a932eebfefb67ae0c07eb6
2021-05-24 18:05:56 +01:00
Steven Ng ede641bd77 Adjust padding, margin of tabs in the WidgetsFullSheet
Also remove elevation set to tab to remove unwanted shadow.

Test: Set up a work profile. Then, open the full widgets picker.
      Observe padding & margin of the work / personal tabs.
Bug: 188221455
Change-Id: I761cb1c1410f87c80a5fdca3803fb8b099d499d6
2021-05-24 11:40:16 +01:00
TreeHugger Robot b841731a35 Merge "Fixing missing unlinktoDeath" into sc-dev am: eb0a14ad79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14684233

Change-Id: I3acf3f5c5a340b3686e41e67fb885b072de44ead
2021-05-22 01:25:26 +00:00
TreeHugger Robot eb0a14ad79 Merge "Fixing missing unlinktoDeath" into sc-dev 2021-05-22 01:05:05 +00:00
Sunny Goyal b5596f72e4 Fixing missing unlinktoDeath
Bug: 186712316
Test: Manual
Change-Id: If06737403c346c5ccca533dec647e3a0691f1bfa
2021-05-21 15:29:33 -07:00
Sunny Goyal 6755587219 Using icon color for dot and halo
Bug: 188839628
Test: Manual
Change-Id: I8a393cc7073d5a249619b4033ec860c55f17167a
2021-05-21 12:57:38 -07:00
Sunny Goyal e9d27f137f Updating method for getting themed icon
Bug: 183641907
Test: Manual
Change-Id: I417886acea1b518c184d8e7c649367cae841a7e4
2021-05-21 12:29:15 -07:00
TreeHugger Robot bd966d6c12 Merge "Apply the current system window insets to launcher preview" into sc-dev am: 576722164a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14646650

Change-Id: I99cc8ff6901cfde5bf2e4e18e7e3626fd91b041f
2021-05-21 18:26:46 +00:00
TreeHugger Robot 576722164a Merge "Apply the current system window insets to launcher preview" into sc-dev 2021-05-21 18:00:07 +00:00
TreeHugger Robot 02567591a5 Merge "Avoid drawing tall header when scrolling search results" into sc-dev am: 3350508bb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14661228

Change-Id: Ic0aa3ce3ae05c709abdcf876409d296c38109861
2021-05-21 17:50:56 +00:00
TreeHugger Robot 3350508bb6 Merge "Avoid drawing tall header when scrolling search results" into sc-dev 2021-05-21 17:34:42 +00:00
Songchun Fan cd72a7d265 Merge "Reapply All Apps icons on download complete." into sc-dev am: 6a69ff55b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14554680

Change-Id: I65b8d92b951796bc8f97a45e38de941d25b5a611
2021-05-21 16:06:48 +00:00
Sunny Goyal fa851c78e9 Merge changes from topic "revert-14664190-JGHJCCJYPM" into sc-dev am: 67914aff50
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14669170

Change-Id: Ia589d1d6178ccf2f5b7931cfd5c8d9c4a00cad59
2021-05-21 16:06:43 +00:00
Songchun Fan 6a69ff55b7 Merge "Reapply All Apps icons on download complete." into sc-dev 2021-05-21 15:59:58 +00:00
Sunny Goyal 67914aff50 Merge changes from topic "revert-14664190-JGHJCCJYPM" into sc-dev
* changes:
  Initiate taskbar only after the user is unlocked
  Revert "Revert "Renaming TaskbarController to LauncherTaskbarUIC..."
  Revert^2 "Moving taskbar lifecycle to TouchInteractionService"
2021-05-21 15:45:11 +00:00
Alina Zaidi d918a1a504 Align 'No widgets available' text box properly in Widget picker. am: 260c38c4a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14505876

Change-Id: I6a36ef6932b7654d5911ab47fc3a774745455a26
2021-05-21 13:12:02 +00:00
Alina Zaidi 260c38c4a0 Align 'No widgets available' text box properly in Widget picker.
Bug: 186209657
Test: Tested manually
Change-Id: I85fa43cd745a8c9f9601d25ed3a35f512506234d
2021-05-21 10:49:03 +01:00
Steven Ng c855244157 Merge "Clear widgets search bar focus when the user taps outside the search bar" into sc-dev am: 9f194ee290
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14622878

Change-Id: Ief5b0daa48a6113baaedff097aba9d0709cac1e0
2021-05-21 09:08:24 +00:00
Steven Ng 9f194ee290 Merge "Clear widgets search bar focus when the user taps outside the search bar" into sc-dev 2021-05-21 08:52:50 +00:00
Sunny Goyal d5500548dc Revert^2 "Moving taskbar lifecycle to TouchInteractionService"
430465a3d5
Bug: 187353581
Change-Id: I7b2280d16adfafd3e85ffc1d22e32d0c00d12b67
2021-05-21 07:05:02 +00:00
Chihhang Chuang ccb71776c6 Apply the current system window insets to launcher preview
For wallpaper picker, the position of app icon on the wallpaper preview would match to the launcher after applying the wallpaper.

Wallpaper picker: https://screenshot.googleplex.com/JZazpgZLgzacZMZ.png
Launcher: https://screenshot.googleplex.com/9uTTQwdmcnFZ7Vi.png
Gesture mode: https://screenshot.googleplex.com/3YaKbBerYgtHBFb.png
3-button mode: https://screenshot.googleplex.com/7sA5nE3GmbuKf62.png

Fixes: 188539072
Test: Manually
Change-Id: I553000e6ae646207eb94fa33e97d00a3990043c8
2021-05-21 14:41:37 +08:00
Pierre Barbier de Reuille 8a3edc0ad8 Merge "Correct size of AppWidget for color extraction." into sc-dev am: fd3ad5d769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14649810

Change-Id: Icdd45e1e1dd942af4b8b2f6e67636b6b985b4880
2021-05-21 06:07:18 +00:00
TreeHugger Robot 7174a21237 Merge "Fixing Launcher preview leaking surface and memory" into sc-dev am: 50308f3750
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14654425

Change-Id: I79fa2f446f2f587468c691c47ed77c59dc201900
2021-05-21 06:06:59 +00:00
Pierre Barbier de Reuille fd3ad5d769 Merge "Correct size of AppWidget for color extraction." into sc-dev 2021-05-21 06:06:30 +00:00
TreeHugger Robot 50308f3750 Merge "Fixing Launcher preview leaking surface and memory" into sc-dev 2021-05-21 05:51:08 +00:00
Winson Chung 7af9af114d Merge "Tweak ordering of first match search" into sc-dev am: 07414d5cd5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14668159

Change-Id: Ib9ee0e0850f1f3cbb38bd7037cb2a9b0f6c5cf53
2021-05-21 03:42:29 +00:00
Winson Chung 07414d5cd5 Merge "Tweak ordering of first match search" into sc-dev 2021-05-21 03:15:55 +00:00
TreeHugger Robot 773a332179 Merge "Animate recommended widgets vertical transition when reset widgets picker scroll position" into sc-dev am: 45f7360432
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14649811

Change-Id: I7cfbadbc8f47c90672fb661ba2d2108bfb5fe239
2021-05-21 02:25:07 +00:00
TreeHugger Robot 45f7360432 Merge "Animate recommended widgets vertical transition when reset widgets picker scroll position" into sc-dev 2021-05-21 02:02:47 +00:00
Steven Ng bcdf855e61 Merge "Apply android:attr/dialogCornerRadius to widgets picker dialog top corners" into sc-dev am: 36f9aa7530
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14643392

Change-Id: Iaf28d442d190004cb57e62eed7e922fbfac12830
2021-05-20 23:48:15 +00:00
Steven Ng b6e116c31f Merge "Remove work profile badge from widget previews" into sc-dev am: b46428fcd9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14648790

Change-Id: If3e90995d07e518d6383d63c8c1dbfc7274c857f
2021-05-20 23:48:06 +00:00
Steven Ng 43a9c58a24 Merge "Reset visible entries when the app tile of the same app no longer match" into sc-dev am: 444b2489a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14622880

Change-Id: I621c04031c45ecae02475f4f597b223c4dc9f80b
2021-05-20 23:48:01 +00:00
Steven Ng 36f9aa7530 Merge "Apply android:attr/dialogCornerRadius to widgets picker dialog top corners" into sc-dev 2021-05-20 23:46:53 +00:00
Steven Ng b46428fcd9 Merge "Remove work profile badge from widget previews" into sc-dev 2021-05-20 23:42:50 +00:00
Steven Ng 444b2489a5 Merge "Reset visible entries when the app tile of the same app no longer match" into sc-dev 2021-05-20 23:42:24 +00:00
Steven Ng ac053fb4c2 Merge "Widgets: Only reset expanded item & scroll to top if the user switch tab" into sc-dev am: f357dc4f3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14622871

Change-Id: I4ae28cd0bbc1e84268f4d6c9c1d047d39e582ae1
2021-05-20 23:39:21 +00:00
Steven Ng f357dc4f3e Merge "Widgets: Only reset expanded item & scroll to top if the user switch tab" into sc-dev 2021-05-20 23:24:35 +00:00
Lucas Dupin 401d94b0bc Merge "Make launcher opaque when scrim becomes opaque" into sc-dev am: c2bcdcee9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14654426

Change-Id: I4543c5073dacd2b1039b0c95bca7e7315d470ed9
2021-05-20 23:16:43 +00:00
Lucas Dupin c2bcdcee9b Merge "Make launcher opaque when scrim becomes opaque" into sc-dev 2021-05-20 23:11:46 +00:00
Winson Chung bd2fa26bda Tweak ordering of first match search
- Tweak iteration for finding first match, go by operator priority and
  check each cell layout by order to return the first view that matches
- Also reset the launch cookie in cases where we're launching a task
  that doesn't support cookies (ie. via prediction), otherwise we may
  still try to associate it with the last launched cookie later

Fixes: 187720286
Test: Swipe up from various icon types across hotseat/workspace
Change-Id: I71c4c13c442b0884b2247589685f976eaaeb30a4
Signed-off-by: Winson Chung <winsonc@google.com>
2021-05-20 14:50:33 -07:00
Sunny Goyal df4241ca4e Fixing Launcher preview leaking surface and memory
> Closing existing preview if a new request comes for same host token
> Closing in-memory icon db when closing preview
> Removing unnecessary wait blocks on UI thread and rendering
  view asynchronously
> Fixing preview loading failing on LauncherAppState access

Bug: 186712316
Bug: 187140897
Test: Manual
Change-Id: I045930b007e5dc015320224a197eee20a8354d17
2021-05-20 21:37:28 +00:00
Lucas Dupin 0c6341af99 Make launcher opaque when scrim becomes opaque
This will help with overdraw, because we don't need to draw the
wallpaper.

Test: manual
Test: adb shell dumpsys SurfaceFlinger --timestats -dump
Bug: 187703092
Change-Id: I2ebae94725578e5f4d640cd6b45da3f4d1f21a20
2021-05-20 14:33:39 -07:00
Steven Ng 400493c70c Apply android:attr/dialogCornerRadius to widgets picker dialog top corners
Test: Open full & bottom widgets picker and observe the top corners.
Bug: 188651333
Change-Id: If091e2d760042582bb98cbd3e44663542098ecd9
2021-05-20 22:05:29 +01:00
Pierre Barbier de Reuille 1b8bbb6c40 Correct size of AppWidget for color extraction.
Correct the size of the App Widget: first, compute the size when the
widget is positioned (it wasn't done), then do not apply the
transformation when computing the size of the widget when drawn.

Note: Somehow, there is a shift by 1 on the position on the x axis, both
in landscape and portrait. So I added a +1 to get the exact same values.
If not, we have a risk of getting different colors.

Fix: 188759989
Bug: 187907544
Test: Added logs and moved a widget by hand, check the actual
coordinates with hsv.

Change-Id: Ia3bd5b3e3ea9a3ef75f8cdf466a9800786646a94
2021-05-20 21:02:30 +01:00