Commit Graph

12718 Commits

Author SHA1 Message Date
Hyunyoung Song 7cc29dc44d Fix RecyclerViewFastScroller bugs, hide keyboard
Bug: 189982238
Bug: 187561242
Bug: 187909098

Test: manual
Change-Id: I693810e5761004c48d028253c25a2fe96477af40
2021-06-11 09:43:10 -07:00
Stevie Kideckel 2dab912b95 Use LayoutManager.onLayoutCompleted as a signal that content has changed
onChildAttachedToWindow is called before the layout manager is finished
processing the layout, so incorrect measurements / intermediate
animation states can be present.

onLayoutCompleted occurs after each full layout calculation, including
measuring multiple views or animating, and is a better signal to use.

Fix: 190391539
Test: verified locally with search use case and other expand collapse
cases

Change-Id: If01caf33c6c3371636895e1361d80de536363239
2021-06-11 16:40:49 +00:00
Anton Hansson 8b780d8517 Merge "Revert "[AllApps][Work] Introduce work toggle Fab"" into sc-dev am: 17ef90b2cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14939015

Change-Id: I47bd374d48ee1cdbdc69b4cb3504296c7d475396
2021-06-11 15:13:08 +00:00
Anton Hansson 17ef90b2cb Merge "Revert "[AllApps][Work] Introduce work toggle Fab"" into sc-dev 2021-06-11 15:02:25 +00:00
Anton Hansson fc235903ab Revert "[AllApps][Work] Introduce work toggle Fab"
This reverts commit 08cca82eca.

Reason for revert: broke errorprone build
Bug: 190150515

Change-Id: I1d8707392310e745713b8780bdb957299b88a3a6
2021-06-11 14:05:07 +00:00
Jonathan Miranda 6247cf8a68 Merge "Folder preview polish." into sc-dev am: 65c20f4a91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14912724

Change-Id: I7f9abd7f390c7bec329b8600faa051d162e68d1d
2021-06-10 23:24:35 +00:00
Jonathan Miranda 65c20f4a91 Merge "Folder preview polish." into sc-dev 2021-06-10 23:11:06 +00:00
Cyrus Boadway 2668e731a0 Add activity-start/return animation to widget configuration
When launching the configuration activity for a widget, use the
activity transition animation.

Test: manual
Bug: 190487998

Change-Id: Ife84e86eec74f81fecddce07c833356a7962fd4b
2021-06-10 21:37:04 +00:00
Cyrus Boadway 9f06168692 Use the splash screen background color as the fallback background color
For the widget transition animation fallback background color, use either
the splash screen background color if a task is starting or the task
description-attached background color.

With a background in place, allow the window to fully fade out before
fading in the widget, by moving the window alpha math into an animation
factory-specific implementation.

Bug: 187706750
Test: Manual
Change-Id: I2b5a7783b0585d447ad60534bc48d2e2176877ed
2021-06-10 21:03:24 +00:00
Alina Zaidi e908dbba29 Merge changes I5d1c9e4b,I08154c94 into sc-dev am: 1fbf9200f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14899453

Change-Id: I2ad1c6fd6c70d06f3aea57b465cddb107f4aba2e
2021-06-10 20:59:43 +00:00
Alina Zaidi 1fbf9200f1 Merge changes I5d1c9e4b,I08154c94 into sc-dev
* changes:
  Flip ArrowTipView when it goes beyond screen height.
  Add more education tips for widgets. (3/3)
2021-06-10 20:46:20 +00:00
Santhosh Thangaraj 192924459b Fix the page number based Seen impression.
Test: On device.
Bug: 183117427
Change-Id: Ic1b11fb7630f60f11387951749420653aa3f0c8a
2021-06-10 20:44:09 +00:00
Jon Miranda 32ff76cb4e Adding color back to popup container.
For Color exctraction now occurs in groups:
- System shortcuts
- Deep shortcuts
- Notifications

For home setting popup, each DeepShortcutView will have its own
extracted color.

Bug: 188095443
Test: manual
Change-Id: I7e209f863ff180b8f017aeb2a73c6f1a51842e68
2021-06-10 19:15:24 +00:00
Steven Ng 9c6b9c311d Merge "Fix height estimation of the widgets recommendation table" into sc-dev am: d4bae086d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14937090

Change-Id: I64a55365b1e1a50104b6d4199c5a153f4bde3299
2021-06-10 18:30:24 +00:00
Steven Ng d4bae086d3 Merge "Fix height estimation of the widgets recommendation table" into sc-dev 2021-06-10 18:11:45 +00:00
Steven Ng bc5099e9a6 Fix height estimation of the widgets recommendation table
There are two vertical paddings
1. Table padding
2. Widget cell padding

We haven't taken account the widget cells padding

Test: Manual
Bug: 189814077
Change-Id: I9b1dc9e880d4402b9c461d0024a0748c0afc408a
2021-06-10 16:57:40 +01:00
Stevie Kideckel 1059c30f3a Account for header margin depending on which header is selected
This removes jitter from incorrectly counting or not the margins for the
headers near the top of the widget picker list.

Bug: 189956230
Test: verified locally
Change-Id: I3eeddbf8a1fb7cca31fe2a12c28b0eb444de631b
2021-06-10 15:29:46 +00:00
Alina Zaidi dca47432fc Flip ArrowTipView when it goes beyond screen height.
Bug: 185354491
Test: Manually tested tips in widget picker, all apps, and
reconfigurable widgets tip.

Change-Id: I5d1c9e4b8bc3ae89834bc198016ffa409a2b28ad
2021-06-10 15:43:30 +01:00
Alina Zaidi ecdf6575ec Add more education tips for widgets. (3/3)
Show tip on reconfigurable widget in launcher.

Bug: 185354491
Test: Manually tested tips in widget picker, all apps, and
reconfigurable widgets tip.

Change-Id: I08154c944285cac6a21c3ef4aafd878bbbccf44b
2021-06-10 14:23:47 +01:00
Takeshi Hagikura 43d53432aa Update the colors of the tabs of work profile pagination
Update the tab colors based on the discussion in the bug and the
design mock.
Rename the color/all_apps_tab_bg to
color/all_apps_tab_background_selected to make the usage of the color
explicit.
(Confirmed it's only used for the color of the selected tab)

Bug: 189488670
Test: Visual inspection
Change-Id: I6ac38f71a8dd8852e1ab2e70f2f8434e9101daa1
2021-06-10 18:55:59 +09:00
Hyunyoung Song 93652af586 Merge "Revert the squish translate from all apps" into sc-dev am: 8f3d9eba02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14921510

Change-Id: I334d8dce46078223f7302e4dfdcafa9727e57230
2021-06-10 04:07:27 +00:00
Hyunyoung Song 8f3d9eba02 Merge "Revert the squish translate from all apps" into sc-dev 2021-06-10 03:53:33 +00:00
Samuel Fufa b21f9d8c08 [AllApps][Work] Introduce work toggle Fab am: 08cca82eca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14724697

Change-Id: Ie775dacc94be5295329f7dd2c20908eed4c099fd
2021-06-09 19:58:42 +00:00
Samuel Fufa 08cca82eca [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: I69ffa0ef367b182688e69c730fc9dee1afa7cadd
2021-06-09 17:13:07 +00:00
Jon Miranda f564b65f2a Folder preview polish.
- Fixes notification dot not aligning in 4x5 grid
- Fixes clipping issues with large folders
- Fixes clipping issues with preview item animations

Bug: 188095988
Test: manual

Change-Id: I6821b3cb3c65e5928c7be1cddd7f292a37842698
2021-06-09 10:04:39 -07:00
Hyunyoung Song afa327d176 Revert the squish translate from all apps
Bug: 189973274
Bug: 189975416

Test: manual, attached video on the bug
Change-Id: I881a2b79462e8d420b3dcb6a6b98adbe9e8e0394
2021-06-09 09:47:29 -07:00
TreeHugger Robot bf9b2ca0bd Merge "Fix wrong highlighted personal | work tab" into sc-dev am: 962b212c9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14904550

Change-Id: I4921e484d4762ca2a6425613eef58e4243c04acf
2021-06-09 03:03:57 +00:00
TreeHugger Robot 962b212c9e Merge "Fix wrong highlighted personal | work tab" into sc-dev 2021-06-09 02:41:40 +00:00
TreeHugger Robot 7e019e8a47 Merge "Re-enable swipe up view inflation test." into sc-dev am: 93e232a57b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14848883

Change-Id: I0833ea17df3ef812c13168f3c503ae7b90586078
2021-06-09 01:06:26 +00:00
TreeHugger Robot 285c50740a Merge "[AA+] Reset search manager when exiting all apps." into sc-dev am: e57006fe63
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14804874

Change-Id: I074e33f790758400825ee4aa34f9628207d71f96
2021-06-09 00:52:10 +00:00
TreeHugger Robot 93e232a57b Merge "Re-enable swipe up view inflation test." into sc-dev 2021-06-09 00:47:11 +00:00
TreeHugger Robot e57006fe63 Merge "[AA+] Reset search manager when exiting all apps." into sc-dev 2021-06-08 21:50:31 +00:00
Sunny Goyal 1721ccf385 Simplifying the drop animation code
> Removing some unused parameters

Bug: 190524398
Test: Manual
Change-Id: Iea0c2e7a9d30a10fd7443ea57992c59ea60badf8
2021-06-08 14:43:57 -07:00
zakcohen 284eef2bf9 Re-enable swipe up view inflation test.
Disable chips by default as they are not plan of record for launch.

Bug: 141579810
Test: Local and ran test
Change-Id: Iae270c6ac4bbec4f7c29b1137cf926383443e85e
2021-06-08 14:24:20 -07:00
Steven Ng ccaa1c2c4a Merge "Use WidgetSizes to estimate widget size instead of custom calculation" into sc-dev am: 4716ab3037
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14881309

Change-Id: Ib8aaaf71f69c669c42692ee11aecf6d73fa4cd1a
2021-06-08 19:12:17 +00:00
Steven Ng 0ed1b41464 Merge "Exact widget sizes functionalities into an utility class" into sc-dev am: 84fe7e3a1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14881307

Change-Id: I5202727f975ce463179674cd54ba8d4b75063f9d
2021-06-08 19:12:12 +00:00
Steven Ng 4716ab3037 Merge "Use WidgetSizes to estimate widget size instead of custom calculation" into sc-dev 2021-06-08 19:11:25 +00:00
Steven Ng 84fe7e3a1e Merge "Exact widget sizes functionalities into an utility class" into sc-dev 2021-06-08 18:55:07 +00:00
Samuel Fufa e721f7272c Fix wrong highlighted personal | work tab
Bug: 189915880
Test: Manual
Change-Id: I3e8687038d4f0bfdd1c5b7d8c444520730a2bcd4
2021-06-08 13:31:40 -05:00
Steven Ng f8eca2008d Merge "Use grid size as the upper bound for widgets' default size in initSpans" into sc-dev am: eb1617521c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14776609

Change-Id: Ic74b543e4fb94ab377472cb5d8e25fe449818081
2021-06-08 15:06:03 +00:00
Steven Ng eb1617521c Merge "Use grid size as the upper bound for widgets' default size in initSpans" into sc-dev 2021-06-08 14:48:29 +00:00
Steven Ng 1d47d8c705 Use grid size as the upper bound for widgets' default size in initSpans
Test: In Pixel 4, drag a monthly view Google calendar widget to a new
      home page from the full widgets picker. The widget outline is
      correctly shown.
Bug: 189060113
Change-Id: I33113b29cc8923098de95f1d5eb14c2b02429de1
2021-06-08 14:15:50 +01:00
Steven Ng 7e06df2b50 Use WidgetSizes to estimate widget size instead of custom calculation
Also fix 2 bugs in WidgetCell
1. preview layout: padding is added to the AppWidgetHostView rather
   than the preview container. We shouldn't add padding to the size
   of the preview container.
2. widget_preview_shortcut_padding is a padding added to shortcuts but
    not widgets.

Test: Open full widgets picker and observe widgets are rendered
      correctly in the widgets recommendation table. Also, observe
      the generated bitmap images are correctly rendered.
      Run AddWidgetTest.
Bug: 189975670
Change-Id: I00db3200e0b61dc5e82f3c4bfdf34e197ea20314
2021-06-08 11:48:11 +01:00
Steven Ng 22b6039270 Exact widget sizes functionalities into an utility class
Test: resize widget, move widget, add widget.
Bug: 189975670
Change-Id: Ia0bc2297891e1cfa33697e985064db5d1dcdfc8b
2021-06-08 11:42:48 +01:00
Stevie Kideckel 51d27b8dda Merge "Fix accounting for the position/offset of headers with collapsing views" into sc-dev am: acf27b6d64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14881294

Change-Id: Ib539fc02df7b9c967aae919fab5dc864a4ece06a
2021-06-08 08:56:41 +00:00
Stevie Kideckel acf27b6d64 Merge "Fix accounting for the position/offset of headers with collapsing views" into sc-dev 2021-06-08 08:37:25 +00:00
Stevie Kideckel fd9bfd3aab Fix accounting for the position/offset of headers with collapsing views
The offset should be taken before views are modified, the position
should be taken after. This fixes an off by one issue when expanding a
header below another already expanded header.

Bug: 183378651
Test: verified locally
Change-Id: I4987d57846d7bcde23b76280f800f19350b3521e
2021-06-08 07:08:42 +00:00
thiruram ea56f849c2 [AA+] Reset search manager when exiting all apps.
This is required to log search session exits properly, especially when exiting AllApps without clearing search query.

Bug: 178562918
Test: Manual
Change-Id: Id4c1007b051e9efd9ae5929c274a70cf3ae3cbf1
2021-06-07 17:14:24 -07:00
Tony Wickham 3f25e91586 Have AlphaUpdateListener update visibility in onAnimationEnd() am: 26ab4621ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14882859

Change-Id: I48b55edefe3e6a77851ff9d903cf0af56e604ece
2021-06-08 00:10:26 +00:00
Tony Wickham 26ab4621ce Have AlphaUpdateListener update visibility in onAnimationEnd()
Previously we were only updating visibility in onAnimationSuccess(), which doesn't handle the canceled case.

Test: swipe up from nav bar twice in all apps, ensure all apps is invisible/non-interactable
Bug: 190315266
Change-Id: Ic59e6d4b404de4ee2d17c45d6fa59e2aee70c65f
2021-06-07 22:16:22 +00:00