Commit Graph

12718 Commits

Author SHA1 Message Date
Alina Zaidi eefccccb19 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev 2021-07-01 11:10:26 +00:00
Steven Ng d9128413cc Merge "Fix widget animation truncated at drop if a widget is resized" into sc-dev 2021-07-01 10:29:49 +00:00
Pierre Barbier de Reuille 41f78f1e13 resolve merge conflicts of 25e37a85ae to sc-v2-dev
Change-Id: I78062d68d051a5f3c369214929f569b17c5a3471
Fix: 192532604
Bug: 192354264
Test: Manual
Merged-In: If573641e4bb5a98ed6b5008e00f70f4bbe492c24
2021-07-01 09:47:10 +00:00
Steven Ng 39a87fda17 Fix widget animation truncated at drop if a widget is resized
Set the widget outline to DragView rather than the content view
hosting a Picture record of AppWidgetHostView at drop.

Bug: 191646816
Test: Manual
Change-Id: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
Merged-In: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
2021-07-01 09:22:25 +00:00
Alina Zaidi 1b5efa3216 Reduce margin for DropTargetBar to avoid buttons to be truncated.
Bug: 187036287
Test: Tested manually by QA testing team on 4X5 grid size
Change-Id: Iaa4cd3e464ccf50427a5aa96d97093601e1d2948
2021-07-01 09:50:46 +01:00
TreeHugger Robot 25e37a85ae Merge "Correct color extraction on App Widget drop." into sc-dev 2021-07-01 08:31:16 +00:00
Vinit Nayak 837359b1ea Set correct divider dimension for task menu options
Previously divider drawable dimension was set on height,
which only works when things are divided vertically.
For horizontal layouts, we need to set divider width.

Bug: 192398954
Test: Tested portrait + fake/real landscape
+ tablet

Change-Id: I5a63df9749bf37c3a563e923a1b4724aa17d9409
2021-07-01 02:05:42 +00:00
Jon Miranda 2cc33ed29a Cancel existing preview item animation during non-animated update.
Otherwise we end up in a bad folder icon state.

Bug: 191227370
Test: Drag icon out of folder bounds,
      Suddenly drop it so its forced to go back to the folder
      Close folder before the animation finishes

Change-Id: Ib751a8209d66c5e9772731fdc1d7f365ae47531a
2021-06-30 17:59:17 -07:00
Steven Ng 12b0dfb826 Fix widget animation truncated at drop if a widget is resized
Set the widget outline to DragView rather than the content view
hosting a Picture record of AppWidgetHostView at drop.

Fix: 191646816
Test: Manual
Change-Id: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
Merged-In: I901743f8ba392de37f3ef69ca386c4b36bfebd7f
2021-06-30 20:47:57 +00:00
Brian Isganitis e99ed7b9d1 Merge "Intercept touch events for launcher preview root view" into sc-dev 2021-06-30 20:36:55 +00:00
Yogisha Dixit ba28286260 Merge "Log widgets source." into sc-dev am: f9acf1d5d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14690879

Change-Id: I2fa39b66ca31549f7754657b7d3bde6bdf8a5f59
2021-06-30 18:33:44 +00:00
Yogisha Dixit f9acf1d5d4 Merge "Log widgets source." into sc-dev 2021-06-30 18:18:12 +00:00
Pierre Barbier de Reuille 43e17301c4 Correct color extraction on App Widget drop.
Disable color extraction on drop until the workspace is back to its
normal size, then re-enable it and force re-coloring. This needs to
happen if the drop is on the workspace, but also if the drop is on the
secondary target.

Fix: 192354264
Test: Manual, see bug for details.
Change-Id: I79203f68843d59384503aa76f4813d886e98afa3
Merged-In: If573641e4bb5a98ed6b5008e00f70f4bbe492c24
2021-06-30 18:50:41 +01:00
Yogisha Dixit 658c5dafd4 Log widgets source.
Test: manual
(1) Upgrading to new DB version is successful (no errors thrown in logcat)
(2) Widgets that were added with the old DB version have CONTAINER_UNKNOWN as their source container
(3) Widgets that are added with the new DB version still log source container after reboot
Bug: 185778648
Change-Id: Iaa38f0be6bc4cb0d29842f9a2ea0d08de000c930
2021-06-30 17:48:14 +00:00
Cyrus Boadway f5f23ba119 Merge "Defer onColorsChanged updates during widget-to-home animation" into sc-dev am: 1edaed8790
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147896

Change-Id: I93c3c42dc173182c7625dea719bbc540a544234a
2021-06-30 17:24:57 +00:00
Cyrus Boadway 0d96baec13 Defer onColorsChanged updates during widget-to-home animation
Color change updates recreate the view, which can interfere with the
widget-to-home return animation, specifically the GhostView's use of the
AppWidgetHostView's render node.

Deferring the application of color changes until the end of the
animation allows the widget to settle and remove the GhostView before a
color change might recreate the widget's view.

Bug: 190818220
Test: manual
Change-Id: I6552e583ebb0e4810077d4e70fe9ecb07fd5d01a
2021-06-30 13:10:02 +00:00
Alex Chau f35a887446 Merge "Snap to relative position to snappd task when dismissing" into sc-v2-dev 2021-06-30 10:24:11 +00:00
Hyunyoung Song 6eee4e4f3d Merge "Rebind recycler views if launcher activity restarted" into sc-dev am: 77c532d799
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15136464

Change-Id: Iaa257f243aac6c2378a89102ab9bbae2d412d500
2021-06-30 04:20:04 +00:00
Hyunyoung Song 77c532d799 Merge "Rebind recycler views if launcher activity restarted" into sc-dev 2021-06-30 04:00:23 +00:00
Jonathan Miranda 2178eedc6a Merge "Set elevation of popup and arrow to match. This ensures no shadow overlap." into sc-dev am: 26a485bb2a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15147164

Change-Id: I71252441a356c0119eeb94bdef36ab14d370b2a2
2021-06-30 03:08:23 +00:00
Jonathan Miranda 26a485bb2a Merge "Set elevation of popup and arrow to match. This ensures no shadow overlap." into sc-dev 2021-06-30 02:56:18 +00:00
Brian Isganitis 610e43f90e Intercept touch events for launcher preview root view
This change prevents any accidental touches on any widgets in the
preview.

Test: Tapping on launcher preview in wallpaper app should never activate
a widget.
Fix: 191623924

Change-Id: Iac7eab057ec33ff491365a993af75a0b06a27f7e
Merged-In: I98d462eca699cf368dcd5894f15584f280932ccc
2021-06-29 23:59:03 +00:00
Brian Isganitis 0aa22aaea1 Merge "Intercept touch events for launcher preview root view" into sc-v2-dev 2021-06-29 23:58:17 +00:00
Steven Ng 755c2c54c7 Merge "Use category icon for pending conversation widgets" into sc-dev am: d35dcdec05
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142493

Change-Id: Id2b6a1429d1b8f84e901fffc0e669c357888d9be
2021-06-29 23:16:56 +00:00
Jonathan Miranda 576e567f0f Merge "Fix bug where status bar was not set properly." into sc-dev am: 1b6a8b2255
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15146553

Change-Id: I1e4b057e8a5f75c823eb15a5539c3130ddb06183
2021-06-29 23:16:50 +00:00
Steven Ng d35dcdec05 Merge "Use category icon for pending conversation widgets" into sc-dev 2021-06-29 23:15:04 +00:00
Jonathan Miranda 1b6a8b2255 Merge "Fix bug where status bar was not set properly." into sc-dev 2021-06-29 23:03:15 +00:00
Jon Miranda fa73c02172 Set elevation of popup and arrow to match. This ensures no shadow overlap.
Bug: 191823198
Test: long press app where arrow is on top and bottom in:
      workspace, all apps, and search UI

Change-Id: Icc4ac259607175d5e12447a844ba166ba28b74af
2021-06-29 15:49:46 -07:00
Hyunyoung Song 0b9537e6fc Rebind recycler views if launcher activity restarted
Bug: 185038312
Test: manual
TL;DR;;
What was attempted but was too much refactoring of the code.

Failed attempt #1: try re triggering the search.
This was not trivial as SearchSession object is yet created.

Failed attempt #2: Restoring AdapterItems in AlphabeticalAppsList
This meant AdapterItems class and also it's children
had to extend Parceleable object.

Ultimate fix:
Original issue of dupe view id among slice and work recyclerview
should be fixed. And restoring should just work.

Change-Id: I1bddd6aa5bc736ade3b02f69aa947d64cfa467d6
2021-06-29 14:52:57 -07:00
Jon Miranda 401b921c19 Fix bug where status bar was not set properly.
- Need to check both alpha of the view, and alpha of the background color.

Bug: 187467559
Test: check status bar colors when using:
      - on white wallpaper,
      - on black wallpaper,
      - on wallpaper with white text
      - on wallpaper with dark text

Change-Id: Ie6f34d34dfa9dea716f95bd6a95125fbd650fc29
2021-06-29 14:23:55 -07:00
Yogisha Dixit ffd5acea77 Merge "Show resize frame when widget is added." into sc-dev am: 419ee4599e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/13956205

Change-Id: I318890ec7296fdd9f2176cf19e77898ed5acbf0e
2021-06-29 21:21:45 +00:00
Yogisha Dixit 419ee4599e Merge "Show resize frame when widget is added." into sc-dev 2021-06-29 21:07:34 +00:00
Brian Isganitis 3b39f3164b Intercept touch events for launcher preview root view
This change prevents any accidental touches on any widgets in the
preview.

Test: Tapping on launcher preview in wallpaper app should never activate
a widget.
Bug: 191623924

Change-Id: I98d462eca699cf368dcd5894f15584f280932ccc
2021-06-29 16:07:16 -04:00
Samuel Fufa 42064e0d30 Merge "Update snackbar color" into sc-dev am: 48ec126d8b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15129885

Change-Id: Ib158406b7300fe1dcb77279cba80d764bc294e29
2021-06-29 19:05:06 +00:00
Alex Chau ba61b98fca Snap to relative position to snappd task when dismissing
- Calculate the diff to snapped page scroll and apply in onLayout, so tasks won't jump after dismiss when not in snapped position
- In grid, always keep the relateive snapped page unchanged to avoid jump

Bug: 188793333
Test: manual
Change-Id: Id11c2d700dc55440de39cc7409d06a712cedc9bc
2021-06-29 19:54:21 +01:00
Samuel Fufa 48ec126d8b Merge "Update snackbar color" into sc-dev 2021-06-29 18:48:38 +00:00
Alina Zaidi dd0b46e6db Merge "Make sure search recycler view is bound to fast scroller if user is in search mode at the time of attachment of work/personal recycler view." into sc-dev am: 7ed32025f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15142492

Change-Id: I19abded4e3e36cf1adf9ba9185b7debb543fd54d
2021-06-29 18:30:16 +00:00
Alina Zaidi 7ed32025f1 Merge "Make sure search recycler view is bound to fast scroller if user is in search mode at the time of attachment of work/personal recycler view." into sc-dev 2021-06-29 18:13:23 +00:00
Yogisha Dixit 037a5362d8 Show resize frame when widget is added.
I referenced the code in Workspace.java that updates the widget view's
layout params before showing the resize frame.

Test: manual, AddWidgetTest and AddConfigWidgetTest tapl tests
Bug: 183437963
Change-Id: I6655917878fa22d6084b4bf39fc0661e7278d6f9
2021-06-29 18:25:38 +01:00
Steven Ng 12f7a59e5c Use category icon for pending conversation widgets
Fix: 192333050
Test: Manual
Change-Id: Ie3895cd4747f1bec1c8ca9af82347bb0eafa7415
2021-06-29 18:04:09 +01:00
Alina Zaidi 57973c328a Make sure search recycler view is bound to fast scroller if user is
in search mode at the time of attachment of work/personal recycler view.

Bug: 191980945
Test: Tested manually.
1) Open widget picker, scroll.
2) Enable dark mode, scroll.
3) Type search query, scroll.
4) Disable dark mode, scroll.
5) Have work profile in phone and repeat the above with work tab open
and search.

Change-Id: I106717091a88868c4bbe3fad0dd71c8344e9c8ed
2021-06-29 16:32:32 +01:00
Steven Ng 4edea3a6a6 Set the widgets pickers' width to at most 80% of screen width on
large screen devices

Test: Phone: Open the full widgets picker and observe the width of
      the widgets picker fills the device screen width.
      Large screen devices: Open the bottom widgets picker and observe
      the width of the widgets picker only takes at most 80% of the
      devices' screen width.
      Same behavior is observed for bottom widgets picker.
Bug: 186425352
Change-Id: I801b73ea031a290fb6a7295dca826ac91841877e
2021-06-29 16:24:34 +01:00
Steven Ng 190471ff2d Merge "Set the widget preview title a11y text to "{widget name} widget"" into sc-dev am: 9bb83f65cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15127003

Change-Id: I6962b6c720359677764bdbde507b2a6aaae801f1
2021-06-29 14:41:27 +00:00
Steven Ng 9bb83f65cb Merge "Set the widget preview title a11y text to "{widget name} widget"" into sc-dev 2021-06-29 14:25:13 +00:00
Steven Ng 85486d1c2c Set the widget preview title a11y text to "{widget name} widget"
Fix: 187376680
Test: Manual
Change-Id: I211d8e2b437091808d1f5a764075af4c3832ef48
2021-06-29 12:12:43 +01:00
Steven Ng b14a7a2d16 Merge "Extract common measurement in widgets pickers to its base class" into sc-dev am: 9f2674b6a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15114084

Change-Id: If0e29d3c3d9461b0c222fb9ca826f253733cf0a1
2021-06-29 11:02:12 +00:00
Steven Ng 9f2674b6a9 Merge "Extract common measurement in widgets pickers to its base class" into sc-dev 2021-06-29 10:45:58 +00:00
Yogisha Dixit 57a6f10e40 Merge "Don't show resize handle if widget cannot be resized." into sc-dev am: 9b8932f579
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15114085

Change-Id: Iff6ecb28dfb972b347faab76c757c8c3ec955d87
2021-06-29 10:13:54 +00:00
Yogisha Dixit 9b8932f579 Merge "Don't show resize handle if widget cannot be resized." into sc-dev 2021-06-29 09:59:40 +00:00
Yogisha Dixit ad68318048 Don't show resize handle if widget cannot be resized.
Test: manual
Bug: 190015493
Change-Id: Ibb0cc347103b8d01d30a19925f929617426e4889
2021-06-29 09:08:09 +01:00