Commit Graph

4910 Commits

Author SHA1 Message Date
Tony Wickham 0baf062698 Add TaskbarControllers#runAfterInit()
And use it in TaskbarModelCallbacks#commitItemsToUI(), which in rare cases can run during init() before other controllers (namely TaskbarStashController) have been initialized.

Test: call commitItemsToUI() in TaskbarModelCallbacks#init(), ensure no crash
Fixes: 204847702
Change-Id: Ib9df3ea91d41c76ad1d3392e43b444b8b4a91374
2021-11-24 19:18:12 +00:00
Tony Wickham a930bca528 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev am: b4aefc1277 am: cc6b8488bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16325264

Change-Id: I7c71ae9aa8c949907286c31a2e6c75871e599ec7
2021-11-24 18:27:32 +00:00
Tony Wickham b4aefc1277 Merge "Stash taskbar when IME is present, including during gestures" into sc-v2-dev 2021-11-24 17:54:18 +00:00
Alex Chau ad83e8aed1 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev am: 226bd5b973 am: c28e01c0a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16330423

Change-Id: I2ca737b2d37e0c0de26e6e60f689f621af0dc485
2021-11-24 10:54:17 +00:00
Alex Chau 226bd5b973 Merge "Fix grid layout problem after going back from split select" into sc-v2-dev 2021-11-24 10:32:46 +00:00
Tony Wickham 821e37b447 Stash taskbar when IME is present, including during gestures
- SysUI removes SYSUI_STATE_IME_SHOWING when starting a gesture from an app, but because unstashing has implications on the gesture transition (e.g. clips the bottom of the app), we defer handling the ime hiding until the gesture settles. Repurposed the flow that swaps the taskbar background during the gesture to support this case as well.
- Delay the unstash when IME is closing, to align with the end of the IME exit transition
- Remove TaskbarViewController.ALPHA_INDEX_IME now that we stash when IME is opening, since stashing already hides the taskbar icons
- Also support passing a starting progress to the stashed handle reveal animation, to allow it to be reversed when cancelled. For example, when returning to an app that has IME showing, we first start unstashing because we're in an app, but then we get the signal that IME is attached so we stash again almost immediately (within a frame or two).

Test: In both 3 button and fully gestural, open a keyboard in an app, ensure taskbar gets out of the way and then reappears at the end when the keyboard is dismissed
Bug: 202511986
Change-Id: I93c298a98ba369ea6310466ff3f802231c582687
2021-11-23 16:37:06 -08:00
Winson Chung 2685dba8a8 Merge "Prevent setting launcher layer has opaque when there is content behind" into sc-v2-dev am: 2919653136 am: ee70dafcf0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16326556

Change-Id: Id9ee656b43f892ddcd3168527c70d5dcdab5a7ff
2021-11-23 23:35:54 +00:00
Winson Chung 2919653136 Merge "Prevent setting launcher layer has opaque when there is content behind" into sc-v2-dev 2021-11-23 23:04:01 +00:00
Winson Chung cc60ff2fff Merge "Removing logs" into sc-v2-dev am: c1afaa4042 am: c0098a8628
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16248600

Change-Id: Id59fc54915e3f0c54d38904dff7c62d3c937e028
2021-11-23 22:23:39 +00:00
Winson Chung c1afaa4042 Merge "Removing logs" into sc-v2-dev 2021-11-23 21:58:14 +00:00
Vinit Nayak 9119e1fab3 Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev am: 458832c09e am: f36ba262a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16301835

Change-Id: I8fbd6a4122cd1741f7e0c6a6842b0726ca9ec9cf
2021-11-23 20:33:28 +00:00
Vinit Nayak 458832c09e Merge "Show multiple App Info A11y options for split app icons" into sc-v2-dev 2021-11-23 20:09:47 +00:00
TreeHugger Robot 16c822788f Merge "Add scrim below TaskMenu" into sc-v2-dev am: db5f5f05e7 am: 65715599ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16321951

Change-Id: I9fc1e9a797f9eea85984e4da597d8c3e50223d47
2021-11-23 19:50:55 +00:00
Winson Chung bd65d56958 Fix issue with Shell listeners being unbound if SysUI is restarted am: 34e384d2e1 am: c9a2a042e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16326990

Change-Id: I83e77be29eaf63cd5a1c54fde7a36612f328962c
2021-11-23 19:50:38 +00:00
TreeHugger Robot db5f5f05e7 Merge "Add scrim below TaskMenu" into sc-v2-dev 2021-11-23 19:29:00 +00:00
Fedor Kudasov 220f135d88 Merge "Annotate getMaxRadius" 2021-11-23 16:53:07 +00:00
Alex Chau 460638e5ef Fix grid layout problem after going back from split select
- Don't reset mFocusedTaskViewId when focused task become split, so it's reset properly when it's added back to RecentsView
- Moved applySplitScrollOffset to RecentsViewStateController to be called after mSplitHiddenTaskView is added back to RecentsView
- Update scroll after going back from split
- Don't reset mSplitHiddenTaskView's translation as it'll clear the grid translations

Test: manual
Bug: 181707736
Change-Id: I4bd204fc537ee520216f875b3eddf4dc94f7bfd8
2021-11-23 16:07:25 +00:00
TreeHugger Robot 8f1e15edab Merge "Revert "Sending broadcast message when home screen is ready."" 2021-11-23 15:31:46 +00:00
Fedor Kudasov 804dd0a2e1 Annotate getMaxRadius
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I9a3561f415fa5a20167002e42f7fe41b60b3dc9c
2021-11-23 14:20:54 +00:00
Stefano Galarraga d4c6ecdca6 Revert "Sending broadcast message when home screen is ready."
Revert "Receiving a broadcast message when home screen is ready."

Revert submission 16169565-b/199120420

Reason for revert: Breaking Build (b/207471332)
Reverted Changes:
Ibc101a249:Receiving a broadcast message when home screen is ...
I18628552a:Sending broadcast message when home screen is read...

Change-Id: Ib29eae2d58c9ae2e3002c0fa18265c6767733e22
2021-11-23 13:25:21 +00:00
Thales Lima f316a267d8 Add scrim below TaskMenu
When opening a menu, a scrim with 80% alpha should be shown on top of
Recents view.

Align task menu second row with icon: when the menu shows up in the
bottom row in landscape, the menu should be aligned on the second row.

TODO: there is a RTL bug that I'm waiting because it also affects other
parts, not only this menu.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: I6846ee937cb5e739e8be64d17045bc3b32e28e46
2021-11-23 09:13:25 -03:00
Raj Garg b4bc22fd33 Merge "Sending broadcast message when home screen is ready." 2021-11-23 08:51:46 +00:00
Winson Chung 34e384d2e1 Fix issue with Shell listeners being unbound if SysUI is restarted
- If SysUI is restarted (ie. during dev or a crash), the components
  registering the shell listeners may not be aware of this, and
  listener callbacks will not be re-registered.  Currently all the
  listeners are managed correctly (bound & later unbound) so we can
  just keep the active listener references to re-register if this
  happens.

Bug: 207142749
Test: Kill SysUI, start some apps and ensure Launcher still shows them
      in recents
Change-Id: Iba3b11ee972caf8f0b482942d38c3a7359211180
2021-11-23 08:04:14 +00:00
Winson Chung 6526973952 Prevent setting launcher layer has opaque when there is content behind
- This can prevent the layered content behind to not be visible (and
  since launcher draws a cutout and the wallpaper isn't shown, may
  result in a black rect.  We only specialize for this case while
  Launcher is in Overview.
- Also don't need to defer updating drawsBelowRecents, this can result
  in the state not being reflected since it runs after the last update
  of the transform params

Bug: 205789573
Test: Swipe up from app and ensure behind layers are visible (also
      ensure this doesn't affect blur during the swipe or optimizations
      after you leave overview)
Change-Id: I07689b3d9b65708797576e5fbefe12fb1f544119
2021-11-23 05:21:31 +00:00
TreeHugger Robot 699c650c70 Merge "Invoke Assistant on 3 button long click on Taskbar" into sc-v2-dev am: 0b7ed895e7 am: 4b3006da4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308573

Change-Id: I80c2bfa548c054adb89e1a5f6d9f90cb547cf9bc
2021-11-23 04:08:39 +00:00
TreeHugger Robot 0b7ed895e7 Merge "Invoke Assistant on 3 button long click on Taskbar" into sc-v2-dev 2021-11-23 03:34:04 +00:00
Vinit Nayak bca13abc82 Invoke Assistant on 3 button long click on Taskbar
Bug: 204273914
Change-Id: I757fa40ad9ac0ace44b57c7dd08ec30b4c0ae6d0
2021-11-22 17:32:16 -08:00
Winson Chung 2d6773308b Merge "Skip scheduling frame callback if view root is already detached" into sc-v2-dev am: a5642379d9 am: 52d5ec0143
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308550

Change-Id: I933701209dd655633e7df709c0a67aa0eb72abe8
2021-11-23 01:11:54 +00:00
Winson Chung a5642379d9 Merge "Skip scheduling frame callback if view root is already detached" into sc-v2-dev 2021-11-23 00:41:30 +00:00
Tony Wickham 329d07d91d Merge "Add support for dark tint on taskbar nav buttons" into sc-v2-dev am: 426b021e22 am: 7a957e914e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16250063

Change-Id: I15f08a40e4414b410a1571b97284ada43d610747
2021-11-22 22:30:14 +00:00
Tony Wickham 426b021e22 Merge "Add support for dark tint on taskbar nav buttons" into sc-v2-dev 2021-11-22 22:05:35 +00:00
Alex Chau 7c6ef08dd2 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev am: 48644c75b3 am: 97c12c8b72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306378

Change-Id: Ib92ae0899d08411ce07ddac36cae0f6d4466723d
2021-11-22 21:36:00 +00:00
Alex Chau 48644c75b3 Merge "Consider launching task's position on screen in pivot calculation" into sc-v2-dev 2021-11-22 21:07:41 +00:00
Winson Chung 5290db66a8 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev am: 550dc8dc69 am: 1c0bced602
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16308385

Change-Id: I0a5e8451e1f415bcf92e31b8428c293f10e25b88
2021-11-22 17:43:01 +00:00
Winson Chung 550dc8dc69 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev 2021-11-22 17:22:16 +00:00
Alex Chau a0aa9ac6e4 Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev am: 3c2298668a am: 0c59f1ac7b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307753

Change-Id: I2c49271d01922df710d53f1d52090ed0c1593880
2021-11-22 11:35:51 +00:00
Alex Chau 3c2298668a Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev 2021-11-22 11:12:23 +00:00
Winson Chung e2074f01c0 Skip scheduling frame callback if view root is already detached
- Also remove references to deprecrated compat class

Bug: 206932656
Test: Presubmit
Change-Id: I1add65b0fe03dedea872d162e51095bf9c648acf
2021-11-20 00:58:43 +00:00
Winson Chung c2a84d887f Clear ref after animation if visual stashing not supported
Bug: 206814323
Test: Presubmit
Change-Id: Ia38bd2707edbddf1b1f2ad98b3cdac4c8c62a6d3
2021-11-19 23:52:18 +00:00
Winson Chung 87b70a6915 Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev am: 5e49df2bbe am: 616f181857
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307006

Change-Id: I0be97fe98b93085d7a1cc5bc145d17045a8c0989
2021-11-19 22:53:13 +00:00
Winson Chung 5e49df2bbe Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev 2021-11-19 22:24:13 +00:00
Jonathan Miranda 2a1dc00688 Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev am: 2d9ac4e67f am: 1b7ffc9b2b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307200

Change-Id: Ie97e5779a725271b5bc83d786b6482dfa111c518
2021-11-19 22:17:16 +00:00
Vinit Nayak 1c1dc23d9b Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev am: 54baaae0ab am: 01eab872ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16307108

Change-Id: I463b401308cd90be532c6419fe4a72990dcb19ea
2021-11-19 22:17:08 +00:00
Jonathan Miranda 2d9ac4e67f Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev 2021-11-19 22:05:07 +00:00
Vinit Nayak 54baaae0ab Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 21:51:03 +00:00
Zak Cohen d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Alex Chau af43216f0d Merge "Use only current density to check isTablet" into sc-v2-dev am: 7ba828c1a9 am: 8d3d6b1961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16306379

Change-Id: I66dd05d8c193cebfafa2095f986d8ea2bc3f9c57
2021-11-19 20:58:15 +00:00
Jon Miranda 1f2b9b1c36 Use empty intent instead of null when creating stub TaskKey
Bug: 199027804
Test: manual
Change-Id: Ie66c8740453088791e026fa51a2842f59c6c67fd
2021-11-19 12:06:42 -08:00
Vinit Nayak a59835214f Open taskMenu based on TaskIdAttributeContainer
* We were always passing in the same task no matter
which task icon was clicked.
* Use TaskIdAttributeContainer to associate
IconViews with their respective tasks

Fixes: 206154715
Test: Correct menu opens for split and fullscreen
tasks

Change-Id: I5f264bb69828532bdefffb7ec4b9ff1e501de086
2021-11-19 11:38:31 -08:00
Winson Chung a5960223cf Set sync applier on the transform params for the glued targets
Bug: 199043513
Test: Swipe up with split task and scroll really quickly
Change-Id: Ie10b27457903d8db4d4c973ab5b7e669da2c4998
2021-11-19 19:33:54 +00:00