Commit Graph

2463 Commits

Author SHA1 Message Date
Sunny Goyal 50884dadfe Lazily loading theme icons
Theme icons are generated and stored in cache, but only loaded if requested in lookup flags
This allows to keep the memory usage low, but not loading theme icons for all the apps

Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Updated tests
Change-Id: I494eab9c4f70670e6f5aeb864ed5287f6b9f1b9e
2025-03-31 13:07:03 -07:00
Sunny Goyal bdd3f29342 Using item inflater for predicted items and previews
Bug: 406668365
Test: Verified manually in picker
Flag: EXEMPT refactor
Change-Id: If8ca919a19b7d1b6cbdc33823a9f294df1afa968
2025-03-28 13:05:25 -07:00
Sunny Goyal 2201485e22 Merge "Using ItemInflator for inflating Folder instead of duplicating code" into main 2025-03-27 12:45:01 -07:00
Sunny Goyal 0479ff832c Using ItemInflator for inflating Folder instead of duplicating code
Bug: 406668365
Flag: EXEMPT refactor
Test: atest FolderTest
Change-Id: I63186ba620b5380edfc5e8cded253a85379a5d82
2025-03-27 09:48:46 -07:00
Sunny Goyal 3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF) 35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Sunny Goyal cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Treehugger Robot e0a018785e Merge "Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps" into main 2025-03-24 11:03:55 -07:00
Treehugger Robot d3e559a244 Merge "Add logging for which type of migration occurs." into main 2025-03-20 11:13:55 -07:00
Federico Baron c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Charlie Anderson 19c4a92ebc Avoid downgrading archived app icon when widget is restored and when apps are archived.
- Restored widget were requesting icons through iconcache, and overwriting the restored icon from restored db.
	- Manually archiving icons would delete icon in cache, we should instead reuse the icon from when it was installed.

Bug: 399649982
Test: Manually performing restore with apps, widgets and shortcuts.
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Change-Id: I4184af480f29eb3ef41173fe5edc5307f263d0b0
2025-03-19 21:28:37 -04:00
Federico Baron 896f1a66bf Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps
Flag: EXEMPT test only
Test: TaplUninstallRemoveTest#testUninstallFromAllApps
Bug: 386231522
Change-Id: Ic1f0f343153b2052438ea8ea6b9d84c429f844c1
2025-03-19 21:57:29 +00:00
Sunny Goyal 25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Treehugger Robot ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Treehugger Robot 313d7e1ce3 Merge "Revert "Add screenrecord for uninstallWorkspaceIcon"" into main 2025-03-10 13:36:11 -07:00
Federico Baron 8dcf879c14 Revert "Add screenrecord for uninstallWorkspaceIcon"
This reverts commit 66999f0a19.

Reason for revert: no longer an issue

Change-Id: I55a045846825e6b62fac4a9ed59380620870e953
2025-03-10 11:26:15 -07:00
Sebastian Franco aeb99f8d24 Moving zip rule to Multivalent to fix roboelectric test in A-studio
This fixes roboelectric test Running in Android Studio.

Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: Running roboelectric test in Android Studio
Change-Id: I903c6cea3c981a9c38cfcd05b54e4095b6fe2a8a
2025-03-07 11:56:45 -08:00
Sebastián Franco 2bab5687b0 Merge "Enabling Fixed Landscape in Launcher3 tests" into main 2025-03-06 15:06:03 -08:00
Treehugger Robot 3a000d06fa Merge "Revert "Ignore the tests temporarily."" into main 2025-03-06 13:09:43 -08:00
Federico Baron 7610b9c17f Revert "Ignore the tests temporarily."
This reverts commit de0d4498c8.

Reason for revert: b/353505773 seems to have rolled out 

Change-Id: I3ddcdb1b2de2cfd07e12af284f1f784996f82623
2025-03-06 10:58:12 -08:00
Sebastian Franco c9f6668ab1 Add all the dumpt test results into a zip in artifacts
Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: dump files should now be available in test artifacts
Change-Id: Ic77b75f7792bc511e364a6af697eb1282ad49ab3
2025-03-04 13:16:47 -08:00
Sebastian Franco 331fd2dac6 Enabling Fixed Landscape in Launcher3 tests
Bug: 398279312
Test: Any test using PortraitLandscapeRunner
Test: IntegrationFixedLandscape
Flag: com.android.launcher3.one_grid_specs
Change-Id: I5a1801374f39381e678e764f8e417cf0f8bf6ad7
2025-03-04 13:15:26 -08:00
Sunny Goyal 372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Treehugger Robot f42f516621 Merge "Remove unused spec in device_profiles.xml" into main 2025-03-03 17:24:20 -08:00
Federico Baron d8f0bed596 Remove unused spec in device_profiles.xml
Bug: 395912263
Flag: com.android.launcher3.one_grid_specs
Test: n/a, code cleanup
Change-Id: Ifd1ecf905427902f895a1b4e16711874fd52ddf3
2025-03-03 18:35:10 +00:00
Sunny Goyal 5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Federico Baron 66999f0a19 Add screenrecord for uninstallWorkspaceIcon
Bug: 399756302
Flag: EXEMPT TEST_ONLY
Test: TaplUninstallRemoveTest
Change-Id: I4bdf8087276a93f8f736c23ba95f35acb7f05c3a
2025-02-28 21:27:07 +00:00
Treehugger Robot 087e54c81c Merge "Removing temporary debug tracing" into main 2025-02-24 14:55:05 -08:00
Sunny Goyal b1fab90e26 Enforcing grid customization permission in manifest instead of code
Bug: 389173244
Test: Updated tests
Flag: EXEMPT manifest change
Change-Id: I0fee57f935156da6b2b5a612259db2c4b3605846
2025-02-24 10:40:43 -08:00
Sunny Goyal c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Sunny Goyal db724a010c Removing temporary debug tracing
Bug: 378167329
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: I06ed0d96a83c13b1bce9aff8e2e21fa1510bc4c2
2025-02-20 12:26:35 -08:00
Owner Cleanup Bot a5d9e8a600 Merge "[owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS" into main am: c3a2e87058 am: aa4f86641c
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490672

Change-Id: Ic91f4281f7e12f23046a7e739830c5d76dbeccb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-18 14:33:03 -08:00
Charlie Anderson 3487ef52f2 Merge "Temporarily disable shapes flag in image and device dump tests." into main 2025-02-18 10:14:11 -08:00
Charlie Anderson 24e65da8b3 Temporarily disable shapes flag in image and device dump tests.
Will re-enable after more shapes changes, as part of b/396211437

Bug: 396211437
Bug: 395952745
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit
Change-Id: Ib0c85167df2723632adce9dadae718a2a1b7b757
2025-02-14 15:14:19 -05:00
Anushree Ganjam 5a8fcc3d40 Merge "Refactor TestEmitter and it doesn't need to be MainThreadInitializedObject" into main 2025-02-14 10:35:40 -08:00
Anushree Ganjam 7128c6fcfb Refactor TestEmitter and it doesn't need to be MainThreadInitializedObject
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I30e7c3c165db698785e9e4d7e2256ab061ff71a2
2025-02-13 15:20:17 -08:00
Charlie Anderson 527be0c133 Temporarily disable shapes flag for tests that it breaks.
- when done with breaking changes will update tests as part of b/396211437

Bug: 395952745
Bug: 396211437
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit

Change-Id: I461f6834932a710efa439a112bce23359aee13de
2025-02-13 09:32:52 -08:00
Owner Cleanup Bot 40e6a538ab [owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I012d61af6b55dd1ae2f00be846af393bc7bc2f38
2025-02-11 16:03:09 -08:00
Sunny Goyal 5bca45a739 Moving InvariantDeviceProfile to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia99ee031e96c5e6069a56fe90a262a533dd8665a
2025-02-11 15:22:18 -08:00
Treehugger Robot d3b31eb20d Merge "Removing BaseDraggingActivity > Merging come methods to BaseActivtiy > Separating wallpaper theme implementation to an independent class" into main 2025-02-04 09:29:46 -08:00
Treehugger Robot f86a05eee2 Merge "Fix attempt for testAddAndDeletePageAndFling" into main 2025-02-03 20:46:21 -08:00
Sunny Goyal edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00
Federico Baron 1c1b130a4b Fix attempt for testAddAndDeletePageAndFling
it looks like the issue is that the layout has a widget on the second
page leading the page count to be different than expected

Bug: 381918059
Test: TaplWorkspaceTest#testAddAndDeletePageAndFling
Flag: TEST_ONLY
Change-Id: I19e475450494a5580e8fd04d02692624c086807c
2025-02-03 23:05:51 +00:00
Charlie Anderson 0905744966 Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons.
- includes loading icons for AllApps as archived apps show there as well

Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
2025-02-01 01:11:04 +00:00
Sebastián Franco cf060a9871 Merge "Remove screen record annotation from passing test" into main 2025-01-29 09:42:33 -08:00
Sebastian Franco 057f613d5b Remove screen record annotation from passing test
Fix: 322823478
Fix: 331261431
Test: TaplTestsLauncher3Test
Flag: TEST_ONLY
Change-Id: I5d744b20701ae9a97c4422616f13a5faa55c6c76
2025-01-28 18:54:39 -08:00
Charlie Anderson db9bb3c869 Merge "Convert UserCache to use Dagger" into main 2025-01-28 16:15:03 -08:00
Charlie Anderson e90282b317 Convert UserCache to use Dagger
Bug: 372012340
Test: Presubmit
Flag: EXEMPT Dagger Change
Change-Id: I36a0a3f56540c0515d99badc127c2ab8534e684e
2025-01-28 15:30:07 -05:00
Jagrut Desai b3bb1f1c4a Merge "Removing ScreenRecord from test" into main 2025-01-27 13:56:58 -08:00