The default value was not set. I decided to flip the variable to make
it more readable.
Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I7fb4bbdce45a14312e42abcf71f7f0643376ddc6
- Taskbar background will fade in based on
1. Velocity threshold
2. End target gesture destination
Bug: 298089923
Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Change-Id: I2c16352e1c0c52a8afc49900a39b80383bacde62
- In phone setup mode, gesture mode is no button but the inset we report should be setup inset
Fixes: 340998601
Test: https://screenshot.googleplex.com/8Q4WHorpUeqWSjw
Change-Id: I84d60ecc7179008e80e7b09eda5b3a1abb24e138
We already reached the limit of 32 flags for an int. To be able to have
more, changing from int to long.
This is needed, as new flags have to be added.
Flag: NONE
Test: Manually running SysUI and Launcher
Test: Unit tests in CL
Bug: 335625543
Change-Id: Iec1d40218264c7c64c50fd09764aa07c0caa7787
- Reverted the previous change. It doesn't fix the issue when launching setup mode with command line. The fact that it looked as if it's fixed from factory reset might be a fluke
- Found out that we unstash the task bar to home from setup somewhere in TaskbarStashController. This is related to stashed alpha only.
Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I04daf41ae9a1c3b7e6e4962dd4a8c62b708e0a54
FLAG_STASHED_SMALL_SCREEN is not updated after setup UI finishes.
Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I297e3b44f49f94ab5a1b9fe5ff16ff64c6cf2c0a
This change moves the IME flag to be part of FORCE_STASHED rather than
STASHED_IN_APP, since there are cases where we are not in an app but
still want to stash the IME.
You can still bring up transient taskbar over IME since we do not set
the IME flag for transient mode (see TaskbarStashController#shouldStashForIme() first guardrail).
Test: Manual
Flag: N/A
Fix: 336592511
Change-Id: Iafa32b1a52f4bfbc0d3a4e77b19c82149dc42d0a
* Remove Launcher state manipulation from `DesktopVisibilityController`
* Remove Taskbar state updates for desktop mode in
`LauncherTaskbarUIController`
* Update app widget animation for Home transision
* Update `RemoteTargetGluer` remote targets setup for Dekstop mode
Bug: 309014605
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_wallpaper_activity DEVELOPMENT
Test: manual
Change-Id: Ie2a7ad214a4d4e7e642d1236f2375ba6d17f3781
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.
Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps
Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
Fixed issue whereby taskbar background disappears as expected when the IME switcher is present, but does not appear again if the overview button is pressed after this state.
Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 297472865
Change-Id: If1074b28870c794db8a87dd6cd59f9656dc7c15d
Issue : Currently opposite jank is being reported taskbar expand and taskbar collapse
Test: Checked the trace
Fixes: b/326333977
Flag: None
Change-Id: Ib5adeb33506717ee28d669c5d46557087ebf7e60
Stash taskbar when
1) Software keybaord is docked
2) Input toolbar is placed at the taskbar area (stash so toolbar and taskbar would not overlap)
Testing result:
https://drive.google.com/file/d/1NMDexHl0FgyHFaOUh_GSEEUU2k08STJH/view?usp=sharing
Bug: 317251202
Test: TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Flag: N/A
Change-Id: I90662bc6e68f644e919f5c702059476b02519ed6
An alternative here is to use the root layer when NO_RECREATE flag is on. However, we do not have a reference to it here (shall we consider passing it in?)
Fixes: 325096498
Test: Need to verify
Change-Id: I1709bc88753a90547f7a61dc6e24cdaf489d19e0
Bug: 280497051
Test: Manual, turn on desktop windowing mode. Enter input mode in an app, drag it from the top to be window mode. Verify if taskbar is present
Flag: N/A
Change-Id: I31dc922c480cd0b39a64763155777b906e3bd14a
- Fixes case where handle is initially invisible but will be stashed
and visible, e.g. when launching an app from home screen
- To fix the original issue of sampling happening unnecessarily for
three button nav, also check supportsVisualStashing()
Fixes: 321257120
Flag: None
Test: Launch an app from home in gesture nav mode
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Change-Id: I1f26436de3081fd00f75a5921010e361e9a9f34e
Calling this ensures we update touchableRegion accordingly.
Since this will also start the stashed handle region sampling,
which we don't need for 3 button mode, also adjust logic to
check that the StashedHandleView is actually visible.
Flag: None
Test: Lock screen, run `adb shell cmd uimode night yes`, unlock
Test: Lock screen, rotate, unlock
In both cases, verify touchableRegion is accurate
Fixes: 315393203
Change-Id: I951af6b97cad0ee0f362dc22f3996cfd9286a21e
- The taskbar stashing logic with hardware keyboards was different
between tests and user experience; aligned the test to be the
same.
- There is still a previous test failure that only occurred in
post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.
Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
Unless hardware keyboard is attached and taskbar is pinned.
Fix: 316270741
Bug: 255818649
Test: Manual. Using combinations of transient taskbar, virtual and hardware keyboards.
Flag: NONE
Change-Id: I1fae1655fc16b9fa951510cf834d2a33cb8956d8
This is fundamentally caused by the phone device profile not having task bar related attributes, which crashes in icon alignment animation. We had resolved it by skipping this animation based on isPhoneMode check. However, we passed in launcherDp instead of taskbarDp (from TaskbarActivityContext) which doesn't always have the most up to date information in race conditions (e.g. repetitively fold/unfold)
Fixes: 311431054
Test: repetively fold/unfold, make sure it doesn't crash
Change-Id: I65f600112da4123d337b3f59a2fe6dd13ac7af74
In small screen, we use 48dp for nav bar height, while it's 60dp for task bar.
Bug: 230395757
Test: manual
Change-Id: Ia7083a1b2246981466e1163404c63b645a6bf5b1
So we recreate task bars when configuration is changed, if ENABLE_TASKBAR_NAVBAR_UNIFICATION = true. In order for unstashed state to propagate, we need to save STASHED_IN_APP_AUTO in TaskbarSharedState.
Fixes: 311429718
Test: Unstash the task bar in app, rotate, make sure the task bar stays unstashed
Change-Id: I7db773725ea89976612e9e91af5b6911d0ec5fc0
We rely on contentHeightToReportToApps and tappableHeightToReportToApps (that ultimately call into DeviceProfile) of TaskbarStashController to initialize the insets. However, DeviceProfile only initializes those values when isTaskbarPresent is true. Rather than completely changing the initialization of DeviceProfile, we special case in TaskbarStashController that uses the bar height for inset
Bug: 274517647
Test: turn on FLAG_HIDE_NAVBAR_WINDOW and TASKBAR_NO_RECREATION, make sure the insets are correct in both 3 button and gesture nav mode
Change-Id: I164a6e2c9f9d24888155b45325ee8ce46ca2c39f
This includes the previously added Taskbar System Action, as well
as a new one for Screen Search.
Bug: 299321919
Test: Manual
Change-Id: I4a8fa1dde402dc2de5f448cb2edbe712e128ff12
Bug: 284104811
Test: manual - enable 3 button nav
- expand a bubble in overview
=> observe that scrim is shown on top of taskbar and it
isn't stashed
- repeat with transient taskbar but instead it stashes
when bubbles are expanded in overview
Change-Id: I725513bb0015c85f26fb1eedbe22da5eb2612e55
Test: manual - have transient taskbar
- have a bubble
- go to overview
- expand bubbles
=> observe that transient taskbar stashes
- collapse bubbles
=> observe that transient taskbar unstashes
- verify that expanding bubbles in app and on launcher
home behaves as expected (stashes taskbar in app and
don't see taskbar or stashed handle on home)
Bug: 284104811
Change-Id: I3d7057ed651e66ab2a0292725f30153ee4d6d51e
This reverts commit 51a210d787.
Reason for revert: test may have been fixed before this got merged, will merge revert to confirm
Change-Id: Ib26b94af971eceb02e6bf58f39a578ee04eb72e8
* Partial revert of ag/24139629
* Taskbar showing up where it shouldn't in gesturenav,
this change isn't behind the flag
Bug: 295047555
Change-Id: Ib36b1fed5e25c667e396291a30a68730e1daa517
* WM checks that the number of insets don't change for
a given window once it's added. Previously when we changed
nav modes the window was removed and a new one was added, so
changing insets amounts/types didn't matter.
* Now that we use the same window and re-provide the insets,
the number of them provided have to match (insets values themselves
can change as much as needed)
* Fix minor bug when checking bit mask for gravity
Test: Switch between nav modes, no crash; no change in behavior
w/ flag turned off
Bug: 274517647
Flag: persist.wm.debug.hide_navbar_window
Change-Id: I750f843e8210ba1c800b61ac79664265924c054a
Change-Id: Idba4e8e1888fa58bf872c04cb042f77a8b5b0573
Jon Miranda
Tracy Zhou
Chris Göllner
Anushree Ganjam
Brian Isganitis
Ivan Tkachenko
Alina Zaidi
Tony Wickham
Sukesh Ram
Jagrut Desai
Helen Cheuk
bvineeth
Andy Wickham
Pat Manning
Mady Mellor
Vinit Nayak