Commit Graph

1277 Commits

Author SHA1 Message Date
Jordan Demeulenaere 51132f7f86 Format files with the upcoming version of ktfmt am: be82bc661c am: 652ec4997a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21565649

Change-Id: I06342a9bb4b91dd00196b76dec1dd2daaf4ee2e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 15:55:10 +00:00
Jordan Demeulenaere 652ec4997a Format files with the upcoming version of ktfmt am: be82bc661c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21565649

Change-Id: Icd28fd41925b49d0f8c4318365a244e3fa43f637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 13:22:07 +00:00
Jordan Demeulenaere be82bc661c Format files with the upcoming version of ktfmt
This CL was generated automatically from the following command:

$ external/ktfmt/prepare_upgrade.py --repo=packages/apps/Launcher3/ --build_id=9645412 --bug_id=266197805

This CL formats all files already correctly formatted with the upcoming
version of ktfmt.

Bug: 266197805
Test: Presubmits
Change-Id: Ide7d63a75fed98aabe348821355356c77f00a9ec
Merged-In: Ide7d63a75fed98aabe348821355356c77f00a9ec
2023-03-01 09:11:48 +00:00
Alex Chau 5a21a787f5 Merge "Skip updateIconAlphaForHome if Taskbar is already destroyed" into tm-qpr-dev am: 81b1d3576a am: 694a0a8685
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21610408

Change-Id: I18e4e859134652a81b370e2af77ba40016ed881a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 22:43:03 +00:00
Alex Chau 694a0a8685 Merge "Skip updateIconAlphaForHome if Taskbar is already destroyed" into tm-qpr-dev am: 81b1d3576a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21610408

Change-Id: I35d9bcf444bd9fb8b5ac5223f5579e0eb0901a03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 22:02:13 +00:00
Alex Chau 7fee161cd5 Skip updateIconAlphaForHome if Taskbar is already destroyed
Bug: 269409332
Test: Switch display with and without Tasxkbar at home and in-app, Taskbar and Hotseat visibility are correct
Change-Id: I598f618c336067bf795b77ccdf3b03f420634047
2023-02-28 12:46:50 +00:00
Jagrut Desai 70db29a34d Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev am: 3addf0b66d am: 8a8bda5b3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470199

Change-Id: I66c04acb33c47329dfdc16f4ef8c264bb710e198
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 02:57:09 +00:00
Jagrut Desai 8a8bda5b3c Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev am: 3addf0b66d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470199

Change-Id: I6239794dc53cc85288b8496c1862df1d803ba0e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 02:21:40 +00:00
Jagrut Desai 3addf0b66d Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev 2023-02-25 01:49:59 +00:00
Jagrut Desai 454fb81f39 Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev am: 0355c793c0 am: d3f23005af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21560134

Change-Id: Ifa917ee63eb85bc4dca837b4e3fb92acb914e5ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 01:09:45 +00:00
Jagrut Desai d3f23005af Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev am: 0355c793c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21560134

Change-Id: I75a8b22ad44b3ccf78a546f7d7569be9fc1dbff2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-25 00:39:22 +00:00
Jagrut Desai 560b0eac62 Implement All Apps Icon upto the visual Specs.
Test: Visual
Bug: 267382941

Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
Jagrut Desai 0355c793c0 Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev 2023-02-24 23:34:56 +00:00
Jagrut Desai 3fbaaf9628 Prevent Taskbar from stashing in immersive mode overview.
Test: Visual, Video in Buganizer
Bug: 262589756
Change-Id: Ifbdfb3a4104817e5f50833c42c3c6fc5964388b7
2023-02-23 14:19:10 -08:00
Tiger Huang 210c689996 Merge "Use insetsRoundedCornerFrame to check if taskbar is expanded or not" into udc-dev 2023-02-23 04:37:01 +00:00
Tony Wickham b83d56bc27 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493 am: c8207a7e23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764

Change-Id: I4af1a2fe1e79d2f36d275a057178efd7e750b0e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 18:10:26 +00:00
Tony Wickham c8207a7e23 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764

Change-Id: I04cbb24dc071677a8e6f5c4fa8981efc5bec6d34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 16:59:30 +00:00
Tony Wickham 3d1bb16493 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev 2023-02-22 16:24:48 +00:00
Tony Wickham 3a36d4890a Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a am: b506ae73b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497

Change-Id: I51be618db419357a60d0597f3f195ad284bd2c83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 06:22:44 +00:00
Tony Wickham b506ae73b0 Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497

Change-Id: Ica30f4d7a313b5966b8ca72654f4002e581faf31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 05:23:21 +00:00
Vinit Nayak 8e17afacdd Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67 am: 06ed4db282
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212

Change-Id: I4f8fab35c7c4c1de91927fc01a3b8a90d8d4aacd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 03:51:29 +00:00
Tony Wickham 00f89fbbf6 Fix taskbar drag view scale when returning to original icon
- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
  this accounts for padding as well as extra ring inset for
  PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
  the system drag and drop, instead of using the current scale which
  might be in the process of animating

Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838

Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
2023-02-22 03:41:03 +00:00
Tony Wickham 2a567ec85a Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev 2023-02-22 03:38:38 +00:00
Vinit Nayak 06ed4db282 Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212

Change-Id: Id6f868aa87f0ba53673764f412d12ed936f78aea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 02:50:49 +00:00
Vinit Nayak 54c262cd67 Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev 2023-02-22 02:15:46 +00:00
Winson Chung 071aff5b49 Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606 am: 0e9de04dfb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928

Change-Id: I282754b27a97e70223554050d31c2754cb52eb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 01:16:54 +00:00
Tony Wickham 16cfed3d1f Fix a couple of drag and drop issues from transient taskbar
- Don't stash until drag ends, but immediately stash at that point
  (regardless of success or failure, though failure will animate to the
  original icon before stashing)
- Send transient taskbar's bounds to WM Shell via intent extra such that
  they ignore drag events in that region

Test: manual in persistent and transient taskbar
Bug: 269814838
Fixes: 268526633
Fixes: 259645384
Change-Id: I5ded3998046f259ed6e79cb4ed765ad7b0c72e45
2023-02-22 00:46:51 +00:00
Winson Chung 0e9de04dfb Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928

Change-Id: I0e22beac88c2dd89078767d1846fb3470a8b26d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-22 00:17:27 +00:00
Winson Chung d30ef72606 Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev 2023-02-21 22:50:31 +00:00
TreeHugger Robot a09599d97f Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev am: 73a2334f7f am: f94e71eca0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590940

Change-Id: I622200bd7dca3086433170dc680ccc9aa2bc0e8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 22:47:21 +00:00
Schneider Victor-tulias 34f8c2f14a Merge "Keyboard quick switch polish" into tm-qpr-dev am: 8129ebfd04 am: 42f0aaac4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21466357

Change-Id: Ic68faa66297ea8bd2b960ec485bc0c421142122b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 22:46:07 +00:00
Jon Miranda 0a98138d4a Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev am: 6bb01ee8ca am: 2bd32abb3f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21486650

Change-Id: I47867da0ac599f5ad6fd029b5e3ab3364cb60474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 22:43:48 +00:00
TreeHugger Robot f94e71eca0 Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev am: 73a2334f7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590940

Change-Id: Ie07cb2abf9cadb3812014585691e58cf63c5baf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:45:28 +00:00
Schneider Victor-tulias 42f0aaac4b Merge "Keyboard quick switch polish" into tm-qpr-dev am: 8129ebfd04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21466357

Change-Id: I55765649648db123f919699ffd6f42c787bf9ddc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:44:54 +00:00
Jon Miranda 2bd32abb3f Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev am: 6bb01ee8ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21486650

Change-Id: I3b2f7b368eb7007886e415391585e3725d9dcd82
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 21:44:41 +00:00
TreeHugger Robot 73a2334f7f Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev 2023-02-21 21:15:22 +00:00
Schneider Victor-tulias 8129ebfd04 Merge "Keyboard quick switch polish" into tm-qpr-dev 2023-02-21 21:03:30 +00:00
Jon Miranda 6bb01ee8ca Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev 2023-02-21 20:09:41 +00:00
TreeHugger Robot af1c102e69 Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev am: 9769b2844c am: 90cf9e6855
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21452616

Change-Id: I2b925e0e493bd3dc303d41e940962d9cd9c55d7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 05:35:44 +00:00
TreeHugger Robot 90cf9e6855 Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev am: 9769b2844c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21452616

Change-Id: Icfa1d57cb210098675ef70313c675f62c29b5e61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-21 04:34:48 +00:00
TreeHugger Robot 9769b2844c Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev 2023-02-21 03:24:41 +00:00
Jon Miranda 7a73f3ee82 Seamless handoff between stashed handle and taskbar.
Bug: 267806083
Bug: 246634367
Test: manual
Change-Id: I0c3d7a19aaa36a323c6fb3349852727f56842bb2
2023-02-21 01:42:30 +00:00
Winson Chung e2daf2c1be Merge "Only call per-user calls for gesture settings observer" into tm-qpr-dev am: 192e7afc3c am: 785f15d965
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21459072

Change-Id: Ic26e7bcd72b26c44f6e313321e0c5c120121961a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-20 20:31:55 +00:00
Tiger 2d2e34cf81 Use insetsRoundedCornerFrame to check if taskbar is expanded or not
When taskbar is expanded, insetsRoundedCornerFrame will be set to true
via LayoutParams. We can adjust animation bounds or crop the taskbar
surface based on the insetsRoundedCornerFrame. In this way, the insets
types in TaskTransitionSpec can be removed.

This is a step to remove ITYPEs.

Bug: 234093736
Test: atest LetterboxUiControllerTest SizeCompatTests
Change-Id: Ibffd5beaf49f3196356b140938c4b2c8cc9d424e
2023-02-20 19:20:52 +08:00
Winson Chung 3bce15d2a2 Fix issue with global drag from taskbar being disabled
- BackgroundAppState extends OverviewState, so in some cases we will
  transition to background app, which inadvertently triggers global
  drag and drop from being enabled

Bug: 269819279
Test: Enter split, cycle the screen and try to drag an app from the
      transient bar
Change-Id: I0e8c5e8bbaa0220fc870d2db866152864253010f
2023-02-18 06:34:08 +00:00
Vinit Nayak c97bb4600f Move split functions from RecentsView to SplitSelectStateController
* Moving things out of RecentsView to avoid
dependency on a non-testable class
* Also helping prevent bloating RecentsView.java

Bug: 266482558
Test: Single Chrome instance in recents. Initiate split
with Chrome from workspace, tap on Chrome again in Taskbar,
ensure no crash.

Change-Id: I99ec704479ffaa860f4d80c2cb9f54182f31f41a
2023-02-17 17:28:08 -08:00
Jon Miranda ddb909603a Remove setImeIsVisible/setTouchesEnabled as its already handled by insets.
Bug: 260101467
Test: manual
Change-Id: Iba22a6db61abd4be0b2a15b2e4099d9bc03ddbc9
2023-02-18 00:27:03 +00:00
Schneider Victor-tulias 0bba3d6184 Keyboard quick switch polish
- Added support for escape(backtick on some keyboards) keyboard keys
- Added support for d-pad left and right keyboard keys
- Fixed janky behaviour when quick switching too quickly.
- Removed unused code

Bug: 269618928
Test: Tried quick switch very quickly, tried escape, d-pad left and right keys in RTL and LTR modes
Change-Id: Ie03207cb349891e9c2de18502f3f65b7c8f9c018
2023-02-17 15:44:04 -08:00
Winson Chung 785f15d965 Merge "Only call per-user calls for gesture settings observer" into tm-qpr-dev am: 192e7afc3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21459072

Change-Id: Ia6ba4cf78923ee0d2b7cba88be4482c09e05b524
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 21:22:56 +00:00
Alex Chau cc7fc9f5cc Merge "Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed" into tm-qpr-dev am: ac4c866538 am: e892b3e4c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21467064

Change-Id: Ia9fb0b47902f28cbc9eaa5157aefc4fc779cf55e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-17 19:53:29 +00:00