Commit Graph

9125 Commits

Author SHA1 Message Date
Samuel Fufa 08457b0017 Dragging an icon from prediction row to workspace crashes launcher
Test:Manual
Bug:139942462
Change-Id: I5c4a2ca518b08f4ccf47072f8f355e76b7da9424
2019-08-23 14:40:11 -07:00
Sunny Goyal 6fe3eec95c Moving various common executors to a single location
Change-Id: I44bca49b8adb6fa22c3b48d10f674e42c28d792c
2019-08-20 14:36:17 -07:00
Samuel Fufa 6888b5ceaa Merge "Support Agassi (Search Engine choice) in Android R" into ub-launcher3-master 2019-08-16 21:57:58 +00:00
Samuel Fufa 9ec8cfa269 Support Agassi (Search Engine choice) in Android R
Test:
1) set your preferred search provider using `adb shell settings put global SEARCH_PROVIDER_PACKAGE_NAME <value>`.(eg: com.duckduckgo.mobile.android)
2) install the package name and confirm search widget on launcher is updated
3) uninstalled the package and confirm widget is replaced with placeholder on launcher.

Bug:137653564
Change-Id: I8904d5915a8c03ea6068fb5950af15ca786b8ad7
2019-08-16 14:46:00 -07:00
Pinyao Ting 2f9019e56c add null check when accessing target component from iteminfo
Bug: 139540363
Change-Id: I25d0100077de67b085c27b5ef91e22c6ac1ad959
2019-08-16 14:25:31 -07:00
Hyunyoung Song 27df700f05 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev
am: 96eba3aea6

Change-Id: I738256f1623119a61197c03008e098b066161542
2019-08-15 16:03:32 -07:00
Hyunyoung Song 96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
Samuel Fufa 84245e84c8 Default name's language of folder won't change after changing the system language
Test: Manual - Create unnamed folder and change system language. Folder
name should pickup new language.
Bug:78611156
Change-Id: Ie06baebe5b9a64e91630c581b75b674f363b9973
2019-08-15 09:56:12 -07:00
TreeHugger Robot 46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
TreeHugger Robot 4c19f94181 Merge "Adding app search improvement flag" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Sunny Goyal 934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Samuel Fufa 8628eb9353 Sorting people by key crashes launcher
Approch: approach: filter out people with null getKey before sorting.

Bug:139436782
Change-Id: I6510a12374ff4fec02c879ff76ba42b1fcdb8281
2019-08-14 15:12:43 -07:00
Alex Mang 713cd6fd56 Adding app search improvement flag
Bug: 125027540
Change-Id: I68fd7710b108e9f2fa1f5ff335326585a92deb23
Merged-In: I68fd7710b108e9f2fa1f5ff335326585a92deb23
(cherry picked from commit d27e31995b)
2019-08-14 21:58:57 +00:00
TreeHugger Robot 23582eb7c0 Merge "Refactoring some folder binding logic:" into ub-launcher3-master 2019-08-14 21:10:20 +00:00
yingleiw 6f703ccff5 Add directional accessibility page actions to PagedView
am: 02cc848896

Change-Id: Ide8077d5996de0faaec6d1ef0afee0e0e639d889
2019-08-14 13:09:36 -07:00
Becky Qiu 1289197487 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev
am: 22edac9bf5

Change-Id: Iae05c668fecf84c79086cfb6821e9644ac08bb71
2019-08-14 13:09:14 -07:00
Sunny Goyal 11a50747ed Refactoring some folder binding logic:
> Moving grid calcutation in a separate class
> Moving content saving logic to folder instead of relying on item bind

Bug: 139051851
Change-Id: I81b226dbebe13652482a767c992e8cc8f4f35a60
2019-08-14 12:03:09 -07:00
yingleiw 02cc848896 Add directional accessibility page actions to PagedView
For PagedView, when isPageOrderFlipped is true, it means the LTR mode is
flipped. For the "recents" in launcher, isPageOrderFlipped is true.
However, this doesn't affect the directional page operations since
scrollLeft()/Right() already has correct Rtl considerations. See
b/78788182 for more information on the LTR mode.

Test: Tested with the "recents" in launcher. Verified that page left
action always move pages to the right (so that the next page from the
left side shows), and page right actions always move pages to the left
(so that the next page from the right side shows). Also tested with the
home screen 1/2, 2/2 paging.
Bug: 136277517

Change-Id: I965d651c37d258eaa8ea347d1ad6f698f9b590bf
2019-08-14 18:05:08 +00:00
Becky Qiu 22edac9bf5 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev 2019-08-14 17:48:45 +00:00
Samuel Fufa 866ff00eb3 Add a "Dismiss" option for predicted apps in Launcher
Test: LongPress on a pridicted app to see dismiss options.
Bug:139020180
Change-Id: I877863c65def0d845c0ae2f0987fe7a4f6277565
2019-08-13 23:57:11 +00:00
TreeHugger Robot d21505bcb7 Merge "Moving section names to model, to avoid an unnecessary hashmap" into ub-launcher3-master 2019-08-13 18:24:25 +00:00
Alex Mang cdbf19aa60 Merge "Adding app search improvement flag" into ub-launcher3-master 2019-08-12 19:22:25 +00:00
Becky Qiu 90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
vadimt 3c523040cb Support for memory tests
am: c1a2764a6e

Change-Id: Ife853a32fa9e52f8993d25167af61dabc7fd64b8
2019-08-09 10:40:20 -07:00
Alex Mang d27e31995b Adding app search improvement flag
Bug: 125027540
Change-Id: I68fd7710b108e9f2fa1f5ff335326585a92deb23
2019-08-09 01:51:23 +00:00
vadimt c1a2764a6e Support for memory tests
Change-Id: I867a232a293f7bddbc630f563f18c0db94ac4b6e
2019-08-08 12:03:09 -07:00
Vinit Nayak 268e4ff95c Remove activityInfo from cache on package uninstall
We were keeping stale activityInfo objects from
package manager after an application got uninstalled.
We also were not removing task icons from the
cache after they were removed, which meant killing an
app and then re-opening would put 2 entries in the cache
since the two had unique process IDs.

fixes: 137731960
Test: Download app from play store, open it,
go to overview and observe that correct icon showing.
Uninstall it, download same app again, open it, and
in overview confirm that correct app icon is still showing

Change-Id: Icf482b0ad0ae66c10d52547582d8eeb2a544fb88
2019-08-08 11:11:03 -07:00
Sunny Goyal e529a86fbd Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
2019-08-07 15:51:25 -07:00
Sunny Goyal 0af5134bc5 Moving section names to model, to avoid an unnecessary hashmap
Change-Id: I9620367e0c2203b2290a4a188411ccb9174ae130
2019-08-06 15:21:36 -07:00
Pinyao Ting e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Pinyao Ting 49a3e699f9 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 20:41:58 -07:00
Sunny Goyal 9275c820e0 Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev am: 0a9e91b6e4
am: 2c848d029c

Change-Id: I827430185fbab9433f74f402f382cb004ab744c3
2019-08-05 17:45:45 -07:00
Sunny Goyal 2c848d029c Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev
am: 0a9e91b6e4

Change-Id: Iad5027f7925981de0720ca960e5a8ffdd2a1463c
2019-08-05 17:39:41 -07:00
TreeHugger Robot 0a9e91b6e4 Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev 2019-08-06 00:33:31 +00:00
Sunny Goyal 6b6d0a3972 Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice
Bug: 138646754
Change-Id: I76eccdb812013299e18f197ba17ff858a01a6338
2019-08-05 17:20:10 -07:00
Vadim Tryshev 347ce4529b Merge "Adding debug tracing to catch non-dragging to workspace" into ub-launcher3-qt-qpr1-dev
am: f4a1814c3f

Change-Id: I2bb035bf176cb0fb3e16456f52153de065855740
2019-08-05 17:06:36 -07:00
Vadim Tryshev f4a1814c3f Merge "Adding debug tracing to catch non-dragging to workspace" into ub-launcher3-qt-qpr1-dev 2019-08-05 23:30:13 +00:00
Jon Miranda 3edba34cb2 Fix launcher crash when trying to open work profile promise icon. am: 0121d466ec
am: ccf108c5f3

Change-Id: I95441f44090f04f391ad436f9177f8cceb496d15
2019-08-05 15:02:12 -07:00
Jon Miranda ccf108c5f3 Fix launcher crash when trying to open work profile promise icon.
am: 0121d466ec

Change-Id: I40272f5061cea59b846d6633cd60217a263eb454
2019-08-05 14:55:12 -07:00
Jon Miranda 0121d466ec Fix launcher crash when trying to open work profile promise icon.
Bug: 138609751
Change-Id: Ifb1c4628ce6307a19a2bb696e4771d5cd5810a90
2019-08-05 14:36:04 -07:00
vadimt f1726290d4 Adding debug tracing to catch non-dragging to workspace
Bug: 138729456
Change-Id: I28f1eaeb17a75cbc6f52b259d0226deaff42e0bb
2019-08-05 13:52:36 -07:00
Jon Miranda 0b257d3e20 Merge "Bandage fix for bitmap fatal exception where width / height !> 0." into ub-launcher3-qt-r1-dev am: cf92f3edb0
am: b1d8ad6be5

Change-Id: Ifb3662ee293ff5eace912be50e622171a0bcaaa6
2019-08-01 16:52:13 -07:00
Becky Qiu 29e8ef3611 Log the right workspace id for -1 screen for stop and resume.
am: bfc2da1fd8

Change-Id: Iafe8c7cc05d0fb76a3e8768bb8513b4696861c78
2019-08-01 16:51:54 -07:00
Jon Miranda b1d8ad6be5 Merge "Bandage fix for bitmap fatal exception where width / height !> 0." into ub-launcher3-qt-r1-dev
am: cf92f3edb0

Change-Id: Iea9db807ebc65bcb612294a4283346e714b25f63
2019-08-01 16:50:56 -07:00
TreeHugger Robot cf92f3edb0 Merge "Bandage fix for bitmap fatal exception where width / height !> 0." into ub-launcher3-qt-r1-dev 2019-08-01 23:27:31 +00:00
Jon Miranda 40bce3efe4 Bandage fix for bitmap fatal exception where width / height !> 0.
Bug: 135558924
Change-Id: I0a22ba849b50eee87abd52ab9ec3211294a6c40b
2019-08-01 16:17:37 -07:00
Becky Qiu 9c6cfb4e04 Fill the log container as hotseat or workspace based on position.
am: 84fa94e2fc

Change-Id: If9a5d88062addbd09909e04ef5c2c59e7e5488a7
2019-08-01 16:00:47 -07:00
Becky Qiu bfc2da1fd8 Log the right workspace id for -1 screen for stop and resume.
Test: manual
Bug: 137952354

Logs after this fix:
08-01 12:01:36.220 17105 17105 D UserEvent: action:STOP
08-01 12:01:36.220 17105 17105 D UserEvent:  Source child:WORKSPACE id=-1
08-01 12:01:36.220 17105 17105 D UserEvent:  Elapsed container 5511 ms, session 5511 ms, action 0 ms
08-01 12:01:36.220 17105 17105 D UserEvent:
08-01 12:01:38.042 17105 17105 D UserEvent:
08-01 12:01:38.042 17105 17105 D UserEvent: -----------------------------------------------------
08-01 12:01:38.042 17105 17105 D UserEvent: action:RESUME
08-01 12:01:38.042 17105 17105 D UserEvent:  Source child:WORKSPACE id=-1
08-01 12:01:38.042 17105 17105 D UserEvent:  Elapsed container 7334 ms, session 7334 ms, action 0 ms
08-01 12:01:38.042 17105 17105 D UserEvent:

Change-Id: Ic2d88eee3ff7a0e28d5c7e4cab8ee61952ed95ee
2019-08-01 22:55:42 +00:00
Becky Qiu 84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00