Commit Graph

2195 Commits

Author SHA1 Message Date
Winson Chung 0ea61abe10 Merging ub-launcher3-qt-dev, build 5642962
Test: Manual

Bug:122345781 P1 Inflation happens and a binder call during swipe up gesture, that may cause jank
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:132209249 P1 Gesture bar interferes with Messenger chat heads.
Bug:132815672 P1 -1 to home swipe up gesture
Bug:132886768 P1 Swipe home animation sometimes drops frames
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133226418 P1 [Gesture Nav] App launch animation has has incorrect origin when launched in Overview
Bug:133508173 P1 App switching is very janky on QT
Bug:133871965 P1 (V35 20190528.00_RC00):Unable to unlock/minimize phone app during ongoing call
Bug:134095068 P1 Shouldn't use seamless rotation in another case
Bug:134166337 P1 3P Launcher Breaks Overview (Standalone)
Bug:134172603 P1 Tracing for lab-only flakes
Bug:134517106 P1 Swipe up to home should fade out scrim
Bug:134532571 P1 Launcher flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview, but the current state is not BASE_OVERVIEW; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/overview_panel\E']
Bug:134674880 P1 App group name in expanded view is invisible with white wallpaper
Change-Id: I9bca7db0f03bd4c0581ce946646bf5209e8f6c79
2019-06-07 13:36:20 -07:00
TreeHugger Robot bfe171f9cb Merge "Add tracing for b/134532571" into ub-launcher3-qt-dev 2019-06-07 00:10:30 +00:00
vadimt 0f08db5eeb Add tracing for b/134532571
Bug: 134172603
Bug: 134532571
Change-Id: I75c8e0212a9b35d33842d5380fbe733b486be932
2019-06-06 17:00:57 -07:00
TreeHugger Robot 19f7c6fefb Merge "Disable seamless rotation for 3 and 2 button mode" into ub-launcher3-qt-dev 2019-06-06 22:45:47 +00:00
Sunny Goyal 0b1cb75ee8 Disable seamless rotation for 3 and 2 button mode
Bug: 134095068
Change-Id: I8603e49a85b5524a02c9085485a180b022e3f91e
2019-06-06 15:35:45 -07:00
Vadim Tryshev 8278148e41 Merge "Test: using RuleChain to create a correct order of rules." into ub-launcher3-qt-dev 2019-06-06 21:20:50 +00:00
vadimt 44e9a873fc Test: using RuleChain to create a correct order of rules.
Change-Id: I2eeb933eab8e5f19b1f80d47566a511ddbdeb28b
2019-06-06 14:02:33 -07:00
TreeHugger Robot 256762251e Merge "Reduce alpha delay 25ms to reduce flashy feeling of appearing large." into ub-launcher3-qt-dev 2019-06-06 19:48:42 +00:00
TreeHugger Robot 7183795ff8 Merge "Using a separate InputConsumer when Launcher is resumed but not focused" into ub-launcher3-qt-dev 2019-06-06 19:06:30 +00:00
Sunny Goyal 6f479ff9de Using a separate InputConsumer when Launcher is resumed but not focused
When Launcher is not focused and we try to dispatch events to Launcher, it
can lead to a inconsistent state. For eg, NavBarTouchController was trying
to take launcher from NORMAL to NORMAL state causing the endCallback to be
called immediately, which in turn didn't clear Swipedetetor state

Bug: 132209249
Bug: 132815672
Change-Id: I82e4fdcb8fd5339e82fc8551f3a6e0b046d906f8
2019-06-06 11:57:54 -07:00
Tony Wickham 215ab0ca87 Merge "Fix flicker to OVERVIEW state during quick switch" into ub-launcher3-qt-dev 2019-06-06 18:55:14 +00:00
vadimt 63013c5e57 Temporarily not using RuleChain as it mysteriously breaks tests
Change-Id: I8bdd9a8ea12cfdbd92fe724181e7479cadcb26fe
2019-06-05 18:34:23 -07:00
Tony Wickham df4727e8ee Fix flicker to OVERVIEW state during quick switch
Here's what was happening:
- When animating to a new task, the launcher controller ends first (when
  quick switching it likely ends immediately since we're already scaled up).
- Then we get onApplyWindowInsets(), which re-builds the launcher controller.
- Finally, the window animation ends, invalidating the handler and ending
  the new controller, which sets the state to OVERVIEW.

To fix this, never create a new controller if it has ever been started.

Bug: 133508173
Change-Id: Ibd0e18e488353df73159ffbdd9a3b335bed57d98
2019-06-05 17:19:20 -07:00
Sunny Goyal bfaabbea81 Merge "Fixing wrong origin when launching new task from overview" into ub-launcher3-qt-dev 2019-06-06 00:16:29 +00:00
Vadim Tryshev e7f313dc0c Merge "Taking local screenshot before navigation state is restored" into ub-launcher3-qt-dev 2019-06-05 23:34:05 +00:00
vadimt 7a38854284 Taking local screenshot before navigation state is restored
Change-Id: Id8003b17c68af5b4882bdbf5e14a142875791cbc
2019-06-05 16:18:55 -07:00
Tony Wickham be1fde798c Merge "Fade out scrim when swiping to home" into ub-launcher3-qt-dev 2019-06-05 22:27:49 +00:00
TreeHugger Robot 4ab6254bdc Merge "Adding some state for fallback recents View" into ub-launcher3-qt-dev 2019-06-05 21:40:38 +00:00
Sunny Goyal bda6b45341 Fixing wrong origin when launching new task from overview
> Also removing some unnecessary layout passes during launch animation

Bug: 133226418
Change-Id: I36fe69827853366deb7c56ca25f39e20c1a0b825
2019-06-05 12:25:28 -07:00
Zak Cohen 8d19146b7b Remove unused hints code.
This layout is handled by the provider of the hints now.

Bug: 132886768
Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
(cherry picked from commit f3231f417d)
2019-06-05 11:18:09 -07:00
Jon Miranda 88dd84254c Reduce alpha delay 25ms to reduce flashy feeling of appearing large.
Bug: 123900446
Change-Id: Ia8ff74eb6b65affbf5c6c1599f4d168b459f324e
2019-06-05 11:07:17 -07:00
Tony ae087dc9b8 Fade out scrim when swiping to home
Bug: 134517106
Change-Id: Ica725e3a327c1c069e3859732ea6a878d361a3d8
2019-06-04 19:25:03 -07:00
Winson Chung ff9fe09b3f Merge "Use device locked input consumer when an activity is showing when locked" into ub-launcher3-qt-dev 2019-06-04 21:42:44 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Winson Chung a3ed49d566 Merging ub-launcher3-qt-dev, build 5633311
Test: Manual

Bug:119330044 P1 [STOPSHIP] Add back shape detection in Launcher icons
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:132298752 P1 Adding widget locks home screen page
Bug:132757019 P1 Swipe up twice quickly from app in 2 button mode; can't access all apps
Bug:133518678 P1 In 2 button mode, flinging up strongly favours quickswitch
Bug:133806285 P1 All apps causes overview to peek in
Bug:133844237 P1 Respect limited width Exclusion Rects in bottom area?
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:134062513 P1 Quickswitch sends lifecycle events to -1
Bug:134094839 P1 Launcher kept crashing on OTA update
Bug:134096917 P1 Launcher animation component gets stuck during swipe up
Bug:134164918 P1 STOPSHIP: Disable chips hard-coded value in qt_dev Launcher
Bug:134172603 P1 Tracing for lab-only flakes
Bug:134442147 P1 Sometimes All Apps won't update on app install/uninstall/update
Change-Id: Ia530fbf9bb5fa67b602ce44aef0cc4a1d1494e13
2019-06-04 12:20:05 -07:00
Winson Chung ed6a3eada7 Use device locked input consumer when an activity is showing when locked
Bug: 133871965
Change-Id: I51a32a99990813e510c757e5e295a09f041c0514
2019-06-04 10:40:31 -07:00
Sunny Goyal 9d8b1376e8 Adding some state for fallback recents View
Maintaining a boolean corresponding to overview or QuickSwitch which
updates the visuals for RecentsView accordingly

Bug: 134166337
Change-Id: If1aec99257de4db1796335f2cf39d2d35789915b
2019-06-03 16:00:06 -07:00
TreeHugger Robot 72c6e7b736 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev 2019-05-31 23:22:30 +00:00
Tony Wickham a04e746e84 Fix getting stuck in BackgroundAppState for 2-button mode
When ending in recents, we reapply the state - therefore, it's important
to make sure we are in OverviewState before onSwipeUpComplete(). This is
done by mLauncherTransitionController, which sets OverviewState on end.
We already force mLauncherTransitionController to end before calling
onSwipeUpComplete(), but in this case we were calling cancel() and
setting mLauncherTransitionController = null, which meant we could never
call end() on it. Instead, we should always call end() if we set it to
null.

Also ensure mLauncherTransitionController is created even if the gesture
is completed, if an existing controller isn't already running. This can
happen if you swipe up quickly enough that we get onGestureEnd before
launcher is drawn, and in that case we still want the launcher component
to animate once its ready. This is even more important for 2-button
mode, because again, we rely on mLauncherTransitionController to set the
state to OverviewState before we reapply it.

Finally, clarified some methods by renaming "swipeUp" to
"swipeUpToRecents".

Bug: 132757019
Change-Id: Ieb24a4f36a39780e5d64d7bc312791608db474d1
2019-05-31 16:11:40 -07:00
TreeHugger Robot 061c43eb4f Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev 2019-05-31 23:01:36 +00:00
Govinda Wasserman 164ebb2e8c Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev 2019-05-31 18:09:53 +00:00
Sunny Goyal 03d32ddb23 Fixing overview scrim not initialized properly when launcher starts
State UI depends on visible content, which can change due to predicitons.
Reapplying the state whenever then happens ensures that we are in correct
start UI

Change-Id: I9f195a92b747fda8a5b217dc960f230d7a695255
2019-05-31 11:00:35 -07:00
Tony Wickham 8765e262c2 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev 2019-05-31 17:46:03 +00:00
Tony Wickham 436d5971b1 Don't recreate the launcher animation controller if gesture ended
This can happen if we get onApplyWindowInsets() after onGestureEnded().
In that case, we can get into some bad states because the running
animation is overwritten and thus can't be canceled.

Bug: 134096917
Bug: 133806285
Change-Id: Ic517d68a46a4446ca382445df1ba62c26e8243ad
2019-05-31 10:21:28 -07:00
Govinda Wasserman 254be7b0e4 Adds trigger for new gesture entrypoint to Assistant bundle
BUG:130186141
Change-Id: I43a4c3d3c9a46b4a1a5c53a81b037ba2be194188
FIX:130186141
2019-05-31 12:20:50 -04:00
TreeHugger Robot f36e5e002a Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev 2019-05-31 06:01:25 +00:00
Jon Miranda 2ff7b53ec5 Fix bug where QSB flickers on app close.
Bug: 123900446
Change-Id: I9b03b2d91d264de237328511b5406e5fcd22dbac
2019-05-30 20:53:27 -07:00
TreeHugger Robot 958cc0657f Merge "Tuning app open/close animation." into ub-launcher3-qt-dev 2019-05-31 02:04:03 +00:00
Jon Miranda b3c9077c76 Tuning app open/close animation.
* Mostly value changes.
* Added a way to round the corners during swipe up to home animation.

Bug: 123900446
Change-Id: Id61d241d919ba51ced0633585e36b7d93efe30b0
2019-05-30 18:43:22 -07:00
TreeHugger Robot ba33d1d216 Merge "If y velocity > x velocity in 2-button mode, go to recents" into ub-launcher3-qt-dev 2019-05-31 00:49:10 +00:00
Tony Wickham 1689d65ac3 If y velocity > x velocity in 2-button mode, go to recents
Also, when landing in recents, snap to the nearest page so that swipe up
consitently goes to task 0 instead of sometimes scrolling to task 1.

Bug: 133518678
Change-Id: I63a161a9f1f87266d3c3fc71c98cd5fc5e2f8874
2019-05-30 17:38:46 -07:00
Sunny Goyal 38d8a63d07 Disabling horizontal swipes if the app has draggable content at the bottom
Bug: 133844237
Change-Id: I67a4140d56f87c464e436d394da77127a965c3e5
2019-05-30 15:13:09 -07:00
Winson Chung 0ef6fe00b0 Merging ub-launcher3-qt-dev, build 5619253
Test: Manual
Bug:112282235 P3 Starting an app from Launcher very rarely takes > 10 sec
Bug:121279417 P2 Why LauncherInstrumentation.WAIT_TIME_MS == 60000?
Bug:123892607 P1 Test broken: WellbeingTests.testPauseAppFromAllApps
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:125844074 P2 Final UX and animations for Launcher DWB integration
Bug:131360075 P1 [Gesture Nav] Polish/finish landscape
Bug:131698989 P2 Add task callback for locked state change
Bug:131741395 P2 Allow windows to scale/move past overview positioning
Bug:131768436 P1 Bad placement of search bar
Bug:131854153 P1 Lots of Cuttlefish (and not only) tests are broken
Bug:131867841 P1 Changing display size does not update the grid
Bug:132460627 P1 Unable to swipe to all apps screen on devices
Bug:132687470 P1 Swiping home from forced landscape app creates cutoff task thumbnail
Bug:132756514 P1 Sometimes (when quick switching?) user gets stuck in full-screen recents view
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:132975416 P1 Flake in NexusPredictionAppTracker.getAppPredictionContextExtras
Bug:132993129 P1 If predictions disabled, app predictions loading bar appears briefly on device restart
Bug:133113732 P1 [B1/C1][QT][CTS_Verifier_9.0_r1]Device Owner Tests-LockTask UI-Enable Overview button failure
Bug:133167096 P1 It is way too easy to dismiss apps from the lock screen
Bug:133651528 P1 [QT]"Pixel Launcher isn't responding" dialog pop up ,after DUT restored.
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133765491 P1 App docked in split screen flickers with emptiness observed while rotating the device
Bug:133783088 P1 Footer showing up on all overview task snapshots even with no items showing.
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:64712476 P3 Import translations for dev branches

Change-Id: Ib4bcefdbb4027992e75e2742d72f199e13467875
2019-05-30 13:18:41 -07:00
Sunny Goyal e9c6f4cc69 Fixing interactive state for background states and
notifying LauncherCallback accordingly

During quick switch Launcher can get resumed only to be paused again
when launching a new app. Updating the logic for deferred resume to
account for that and moving some additional calls to deferredResume

Bug: 134062513
Change-Id: Ia607f178bc17d45d53fb032a06cd70f9abc6b513
2019-05-30 11:59:29 -07:00
vadimt 26185e1fed Adding debug tracing for a lab-only issue
Task doesn't get resumed upon clicking at it.

Bug: 133765434
Change-Id: I8c5c1308041949d94c6982c78b8337ea81ad400f
2019-05-30 10:30:32 -07:00
Sunny Goyal 1d7b2a0672 Merge "Overview - Add motion to the footer shown on overview tasks." into ub-launcher3-qt-dev 2019-05-30 00:18:38 +00:00
Zak Cohen 3f6019fde4 Overview - Add motion to the footer shown on overview tasks.
The motion mirrors the icon view.

Bug: 125844074
Test: manual
Change-Id: Ib980657763aa82c45319c7c93be652f6fc89ffe4
2019-05-29 16:54:36 -07:00
TreeHugger Robot 1dbec0ef43 Merge "Fix bug where shape reveal progress gets started too early." into ub-launcher3-qt-dev 2019-05-29 21:57:41 +00:00
TreeHugger Robot fafe347533 Merge "Animate workspace upwards when opening an app." into ub-launcher3-qt-dev 2019-05-29 21:53:32 +00:00
TreeHugger Robot ea068967ae Merge "Add staggered springs animation when swiping up to home." into ub-launcher3-qt-dev 2019-05-29 21:47:27 +00:00