The wrong calculation is caused by using half size mTaskRect in Split task to calculate the translation X to middle
It should use the fullTaskSize instead of half size. This change refactors the code to store the full size so it does not need to re-calculate many times
Bug: 312371505
Test: Manual, swiping up split task diagonally from right side many times, test the case when mSplitBounds is not null in addAppToOverviewAnim
Test: Tested swipe up to overview for split task/single task in Phone, Tablet and Unfolded phone, with the flag on and off
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: Id2b008a7d9597271e077a125f3195b27196797d7
The update of the focus task overlay should be at last, cause otherwise the first time the "Select" button doesn't work - the text is not highlighted.
Also, we need to update pivot of the selected task only if there is a grid overview enabled. Otherwise the bug is still reproducible on Felix.
Bug: 305125147
Flag: NONE
Test: Manual (both on Tangor and Felix in Portrait/Landscape mode with small/medium/large Display size)
Change-Id: Id928cee0949b9124aeb27cc8210a53993e72ba19
Design doc: go/launcher-focus-outline
Before: BubbleTextView height is larger than its parent, outline is cropped
https://screenshot.googleplex.com/dYXjWAHS4VzPQdJ
After: BubbleTextView has the same height as its parent Prediction Row, outline is fully shown
https://screenshot.googleplex.com/3eMxPwxiHs9JTTq
Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I7bfa4da3b67b4a4abc4dfe9df560dda8d7e9b1bd
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)
Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
Excluding TaplDragTest#testDragToFolder, which is failing on some devices
Will watch their stability; may further promote to presubmit
Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: I6fd9a6fb315dc9ab7bcac788edfac95cc3e9b93f
In SplitScreenController#onStartingSplitLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;
This avoids a latency from the 2-way IPC in
RecentsAnimationListener#onTasksAppeared.
Bug: 275508603
Test: Capture trace when switching app by quickstep.
Change-Id: Ia11cbca0d38cdc2bfd676dfa3d59a5c8931a2d6e
When the dark night mode switch is triggered,systemui calls binder
to the onNavigationBarSurface method in the launcher and applies the
surfaceController.
Keep switching,you will keep applying,resulting in more surface
objects. The behaviour would cause that SurfaceFlinger couldn't
remove the unnecessary navigationbar layers timely and the
navigationbar layer would leak in SF.
Actively release the SC after using the SC in the launcher.
Bug: 317336417
Test: 1.Launch the settings app
2.Click Display menu
3.click the dark theme menu multiple times
4.Check whether the surfaceController is released
adb shell "ls -l/proc/904/fd|wc -l"
Change-Id: Ic449de9dbe0c52e0053be91e67ee9081a574581b
This change adds RTL support for the back gesture icon on the main menu
of the gesture tutorial menu. In RTL mode, it was previously rendering
in the middle of the screen.
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 309564541
Test: ran the tutorial in RTL mode in different form factors.
Change-Id: I24def01ed205355ced23060068ddd74af61134ab
The change around configuration and display cutout to support flexible
display setup is making the received display info is not calculated as
the hard-coded way in taskbar. It will cause the taskbar recreated when
the device reaches a given rotation for the first time.
The recreation is not necessary as it is only a hint of taskbar's
estimation doesn't match the result. Block the recreation in that case
to avoid user visible animation issue.
Bug: 302387383
Test: Rotate a device with movable cutout and no recreation happens
Flag: ACONFIG com.android.window.flags.allows_screen_size_decoupled_from_status_bar_and_cutout TRUNKFOOD
Flag: ACONFIG com.android.window.flags.movable_cutout_configuration DEVELOPMENT
Change-Id: I1aa6add57ec49a49cc7473bfaada6d9212c1fc4b
This CL fixes several issues:
- When launching an app pair on top of the exact same app pair, Overview no longer enters a broken state
- When launching another app quickly after launching an app pair, splitscreen no longer breaks
Fixes: 315190686
Test: Launch app pair and then launch same app pair again from Taskbar -- Overview does not break
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I0d474dd89359e1a10a881c5cf8deee64754219c3
Before we only checked if live tile drawing was enabled at the
start of the dismiss animation, and didn't add the frame callback
listener at all if not. Now we always add the frame callback
listener when dismissing the running task, and check if live tile
drawing is enabled within the listener in case there is a race.
Fixes: 312261719
Test: Swipe up to Overview from an app, immediately swipe up to
dismiss the app; ensure it always follows your finger
Flag: None
Change-Id: Ia12b02d5989c09d2104edd202f8c016f202f76b8
Unless hardware keyboard is attached and taskbar is pinned.
Fix: 316270741
Bug: 255818649
Test: Manual. Using combinations of transient taskbar, virtual and hardware keyboards.
Flag: NONE
Change-Id: I1fae1655fc16b9fa951510cf834d2a33cb8956d8
Bug: 317218355
Flag: ACONFIG com.android.window.flags.predictive_back_system_animations DISABLED
Test: Manual, i.e. verifying statusbar appearance during back to home
Change-Id: I158d4d26bd262337eb3dd09e56c1999935e9788b
The listener allows us to drag and drop widgets outside the launcher.
Bug: 315209740
Test: atest Launcher3Tests
Flag: NA
Change-Id: Iafc6e8903ea4f32540df30152b35d9eb7e98c6d6
Bug: 316663312
Flag: NONE
Test: Manual, i.e. verifying that this change does not introduce any unexpected regressions
Change-Id: I749f3944d5fd71e525ce31ff720dd86f1a84277e
The QSB was a bit wider becuase icons visible size is a bit smaller than their actual size due to b/235886078 so we add a workaround to adjust QSB size based on the visible icon size
Bug: 281587788
Test: atest HomeScreenImageTest
Flag: NONE
Change-Id: I593ca2d588f08b830be0b2ac389c747b6f558b91
Will watch their stability; may further promote to presubmit
Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: Idf3949b1f04b0ff761ef1216fa41e9e8d11e8cdd
Currently only tests that use DebugQuickstepTestInformationHandle
are able to recreate the taskbar.
This change allows recreating the taskbar in system UI TAPL tests.
Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Flag: NA
Change-Id: Id97d26c0aa77db23cd9031f47cf8dd3f79e6a158
helencheuk
Vadim Tryshev
Sunny Goyal
Jagrut Desai
Sergey Pinkevich
Riddle Hsu
Tracy Zhou
Hyunyoung Song
Yunfan Chen
Bill Yi
Saumya Prakash
chuanghua.zhao
Tony Wickham
Liran Binyamin
Johannes Gallmann
Jeremy Sim
Shamali Patwa
Brian Isganitis
Pat Manning
Federico Baron
Schneider Victor-tulias
Priyanka Advani
Uwais Ashraf