Revert submission 32704934-model-test-cleanup
Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.
Reverted changes: /q/submissionid:32704934-model-test-cleanup
Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions
Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit
Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
When using an active model, the data can change on the model thread while
the test is running on a different thread.
Instead using the model data directly without an active model running
Bug: 399155567
Flag: EXEMPT testfix
Test: Presubmit
Change-Id: I332cd7ec0f5a2fb4760ce080f016c725b2233c45
- This is to enable users to theme and shape archived apps
Bug: 402303619
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: performing restore and toggling themed icons on/off
Change-Id: I5883f703c3b0c8df5ee303ea4d99b0c02743faa4
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade
Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
Moving widget filtering to UI layer as it changes with surface
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
Earlier wallpaper preview was reading widgets that were eligible for
displaying in picker, which means widgets that are marked as hidden in
picker wouldn't show up in wallpaper preview.
This fix updates widgets model to maintain map of all widgets (instead of just pickable widgets like before), so that the existing `getWidgetsByComponentKey` function used by wallpaper preview can see all widgets. And, updates picker specific methods to use separate functions (suffixed `forPicker` that filter out picker ineligible widgets when read by picker code).
Bug: 385695615
Test: WidgetsModelTest, WidgetsPredictionUpdateTaskTest and demo
Flag: EXEMPT BUGFIX
Change-Id: I59efe38be0ce1f8a956ba4be42fb6e8b48b5d323
Hotseat apps would not migrate to a new grid if the new grid already had
hosteat filled out. This resolves the issue and addresses the issue of
workspace spots showing up as occuppied when they should be available
Bug: 395786587
Test: GridSizeMigrationTest, GridMigrationTest, ValidGridMigrationTest
Flag: EXEMPT bugfix
Change-Id: I79613986702c7dddf15a9a31c29b4ef59eac2b3a
This reverts commit abbb991d8f.
Reason for revert: DroidMonitor: Potential culprit for Bug X - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: Ifa241a631a1a4361623cfe0e81e31ca6b44e9d73
- includes loading icons for AllApps as archived apps show there as well
Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
CheckLongPressHelper: Cancelling view longpress which inturn also cancels self
This ensures that long press is properly cancelled if the default timeout for system longpress is same as ours
Bug: 379777736
Bug: 379807782
Bug: 379805363
Bug: 379805788
Bug: 379777734
Bug: 379774350
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ic4d9d6c4f79325a5d7ab98eafa1c86db4c2e67a5
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
Revert submission 29570743-fix-default-app-icons
Reason for revert: possible culprit of b/371183869
Reverted changes: /q/submissionid:29570743-fix-default-app-icons
Change-Id: I6be362d03791893f94d3393bf9c9ffc4d9e83ec9
The implementation in this CL is no-op i.e. all widgets will be shown
Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately
In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
> This will make it easier to migrate to dagger as it will
increase the number of constructor parameters significantly
Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
This makes the behavior same as instrumentation test
Bug: 370080120
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: Id4183c91f3951748b657b583fde8860abe55d3a8
> This avoids duplicate RPCs when trying to get multiple properties
from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
logic in IconCache
Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
package validation happens during loader anyway. And using MATCH_INSTALLED
for checking cross user apps may not work all the time
Bug: 363324203
Test: atest GridSizeMigrationUtilTest
Flag: EXEMPT bug fix
Change-Id: Id36e8fdff132242705ef53c85dc6567fbde5d952
Sunny Goyal
Priyanka Advani (xWF)
Charlie Anderson
Federico Baron
Shamali Patwa
Liana Kazanova (xWF)
Treehugger Robot
Stefan Andonian
Sihua Ma
Uwais Ashraf