Commit Graph

15274 Commits

Author SHA1 Message Date
Sebastián Franco 05eb665281 Merge "Decoupling the reorder logic from the CellLayout view" into tm-qpr-dev am: 90ff89e2b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20832424

Change-Id: I888958a5ea8890111506857c90c62a89ded16ba7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 01:00:46 +00:00
Sebastián Franco 90ff89e2b9 Merge "Decoupling the reorder logic from the CellLayout view" into tm-qpr-dev 2023-03-07 00:24:33 +00:00
Hyunyoung Song a10811b4fe Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev am: eeee84efb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21447384

Change-Id: I97443edd17e2c0d4982a9a63bdd61c78c1b9e4e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 18:39:09 +00:00
Hyunyoung Song eeee84efb6 Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev 2023-03-06 18:23:32 +00:00
Sunny Goyal 5a4ff1a073 Merge "Simplifying code around multiple translation components" into tm-qpr-dev am: 33c3e77411
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593003

Change-Id: Id4e43cb78aa1aaeca74c0c3ee449e9bda91924aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:44:31 +00:00
Brian Isganitis 0c15dabc48 Merge changes from topic "running-in-test-camel" into tm-qpr-dev am: d2d2913812
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21725479

Change-Id: Iad48010b9309567049338220a2300cf85f7567c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:39 +00:00
Sunny Goyal 33c3e77411 Merge "Simplifying code around multiple translation components" into tm-qpr-dev 2023-03-04 00:59:54 +00:00
Sebastian Franco e4c0345747 Decoupling the reorder logic from the CellLayout view
ReorderAlgorithm will now handle all the logic associated with the
reorder. Basically all the logic associated with a reorder in CellLayout
was copy and pasted into ReorderAlgorithm.java.

Test: atest TestReorderAlgorithm
Bug: 229292911
Change-Id: Ie096abc346bf705414e47452a42d1dec5be0a041
2023-03-03 16:57:02 -08:00
Brian Isganitis d2d2913812 Merge changes from topic "running-in-test-camel" into tm-qpr-dev
* changes:
  Expose IS_RUNNING_IN_TEST_HARNESS as static method.
  Make isTooltipEnabled a getter due to its mutable dependencies.
2023-03-03 23:15:38 +00:00
Sunny Goyal c2cc5c57c4 Merge "Adding support for overriding flag values in test" into tm-qpr-dev am: f450476c7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21733882

Change-Id: I2504ead8caa9c2db320872899167a4cef0b21e9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:44:09 +00:00
Sunny Goyal f450476c7a Merge "Adding support for overriding flag values in test" into tm-qpr-dev 2023-03-03 19:38:38 +00:00
TreeHugger Robot b753941838 Merge "Set range of overlay for pending download app animation to 0-75% from 0-50%" into tm-qpr-dev am: 7cad8cfce0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21728407

Change-Id: Ic7a25baa67a72b6b1cae8466cd1854dcf1478fac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:36:40 +00:00
TreeHugger Robot 7cad8cfce0 Merge "Set range of overlay for pending download app animation to 0-75% from 0-50%" into tm-qpr-dev 2023-03-03 18:11:55 +00:00
Sunny Goyal b138ec9fc6 Adding support for overriding flag values in test
Bug: 270386012
Test: Verified on device
Change-Id: Ic1af9ca369c0cd2ec49d98875f7b97e90a0050ca
2023-03-03 09:29:42 -08:00
Federico Baron 30b5e78b3a Merge "Widget picker closes and reopens when switching orientation on phones when it's not necessary" into tm-qpr-dev am: 5c17f6b901
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21732117

Change-Id: I8fd694a4a9cd1a4eca26cefbb9bf44e846760a09
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 01:45:46 +00:00
Sebastián Franco ccb06b0184 Merge "Fix widget resize if it last for too long on Multipage CellLayout" into tm-qpr-dev am: 30425b18be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21680045

Change-Id: I75288bce52bbb86900ca600693e9af6cde358d07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 01:41:34 +00:00
Federico Baron 5c17f6b901 Merge "Widget picker closes and reopens when switching orientation on phones when it's not necessary" into tm-qpr-dev 2023-03-03 01:21:52 +00:00
Sebastián Franco 30425b18be Merge "Fix widget resize if it last for too long on Multipage CellLayout" into tm-qpr-dev 2023-03-03 00:59:16 +00:00
Brian Isganitis fdd044e16e Expose IS_RUNNING_IN_TEST_HARNESS as static method.
This variable is now mutable, making the uppercase format misleading.
For instance, users might assume they can use this value in other
immutable properties, when they really should be accessing the latest
value every time they need it.

Context: https://source.android.com/docs/setup/contribute/code-style#follow-field-naming-conventions

Test: Manual
Bug: 271160958
Change-Id: Iaaa51d9153cb8a7d686c72e1210b1948029dcfd5
2023-03-03 00:17:33 +00:00
Federico Baron b25d758827 Widget picker closes and reopens when switching orientation on phones when it's not necessary
Widget picker closes and reopens when switching orientation on phones when it's not necessary. We should only close and reopen widget picker if it's tablet since that's when we want to inflate either the regular widget picker or the two pane widget picker. When we're on a phone, we always want to inflate the regular widget picker, so closing and re-inflating is not needed.

Fix: 271474746
Test: Change orientation in phones vs tablets. Verify that both still work.
Change-Id: I6062b056c4e7675bc830b6884761ec1f2eb20b1d
2023-03-02 14:10:09 -08:00
Federico Baron 5f811c9dad Set range of overlay for pending download app animation to 0-75% from 0-50%
The pending download app animation had an overlay that ranged from 0% to 50% opacity. With this CL we shift the range to 0-75%.

Fix: 271470372
Test: download an app and see the animation for pending download
Change-Id: Ib0332eca2dad37efa916a9410e9466cc63574b5a
2023-03-02 22:08:00 +00:00
Sunny Goyal 82dfc15037 Simplifying code around multiple translation components
Bug: 270759683
Test: Verified on device
Change-Id: I6c758c715828ae25e0e3c60b793cf85d70cb2487
2023-03-02 12:22:03 -08:00
Luca Zuccarini f295e3a85a Hide the splash icon when launching with no view and no item.
This is achieved by instead creating an empty item info that only
specifies the splash type to be solid color.

Bug: 269343536
Test: manual
Change-Id: Ibf5c8f1c949e26af207b8c6e382f71677b9acc2d
2023-03-02 18:19:38 +00:00
Sunny Goyal 5d41fbc53a Merge "Restarting launcher if a flag changes" into tm-qpr-dev am: f4bead71ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21118642

Change-Id: If745a819e7d647cc969b42b16cbcf40e9a108b31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 17:06:07 +00:00
Sunny Goyal f4bead71ea Merge "Restarting launcher if a flag changes" into tm-qpr-dev 2023-03-02 16:23:45 +00:00
Stefan Andonian b341f31fc7 Merge "Preload expensive objects before user is unlocked." into tm-qpr-dev am: 86d8db485f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20391179

Change-Id: I41b2afd3616f2f8fb92e6b9a1bb31359e0d4e258
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 07:30:52 +00:00
Stefan Andonian 86d8db485f Merge "Preload expensive objects before user is unlocked." into tm-qpr-dev 2023-03-02 07:06:54 +00:00
Sunny Goyal c615f883d5 Merge "Removing some usused features" into tm-qpr-dev am: fc45621b36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21675357

Change-Id: Ic301ac2ca894ced2beb5ff8f44e088aaddff4a95
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 01:03:13 +00:00
Sunny Goyal fc45621b36 Merge "Removing some usused features" into tm-qpr-dev 2023-03-02 00:34:00 +00:00
Stefan Andonian 5bd9a225a8 Preload expensive objects before user is unlocked.
This change includes migrating data required for starting the launcher
from encrypted storage into device protected storage. All of the data
being moved has already been approved by the correct authorities.

Bug: 251502424
Test: Performed latency testing using logs from user unlock until first
workspace screen loaded.

Change-Id: I58b0cd1c7bad260c2252f9e172ef85ab885c7fe9
2023-03-01 23:09:07 +00:00
Sebastian Franco c515d02f28 Fix widget resize if it last for too long on Multipage CellLayout
We need to make sure the seam is added when the countX is even
checking for => and if you reszie for a while the occupied grid
starts to have incorrect values.

Fix: 270227019
Test: atest FoldableItemsIntegrity
Test: atest ReorderWidgets
Change-Id: I3faf5d23427dc966c48ce5c613e68e42a101f45b
2023-03-01 13:51:24 -08:00
Andy Wickham ff1c9b678c Merge "Resets All Apps pullback alpha on state change." into tm-qpr-dev am: c94355aa45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21644582

Change-Id: I4ecab91b9f33cdb99e6fdbf018d9e27fa8b9125d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 19:37:20 +00:00
Jeremy Sim baa93c42cb Merge "Fix bug with rotating in the middle of split select staging animation" into tm-qpr-dev am: a49569a90e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21551330

Change-Id: I321507bda3f22ad4aa228a9a15235e576cdf703a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 19:35:02 +00:00
Andy Wickham c94355aa45 Merge "Resets All Apps pullback alpha on state change." into tm-qpr-dev 2023-03-01 19:08:35 +00:00
Jeremy Sim a49569a90e Merge "Fix bug with rotating in the middle of split select staging animation" into tm-qpr-dev 2023-03-01 18:53:00 +00:00
Sunny Goyal 0788fd792e Removing some usused features
Bug: 270386012
Test: Presubmit
Change-Id: Ica71109d43c42d9d0d5269520f7b7e72921f42a6
2023-03-01 09:51:24 -08:00
Alex Chau a1907c710e Merge "Land ENABLE_TASKBAR_IN_OVERVIEW" into tm-qpr-dev am: 6a10a003d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21538759

Change-Id: I47517820ce6448ac3b123ac1044ef07ccc60308b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 17:43:43 +00:00
Alex Chau 6a10a003d6 Merge "Land ENABLE_TASKBAR_IN_OVERVIEW" into tm-qpr-dev 2023-03-01 17:13:35 +00:00
Jordan Demeulenaere 652ec4997a Format files with the upcoming version of ktfmt am: be82bc661c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21565649

Change-Id: Icd28fd41925b49d0f8c4318365a244e3fa43f637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 13:22:07 +00:00
Jordan Demeulenaere be82bc661c Format files with the upcoming version of ktfmt
This CL was generated automatically from the following command:

$ external/ktfmt/prepare_upgrade.py --repo=packages/apps/Launcher3/ --build_id=9645412 --bug_id=266197805

This CL formats all files already correctly formatted with the upcoming
version of ktfmt.

Bug: 266197805
Test: Presubmits
Change-Id: Ide7d63a75fed98aabe348821355356c77f00a9ec
Merged-In: Ide7d63a75fed98aabe348821355356c77f00a9ec
2023-03-01 09:11:48 +00:00
Liam, Lee Pong Lam bb243c385f Add feature flag for remove smartspace default date am: 237d663b70
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532517

Change-Id: I9d2d8bbe5a42027806fc09913dd524938b69de73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 08:59:00 +00:00
Liam, Lee Pong Lam 237d663b70 Add feature flag for remove smartspace default date
Bug: 269761613
Test: Manual

Change-Id: I9d315a5889bb35efa4b3db91e3af6c981c6b9665
2023-03-01 03:46:37 +00:00
Jeremy Sim 8477226a3d Fix bug with rotating in the middle of split select staging animation
This patch fixes a bug where a user could cause a crash by rotating the device in the middle of the split staging animation.

The bug arose because:
1) Normally, when you rotate the device, reapplyState() is called to refresh the UI. This reloads the state, cancels any animations that happen to be running at the time, and generally works fine in most cases.
2) When animations are canceled within Overview, we also call RecentsView#reset() to clean up loose ends and prevent bugs.
3) Unlike other states, the split select state is unique because it is a transient state that holds the user's choices temporarily. If that information was cleared -- by reset() -- before it loads, it will crash.

Fixed by creating a new function in SplitScreenSelectState, onStateReapplied(), that is called when a reload is occurring. It makes sure that animations do not get canceled by calling end() to accelerate them to completion before the reloading occurs.

Fixes: 249819567
Test: Manual
Change-Id: I70c4651bcb5df81edd25f6e58e21520ebb391d01
2023-02-28 17:13:36 -08:00
Alex Chau 8aa3f00238 Land ENABLE_TASKBAR_IN_OVERVIEW
Fix: 270393449
Test: manual
Change-Id: I731bfa8ee86154fd034781e27272abc81a6fe6c6
2023-02-28 20:18:32 +00:00
Sunny Goyal 2003c1c73f Restarting launcher if a flag changes
> Only restart when the screen is off.
> This allows better propogation of flags similar to systemUI
> Adding support for integer flags

Bug: 266854800
Test: Verified on device using device_config shell command
Change-Id: I4ea9c564f2d973f11f9570b5a21365183afefab7
2023-02-28 12:01:22 -08:00
Sunny Goyal e7fe6b57ff Merge "Moving flag creation to a separate file" into tm-qpr-dev am: 1297f400bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21586607

Change-Id: I0b50d9286e8abab8b3d5f54853f8bfc74141cbb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 19:48:41 +00:00
Sunny Goyal 1297f400bc Merge "Moving flag creation to a separate file" into tm-qpr-dev 2023-02-28 19:18:25 +00:00
Sunny Goyal 98204add71 Moving flag creation to a separate file
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation

Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
Merged-In: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-28 18:05:42 +00:00
Andy Wickham 338491687a Resets All Apps pullback alpha on state change.
Previously the progress alpha was updated, but in some cases (e.g.
0 animation speed), the final alpha was not always applied to the
pullback property.

Fix: 243015279
Test: Disable animations, swipe up to all apps, swipe up nav bar
to close, swipe up to all apps again. Alpha is now properly set.
(See b/232536048#comment49).

Change-Id: Ifb8a4cd3ee7cc94a5851d355fdf52860366b8f2f
2023-02-27 19:06:02 -08:00
Helen Cheuk e129994b8b Merge "Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid" into tm-qpr-dev am: a695986d56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549709

Change-Id: Ief8665d9d3f48f4d356830bb386f0c13f3f68ce2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-27 18:34:19 +00:00