Commit Graph

12532 Commits

Author SHA1 Message Date
Jagrut Desai 04c2bf387a Update taskbar corner roundness progress
This cl simply updates taskbar corner roundness after it finishes initializing all the controllers.

Test: Presubmit
Bug: 370984727
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ieb98835c74cc992f47354dbfa86ededeadf5c786
2024-10-09 14:41:22 -07:00
Sunny Goyal 9dcf307a62 Merge "Fixing test flakiness in Launcher initialization" into main 2024-10-08 17:29:27 +00:00
Fengjiang Li a49a2a32be Merge "[Dagger] Make SettingsCache provided by DaggerSingletonObject" into main 2024-10-08 17:13:20 +00:00
Jagrut Desai d37759429b Merge "Fix Taskbar to Hotseat Animation for Non-Predective back apps" into main 2024-10-08 16:08:09 +00:00
Orhan Uysal 3d7bba6a6e Merge "Use desktop API to remove desktop for dismiss" into main 2024-10-08 15:18:06 +00:00
Liran Binyamin 9c3c7cc3e2 Merge "Store the flyout in BubbleBarBubble" into main 2024-10-08 13:31:53 +00:00
Sukesh Ram fb1088ef87 Merge "Refactor Taskbar Button Coloring Code" into main 2024-10-08 08:06:51 +00:00
Fengjiang Li 4d819d9dea [Dagger] Make SettingsCache provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Id709a6e1d14446b8361cf292d5f5422f2ea3524c
2024-10-07 23:10:53 -07:00
Sunny Goyal b619d2c297 Removing dependency on PackageInfo in IconCache
Bug: 363324203
Flag: EXEMPT bugfix
Test: atest IconCacheTest
      atest IconCacheUpdateHandler

Change-Id: I85005ef1069960a17a0f3e7265749a8ef3004172
2024-10-08 04:09:54 +00:00
Mykola Podolian 5ddf3ba31f Merge "Fixed the hotseat placement in RTL mode" into main 2024-10-08 02:05:42 +00:00
Jagrut Desai 0a65c5bd72 Fix Taskbar to Hotseat Animation for Non-Predective back apps
- Refactored Taskbar animation duration to under one method and added logic to sync animation duration according to enableScalingRevealHomeAnimation.
- Change the interpolator for TaskbarLauncherStateController based on enableScalingRevealHomeAnimation.

Test: Presubmit, Manual
Bug: 369378541
Flag: EXEMPT Bug Fix
Change-Id: I942829b475f91e9102801b758eb7ee0d27eee912
2024-10-07 17:01:00 -07:00
Sukesh Ram 9a723c8f21 Refactor Taskbar Button Coloring Code
Given the emergence of b/341190547, this CL seeks to simply refactor the code for readability to aid in investigation efforts.

Flag: EXEMPT bugfix
Bug: 341190547
Test: Manual
Change-Id: I2e42d9c9e8eebd96d4e507b6dd357d7bedcd4a30
2024-10-07 16:03:38 -07:00
Ats Jenk ea6e59537e Merge changes I74af6a72,I603a67a8 into main
* changes:
  Animate bubble bar alpha when notif shade opens
  Set bubble bar invisible while stashed
2024-10-07 22:23:02 +00:00
Liran Binyamin 5e04f0960d Store the flyout in BubbleBarBubble
Extracts the flyout message from the bundle and stores it in
BubbleBarBubble.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet
Change-Id: I5e810290991b4ee638f43add4d6a6514edb167af
2024-10-07 16:57:08 -04:00
Treehugger Robot 84f7220dd5 Merge "Add Recents Window logs to ProtoLog" into main 2024-10-07 19:31:06 +00:00
Tony Wickham fc267fbd69 Merge "Don't invalidate swipe handler until parallel anim finishes" into main 2024-10-07 19:17:03 +00:00
Liran Binyamin 9b093db2f8 Merge "Rename bubble bar flyout fields" into main 2024-10-07 18:27:14 +00:00
mpodolian 3dcb19f33a Fixed the hotseat placement in RTL mode
Updated logic that computest the hotseat shift.

Fixes: 372014534
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Put device into 3 buttons navigation mode, force RTL.
Hotseat is placed next to the navigation buttons bar.

Change-Id: Ie7b6be11a093ffa4006182bdc0b73018ba799246
2024-10-07 10:34:42 -07:00
Schneider Victor-Tulias f3f182a7ef Add Recents Window logs to ProtoLog
Flag: com.android.launcher3.enable_recents_window_proto_log
Bug: 292269949
Test: checked protologs in winscope
Change-Id: Iaafe58a655e9ad7293b579c74b7e7ecaa2df1ea5
2024-10-07 17:14:24 +00:00
Tony Wickham ee98cd4bdf Don't invalidate swipe handler until parallel anim finishes
- When invalidateHandler() is called, it calls endRunningWindowAnim()
  which includes mParallelRunningAnim. This causes a jump if
  mParallelRunningAnim was not already finished, so we now wait to
  invalidate the handler after mParallelRunningAnim ends.

Flag: EXEMPT bugfix
Test: AbsSwipeUpHandlerTestCase (added two tests for this)
Fixes: 370208192
Change-Id: I37ed281a993b1d2fa3634754378314511f3295f0
2024-10-07 16:45:19 +00:00
Orhan Uysal c2adf8cf9c Use desktop API to remove desktop for dismiss
When overview tile for desktop is dismissed, use the shell API instead
of calling the system server directly to remove tasks in the desktop.
This let's desktop fix it's state and call the system server instead.

Bug: 370757235
Test: m and dismiss overview tile from desktop
Flag: com.android.window.flags.enable_desktop_windowing_back_navigation

Change-Id: Ia2abd0ab5a27759c92e0328beb460810ad2af898
2024-10-07 16:39:54 +00:00
Liran Binyamin 75675e123d Rename bubble bar flyout fields
Long term we'd like to use bubbles for any app, so this change
uses more general names instead of the chat-specific naming

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: built and tested on a device
Change-Id: Idec2aa7d9a8df5df0df49231e8871298084f8aa1
2024-10-07 10:37:55 -04:00
Fengjiang Li 9a949ff4ca [Dagger] Make WellbeingModel provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Ie23411457185ab31380f3b0efb660e7dd9d73f29
2024-10-06 00:40:51 -07:00
Sunny Goyal 95045ce03a Fixing test flakiness in Launcher initialization
Using same key for blob store and content provider based layouts

Using a single key for layout provider. This ensures that if one
test doesn't cleanup properly, any followup test which relies on
model initialization overrides the key appropriately

Bug: 370080120
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Idef0a89a5d1ec89e24aae8a4549fd122634dad2f
2024-10-04 20:52:17 +00:00
Mykola Podolian 409b62cb33 Merge "3 button nav is laid out correctly." into main 2024-10-04 20:01:58 +00:00
Vinay Joglekar b0354e7be9 Merge "Fix a bug where the running task would be drawn below recents task" into main 2024-10-04 18:25:58 +00:00
Matt Sziklay f843e5dd53 Merge "Add split instructions view to desktop split." into main 2024-10-04 18:00:36 +00:00
Vinay Joglekar ca94ef431f Merge "Fix a bug where the last large task index was not being set correctly." into main 2024-10-04 17:30:34 +00:00
Treehugger Robot 8f7dd208ba Merge "[NPE] Fix NPE of TaskInfo in FloatingWidgetView#getDefaultBackgroundColor" into main 2024-10-04 17:05:34 +00:00
Jordan Silva c407f1aa5a Fix a bug where the running task would be drawn below recents task
When the live tile is the adjacent app to be launched, it will wrongly update the pivot and translate all the tasks to the side, resulting in a broken animation.

This bug was introduced in ag/29639296, while fixing the launch of the the adjacent task while the live tile was in the center of the screen. To solve this excessive translation, we need to update pivot only when adjacent task is not a live tile.

Bug: 361744056
Change-Id: I56cbabcc351b0becd791b58dd94f65cd0b533bc2
Test: Launch central/side large tile with different live tile combinations
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
2024-10-04 07:55:25 +00:00
Jordan Silva 06dbdcea4e Fix a bug where the last large task index was not being set correctly.
This was causing the focused task shift to be calculated incorrectly, which was resulting in the focused task being shifted too far to the left.


Bug: 330342294
Fix: 371490320
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual. Open 1 DesktopTask, 1 FocusedTask, 2 other tasks in the grid. Dismiss the focused task. The rebalance should work keeping the new focused task next to desktop task.
Change-Id: If6f95814942c2cbadc30a0082649569f21dea60a
2024-10-04 07:28:42 +00:00
Treehugger Robot 5a90a5ab96 Merge "Fix for recents button quick switch with only focus and desktop task" into main 2024-10-04 05:05:37 +00:00
vinayjoglekar b6ac8b2ae9 Fix for recents button quick switch with only focus and desktop task
This CL also fixes : Home -> Recents -> Recents opens the last large tile (Which was broken when there is desktop window tile in recents.)

Test: Manual
BUG: 365756337
Fix: 365756337
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0b8fe3a0a7074355f14ced23ae282fe2943d8ce9
2024-10-03 18:58:48 -07:00
mpodolian 989aa8ac83 3 button nav is laid out correctly.
Updated logic of laying out the 3 nav buttons container. Also updated
placement of the hotseat, so it is not shifted on the phone.

Test: Manual. Fold and unfold felix with and without bubbles. Reboot
the devices and perform the same test.
Fixes: 370773620
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7d5ba51f7ded275f7456a8690d04001b9651f6c5
2024-10-03 16:57:58 -07:00
Ats Jenk d819f32e46 Animate bubble bar alpha when notif shade opens
Similar to taskbar, animate the alpha for bubble bar when notification
shade is expanded.

Bug: 345687278
Test: have bubbles on home screen, swipe down notification shade,
  bubbles are hidden with an animation
Test: have bubbles in app, stashed, swipe down notification shade,
  no change
Test: have bubbles in app, unstashed, swipe down notification shade,
  bubbles hidden with an animation
Test: receive bubble notification while shade is open, check that
  bubble bar is not shown

Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I74af6a7230f81628540f9b935cbe7dc801bd7a01
2024-10-03 15:33:38 -07:00
Ats Jenk 2166749190 Set bubble bar invisible while stashed
Update bubble bar visibility when it is stashed.
Ensures that if alpha is updated, it won't show up.

Bug: 345687278
Test: TransientBubbleStashController
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I603a67a824a5cee0fb35de7c3f2dc98d9d2323ed
2024-10-03 15:33:38 -07:00
Ats Jenk 2f3d7b16c6 Merge "Apply bubble bar background alpha to stroke paint" into main 2024-10-03 20:20:08 +00:00
Mady Mellor 2aedf52b8f Merge "If we're going to overview we might need to unstash" into main 2024-10-03 16:12:09 +00:00
Orhan Uysal 4acf699619 Merge "Fix overview animation after reboot." into main 2024-10-03 14:01:57 +00:00
Shamali Patwa b5c32d4c4f Merge "Add logs in ProxyActivityStarter when it fails to launch an activity" into main 2024-10-03 02:35:54 +00:00
Treehugger Robot 1bbcff3d48 Merge "Fix an issue where bubble bar would collapse when rotating" into main 2024-10-03 02:07:02 +00:00
Shamali P 66b501eae2 Add logs in ProxyActivityStarter when it fails to launch an activity
Apparently, it doesn't log when it fails due to some reason.

In 369422714, we see it being started but the appwidget's config
 activity not being launched. The absorbed exception makes it harder to
  know. There isn't a system log as well.

  At least looking at logs, we think for some reason appwidget's
   configuration activity wasn't launched by launcher.

Bug: 369422714
Test: N/A logging
Flag: EXEMPT BUGFIX

Change-Id: I56294ef37d7ddceb61c4e6d0e10d0f24fde42cb2
2024-10-02 22:33:39 +00:00
Fengjiang Li a909cc2dd7 [NPE] Fix NPE of TaskInfo in FloatingWidgetView#getDefaultBackgroundColor
Fix: 370315165
Flag: NONE - prod crash
Test: presubmit
Change-Id: I50e71f0611fc9c664cfe51fbe9c3fc21462e10ed
2024-10-02 14:30:08 -07:00
Mady Mellor 3e8cc610b3 Fix an issue where bubble bar would collapse when rotating
When the device is rotated, everything gets recreated, in this case,
bubble bar state is typically set to be stashed. However, if taskbar
and bubble bar were unstashed while rotating, bubble bar would be
incorrectly stashed. To fix this, only do the stash if taskbar is
also stashed in this case.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - be in an app, unstash bubbles, rotate device
             => observe that bubble bar is unstashed like taskbar
                after rotation
Bug: 353884121
Change-Id: Ia37397c62a1a6819c1bd42261f8a9955db511da3
2024-10-02 13:55:55 -07:00
Ats Jenk ad7a938268 Apply bubble bar background alpha to stroke paint
Alpha was applied to fill paint only. Add it to stroke paint as well.
Introduce a new method in Utilities to map range of ints and not only
floats.

Bug: 345687278
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7c9e8d6337a857a661de0c945181cdd5ef2fd4ca
2024-10-02 10:20:06 -07:00
Liran Binyamin 1663bb3004 Merge "Bubble bar flyout polish" into main 2024-10-02 16:15:53 +00:00
Treehugger Robot d8daf184bc Merge "Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into main 2024-10-02 15:55:45 +00:00
Schneider Victor-Tulias 9240b68dd6 Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
Flag: EXEMPT bug fix
Fixes: 369359244
Test: performance testing
Change-Id: Id70c4b02738fd1abd62027fcddd0fac3c99fe95e
2024-10-02 14:15:56 +00:00
Treehugger Robot 5c3e15b0e0 Merge "Fix small bug with TaskView tile expansion" into main 2024-10-02 02:13:04 +00:00
Treehugger Robot b4b2d16bcc Merge "Fix translation when focused task or desktop task is dismissed. (3/4)" into main 2024-10-02 00:38:10 +00:00