Commit Graph

11383 Commits

Author SHA1 Message Date
Alex Chau 040f9023f3 Merge "Set controllersInitialized to false when destroying taskbar controllers" into tm-qpr-dev am: d5bccf19c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20112637

Change-Id: Id8d068137811f36a3151fc2b8a631f4f8510c698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 20:51:36 +00:00
Alex Chau d5bccf19c4 Merge "Set controllersInitialized to false when destroying taskbar controllers" into tm-qpr-dev 2022-10-05 20:24:04 +00:00
Alex Chau 72c08d9255 Set controllersInitialized to false when destroying taskbar controllers
Bug: 250912179
Test: presubmit
Change-Id: I16532e99b8f74542def4283b6cc753673eb5ee2d
2022-10-05 15:46:31 +01:00
Nick Chameyev 40497595fe Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev am: 3e7c611358
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20034765

Change-Id: Iadd1c8c50783459352c8543f723b9b1c509eabb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 13:18:03 +00:00
Nick Chameyev 3e7c611358 Merge "Extract PreviewPositionHelper to shared library" into tm-qpr-dev 2022-10-05 12:52:02 +00:00
Johannes Gallmann ad6d2fca0a Merge "Disable split button instead of hiding it" into tm-qpr-dev am: 72f5b73f5d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967444

Change-Id: Idb43c472ee37dc9356ac0c0bb50ac71ba08f3e24
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 10:56:54 +00:00
Johannes Gallmann 72f5b73f5d Merge "Disable split button instead of hiding it" into tm-qpr-dev 2022-10-05 10:29:55 +00:00
Thales Lima a3989e5ab8 Merge "Change taskbar edu size to wrap around icons" into tm-qpr-dev am: 9c32f4c7d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20010056

Change-Id: I4370ab13a97d5a0382587d7f1f4e429f8f779d7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 09:41:33 +00:00
Alex Chau 6db97df61b Merge "Taskbar in overview" into tm-qpr-dev am: 5e47e78a17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19866366

Change-Id: I4be28fef85efc59f4f2cd3f183f29b684d5be649
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 09:41:08 +00:00
Thales Lima 9c32f4c7d8 Merge "Change taskbar edu size to wrap around icons" into tm-qpr-dev 2022-10-05 09:39:46 +00:00
Nick Chameyev cbfb35edc7 Extract PreviewPositionHelper to shared library
Moves Launcher's PreviewPositionHelper to shared
library between SystemUI and Launcher to reuse
it in the future in the partial screensharing
recents selector.

There should be no functional changes in the
code itself.

Bug: 240924926
Test: presubmit
Change-Id: Ib38b6f9db91e63a2598bf81229e3cd3e1a49ca60
2022-10-05 10:23:54 +01:00
Alex Chau 5e47e78a17 Merge "Taskbar in overview" into tm-qpr-dev 2022-10-05 08:58:31 +00:00
Ming-Shin Lu 6013ab3776 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev am: 8ff85dc733
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20064292

Change-Id: I76470c6f6dd2a45ee80682d564b83fd3c24d9069
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 07:14:31 +00:00
Ming-Shin Lu 8ff85dc733 Merge "TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation" into tm-qpr-dev 2022-10-05 06:43:42 +00:00
Ming-Shin Lu 4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
2022-10-05 11:37:37 +08:00
Tracy Zhou b2cd75e5df Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev am: d7a7bfc304
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20079254

Change-Id: I35c73d16ad7833faef59009b1d17800570763f13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 20:35:37 +00:00
Tracy Zhou d7a7bfc304 Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev 2022-10-04 20:02:30 +00:00
TreeHugger Robot 93767d52ad Merge "Reset TaskView transformations on orientationHandler change" into tm-qpr-dev am: 6a84ebc7ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19981469

Change-Id: Idbfcb5231cf25cd402cd70e79e5eb0f75a5b5d2e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 19:52:43 +00:00
Vinit Nayak e0f012491c Merge "Hide back button if IME shows in SUW" into tm-qpr-dev am: 188c8916ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004092

Change-Id: Ia2e8a03d8e0ab2786668300ef611379c742b337c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 19:51:42 +00:00
TreeHugger Robot 6a84ebc7ab Merge "Reset TaskView transformations on orientationHandler change" into tm-qpr-dev 2022-10-04 19:05:43 +00:00
Vinit Nayak 188c8916ee Merge "Hide back button if IME shows in SUW" into tm-qpr-dev 2022-10-04 19:01:42 +00:00
Winson Chung 7d0d0f2bbd Merge "Updating launcher for pip interface cleanup" into tm-qpr-dev am: a5846c9868
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20106888

Change-Id: I8648bf54cadd21aef823e7881b67e84d6a34f172
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 17:19:50 +00:00
Winson Chung a5846c9868 Merge "Updating launcher for pip interface cleanup" into tm-qpr-dev 2022-10-04 16:54:48 +00:00
Pat Manning 2d8a1ef7b6 Merge "Refresh taskbar apps show on DeviceProfile change." into tm-qpr-dev am: 0fa114ecc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19951576

Change-Id: I7663f59ecdbca4121d72f8929f74c7a02b89032f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 12:07:08 +00:00
Pat Manning 0fa114ecc0 Merge "Refresh taskbar apps show on DeviceProfile change." into tm-qpr-dev 2022-10-04 11:46:48 +00:00
Alex Chau 4cbe626712 Merge "Refactor TaskbarLauncherStateController to use a single AnimatedFLoat" into tm-qpr-dev am: 2f7fd17dc1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20082145

Change-Id: I719211763f768d08979dce6953e6d5c2bb6a8ea3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 10:34:19 +00:00
Thales Lima 5e92948c42 Merge "Check for view measurement before animating" into tm-qpr-dev am: e8efdc1185
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20073475

Change-Id: Ie0f8c40567dce7ab39ef397f4e135f4378c198d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 10:34:09 +00:00
Alex Chau 2f7fd17dc1 Merge "Refactor TaskbarLauncherStateController to use a single AnimatedFLoat" into tm-qpr-dev 2022-10-04 10:32:54 +00:00
Thales Lima e8efdc1185 Merge "Check for view measurement before animating" into tm-qpr-dev 2022-10-04 10:09:10 +00:00
Vinit Nayak 55298f9901 Merge "Add margin to SUW back button" into tm-qpr-dev am: 64510b48b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20004084

Change-Id: Ib2daed04fdd78f8e80ad16725d5d6b80524708bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 03:43:21 +00:00
Vinit Nayak 64510b48b0 Merge "Add margin to SUW back button" into tm-qpr-dev 2022-10-04 03:10:21 +00:00
Jeremy Sim 37638afbec Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev am: 33e57ebc1a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20103367

Change-Id: If54807ba3c13eb9d8a8ccdc0defa69b35beca442
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-04 00:12:23 +00:00
Winson Chung 1c3f817f89 Updating launcher for pip interface cleanup
Bug: 238217847
Test: atest WMShellUnitTests
Change-Id: I375e67eeb07ffe50bf15eafb65c1e9d215118c73
2022-10-03 23:56:39 +00:00
Jeremy Sim 33e57ebc1a Merge "Fix animation slowdown when splitting from All Apps" into tm-qpr-dev 2022-10-03 23:31:59 +00:00
Vinit Nayak b03ec55872 Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev am: 66160e9dd8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029582

Change-Id: I2f2ce0e026d6dbecaacdd7f026e208d658249eae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 23:14:57 +00:00
Vinit Nayak 66160e9dd8 Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev 2022-10-03 22:45:42 +00:00
Jeremy Sim 86065b81e0 Fix animation slowdown when splitting from All Apps
This patch fixes a tablet bug related to splitting from All Apps. Splitting from AllApps was playing a very slow animation.

The bug occurred because there was no case set in QuickstepAtomicAnimationFactory for animating from the ALL_APPS state.

Fixed by setting the appropriate case in QuickstepAtomicAnimationFactory.

Fixes: 247053528
Test: Manual
Change-Id: I7391dc7049a6ff5a7f8c7e1ae8b69e29899248fa
2022-10-03 12:49:31 -07:00
Alex Chau d67ddc4920 Taskbar in overview
- Behind ENABLE_TASKBAR_IN_OVERVIEW which is disabled by defualt
- Make taskbar unstashed in overview with background visible
- Ensure taskbar is touchable in overview

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with ENABLE_TASKBAR_IN_OVERVIEW x taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ib25d68f68e89564851b226536e456d0b2f6306f8
2022-10-03 20:15:12 +01:00
Stefan Andonian 371ba32e44 Fix ViewCapture NPE. am: b759de4769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075879

Change-Id: I1c44ad208cc7d36d070971ef507c735ca385cdfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 18:40:33 +00:00
Stefan Andonian b759de4769 Fix ViewCapture NPE.
The ViewPropertyRefs, when copied from 1 frame to another, where also
transferring the same "next" reference. Sometimes, the recycled
ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied
ViewPropertyRefs, which would caused an NPE, since the recycled VPR
would have it's next value set to null.

Bug: 249125402
Test: Repro steps are dragging and dropping around an item on the
workspace to different locations. This consistently repro's the crash in
about 10 seconds of doing this. Afte the fix, the crash stopped.

Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada
2022-10-03 15:25:04 +00:00
Alex Chau 58bc281142 Refactor TaskbarLauncherStateController to use a single AnimatedFLoat
- Use a single iconAlignment animation
- Introduced isInLauncher/goingToLauncher/FLAGS_LAUNCHER as combined FLAG_RESUMED|FLAG_RECENTS_ANIMATION_RUNNING
- iconAlignment is now centralized in onStateChangeApplied with single source of truth

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ie51b602394c155aca060a84585eb0e677e23425c
2022-10-03 11:24:00 +01:00
Jeremy Sim 635815666c Fix 2 bugs involving split staging task translation am: 978b0021a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20087546

Change-Id: Iffca62d17d40b168ff53c5624dc09dda2fbe4fec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-01 01:23:06 +00:00
Jeremy Sim 978b0021a9 Fix 2 bugs involving split staging task translation
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.

Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().

Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
2022-09-30 14:30:04 -07:00
Thales Lima 517cafff18 Check for view measurement before animating
Sometimes the view is there but it was not measured yet, and that was making the animation run with wrong icon position values.

Fix: 233247401
Test: manual
Change-Id: Ibcce24391e99b02ecdb492191c39b62d332abe4f
2022-09-30 16:04:42 +01:00
Vinit Nayak 7523b94105 Hide back button if IME shows in SUW
Fixes: 230830643
Test: Visually see no back button when IME
shows up on enter pin screen

Change-Id: Icdde92d39962c3891a56bb07de5b16a22635729e
2022-09-29 15:47:15 -07:00
Vinit Nayak c7295ee37a Add margin to SUW back button
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.

Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity

Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
2022-09-29 15:47:15 -07:00
Brian Isganitis 00f9389e4e Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647

Change-Id: Ie484ca3d0918573c7e706ddea23823ea82cc9f1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 21:41:47 +00:00
Brian Isganitis f733a716fd Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev 2022-09-29 21:13:59 +00:00
Tracy Zhou c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
Vinit Nayak 64e8d014a0 Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375

Change-Id: I897b8dde1e1691f4fc2c9ca632dcf7579f186b3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 18:58:35 +00:00