Commit Graph

1072 Commits

Author SHA1 Message Date
Sunny Goyal 5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Sunny Goyal fc2735ed96 Fixing widgets broken during reconfiguration
Async widget inflation may complete after the updates have been deferred,
leading the widget to a broken state.
Reapply widget if its root content changed while deferred

Bug: 375442765
Bug: 327696338
Test: Verified manually
Flag: EXEMPT bugfix
Change-Id: I78d0f4ce92ee9bd2ee001de3a0e181f2e727218c
2025-02-27 12:36:15 -08:00
Sunny Goyal c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Owner Cleanup Bot 27dae5ff63 Merge "[owners] Remove zakcohen@google.com from src/com/android/launcher3/widget/picker/OWNERS" into main am: 40e6992c56 am: 3e6ebbb761
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490733

Change-Id: I0c033754c4c3767efb56556e1187d66af28b139a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-18 14:33:42 -08:00
Owner Cleanup Bot b0a7ca0dbb [owners] Remove zakcohen@google.com from src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ibb729a15daafdf804c57c080a72ab8004f6861a0
2025-02-11 16:02:48 -08:00
Cole Faust 04bff7b50c Merge "Replace .toList() with .collect()" into main 2025-02-10 11:59:47 -08:00
Sunny Goyal edc1453cf1 Removing BaseDraggingActivity
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class

Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
2025-02-03 17:23:10 -08:00
Cole Faust ad78da873d Replace .toList() with .collect()
.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().

This was found while updating android lint.

Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: I71fd1435b7645ea4f1f653c05fef1ddc47adbc14
Merged-In: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
2025-02-03 14:19:57 -08:00
Cole Faust 1b9fd985d4 Replace .toList() with .collect()
.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().

This was found while updating android lint.

Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
2025-02-03 14:19:12 -08:00
Shamali P 29715c0a00 Fix issue that talkback announces click label on pin sheet
Pin sheet doesn't support tap-to-add, so doesn't need tap announcement.

Bug: 390562493
Fix: 390562493
Test: With talkback
Flag: EXEMPT bugfix
Change-Id: Iad71248f288e73f4dfbc9077ce8a2454bb5e3e56
2025-02-03 07:00:36 -08:00
Sunny Goyal dfbbebc9e3 Revert^2 "Unifying various model update callbacks into one"
72f9943f64

Change-Id: I38901714947a2b7926723ea25df4a2b8216303e4
2025-01-30 13:19:32 -08:00
Pechetty Sravani (xWF) 72f9943f64 Revert "Unifying various model update callbacks into one"
Revert submission 31445615-model-callbacks

Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>

Reverted changes: /q/submissionid:31445615-model-callbacks

Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
2025-01-29 22:46:55 -08:00
Sunny Goyal 36c3112abf Unifying various model update callbacks into one
Making the BubbleTextView.applyItem stateless so that it does not depend on the order of events

Bug: 390572144
Flag: EXEMPT refactor
Test: atest LauncherBindableItemsContainerTest
      atest BubbleTextViewTest
Change-Id: Ib9c0ac6c330d6f4e08c3db5772d35787fa056b65
2025-01-28 16:03:01 -08:00
Shamali P 7d64195793 Fix issue that recommendations were visible in landscape mode.
ag/30344959 showed the recommendations if available, to avoid the issue
of widgets list flashing when exiting search mode. However, we usually
hide recommendations in phone landscape due to the sticky header layout
not having enough space. In this fix, instead, we rebind recommendations
as before (to let the logic there decide whether to show or hide them),
and in order to fix the flashing problem that the earlier change was handling, we reset the recycler view.

Bug: 391231345
Flag: EXEMPT bugfix
Test: Manual, we don't have tests for interactions between screens
Change-Id: I535aa43cc553c9287c5d38ef7cde30f01e84d347
2025-01-22 16:19:35 -08:00
Sebastian Franco 5a9280203b Fix Widgets in portrait being restricted by landscape grid and vice-versa
Fix: 380049023
Test: Verified locally
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ie06a7eaa059d5b8e675a16da80dc03803d28ea2f
2024-12-30 14:42:37 -06:00
Shamali P ed5b8ea05f Remove page number announcement on carousel and set it on description
Others e.g. folder etc. will need to handle it separately, so, didn't
update pagedView.

Bug: 383252838
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I43f3818afcdaa4d4805df2af0890b970d71db9a7
2024-12-23 07:58:56 -08:00
Sunny Goyal 18e480838a Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options
Bug: 381897614
Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: Ic89d48dd1c5dc8b0a89b1898cd7b00d9c61d6513
2024-12-12 18:32:55 -08:00
Shamali Patwa 5f5b1a3f56 Merge "Fix missing IME back animation in widget picker" into main 2024-12-10 19:44:47 +00:00
Shamali P aaf585aef2 Fix missing IME back animation in widget picker
Discussed with folks who worked on IME animation, and root cause seemed
to be picker unconditionally clearing the focus. Also, there is no
in-built way for clearing focus on other user interactions. So, had to
write custom logic to conditionally clear the focus.

Bug: 369933372
Test: See screencast (tested back, and other user interactions)
Flag: EXEMPT BUGFIX
Change-Id: I693bd27662563e5320159c082eb955a3bd5386f8
2024-12-10 16:28:05 +00:00
Sunny Goyal ee15f52a7c Loading generated preview on-demand instead of keeping everything in memory
Bug: 369906121
Test: atest GeneratedPreviewTest
Flag: EXEMPT bugfix
Change-Id: Idd7610e8a5c577d2c7b0a1d7d2a1f1efde40b11f
2024-12-06 22:25:40 +00:00
Shamali Patwa 2909e72d36 Merge "Update accessibility hint for widget cell that shows add button." into main 2024-12-04 20:22:26 +00:00
Shamali P 0e668e1b1d Update accessibility hint for widget cell that shows add button.
With tap to add feature, tapping widget cell reveals add button.

So, clarify the intent with ACTION_CLICK

Bug: 374033389
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: I03e47241fbc16f1354394e3a6fd412998642e6cf
2024-12-04 18:12:36 +00:00
Pinyao Ting 1f72f9b3de Fix issue in scrolling in remote compose widgets
There was special check in LauncherAppWidgetHostView to disallow intercept touch events in launcher when the widget is scrollable, the same check needs to be implemented for remote compose widget for scrolling to work properly.

Bug: 339721781
Change-Id: I8b824f293ab287a7844f93610b8b952c4aefa3dd
Test: manual
Flag: EXEMPT bugfix
2024-12-04 00:45:48 +00:00
Treehugger Robot 27c2f4ddc1 Merge "Decouple Backup / Restore Error Codes" into main 2024-12-02 18:57:17 +00:00
Stefan Andonian 6df13d3b8e Decouple Backup / Restore Error Codes
Bug: 381315244
Test: Simply looked at emitted error codes and changed names if they were used in multiple locations.
Flag: EXEMPT bug fix
Change-Id: Iab4a8d6ff410682f448b2ac32e44b766d79a7616
2024-11-27 16:48:28 -08:00
Shamali Patwa d2cc1f0577 Update the enforce_system_radius_for_app_widgets flag's type
Renamed to use_system_radius_for_app_widgets since metadata cannot be updated after submitting definition.

Bug: 373351337
Test: N/A flag metadata update
Change-Id: I25283b05341517f5984b0f2fc0d27efe8027a3de
Flag: com.android.launcher3.use_system_radius_for_app_widgets
2024-11-18 21:58:48 +00:00
Johannes Gallmann cd46d978bd Merge "Never scale navbar scrim in all apps and widget picker" into main 2024-11-18 08:20:46 +00:00
Johannes Gallmann c87d41f369 Never scale navbar scrim in all apps and widget picker
The navbar scrim is scaled during the predictive back animation. This should be prevented since the navbar itself does not change it's position or scale.

Bug: 373544911
Test: Manual, i.e. verifying that the navbar scrim remains in its original position during the predictive back animation (with 3-button-nav) on phones and tablets
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: Iaffd31de5493dea8c856ad3d5b441cca066bbad8
2024-11-15 11:00:30 +00:00
Shamali Patwa 780ce64f68 Merge "Don't bind scrollbar if current recycler view isn't changed." into main 2024-11-13 22:51:04 +00:00
Shamali P 4c727e38fd Don't bind scrollbar if current recycler view isn't changed.
Bug: 378417297
Flag: EXEMPT BUGFIX
Test: Installed app in bg with picker open and verified no scroll to top
Change-Id: I9b3c6a22c9b971f4d11bc6a6e534d4b6e0ca60bf
2024-11-13 19:45:28 +00:00
Shamali P 697dcf44ac Maintain selected or last header on clicking "Show all" button
Bug: 356127021
Test: Manual and tapl test
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Change-Id: I762695f9999e5ea4c722dbedde6d7efabd3ab0cb
2024-11-12 22:31:14 +00:00
Shamali P 35a25984c3 Update the widget picker UI to show the "view all" button
Screenshot test in follow up to include the button.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: Iac847361a0fa4a4b57d37e802ce6a7a5d8bb17d7
2024-11-07 14:01:39 +00:00
Shamali P 1c173e96be Define the list entry and view holder for the view all button
Child cl updates the adapter & picker to use this list entry type.

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Manual
Change-Id: I69e82fb7df24270dac4cc0afd003e98247280552
2024-11-07 14:01:29 +00:00
Shamali P 656a026488 Fix issue that expanding only search result led to weird scroll
This piece of code was making list scroll for last item, which doesn't
really resolve problem or help for expanding items at end of visible
 list. As such scrolling only to get last time into visible area doesn't
 benefit anything (but creates inconsistency).

Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: I7ca519edfbb3a18c10fa518e28183da365f740e4
2024-10-25 23:00:57 +00:00
Shamali P be18ff2b7d Fix issue that items were invisible in 2-pane picker with talkback.
Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: Id8419e51bf20a38f203ce2422bae6290babcd63e
2024-10-25 23:00:36 +00:00
Sunny Goyal c5c619b657 Merge "Keeping the custom widget placeholder even when the plugin is not corrected" into main 2024-10-25 16:47:38 +00:00
Sunny Goyal 6bbd805e77 Keeping the custom widget placeholder even when the plugin is not corrected
Custom widget plugin can take some time to load, which causes already added
custom widgets to get removed during reboot. Instead keeping the placeHolder
while the plugin loads

Bug: 375444632
Flag: EXEMPT bugfix
Test: Manually verified using a custom plugin
Change-Id: Ibdf14f6d24adc194a716b29bb75a22220384e730
2024-10-24 12:40:13 -07:00
Shamali Patwa 2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Sunny Goyal 0b7f4cf1e2 Fixing deadlock in dagger singletons
Bug: 373557167
Flag: EXEMPT dagger
Test: atest DaggerSingletonDeadlockTest

Change-Id: I2304237bfd818c99b82bbfceea8a81ddb136b5a1
2024-10-21 18:09:37 +00:00
Sunny Goyal 9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Treehugger Robot 8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
Sunny Goyal e4ce5ebc5e Fixing leak in LauncherAppWidgetProviderInfo
Bug: 372998377
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Ibf7c66f2aba510f86d23825816639bc3197884aa
2024-10-14 16:22:52 -07:00
Sihua Ma 58fc65dedf [Dagger] Make CustomWidgetManager provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE Dagger change
Change-Id: I9c2a9cc12aa2a409e8f9053a059426843f72deed
2024-10-14 22:35:59 +00:00
Treehugger Robot 99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal 43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Fengjiang Li a49a2a32be Merge "[Dagger] Make SettingsCache provided by DaggerSingletonObject" into main 2024-10-08 17:13:20 +00:00
Fengjiang Li 4d819d9dea [Dagger] Make SettingsCache provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Id709a6e1d14446b8361cf292d5f5422f2ea3524c
2024-10-07 23:10:53 -07:00
Catherine Liang 53683d4ca4 Merge "Handle messages to update Launcher preview color" into main 2024-10-07 19:00:14 +00:00
Catherine Liang b5fdc80bb2 Handle messages to update Launcher preview color
Receive color update messages with a list of color resource ids and a
corresponding list of color overrides, and adjust the preview
accordingly.

Flag: com.android.systemui.shared.new_customization_picker_ui
Test: manually verified that the selected colors are previewed
Bug: 350718581
Change-Id: Ibcde0575416df00b76627ac1004f21f5f9af1196
2024-10-04 19:33:45 +00:00
Treehugger Robot 49e27e5257 Merge "Make widget sheet layout container not focusable" into main 2024-09-30 22:44:28 +00:00