Sunny Goyal
749983b192
Moving flag creation to a separate file
...
> This provides better control over proguarding descriptions
> Enforcing bug number in flag creation
Bug: 270386012
Test: Presubmit and verified on device
Change-Id: I31014e397690379024d2e42c0e913ce806b9569c
2023-02-27 23:19:39 +00:00
Jagrut Desai
70db29a34d
Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev am: 3addf0b66d am: 8a8bda5b3c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470199
Change-Id: I66c04acb33c47329dfdc16f4ef8c264bb710e198
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-25 02:57:09 +00:00
Jagrut Desai
8a8bda5b3c
Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev am: 3addf0b66d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21470199
Change-Id: I6239794dc53cc85288b8496c1862df1d803ba0e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-25 02:21:40 +00:00
Jagrut Desai
3addf0b66d
Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev
2023-02-25 01:49:59 +00:00
Jagrut Desai
454fb81f39
Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev am: 0355c793c0 am: d3f23005af
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21560134
Change-Id: Ifa917ee63eb85bc4dca837b4e3fb92acb914e5ea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-25 01:09:45 +00:00
Jagrut Desai
d3f23005af
Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev am: 0355c793c0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21560134
Change-Id: I75a8b22ad44b3ccf78a546f7d7569be9fc1dbff2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-25 00:39:22 +00:00
Jagrut Desai
560b0eac62
Implement All Apps Icon upto the visual Specs.
...
Test: Visual
Bug: 267382941
Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
Jagrut Desai
0355c793c0
Merge "Prevent Taskbar from stashing in immersive mode overview." into tm-qpr-dev
2023-02-24 23:34:56 +00:00
Alex Chau
888bc47918
Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev am: a8c2ffc128 am: 2248a0e941
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549707
Change-Id: I09d435775d10fdd5bae2df06730560444081db02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 22:50:52 +00:00
Alex Chau
2248a0e941
Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev am: a8c2ffc128
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21549707
Change-Id: Id3f5805bdda91219419b0a1b784dae6655d6d2bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 21:57:58 +00:00
Alex Chau
a8c2ffc128
Merge "Fix various animation issues when total width of grid tasks < screen width" into tm-qpr-dev
2023-02-24 21:42:58 +00:00
Alex Chau
359ac14d13
Fix various animation issues when total width of grid tasks < screen width
...
Bug fixes:
- Unusual long scroll when only focus task left after split select
- Animation jump when tasks cannot fit screen width after dismiss or split select
To fix the above issue, generified calculations when total grid task width < screen width:
- Removed some special case handling when only focus task left (getSnapToFocusedTaskScrollDiff), and instead replace with generic logic that calculation that extra scroll position (shortTotalCompensation) needed when long row width is smaller than the grid size
- Fixed snapped task grid translation calculation to account for shortTotalCompensation
- Last task scroll calculation should account for shortTotalCompensation too
- Calculate the expected shortTotalCompensation after dismiss, and use that to adjust the close gap between clearAll distance
splitScrollOffset that we applied during split screen does not work well when shortTotalCompensation != 0. splitScrollOffset is not a good solution to handle split placeholder, as it allow tasks to scroll to weird position. I removed splitScrollOffset completely, and only apply split translation when split placeholder covers the tasks:
- Removed splitScrollOffset on TaskView/ClearAll, so scroll position of TaskView will not change while in split to splify things.
- When split placehodler will cover task's natural position (taskSize) in overview grid, apply split translation on all tasks similar to handheld
- Removed isSplitPlaceholderFirstInGrid/isSplitPlaceholderLastInGrid adjustments
Bug: 257952455
Test: Enter overview from home
Test: Enter overview from app, with variations that quick switch and enter
Test: Dismiss task from different position
Test: Split select task from different position
Test: Repeat with/without GRID_ONLY_OVERVIEW flag
Test: Repeat with handheld
Change-Id: I7689b5384845f03491041b6d910835c9ac4fab08
2023-02-24 18:42:13 +00:00
TreeHugger Robot
0aa1de56cd
Merge "[Gesture Library Integration] Update the check for motion events on trackpad" into udc-dev
2023-02-23 23:15:59 +00:00
Jagrut Desai
3fbaaf9628
Prevent Taskbar from stashing in immersive mode overview.
...
Test: Visual, Video in Buganizer
Bug: 262589756
Change-Id: Ifbdfb3a4104817e5f50833c42c3c6fc5964388b7
2023-02-23 14:19:10 -08:00
Tracy Zhou
d248ee7507
[Gesture Library Integration] Update the check for motion events on
...
trackpad
The gesture library is ported and enabled, thus we are updating our
check for motion events on trackpad.
Bug: 254783214
Test: Swipe up and hold to go to overview; swipe up to go home
Change-Id: I4b74e88c7f8b6ef86c779391b0f8064ea828ed8f
2023-02-23 20:58:22 +00:00
TreeHugger Robot
93e3b7be9b
Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev am: 01c1dff441 am: 9fc14b94cd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539136
Change-Id: I283fc2baa17b5d75f1eb28bd95b39330d97bb61c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 16:43:31 +00:00
TreeHugger Robot
9fc14b94cd
Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev am: 01c1dff441
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21539136
Change-Id: Ic134a1cd2780c2f2ff5f294f33a1f8367b3b6eb9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 15:10:37 +00:00
TreeHugger Robot
01c1dff441
Merge "ENABLE_WIDGET_PICKER_DEPTH" into tm-qpr-dev
2023-02-23 13:22:15 +00:00
Sunny Goyal
5b1a6cc137
Merge "Removing some obsolete features" into tm-qpr-dev am: b3a95149f5 am: 51eb7b611b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537730
Change-Id: I861e29f63df948aca8a6b7c05fa1b31b612cdc7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 09:22:11 +00:00
Sunny Goyal
51eb7b611b
Merge "Removing some obsolete features" into tm-qpr-dev am: b3a95149f5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21537730
Change-Id: Ia7fb81792677cbc3979f138dcea93a77cc44af14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 08:47:16 +00:00
Tiger Huang
210c689996
Merge "Use insetsRoundedCornerFrame to check if taskbar is expanded or not" into udc-dev
2023-02-23 04:37:01 +00:00
Vinit Nayak
26016622c1
Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff am: 2fea4c6f1b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925
Change-Id: I418fa47df9af8c94a31d3c30124c96cc78e6d758
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 00:53:05 +00:00
Sunny Goyal
171bb04407
Removing some obsolete features
...
Bug: 270386012
Test: Presubmit
Change-Id: I9d68b3d17e02d6e79ab726eb7c8da1e5a4d337ef
2023-02-22 23:17:15 +00:00
Vinit Nayak
2fea4c6f1b
Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925
Change-Id: Id91fe8d96fbcc1cdad9ef59610c934e59c441410
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 22:30:50 +00:00
Alex Chau
ce9766da2d
ENABLE_WIDGET_PICKER_DEPTH
...
Fix: 270393895
Test: manual
Change-Id: I167354425e5469663c283919f84c8bdf664cceec
2023-02-22 20:18:39 +00:00
Vinit Nayak
4e3636e8d0
Refactor SplitSelectStateController to add testing
...
Bug: 266482558
Change-Id: I2d62a3a310043710d66a26bc533df2309084b81e
2023-02-22 10:51:49 -08:00
Tony Wickham
b83d56bc27
Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493 am: c8207a7e23
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764
Change-Id: I4af1a2fe1e79d2f36d275a057178efd7e750b0e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 18:10:26 +00:00
Tony Wickham
c8207a7e23
Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev am: 3d1bb16493
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21533764
Change-Id: I04cbb24dc071677a8e6f5c4fa8981efc5bec6d34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 16:59:30 +00:00
Tony Wickham
3d1bb16493
Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev
2023-02-22 16:24:48 +00:00
Pat Manning
4faa11aea1
Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03 am: 3eadaa7d77
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663
Change-Id: Icd9a71482cfbb235d03b0fadfbfd6f74d4bc44d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 14:09:34 +00:00
Pat Manning
3eadaa7d77
Merge "Animate grid tasks to modal state." into tm-qpr-dev am: 1b27affb03
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060663
Change-Id: I3fc5d3fde2fadf3e95383c3827be7901b3712ef5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 13:00:42 +00:00
Pat Manning
1b27affb03
Merge "Animate grid tasks to modal state." into tm-qpr-dev
2023-02-22 11:18:47 +00:00
Tony Wickham
3a36d4890a
Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a am: b506ae73b0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497
Change-Id: I51be618db419357a60d0597f3f195ad284bd2c83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 06:22:44 +00:00
Tony Wickham
b506ae73b0
Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev am: 2a567ec85a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527497
Change-Id: Ica30f4d7a313b5966b8ca72654f4002e581faf31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 05:23:21 +00:00
Vinit Nayak
8e17afacdd
Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67 am: 06ed4db282
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212
Change-Id: I4f8fab35c7c4c1de91927fc01a3b8a90d8d4aacd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 03:51:29 +00:00
Tony Wickham
00f89fbbf6
Fix taskbar drag view scale when returning to original icon
...
- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
this accounts for padding as well as extra ring inset for
PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
the system drag and drop, instead of using the current scale which
might be in the process of animating
Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838
Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
2023-02-22 03:41:03 +00:00
Tony Wickham
2a567ec85a
Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev
2023-02-22 03:38:38 +00:00
Vinit Nayak
06ed4db282
Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev am: 54c262cd67
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21468212
Change-Id: Id6f868aa87f0ba53673764f412d12ed936f78aea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 02:50:49 +00:00
Vinit Nayak
54c262cd67
Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev
2023-02-22 02:15:46 +00:00
Winson Chung
071aff5b49
Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606 am: 0e9de04dfb
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928
Change-Id: I282754b27a97e70223554050d31c2754cb52eb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 01:16:54 +00:00
Tony Wickham
16cfed3d1f
Fix a couple of drag and drop issues from transient taskbar
...
- Don't stash until drag ends, but immediately stash at that point
(regardless of success or failure, though failure will animate to the
original icon before stashing)
- Send transient taskbar's bounds to WM Shell via intent extra such that
they ignore drag events in that region
Test: manual in persistent and transient taskbar
Bug: 269814838
Fixes: 268526633
Fixes: 259645384
Change-Id: I5ded3998046f259ed6e79cb4ed765ad7b0c72e45
2023-02-22 00:46:51 +00:00
Winson Chung
0e9de04dfb
Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev am: d30ef72606
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21491928
Change-Id: I0e22beac88c2dd89078767d1846fb3470a8b26d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 00:17:27 +00:00
Winson Chung
d30ef72606
Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev
2023-02-21 22:50:31 +00:00
TreeHugger Robot
a09599d97f
Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev am: 73a2334f7f am: f94e71eca0
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590940
Change-Id: I622200bd7dca3086433170dc680ccc9aa2bc0e8e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 22:47:21 +00:00
Schneider Victor-tulias
34f8c2f14a
Merge "Keyboard quick switch polish" into tm-qpr-dev am: 8129ebfd04 am: 42f0aaac4b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21466357
Change-Id: Ic68faa66297ea8bd2b960ec485bc0c421142122b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 22:46:07 +00:00
Jon Miranda
0a98138d4a
Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev am: 6bb01ee8ca am: 2bd32abb3f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21486650
Change-Id: I47867da0ac599f5ad6fd029b5e3ab3364cb60474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 22:43:48 +00:00
TreeHugger Robot
f94e71eca0
Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev am: 73a2334f7f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20590940
Change-Id: Ie07cb2abf9cadb3812014585691e58cf63c5baf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 21:45:28 +00:00
Schneider Victor-tulias
42f0aaac4b
Merge "Keyboard quick switch polish" into tm-qpr-dev am: 8129ebfd04
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21466357
Change-Id: I55765649648db123f919699ffd6f42c787bf9ddc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 21:44:54 +00:00
Jon Miranda
2bd32abb3f
Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev am: 6bb01ee8ca
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21486650
Change-Id: I3b2f7b368eb7007886e415391585e3725d9dcd82
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 21:44:41 +00:00
TreeHugger Robot
73a2334f7f
Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev
2023-02-21 21:15:22 +00:00