Commit Graph

18369 Commits

Author SHA1 Message Date
Brandon Dayauon 00bd00fd4e Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:68c18236adb5d49d5ba3c5a19187759af63a53b4)
Merged-In: Idef427bad6551ae56b13e35393e076b8e000af5a
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-25 18:41:06 +00:00
Schneider Victor-tulias b24d4d5a8f Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dba7cbae1adfde615060598a55b5ee0edfedef9f)
Merged-In: I2b20100ddeb562291edf5f0bacbce916002eee45
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
2024-03-21 23:50:53 +00:00
Andreas Agvard 28b28e0365 Removes recovery
Flag: NONE
Bug: 326143814
Test: Unit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6ce297a2ff1583e49cf3e2e1e89d1ead7f83dac0)
Merged-In: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
Change-Id: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
2024-03-20 21:25:22 +00:00
Tony Wickham f027b4eb36 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
2024-03-20 01:15:25 +00:00
Brian Isganitis fbda2e6ccb Reset stashed in Taskbar All Apps for gestures instead of IME insets.
Test: Manual
Flag: NONE
Fix: 328960039
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1956246b6e7098aeaeece3760b1ea97d096d3588)
Merged-In: I62c53c21bf850b7080e12086235cba28164f4d70
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
2024-03-19 21:03:07 +00:00
Pat Manning 1e6bf12fdb Set next page immediately on subsequent arrow/tab presses when navigating overivew.
This allows the user to scroll as quickly as they want.

Fix: 328749622
Test: manual
Flag: NONE
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a9a11b47c3bff4d3ec4a4f300e12895d3235fe95)
Merged-In: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
Change-Id: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
2024-03-14 23:58:12 +00:00
Alex Chau 0425766b1a Allow Task menu to draw down to screen bottom
- Use all available spaces minus inset to draw the task menu
- Also enabled scrolling for app chi1p menu

Fix: 329271577
Bug: 326952853
Test: manual
Flag: Nonee
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:26e487c6acd86c668518d379f90cb84f3d89a486)
Merged-In: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
Change-Id: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
2024-03-14 00:59:19 +00:00
Vinit Nayak 514185537a Update Launcher state anim duration for pinned & transient taskbar
* We were syncing the duration of the animation to be at most
that of the taskbar/hotseat animation but only for transient taskbar.
* Now we sync for transient and pinned

Fixes: 328052756
Test: Anim jank doesn't repro
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9a3c48468b35377ef46bf2b362f68c467ecd45ad)
Merged-In: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
Change-Id: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
2024-03-14 00:59:11 +00:00
Jordan Silva 798644d1f1 Fix overview live tile flickers when clicking on overview action buttons
When a Live Tile is present on overview and an action is triggered (e.g., Split, Select, Screenshot), the live tile flickers due to a competing snapshot modification and animation on UI thread. The live tile is updated to switch to screenshot and at the same time the finishRecentsAnimation is triggered.

This CL bumps the number of frames to wait after the view is updated to run the Runnable code. Bumping back the mDeferFrameCount to 2 solves the sync between rendering the snapshot and hiding the Live Tile.

Fix: 327380570
Flag: N/A
Test: Manual. Open an App -> Swipe to Overview (Live title) -> Click on Split.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:024a1018e4c96b43d8f122bb1c614c3e3ea5bab7)
Merged-In: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
Change-Id: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
2024-03-14 00:59:01 +00:00
Schneider Victor-tulias 7fb98d3542 Disable slow recents animation handling
Flag: N/A
Fixes: 324228222
Test: programmatic delay and several gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5b9d94adc5ca18a9dd5e7cee44dc3c0168172c8c)
Merged-In: I98f3575047e442a4f57582b40cc0f36f1f113356
Change-Id: I98f3575047e442a4f57582b40cc0f36f1f113356
2024-03-13 00:35:27 +00:00
Vinit Nayak d11b171357 Fix split selection for 3P launcher with animations off
* When animations were off, the currentState in
FallbackRecentsStateController is incorrect (we didn't need
that check at all)
* Surfaced a bug in MultiValueUpdateListener that is being
fixed in ag/26416537

Test: 1P + 3P launcher all of the following:
starting split from overview with animations and without
rotation
selecting second app before and after rotation
Fixes: 327346105
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b274152194799639febe58c4fa1daa896595fd8c)
Merged-In: I4f19119c30a8669bba6ced06e30773f085a78047
Change-Id: I4f19119c30a8669bba6ced06e30773f085a78047
2024-03-13 00:35:16 +00:00
randypfohl 81d456f1d3 When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot
Bug: 326550571

Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set

Flag: none
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:fca7ee23ba35c35292e6f26ca051cd64c437ca27)
Merged-In: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
2024-03-08 23:56:54 +00:00
Andreas Agvard 81a7d0b191 Adds new AssistStateManager settings
Flag: NONE
Bug: 326143814
Test: Unit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d78d9bb5e2b300c68aae4c6071c913f332a994eb)
Merged-In: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
Change-Id: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
2024-03-07 20:54:43 +00:00
Treehugger Robot 2be60d98a8 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-03-04 17:25:25 +00:00
Sam Cackett ddde91b915 Merge "Translate IconMenu up when the TaskMenu is expanded and moved" into main 2024-03-04 17:17:24 +00:00
samcackett 3a2aa5bc04 Translate IconMenu up when the TaskMenu is expanded and moved
Fixes: 327564916
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I8acd79a21c7ce1d65496e7e6cb8ea0aa8912738d
2024-03-04 11:43:17 +00:00
Jeremy Sim 742f710168 Merge "Fix bug with TalkBack not reading out SplitInstructionsView" into main 2024-03-03 00:18:47 +00:00
Bill Yi 2320d553c7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1e8590b55cd77be368a46668cc8764463a264ebf
2024-03-01 19:32:34 -08:00
Jagrut Desai 02c56e8258 Merge "Fixing taskbar being unstashed after opening to unfolded mode" into main 2024-03-01 21:43:24 +00:00
PODISHETTY KUMAR b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Jeremy Sim d2c28c7ee3 Fix bug with TalkBack not reading out SplitInstructionsView
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.

Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
2024-02-29 21:35:20 -08:00
Jeremy Sim c8c4fd8aeb Merge "Fix disabled state for non-resizeable app pairs" into main 2024-03-01 05:14:48 +00:00
Vinit Nayak 5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jagrut Desai 3c3bef333a Fixing taskbar being unstashed after opening to unfolded mode
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: I91aa947a707e3fc918e617f207e823b2f1460466
2024-02-29 16:17:24 -08:00
Bill Yi 08fe4d0135 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-29 23:12:58 +00:00
Jeremy Sim 31b934f28f Fix disabled state for non-resizeable app pairs
This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.

This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.

Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
2024-02-29 13:42:43 -08:00
Saumya Prakash 3fb35d3fb8 Merge "Remove the tint from taskbar themed icons for dark mode." into main 2024-02-29 20:05:15 +00:00
Jeremy Sim 8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Tony Wickham 47a85e4607 Merge "Call showCurrentTask again if applyLoadPlan doesn't include running task" into main 2024-02-29 17:19:11 +00:00
Bill Yi 70799d4540 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If0d3c974835120248fb17d97fd678ef5921a46a8
2024-02-28 21:55:23 -08:00
Jeremy Sim 41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Vinit Nayak 2b4e99344d Merge "Remove A11y node info for SplitInstructionsView" into main 2024-02-29 03:16:28 +00:00
Tony Wickham bf885ceb5f Call showCurrentTask again if applyLoadPlan doesn't include running task
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure
the gesture works as expected (e.g. can quick switch, go home, or to
overview with all tasks visible).
Flag: none
Fixes: 324495241

Change-Id: If3b61f7d1725ee573fad38140bfeb77f3a6cea1e
2024-02-29 00:36:16 +00:00
Saumya Prakash ba04c0c1dc Remove the tint from taskbar themed icons for dark mode.
We remove the added tint to taskbar themed icons to match how they look
in the hotseat on launcher home screen specifically for dark mode.

Fix: 323952706
Test: Turn on themed icons and dark mode. Compare app icons in taskbar
and in hotseat
Flag: N/A

Change-Id: I4dfe352ca17ef5537e48fcc3cff66ba4fd4f603a
2024-02-28 23:07:07 +00:00
Jagrut Desai 07959348e6 Merge "Fixing taskbar unstashing after unfolding" into main 2024-02-28 15:21:40 +00:00
Eghosa Ewansiha-Vlachavas 7cc75c6a43 Merge changes from topics "removeDesktopMode2", "replaceDesktopWindowingFlag" into main
* changes:
  [2/n] Remove use of `persist.wm.debug.desktop_mode_2`
  [2/n] Replace read-only desktop windowing flag with runtime flag
2024-02-28 14:24:09 +00:00
Federico Baron c2b06abd6c Merge "Add screenrecord for testOverviewDeadzones" into main 2024-02-28 06:16:32 +00:00
Vinit Nayak 0edcfa4979 Merge "Update animation timing for split dismiss animation" into main 2024-02-28 04:14:28 +00:00
Sukesh Ram 1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
Vinit Nayak dfbf253f90 Remove A11y node info for SplitInstructionsView
* Individual text view and cancel button still
have their own a11y actions, but top level
view doesn't need one

Test: Tested w/ switches to ensure parent view
doesn't get selected. Tested w/ Talkback to
ensure we can still cancel through talkback
Fixes: 323462927

Change-Id: I60d21f6e768c59f29f51007f56ff784821487895
2024-02-27 16:54:02 -08:00
fbaron eb65ca1600 Add screenrecord for testOverviewDeadzones
Bug: 326839375
Test: TaplTestsQuickstep#testOverviewDeadzones
Flag: NONE
Change-Id: Ic7e889be042a76aa0979cc32d3d43a562a80f491
2024-02-27 14:55:11 -08:00
Jagrut Desai e424570af1 Fixing taskbar unstashing after unfolding
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: Iddd10df6e40ee2de4ef08eb18df88d48b7468035
2024-02-27 14:44:26 -08:00
Vinit Nayak 9c29c1e1c4 Update animation timing for split dismiss animation
* We weren't specifying an animation duration for the
dismiss placeholder animation, and it wasn't inheriting
from the animatorSet since that didn't have any duration
set on it.
* Now we explicitly set a duration (usually matching that of
the current launcher state config) to the timings line up
well

Test: Repro steps don't show bug. Also tested on large screen dismissing
contextual split from overview and home, seems fine
Fixes: 314860754

Change-Id: I701e4f88c1ddd92561da4fb76715a859f587c91e
2024-02-27 12:10:44 -08:00
Schneider Victor-tulias 7e0703eca0 Merge "Fix blocked gesture handling on failed startRecentsActivity calls" into main 2024-02-27 18:53:13 +00:00
Sam Cackett fe2ff288de Merge "Set max height on TaskMenuView and scroll if too many elements" into main 2024-02-27 17:02:51 +00:00
Treehugger Robot 287e981ce9 Merge "Fix bouncing of task view when dragged past dismiss threshold." into main 2024-02-27 16:41:59 +00:00
Uwais Ashraf dddafae44e Fix bouncing of task view when dragged past dismiss threshold.
Before: https://screenshot.googleplex.com/56AHSMFkNwC76BV
After: https://screenshot.googleplex.com/AjuWqZaSNxmNYn8

Other cases after:
https://screenshot.googleplex.com/oaNotdg79v7LGUA
https://screenshot.googleplex.com/8SVtzpokbvmAzpv
https://screenshot.googleplex.com/87uRqmEAasBMQz2

Fix: 319577620
Flag: NA
Test: Manual (animation), analyse setPlayFraction log - see screenshots
Change-Id: Ib1f24182b8fc0f6ea1ff07125f25dbfc206ae5c2
2024-02-27 14:15:48 +00:00
Luca Zuccarini 0547036143 Merge "Move remote animation utils to the Animation lib." into main 2024-02-27 13:53:59 +00:00
samcackett 6c93e88faf Set max height on TaskMenuView and scroll if too many elements
Video of functionality: http://shortn/_pz6qhz5yxM

Fixes: 210466650
Test: Manual
Flag: NONE
Change-Id: I8b7873cf03857ee3be047ab30388e679f7a95bfd
2024-02-27 12:45:53 +00:00
Helen Cheuk 96fd73ed84 Merge "Stash taskbar when software keyboard is docked" into main 2024-02-27 10:40:07 +00:00