Making the text reflect the container when you are unable to drop onto a space.

Change-Id: Ib3734b7f7767bdf0fb4c95dcc1298da02c04e9cd
This commit is contained in:
Winson Chung
2012-03-23 15:59:27 -07:00
parent 568c659352
commit 93eef082ec
4 changed files with 14 additions and 10 deletions
+2
View File
@@ -83,6 +83,8 @@ s -->
<string name="group_wallpapers">Wallpapers</string>
<!-- Error message when user has filled a home screen, possibly not used -->
<string name="out_of_space">No more room on your Home screens.</string>
<!-- Error message when user has filled the hotseat -->
<string name="hotseat_out_of_space">No more room on the hotseat.</string>
<!-- Error message when user tries to drop an invalid item on the hotseat -->
<string name="invalid_hotseat_item">This widget is too large for the hotseat.</string>
<!-- Message displayed when a shortcut is created by an external application -->
@@ -791,7 +791,7 @@ public class AppsCustomizePagedView extends PagedViewWithDraggableItems implemen
}
}
if (showOutOfSpaceMessage) {
mLauncher.showOutOfSpaceMessage();
mLauncher.showOutOfSpaceMessage(false);
}
d.deferDragViewCleanupPostAnimation = false;
+7 -6
View File
@@ -881,7 +881,7 @@ public final class Launcher extends Activity
cellXY[0] = cellX;
cellXY[1] = cellY;
} else if (!layout.findCellForSpan(cellXY, 1, 1)) {
showOutOfSpaceMessage();
showOutOfSpaceMessage(isHotseatLayout(layout));
return;
}
@@ -944,7 +944,7 @@ public final class Launcher extends Activity
}
if (!foundCellSpan) {
showOutOfSpaceMessage();
showOutOfSpaceMessage(isHotseatLayout(layout));
return;
}
@@ -1039,7 +1039,7 @@ public final class Launcher extends Activity
}
}.start();
}
showOutOfSpaceMessage();
showOutOfSpaceMessage(isHotseatLayout(layout));
return;
}
@@ -1225,8 +1225,9 @@ public final class Launcher extends Activity
launcherInfo.hostView = null;
}
void showOutOfSpaceMessage() {
Toast.makeText(this, getString(R.string.out_of_space), Toast.LENGTH_SHORT).show();
void showOutOfSpaceMessage(boolean isHotseatLayout) {
int strId = (isHotseatLayout ? R.string.hotseat_out_of_space : R.string.out_of_space);
Toast.makeText(this, getString(strId), Toast.LENGTH_SHORT).show();
}
public LauncherAppWidgetHost getAppWidgetHost() {
@@ -2751,7 +2752,7 @@ public final class Launcher extends Activity
*/
void addExternalItemToScreen(ItemInfo itemInfo, final CellLayout layout) {
if (!mWorkspace.addExternalItemToScreen(itemInfo, layout)) {
showOutOfSpaceMessage();
showOutOfSpaceMessage(isHotseatLayout(layout));
}
}
+4 -3
View File
@@ -2064,7 +2064,8 @@ public class Workspace extends SmoothPagedView
if (!foundCell) {
// Don't show the message if we are dropping on the AllApps button and the hotseat
// is full
if (mTargetCell != null && mLauncher.isHotseatLayout(mDragTargetLayout)) {
boolean isHotseat = mLauncher.isHotseatLayout(mDragTargetLayout);
if (mTargetCell != null && isHotseat) {
Hotseat hotseat = mLauncher.getHotseat();
if (hotseat.isAllAppsButtonRank(
hotseat.getOrderInHotseat(mTargetCell[0], mTargetCell[1]))) {
@@ -2072,7 +2073,7 @@ public class Workspace extends SmoothPagedView
}
}
mLauncher.showOutOfSpaceMessage();
mLauncher.showOutOfSpaceMessage(isHotseat);
return false;
}
}
@@ -2943,7 +2944,7 @@ public class Workspace extends SmoothPagedView
onDropExternal(dragInfo.dropPos, (ItemInfo) dragInfo, (CellLayout) layout, false);
return true;
}
mLauncher.showOutOfSpaceMessage();
mLauncher.showOutOfSpaceMessage(mLauncher.isHotseatLayout(layout));
return false;
}