It does not work to get information about the swapper task on FreeBSD

1998-11-11  Martin Baulig  <martin@home-of-linux.org>

	* *.c: It does not work to get information about the swapper task
	on FreeBSD 2.2.6, so we simple return if pid == 0.

sysdeps/freebsd/ChangeLog

@@ -1,3 +1,8 @@
+1998-11-11  Martin Baulig  <martin@home-of-linux.org>
+
+	* *.c: It does not work to get information about the swapper task
+	on FreeBSD 2.2.6, so we simple return if pid == 0.
+
 1998-10-31  Martin Baulig  <martin@home-of-linux.org>
 
 	* *.c: Use glibtop_warn_io_r () instead of glibtop_error_io_r ().

sysdeps/freebsd/procargs.c

@@ -59,20 +59,26 @@ glibtop_get_proc_args_p (glibtop *server, glibtop_proc_args *buf,
 	
 	memset (buf, 0, sizeof (glibtop_proc_args));
 
+	/* swapper, init, pagedaemon, vmdaemon, update - this doen't work. */
+	if (pid < 5) return NULL;
+
 	sprintf (filename, "/proc/%d/mem", pid);
 	if (stat (filename, &statb)) return NULL;
 
+	glibtop_suid_enter (server);
+
 	/* Get the process data */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
-	if ((pinfo == NULL) || (count < 1))
+	if ((pinfo == NULL) || (count < 1)) {
-		glibtop_error_io_r (server, "kvm_getprocs (proc_args)");
+		glibtop_suid_leave (server);
-	
+		glibtop_warn_io_r (server, "kvm_getprocs (%d)", pid);
-	glibtop_suid_enter (server);
+		return NULL;
+	}
 
 	args = kvm_getargv (server->machine.kd, pinfo, max_len);
 	if (args == NULL) {
-		glibtop_warn_io_r (server, "kvm_getargv");
 		glibtop_suid_leave (server);
+		glibtop_warn_io_r (server, "kvm_getargv (%d)", pid);
 		return NULL;
 	}
 

sysdeps/freebsd/prockernel.c

@@ -81,6 +81,9 @@ glibtop_get_proc_kernel_p (glibtop *server,
 	if (server->sysdeps.proc_time == 0)
 		return;
 
+	/* It does not work for the swapper task. */
+	if (pid == 0) return;
+	
 	/* Get the process information */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
 	if ((pinfo == NULL) || (count != 1))

sysdeps/freebsd/procmap.c

@@ -78,12 +78,19 @@ glibtop_get_proc_map_p (glibtop *server, glibtop_proc_map *buf,
 	int count, i = 0;
 	int update = 0;
 
+	glibtop_init_p (server, (1 << GLIBTOP_SYSDEPS_PROC_MAP), 0);
+	
+	memset (buf, 0, sizeof (glibtop_proc_map));
+
+	/* It does not work for the swapper task. */
+	if (pid == 0) return NULL;
+	
 	glibtop_suid_enter (server);
 
 	/* Get the process data */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
 	if ((pinfo == NULL) || (count < 1))
-		glibtop_error_io_r (server, "kvm_getprocs (proclist)");
+		glibtop_error_io_r (server, "kvm_getprocs (%d)", pid);
 
 	/* Now we get the memory maps. */
 

sysdeps/freebsd/procmem.c

@@ -101,10 +101,13 @@ glibtop_get_proc_mem_p (glibtop *server, glibtop_proc_mem *buf,
 	if (server->sysdeps.proc_mem == 0)
 		return;
 
+	/* It does not work for the swapper task. */
+	if (pid == 0) return;
+	
 	/* Get the process data */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
 	if ((pinfo == NULL) || (count < 1)) {
-		glibtop_warn_io_r (server, "kvm_getprocs (proclist)");
+		glibtop_warn_io_r (server, "kvm_getprocs (%d)", pid);
 		return;
 	}
 

sysdeps/freebsd/procsignal.c

@@ -51,6 +51,9 @@ glibtop_get_proc_signal_p (glibtop *server,
 	
 	memset (buf, 0, sizeof (glibtop_proc_signal));
 
+	/* It does not work for the swapper task. */
+	if (pid == 0) return;
+	
 	/* Get the process information */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
 	if ((pinfo == NULL) || (count != 1)) {

sysdeps/freebsd/procstate.c

@@ -53,6 +53,9 @@ glibtop_get_proc_state_p (glibtop *server,
 	
 	memset (buf, 0, sizeof (glibtop_proc_state));
 
+	/* It does not work for the swapper task. */
+	if (pid == 0) return;
+	
 	/* Get the process information */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
 	if ((pinfo == NULL) || (count != 1)) {

sysdeps/freebsd/proctime.c

@@ -117,6 +117,9 @@ glibtop_get_proc_time_p (glibtop *server, glibtop_proc_time *buf,
 	if (server->sysdeps.proc_time == 0)
 		return;
 
+	/* It does not work for the swapper task. */
+	if (pid == 0) return;
+	
 	sprintf (filename, "/proc/%d/mem", pid);
 	if (stat (filename, &statb)) return;
 

sysdeps/freebsd/procuid.c

@@ -53,6 +53,9 @@ glibtop_get_proc_uid_p (glibtop *server, glibtop_proc_uid *buf,
 	
 	memset (buf, 0, sizeof (glibtop_proc_uid));
 
+	/* It does not work for the swapper task. */
+	if (pid == 0) return;
+	
 	/* Get the process information */
 	pinfo = kvm_getprocs (server->machine.kd, KERN_PROC_PID, pid, &count);
 	if ((pinfo == NULL) || (count != 1)) {