From 5516366d00457f50009e6593b6d4f02ed7ed2058 Mon Sep 17 00:00:00 2001 From: Andrew Sobala Date: Sun, 11 May 2003 14:36:26 +0000 Subject: [PATCH] Fix buffer overflow vulnerability. Bump version to 2.0.2. --- ChangeLog | 4 ++++ configure.in | 2 +- src/daemon/ChangeLog | 4 ++++ src/daemon/gnuserv.c | 5 +++++ 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 2a97d8b5..5e7c31f3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2003-05-11 Andrew Sobala + + * configure.in: release 2.0.2 + 2003-05-10 Danilo Šegan * configure.in: Added "sr" and "sr@Latn" to ALL_LINGUAS. diff --git a/configure.in b/configure.in index d8b5bed4..6744b9f6 100644 --- a/configure.in +++ b/configure.in @@ -8,7 +8,7 @@ AC_CANONICAL_SYSTEM LIBGTOP_MAJOR_VERSION=2 LIBGTOP_MINOR_VERSION=0 -LIBGTOP_MICRO_VERSION=1 +LIBGTOP_MICRO_VERSION=2 LIBGTOP_VERSION=$LIBGTOP_MAJOR_VERSION.$LIBGTOP_MINOR_VERSION.$LIBGTOP_MICRO_VERSION AM_INIT_AUTOMAKE(libgtop, $LIBGTOP_VERSION) LIBGTOP_INTERFACE_AGE=1 diff --git a/src/daemon/ChangeLog b/src/daemon/ChangeLog index ab58c088..2ddb846e 100644 --- a/src/daemon/ChangeLog +++ b/src/daemon/ChangeLog @@ -1,3 +1,7 @@ +2003-05-11 Andrew Sobala + + * gnuserv.c: (permitted): fix buffer overflow vulnerability + 2001-02-14 Martin Baulig * Makefile.am (libgtop_server_LDADD): Removed @LIBSUPPORT@. diff --git a/src/daemon/gnuserv.c b/src/daemon/gnuserv.c index 9f43a0ee..2be6659e 100644 --- a/src/daemon/gnuserv.c +++ b/src/daemon/gnuserv.c @@ -199,6 +199,11 @@ permitted (u_long host_addr, int fd) return FALSE; auth_data_len = atoi (buf); + + if (auth_data_len < 1 || auth_data_len > sizeof(buf)) { + syslog_message(LOG_WARNING, "Invalid data length supplied by client"); + return FALSE; + } if (timed_read (fd, buf, auth_data_len, AUTH_TIMEOUT, 0) != auth_data_len) return FALSE;