oxmc/libgtop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kvm_nlist () returns -1 on error, but a positive return value does not

Browse Source 
2000-02-13  Martin Baulig  <martin@home-of-linux.org>

	* *.c: kvm_nlist () returns -1 on error, but a positive return value
	does not necessarily mean failure. Fixes #3302 which was reported by
	Matthias Scheler some time ago.
This commit is contained in:
Martin Baulig
2000-02-13 15:28:24 +00:00
committed by Martin Baulig
parent 47d4322965
commit 3fec7a0946
10 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sysdeps/freebsd/ChangeLog
View File

@@ -1,3 +1,9 @@
2000-02-13 Martin Baulig <martin@home-of-linux.org>
* *.c: kvm_nlist () returns -1 on error, but a positive return value
does not necessarily mean failure. Fixes #3302 which was reported by
Matthias Scheler some time ago.
2000-02-06 Martin Baulig <martin@home-of-linux.org> 2000-02-06 Martin Baulig <martin@home-of-linux.org>
* Makefile.am: Removed the non-suid `libgtop-sysdeps.la'. * Makefile.am: Removed the non-suid `libgtop-sysdeps.la'.

2
sysdeps/freebsd/cpu.c
View File

@@ -53,7 +53,7 @@ static int mib [] = { CTL_KERN, KERN_CLOCKRATE };
int int
glibtop_init_cpu_p (glibtop *server) glibtop_init_cpu_p (glibtop *server)
{ {
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (cpu)"); glibtop_warn_io_r (server, "kvm_nlist (cpu)");
return -1; return -1;
} }

2
sysdeps/freebsd/mem.c
View File

@@ -94,7 +94,7 @@ glibtop_init_mem_p (glibtop *server)
{ {
register int pagesize; register int pagesize;
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (mem)"); glibtop_warn_io_r (server, "kvm_nlist (mem)");
return -1; return -1;
} }

2
sysdeps/freebsd/msg_limits.c
View File

@@ -82,7 +82,7 @@ static struct nlist nlst [] = {
int int
glibtop_init_msg_limits_p (glibtop *server) glibtop_init_msg_limits_p (glibtop *server)
{ {
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (msg_limits)"); glibtop_warn_io_r (server, "kvm_nlist (msg_limits)");
return -1; return -1;
} }

2
sysdeps/freebsd/netinfo.c
View File

@@ -59,7 +59,7 @@ glibtop_init_netinfo_p (glibtop *server)
{ {
server->sysdeps.netinfo = _glibtop_sysdeps_netinfo; server->sysdeps.netinfo = _glibtop_sysdeps_netinfo;
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) if (kvm_nlist (server->_priv->machine.kd, nlst) < 0)
glibtop_error_io_r (server, "kvm_nlist"); glibtop_error_io_r (server, "kvm_nlist");
return 0; return 0;

2
sysdeps/freebsd/netload.c
View File

@@ -65,7 +65,7 @@ glibtop_init_netload_p (glibtop *server)
{ {
server->sysdeps.netload = _glibtop_sysdeps_netload; server->sysdeps.netload = _glibtop_sysdeps_netload;
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) if (kvm_nlist (server->_priv->machine.kd, nlst) < 0)
glibtop_error_io_r (server, "kvm_nlist"); glibtop_error_io_r (server, "kvm_nlist");
return 0; return 0;

2
sysdeps/freebsd/ppp.c
View File

@@ -84,7 +84,7 @@ glibtop_init_ppp_p (glibtop *server)
#endif #endif
#endif /* HAVE_I4B */ #endif /* HAVE_I4B */
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) if (kvm_nlist (server->_priv->machine.kd, nlst) < 0)
glibtop_error_io_r (server, "kvm_nlist"); glibtop_error_io_r (server, "kvm_nlist");
return 0; return 0;

2
sysdeps/freebsd/sem_limits.c
View File

@@ -85,7 +85,7 @@ static struct nlist nlst [] = {
int int
glibtop_init_sem_limits_p (glibtop *server) glibtop_init_sem_limits_p (glibtop *server)
{ {
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (sem_limits)"); glibtop_warn_io_r (server, "kvm_nlist (sem_limits)");
return -1; return -1;
} }

2
sysdeps/freebsd/shm_limits.c
View File

@@ -83,7 +83,7 @@ static struct nlist nlst [] = {
int int
glibtop_init_shm_limits_p (glibtop *server) glibtop_init_shm_limits_p (glibtop *server)
{ {
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (shm_limits)"); glibtop_warn_io_r (server, "kvm_nlist (shm_limits)");
return -1; return -1;
} }

4
sysdeps/freebsd/swap.c
View File

@@ -99,7 +99,7 @@ glibtop_init_swap_p (glibtop *server)
{ {
#if defined(__FreeBSD__) || defined(__bsdi__) #if defined(__FreeBSD__) || defined(__bsdi__)
#if __FreeBSD__ < 4 || defined(__bsdi__) #if __FreeBSD__ < 4 || defined(__bsdi__)
if (kvm_nlist (server->_priv->machine.kd, nlst) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (swap)"); glibtop_warn_io_r (server, "kvm_nlist (swap)");
return -1; return -1;
} }
@@ -114,7 +114,7 @@ glibtop_init_swap_p (glibtop *server)
#endif #endif
#if !(defined(__NetBSD__) && (__NetBSD_Version__ >= 104000000)) #if !(defined(__NetBSD__) && (__NetBSD_Version__ >= 104000000))
if (kvm_nlist (server->_priv->machine.kd, nlst2) != 0) { if (kvm_nlist (server->_priv->machine.kd, nlst2) < 0) {
glibtop_warn_io_r (server, "kvm_nlist (cnt)"); glibtop_warn_io_r (server, "kvm_nlist (cnt)");
return -1; return -1;
} }